sr-dev October 2009

sr-dev@lists.kamailio.org

30 participants
468 discussions

git:kamailio_3.0: update drp_rpls statistics
by Daniel-Constantin Mierla 23 Oct '09

23 Oct '09

Module: sip-router Branch: kamailio_3.0 Commit: 770ced39b0b749355559e2a35bedf1b9c3674adc URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=770ced3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Oct 23 16:39:59 2009 +0200 update drp_rpls statistics --- forward.c | 6 +++++- receive.c | 9 +++++++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/forward.c b/forward.c index a7328e3..eae80ed 100644 --- a/forward.c +++ b/forward.c @@ -736,7 +736,11 @@ int forward_reply(struct sip_msg* msg) } #endif - if (msg_send(&dst, new_buf, new_len)<0) goto error; + if (msg_send(&dst, new_buf, new_len)<0) + { + sr_event_exec(SREV_CORE_STATS, (void*)4); + goto error; + } #ifdef STATS STATS_TX_RESPONSE( (msg->first_line.u.reply.statuscode/100) ); #endif diff --git a/receive.c b/receive.c index 495f383..92f6bb0 100644 --- a/receive.c +++ b/receive.c @@ -225,7 +225,10 @@ int receive_msg(char* buf, unsigned int len, struct receive_info* rcv_info) on via1 being parsed in a pre-script callback --andrei */ if (exec_pre_script_cb(msg, ONREPLY_CB_TYPE)==0 ) + { + sr_event_exec(SREV_CORE_STATS, (void*)4); goto end; /* drop the request */ + } /* exec the onreply routing script */ if (onreply_rt.rlist[DEFAULT_RT]){ @@ -235,8 +238,10 @@ int receive_msg(char* buf, unsigned int len, struct receive_info* rcv_info) LOG(L_WARN, "WARNING: receive_msg: " "error while trying onreply script\n"); goto error_rpl; - }else if (ret==0) goto skip_send_reply; /* drop the message, - no error */ + }else if (ret==0){ + sr_event_exec(SREV_CORE_STATS, (void*)4); + goto skip_send_reply; /* drop the message, no error */ + } } /* send the msg */ forward_reply(msg);

1 0

git:kamailio_3.0: update drp_reqs statistics
by Daniel-Constantin Mierla 23 Oct '09

23 Oct '09

Module: sip-router Branch: kamailio_3.0 Commit: f4b64fc173c4ecc470346f05514af43adbda294a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f4b64fc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Oct 23 16:48:16 2009 +0200 update drp_reqs statistics --- forward.c | 2 ++ receive.c | 3 +++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/forward.c b/forward.c index eae80ed..3a4fbf4 100644 --- a/forward.c +++ b/forward.c @@ -584,6 +584,8 @@ end: /* received_buf & line_buf will be freed in receive_msg by free_lump_list*/ if(ret==0) sr_event_exec(SREV_CORE_STATS, (void*)1); + else + sr_event_exec(SREV_CORE_STATS, (void*)3); return ret; } diff --git a/receive.c b/receive.c index 92f6bb0..b6e6f6e 100644 --- a/receive.c +++ b/receive.c @@ -182,7 +182,10 @@ int receive_msg(char* buf, unsigned int len, struct receive_info* rcv_info) on via1 being parsed in a pre-script callback --andrei */ if (exec_pre_script_cb(msg, REQUEST_CB_TYPE)==0 ) + { + sr_event_exec(SREV_CORE_STATS, (void*)3); goto end; /* drop the request */ + } set_route_type(REQUEST_ROUTE); /* exec the routing script */

1 0

git:kamailio_3.0: update err_rpls statistics
by Daniel-Constantin Mierla 23 Oct '09

23 Oct '09

Module: sip-router Branch: kamailio_3.0 Commit: b542c1c71ed132e58d0d07d5ba66a241384ae6a2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b542c1c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Oct 23 16:04:21 2009 +0200 update err_rpls statistics --- receive.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/receive.c b/receive.c index 579a6c2..4d10d1a 100644 --- a/receive.c +++ b/receive.c @@ -207,6 +207,7 @@ int receive_msg(char* buf, unsigned int len, struct receive_info* rcv_info) if ((msg->via1==0) || (msg->via1->error!=PARSE_OK)){ /* no via, send back error ? */ LOG(L_ERR, "ERROR: receive_msg: no via found in reply\n"); + sr_event_exec(SREV_CORE_STATS, (void*)6); goto error02; }

1 0

git:master: Fixed test 36.sh
by Marius Zbihlei 23 Oct '09

23 Oct '09

Module: sip-router Branch: master Commit: 2c9196b6e53885d4cde7534b3230426d769e561b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2c9196b… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Fri Oct 23 17:31:18 2009 +0300 Fixed test 36.sh Grepped into location after specific string (___test___) Better formating --- test/unit/36.sh | 19 ++++++++++++++----- 1 files changed, 14 insertions(+), 5 deletions(-) diff --git a/test/unit/36.sh b/test/unit/36.sh index 808ccb6..da63623 100755 --- a/test/unit/36.sh +++ b/test/unit/36.sh @@ -31,10 +31,10 @@ CFG=11.cfg cp $CFG $CFG.bak -echo "loadmodule \"db_mysql/db_mysql.so\"" >> $CFG +echo "loadmodule \"../../modules/db_mysql/db_mysql.so\"" >> $CFG # 1768 contacts should fit into 1 MB of PKG memory -../$BIN -V | grep "PKG_MALLOC" > /dev/null +$BIN -V | grep "PKG_MALLOC" > /dev/null if [ $? -eq 0 ]; then NR=176 else @@ -44,16 +44,25 @@ fi; COUNTER=0 while [ $COUNTER -lt $NR ]; do COUNTER=$(($COUNTER+1)) - $MYSQL "insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); insert into location (username, domain, contact, u ser_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___');" + $MYSQL "insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); \ + insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); \ + insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); \ + insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); \ + insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); \ + insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); \ + insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); \ + insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); \ + insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___'); \ + insert into location (username, domain, contact, user_agent) values ('foobar-$COUNTER-$RANDOM', 'local', 'foobar-$COUNTER-$RANDOM@$DOMAIN', '___test___');" done -../$BIN -w . -f $CFG > /dev/null +$BIN -w . -f $CFG > /dev/null ret=$? if [ $ret -eq 0 ]; then sleep 1 for ((i=1;i<=100;i+=1)); do - tmp=`../scripts/$CTL fifo ul_dump | grep "AOR" | wc -l` + tmp=$($CTL fifo ul_dump | grep "User-agent:: ___test___" | wc -l) NR_=$(($NR * 10)) if ! [ $tmp -eq $NR_ ]; then ret=1

1 0

fix_nated_contact() then encode_contact() causes core dump
by Nick Lemberger 23 Oct '09

23 Oct '09

When one runs fix_nated_contact() from the nathelper module for it's intended purpose (it must complete successfully) and then run encode_contact() from the siputils module (it also must complete) Kamailio always core-dumps with: CRITICAL:core:del_lump: offset exceeds message size (202688 > 602) aborting... I'm guessing this has something to do with re-writing the contact header twice and not fixing the message size the second time but I can't say for sure. I have a core file, but it seems rather large (44M). It can be uploaded if need be. This is occurring with both the release 1.5.2tls & 1.6.0notls dev trunk. I posted this bug to the SourceForge Bug Tracker - if this is the wrong list for bug reports on 1.5/1.6 let me know. If this should be put into a different bug tracker, I can do that as well. Regards, Nicholas Lemberger Lakefield Communications

2 1

Revision $Revision$ $Date$
by Olle E. Johansson 23 Oct '09

23 Oct '09

The subversion tags doesn't seem to work in SIP, which will affect documentation files (as well as all the code files, but I worry most about docs now). Any ideas on how to handle this? /O

2 1

git:master: Fixed 11.sh test
by Marius Zbihlei 23 Oct '09

23 Oct '09

Module: sip-router Branch: master Commit: c0df527b410149897f73720ddffb11d3b9325a98 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c0df527… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Fri Oct 23 16:36:36 2009 +0300 Fixed 11.sh test --- test/unit/11.cfg | 3 ++- test/unit/11.sh | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/test/unit/11.cfg b/test/unit/11.cfg index 70a9cfa..243a9a2 100644 --- a/test/unit/11.cfg +++ b/test/unit/11.cfg @@ -7,8 +7,8 @@ disable_tcp=yes # ------------------ module loading ---------------------------------- loadpath "../../modules_k/" -loadmodule "sl" loadmodule "../../modules/tm/tm.so" +loadmodule "sl" loadmodule "rr" loadmodule "maxfwd" loadmodule "textops" @@ -72,3 +72,4 @@ route[1] { } exit; } + diff --git a/test/unit/11.sh b/test/unit/11.sh index 8902e5c..925b704 100755 --- a/test/unit/11.sh +++ b/test/unit/11.sh @@ -31,7 +31,7 @@ fi ; cp $CFG $CFG.bak -echo "loadmodule \"$SR_DIR/modules/db_mysql/db_mysql.so\"" >> $CFG +echo "loadmodule \"../../modules/db_mysql/db_mysql.so\"" >> $CFG $BIN -w . -f $CFG > /dev/null ret=$?

1 0

Domainpolicy module
by Olle E. Johansson 23 Oct '09

23 Oct '09

" The Domain Policy module implements draft-lendl-domain-policy- ddds-02 in combination with draft-lendl-speermint-federations-02 and draft-lendl-speermint-technical-policy-00. These drafts define <acronym>DNS</acronym> records with which a domain can announce its federation memberships. A local database can be used to map policy rules to routing policy decisions. This database can also contain rules concerning destination domains independently of draft-lendl-domain-policy- ddds-02. " https://datatracker.ietf.org/drafts/draft-lendl-domain-policy-ddds/ is marked as expired. http://tools.ietf.org/html/draft-lendl-speermint-federations-03 is expired https://datatracker.ietf.org/drafts/draft-lendl-speermint-technical-policy/ is expired Are these replaced with other documents? Should we rewrite this text? /O

2 1

tls and tls module
by Olle E. Johansson 23 Oct '09

23 Oct '09

We have modules/tls and modules_s/tls - what's the difference? /O

2 1

Presence
by Olle E. Johansson 23 Oct '09

23 Oct '09

I found a set of XML docs in doc/presence that seems to describe something rather old or new - it mentions experimental code in Ottendorf. The question is which presence subsystem we have now - and if this documentation is still valid at all? /O

2 3

← Newer
1
...
10
11
12
13
14
15
16
...
47
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2009