sr-dev May 2009

sr-dev@lists.kamailio.org

26 participants
263 discussions

[ openser-Bugs-2797928 ] Segfaults in dialog_update_db
by SourceForge.net 28 May '09

28 May '09

Bugs item #2797928, was opened at 2009-05-28 15:54 Message generated for change (Tracker Item Submitted) made by axlh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2797928&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Segfaults in dialog_update_db Initial Comment: dialog_update_db() is very crashy. It doesn't do any sanity checks on pointers and as a consequence crashes a lot. I've seen at least 2 occasions at which is crashes: 1) Calling dlg_manage() on a non-invite message 2) Worse, on an invalid message. When a 200 OK is missing a contact header, I get error messages from populate_leg_info(): ERROR:dialog:populate_leg_info: bad sip message or missing Contact hdr ERROR:dialog:dlg_onreply: could not add further info to the dialog But afterwards dialog_update_db segfaults on an invalid bind_addr, from the backtrace: (gdb) bt #0 0xb783c41a in dialog_update_db (ticks=771000, param=0x0) at dlg_db_handler.c:629 #1 0x080a9726 in start_timer_processes () at timer.c:282 #2 0x08069b38 in main (argc=10, argv=0xbfc6f2d4) at main.c:816 Line 629 is for my version: SET_STR_VALUE(values+8, cell->bind_addr[DLG_CALLEE_LEG]->sock_str); (gdb) bt full <snip> {type = DB_STR, nul = 0, free = -1282894544, val = {int_val = 178, ll_val = -5201380350948802382, double_val = -7.7990737395388139e-40, time_val = 178, string_val = 0xb2 "", str_val = {s = 0xb2 "", len = -1211040735}, blob_val = {s = 0xb2 "", len = -1211040735}, bitmap_val = 178}} <snip> ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2797928&group_…

1 0

git:master: * Changed hardcoded string "ser" in paths to "$(MAIN_NAME)".
by Juha Heinanen 28 May '09

28 May '09

Module: sip-router Branch: master Commit: 14a7d974e047ec6d45f65f7705a6c69079ac5689 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=14a7d97… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Thu May 28 16:20:53 2009 +0300 * Changed hardcoded string "ser" in paths to "$(MAIN_NAME)". --- Makefile.defs | 22 +++++++++++----------- 1 files changed, 11 insertions(+), 11 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index 2c2f057..1491503 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -165,38 +165,38 @@ endif CC_EXTRA_OPTS ?= # dirs -cfg_dir = etc/ser/ +cfg_dir = etc/$(MAIN_NAME)/ bin_dir = sbin/ -share_dir = share/ser/ -# lib/ser/modules , lib/ser/modules-s, lib/ser/modules-k -modules_dir = lib/ser/ -lib_dir = lib/ser/ +share_dir = share/$(MAIN_NAME)/ +# lib/$(MAIN_NAME)/modules , lib/$(MAIN_NAME)/modules-s, lib/$(MAIN_NAME)/modules-k +modules_dir = lib/$(MAIN_NAME)/ +lib_dir = lib/$(MAIN_NAME)/ ifeq ($(OS), linux) - doc_dir = share/doc/ser/ + doc_dir = share/doc/$(MAIN_NAME)/ man_dir = share/man/ LOCALBASE ?= /usr/local else ifeq ($(OS), freebsd) - doc_dir = share/doc/ser/ + doc_dir = share/doc/$(MAIN_NAME)/ man_dir = man/ LOCALBASE ?= /usr/local else ifeq ($(OS), openbsd) - doc_dir = share/doc/ser/ + doc_dir = share/doc/$(MAIN_NAME)/ man_dir = man/ LOCALBASE ?= /usr/local else ifeq ($(OS), netbsd) - doc_dir = share/doc/ser + doc_dir = share/doc/$(MAIN_NAME)/ man_dir = man/ LOCALBASE ?= /usr/pkg else ifeq ($(OS), darwin) - doc_dir = share/doc/ser/ + doc_dir = share/doc/$(MAIN_NAME)/ man_dir = man/ LOCALBASE ?= /usr/local else - doc_dir = doc/ser/ + doc_dir = doc/$(MAIN_NAME)/ man_dir = man/ LOCALBASE ?= /usr/local endif

1 0

got quite far, but got stuck in modules_k/uac_redirect
by jh＠tutpro.com 28 May '09

28 May '09

while compiling modules that i use, i got the 3rd last, before compilation failed. -- juha make[2]: Entering directory `/usr/src/trunk-src/openxg-sip-router/modules_k/uac_redirect' ... gcc -fPIC -DPIC -g -O9 -funroll-loops -Wcast-align -minline-all-stringops -falign-loops -ftree-vectorize -mtune=athlon64 -Wall -DNAME='"ser"' -DVERSION='"2.1.0-dev23-make"' -DARCH='"i386"' -DOS='linux_' -DOS_QUOTED='"linux"' -DCOMPILER='"gcc 4.3.2"' -D__CPU_i386 -D__OS_linux -DSER_VER=2001000 -DCFG_DIR='"/usr/local/etc/ser/"' -DPKG_MALLOC -DSHM_MEM -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLACKLIST -DUSE_NAPTR -DF_MALLOC -DUSE_TLS -DTLS_HOOKS -DFAST_LOCK -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM -DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD -DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H -DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DHAVE_EPOLL -DHAVE_SIGIO_RT -DSIGINFO64_WORKARROUND -DUSE_FUTEX -DHAVE_SELECT -DUSE_SCTP -DOPENSER_MOD_INTERFACE -DMOD_NAME='"uac_redirect"' -c rd_funcs.c -o rd_funcs.o rd_funcs.c: In function ??get_redirect??: rd_funcs.c:65: error: ??struct cell?? has no member named ??first_branch?? rd_funcs.c:65: error: ??struct cell?? has no member named ??first_branch?? rd_funcs.c:65: error: ??struct cell?? has no member named ??first_branch?? rd_funcs.c:65: error: ??struct cell?? has no member named ??first_branch?? rd_funcs.c:65: error: ??struct cell?? has no member named ??first_branch?? rd_funcs.c:71: error: ??struct cell?? has no member named ??first_branch?? rd_funcs.c: In function ??shmcontact2dset??: rd_funcs.c:267: warning: passing argument 2 of ??append_branch?? from incompatible pointer type rd_funcs.c:275: error: too many arguments to function ??rd_acc_fct?? make[2]: *** [rd_funcs.o] Error 1

2 1

git:master: dialog (k): safety check of main_rt list boundaries
by Daniel-Constantin Mierla 28 May '09

28 May '09

Module: sip-router Branch: master Commit: 0e8978b8853d44f6de3fb0a2bfcf9eef2d543372 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0e8978b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu May 28 12:31:10 2009 +0300 dialog (k): safety check of main_rt list boundaries --- modules_k/dialog/dlg_handlers.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules_k/dialog/dlg_handlers.c b/modules_k/dialog/dlg_handlers.c index 0ebb4b1..f03951b 100644 --- a/modules_k/dialog/dlg_handlers.c +++ b/modules_k/dialog/dlg_handlers.c @@ -964,7 +964,8 @@ void dlg_ontimeout( struct dlg_tl *tl) dlg = ((struct dlg_cell*)((char *)(tl) - (unsigned long)(&((struct dlg_cell*)0)->tl))); - if(dlg->toroute>0 && main_rt.rlist[dlg->toroute]!=NULL) + if(dlg->toroute>0 && dlg->toroute<main_rt.entries + && main_rt.rlist[dlg->toroute]!=NULL) { dlg_set_ctx_dialog(dlg); fmsg = faked_msg_next();

1 0

git:master: dialog (k): lookup the index of timeout route
by Daniel-Constantin Mierla 28 May '09

28 May '09

Module: sip-router Branch: master Commit: a4c2f8086781f27648b6796ed10a93b91103f6e9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a4c2f80… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu May 28 12:26:13 2009 +0300 dialog (k): lookup the index of timeout route - sr can have str name for routes, therefore K mode is no longer valid --- modules_k/dialog/dlg_handlers.c | 2 +- modules_k/dialog/dlg_var.c | 16 +++++++++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/modules_k/dialog/dlg_handlers.c b/modules_k/dialog/dlg_handlers.c index 2b3d53d..0ebb4b1 100644 --- a/modules_k/dialog/dlg_handlers.c +++ b/modules_k/dialog/dlg_handlers.c @@ -964,7 +964,7 @@ void dlg_ontimeout( struct dlg_tl *tl) dlg = ((struct dlg_cell*)((char *)(tl) - (unsigned long)(&((struct dlg_cell*)0)->tl))); - if(dlg->toroute>0 && dlg->toroute<RT_NO) + if(dlg->toroute>0 && main_rt.rlist[dlg->toroute]!=NULL) { dlg_set_ctx_dialog(dlg); fmsg = faked_msg_next(); diff --git a/modules_k/dialog/dlg_var.c b/modules_k/dialog/dlg_var.c index 588e231..48710e5 100644 --- a/modules_k/dialog/dlg_var.c +++ b/modules_k/dialog/dlg_var.c @@ -20,6 +20,8 @@ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ +#include "../../route.h" + #include "dlg_var.h" dlg_ctx_t _dlg_ctx; @@ -68,6 +70,8 @@ int pv_set_dlg_ctx(struct sip_msg* msg, pv_param_t *param, int op, pv_value_t *val) { int n; + char *rtp; + if(param==NULL) return -1; @@ -88,7 +92,17 @@ int pv_set_dlg_ctx(struct sip_msg* msg, pv_param_t *param, _dlg_ctx.to_bye = n; break; case 4: - _dlg_ctx.to_route = n; + if(val->flags&PV_VAL_STR) { + if(val->rs.s[val->rs.len]=='\0') + _dlg_ctx.to_route = route_lookup(&main_rt, val->rs.s); + else _dlg_ctx.to_route = 0; + } else { + if(n!=0) { + rtp = int2str(n, NULL); + _dlg_ctx.to_route = route_lookup(&main_rt, rtp); + } else _dlg_ctx.to_route = 0; + } + if(_dlg_ctx.to_route <0) _dlg_ctx.to_route = 0; break; default: _dlg_ctx.on = n;

1 0

sip-router with/without tls/sctp
by jh＠tutpro.com 28 May '09

28 May '09

INSTALL document does not mention TLS and SCTP at all. is it so that TLS and SCTP support is automatically included by the make process? there is no comment in Makefile.defs on CORE_TLS variable. it that what is used to control if TLS support is included? in Makefile.defs there is also SCTP variable without any comment. is that what is used to control if SCTP support is included? -- juha

4 3

git:master: * User-Agent and Server headers now contain string "SIP Router" .
by Juha Heinanen 28 May '09

28 May '09

Module: sip-router Branch: master Commit: 7d33b8097711d2ac70e3b160dab17b93aab4b39d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7d33b80… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Thu May 28 09:30:59 2009 +0300 * User-Agent and Server headers now contain string "SIP Router". --- config.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config.h b/config.h index e78d727..021d22a 100644 --- a/config.h +++ b/config.h @@ -85,11 +85,11 @@ #define CONTENT_LENGTH "Content-Length: " #define CONTENT_LENGTH_LEN (sizeof(CONTENT_LENGTH)-1) -#define USER_AGENT "User-Agent: Sip EXpress router"\ +#define USER_AGENT "User-Agent: SIP Router "\ "(" VERSION " (" ARCH "/" OS_QUOTED "))" #define USER_AGENT_LEN (sizeof(USER_AGENT)-1) -#define SERVER_HDR "Server: Sip EXpress router "\ +#define SERVER_HDR "Server: SIP Router "\ "(" VERSION " (" ARCH "/" OS_QUOTED "))" #define SERVER_HDR_LEN (sizeof(SERVER_HDR)-1)

1 0

git:master: * Ported xmlrpc server blocking fix from OpenSIPS.
by Juha Heinanen 27 May '09

27 May '09

Module: sip-router Branch: master Commit: 9f6ac8e61b433fc81cd923e43e819c628be6ce88 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9f6ac8e… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Wed May 27 19:13:29 2009 +0300 * Ported xmlrpc server blocking fix from OpenSIPS. --- modules_k/mi_xmlrpc/abyss_server.c | 5 +++-- modules_k/mi_xmlrpc/abyss_socket.c | 7 +++++++ modules_k/mi_xmlrpc/abyss_socket.h | 6 ++++++ modules_k/mi_xmlrpc/abyss_socket_unix.c | 16 ++++++++++++++-- 4 files changed, 30 insertions(+), 4 deletions(-) diff --git a/modules_k/mi_xmlrpc/abyss_server.c b/modules_k/mi_xmlrpc/abyss_server.c index c23606f..48219fc 100644 --- a/modules_k/mi_xmlrpc/abyss_server.c +++ b/modules_k/mi_xmlrpc/abyss_server.c @@ -1352,7 +1352,7 @@ waitForConnectionCapacity(outstandingConnList * const outstandingConnListP) { void ServerHandleSigchld(pid_t const pid) { - ThreadHandleSigchld(pid); + //ThreadHandleSigchld(pid); } #endif @@ -1388,7 +1388,6 @@ destroyConnSocket(void * const userHandle) { } -#include "../../dprint.h" static void serverRun2(TServer * const serverP) { @@ -1423,6 +1422,8 @@ serverRun2(TServer * const serverP) { if (!error) { addToOutstandingConnList(outstandingConnListP, connectionP); ConnProcess(connectionP); + SocketClose(connectedSocketP); + /* When connection is done (which could be later, courtesy of a background thread), destroyConnSocket() will destroy *connectedSocketP. diff --git a/modules_k/mi_xmlrpc/abyss_socket.c b/modules_k/mi_xmlrpc/abyss_socket.c index 8f3168a..7a367f0 100644 --- a/modules_k/mi_xmlrpc/abyss_socket.c +++ b/modules_k/mi_xmlrpc/abyss_socket.c @@ -147,6 +147,13 @@ SocketCreate(const struct TSocketVtbl * const vtblP, void +SocketClose(TSocket * const socketP) { + socketP->vtbl.close(socketP); +} + + + +void SocketDestroy(TSocket * const socketP) { assert(socketP->signature == socketSignature); diff --git a/modules_k/mi_xmlrpc/abyss_socket.h b/modules_k/mi_xmlrpc/abyss_socket.h index 000e099..90b429e 100644 --- a/modules_k/mi_xmlrpc/abyss_socket.h +++ b/modules_k/mi_xmlrpc/abyss_socket.h @@ -14,6 +14,8 @@ typedef struct in_addr TIPAddr; +typedef void SocketCloseImpl(TSocket * const socketP); + typedef void SocketDestroyImpl(TSocket * const socketP); typedef void SocketWriteImpl(TSocket * const socketP, @@ -57,6 +59,7 @@ typedef void SocketGetPeerNameImpl(TSocket * const socketP, abyss_bool * const successP); struct TSocketVtbl { + SocketCloseImpl * close; SocketDestroyImpl * destroy; SocketWriteImpl * write; SocketReadImpl * read; @@ -92,6 +95,9 @@ void SocketTerm(void); void +SocketClose(TSocket * const socketP); + +void SocketCreate(const struct TSocketVtbl * const vtblP, void * const implP, TSocket ** const socketPP); diff --git a/modules_k/mi_xmlrpc/abyss_socket_unix.c b/modules_k/mi_xmlrpc/abyss_socket_unix.c index cb87abd..c5bdccd 100644 --- a/modules_k/mi_xmlrpc/abyss_socket_unix.c +++ b/modules_k/mi_xmlrpc/abyss_socket_unix.c @@ -102,6 +102,7 @@ SocketUnixTerm(void) { +static SocketCloseImpl socketClose; static SocketDestroyImpl socketDestroy; static SocketWriteImpl socketWrite; static SocketReadImpl socketRead; @@ -116,6 +117,7 @@ static SocketGetPeerNameImpl socketGetPeerName; static struct TSocketVtbl const vtbl = { + &socketClose, &socketDestroy, &socketWrite, &socketRead, @@ -189,14 +191,24 @@ SocketUnixCreateFd(int const fd, } +static void +socketClose(TSocket * const socketP) { + + struct socketUnix * const socketUnixP = socketP->implP; + + if (!socketUnixP->userSuppliedFd && socketUnixP->fd ) { + close(socketUnixP->fd); + socketUnixP->fd = 0; + } +} + static void socketDestroy(TSocket * const socketP) { struct socketUnix * const socketUnixP = socketP->implP; - if (!socketUnixP->userSuppliedFd) - close(socketUnixP->fd); + socketClose(socketP); free(socketUnixP); }

1 0

SF.net SVN: openser:[5860] branches/1.5/modules/mi_xmlrpc
by Juha Heinanen 27 May '09

27 May '09

Revision: 5860 http://openser.svn.sourceforge.net/openser/?rev=5860&view=rev Author: juhe Date: 2009-05-27 16:11:07 +0000 (Wed, 27 May 2009) Log Message: ----------- * Ported xmlrpc server blocking fix from OpenSIPs. Modified Paths: -------------- branches/1.5/modules/mi_xmlrpc/abyss_server.c branches/1.5/modules/mi_xmlrpc/abyss_socket.c branches/1.5/modules/mi_xmlrpc/abyss_socket.h branches/1.5/modules/mi_xmlrpc/abyss_socket_unix.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

1 0

#sip-router irc channel
by Daniel-Constantin Mierla 27 May '09

27 May '09

Hello, the irc fans that want to do "a more real-time chat" about using/developing sip router project, can join the #sip-router channel on irc.freenode.net. Cheers, Daniel -- Daniel-Constantin Mierla http://www.asipto.com/

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
27
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2009