sr-dev September 2009

sr-dev@lists.kamailio.org

32 participants
207 discussions

CVS:commitlog: sip_router/modules/tm h_table.c
by Miklos Tirpak 10 Sep '09

10 Sep '09

tirpi 2009/09/10 18:20:57 CEST SER CVS Repository Modified files: modules/tm h_table.c Log: tm: minor mem leak corrected (backport from git) After the memory of a cell is allocated other modules immediately have a chance to register transaction callbacks, and they may also allocate additional memory for the callback parameters. When sip_msg_cloner() failed, the memory allocated for the callback list was not freed. This happend only when the available shm memory was already very low which caused sip_msg_cloner() to fail. Revision Changes Path 1.114 +17 -1 sip_router/modules/tm/h_table.c http://cvs.berlios.de/cgi-bin/viewcvs.cgi/ser/sip_router/modules/tm/h_table…

1 0

git:master: tm: mem leak correction #2
by Miklos Tirpak 10 Sep '09

10 Sep '09

Module: sip-router Branch: master Commit: 2ea97b8a9a65aaceba8e19fbfc043924a4a82038 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2ea97b8… Author: Miklos Tirpak <miklos(a)iptel.org> Committer: Miklos Tirpak <miklos(a)iptel.org> Date: Thu Sep 10 18:11:56 2009 +0200 tm: mem leak correction #2 - shm_free() needs to be used instead of shm_free_unsafe() - The callback params may have a release function --- modules/tm/h_table.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/modules/tm/h_table.c b/modules/tm/h_table.c index f72737e..06a643c 100644 --- a/modules/tm/h_table.c +++ b/modules/tm/h_table.c @@ -356,7 +356,10 @@ error: for( cbs=(struct tm_callback*)new_cell->tmcb_hl.first ; cbs ; ) { cbs_tmp = cbs; cbs = cbs->next; - shm_free_unsafe( cbs_tmp ); + if (cbs_tmp->release) { + cbs_tmp->release(cbs_tmp->param); + } + shm_free( cbs_tmp ); } destroy_avp_list(&new_cell->user_avps_from);

1 0

git:master: tm: minor mem leak corrected
by Miklos Tirpak 10 Sep '09

10 Sep '09

Module: sip-router Branch: master Commit: 05af490239a5556704999d613e140e25425b0888 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=05af490… Author: Miklos Tirpak <miklos(a)iptel.org> Committer: Miklos Tirpak <miklos(a)iptel.org> Date: Thu Sep 10 17:50:57 2009 +0200 tm: minor mem leak corrected After the memory of a cell is allocated other modules immediately have a chance to register transaction callbacks, and they may also allocate additional memory for the callback parameters. When sip_msg_cloner() failed, the memory allocated for the callback list was not freed. This happend only when the available shm memory was already very low which caused sip_msg_cloner() to fail. --- modules/tm/h_table.c | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/modules/tm/h_table.c b/modules/tm/h_table.c index 11fb1a8..f72737e 100644 --- a/modules/tm/h_table.c +++ b/modules/tm/h_table.c @@ -266,6 +266,7 @@ struct cell* build_cell( struct sip_msg* p_msg ) struct cell* new_cell; int sip_msg_len; avp_list_t* old; + struct tm_callback *cbs, *cbs_tmp; /* allocs a new cell */ /* if syn_branch==0 add space for md5 (MD5_LEN -sizeof(struct cell.md5)) */ @@ -343,6 +344,21 @@ struct cell* build_cell( struct sip_msg* p_msg ) return new_cell; error: + /* Other modules may have already registered some + * transaction callbacks and may also allocated + * additional memory for their parameters, + * hence TMCB_DESTROY needs to be called. (Miklos) + */ + if (unlikely(has_tran_tmcbs(new_cell, TMCB_DESTROY))) + run_trans_callbacks(TMCB_DESTROY, new_cell, 0, 0, 0); + + /* free the callback list */ + for( cbs=(struct tm_callback*)new_cell->tmcb_hl.first ; cbs ; ) { + cbs_tmp = cbs; + cbs = cbs->next; + shm_free_unsafe( cbs_tmp ); + } + destroy_avp_list(&new_cell->user_avps_from); destroy_avp_list(&new_cell->user_avps_to); destroy_avp_list(&new_cell->uri_avps_from);

1 0

git:master: textops(k): new function - msg_apply_changes()
by Daniel-Constantin Mierla 10 Sep '09

10 Sep '09

Module: sip-router Branch: master Commit: 0e24d9be231fc54e13fd069ae28cc050cc708664 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0e24d9b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 10 16:22:08 2009 +0200 textops(k): new function - msg_apply_changes() - apply changes done to SIP request content (e.g., via subst(), append_hf(), remove_hf(), etc.) - after using this function, the content of SIP message buffer is updated and the initially recevied content is lost - function can be used in request route blocks - be careful when used since: - it changes the way you're used so far - not much tested with various modules --- modules_k/textops/README | 506 +++++++++++++++++++------------ modules_k/textops/doc/textops_admin.xml | 32 ++ modules_k/textops/textops.c | 83 +++++- 3 files changed, 420 insertions(+), 201 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=0e2…

1 0

git:master: imc(k): return code classes per command
by Daniel-Constantin Mierla 10 Sep '09

10 Sep '09

Module: sip-router Branch: master Commit: e265d13757b57e88c53bfdbb9f6d3580383d3788 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e265d13… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 10 14:51:08 2009 +0200 imc(k): return code classes per command - for each imc command a range of negative numbers is reserved to signal errors to config file - example enhanced to replect the need of sending replies from config file --- modules_k/imc/README | 30 +++++++++++++++++++++++------- modules_k/imc/doc/imc_admin.xml | 22 +++++++++++++++++++--- modules_k/imc/imc.c | 17 +++++++++++++++-- 3 files changed, 57 insertions(+), 12 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=e26…

1 0

git:master: modules_k/imc: fixed typo in #help reply
by Juha Heinanen 09 Sep '09

09 Sep '09

Module: sip-router Branch: master Commit: 3c807bd3a4428566ad00e12fb0155b04fe636403 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3c807bd… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Wed Sep 9 12:12:58 2009 +0300 modules_k/imc: fixed typo in #help reply --- modules_k/imc/imc_cmd.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/imc/imc_cmd.h b/modules_k/imc/imc_cmd.h index f112632..5e4735c 100644 --- a/modules_k/imc/imc_cmd.h +++ b/modules_k/imc/imc_cmd.h @@ -64,7 +64,7 @@ #define IMC_ROOM_PRIVATE_LEN (sizeof(IMC_ROOM_PRIVATE)-1) #define IMC_HELP_MSG "\r\n"IMC_CMD_START_STR IMC_CMD_CREATE" <room_name> - \ -create new connference room\r\n\ +create new conference room\r\n\ "IMC_CMD_START_STR IMC_CMD_JOIN" [<room_name>] - \ join the conference room\r\n\ "IMC_CMD_START_STR IMC_CMD_INVITE" <user_name> [<room_name>] - \

1 0

extra_hdrs param to imc module
by jh＠tutpro.com 09 Sep '09

09 Sep '09

daniel, i tried imc module, but got into problems, because i'm not able to specify any extra headers the messages send by imc server. it is ok if i try to add extra_hdrs param to imc module like msilo module has? -- juha 3.5. extra_hdrs (string) Extra headers (each ending with \r\n) to be added in messages sent from silo by m_dump. It can contain pseudo-variables

3 8

OID for sip-router
by Olle E. Johansson 09 Sep '09

09 Sep '09

The snmpstats module has a few MIBS included that is based on the entrprise number 27483. OpenSIPS.org has changed the registration for this and now maintains that enterprise number. This might lead to two different mibs with the same OID, which is not a good solution. Before release, I suggest we get a new assigned enterprise number from IANA for the project and change the MIBS and the snmpstats module. Using the same as OpenSIPS is not a good solution. http://www.iana.org/assignments/enterprise-numbers says: 27483 OpenSIPS.ORG (previous was 'OpenSER.ORG') Bogdan-Andrei Iancu bogdan.iancu&voice-system.ro /O

3 4

Freezing for Kamailio 3.0 - Monday, Sep 14, 2009
by Daniel-Constantin Mierla 09 Sep '09

09 Sep '09

Hello, who ever has brand new features to push into upcoming Kamailio 3.0 has to do it this week. The plan is o freeze the code and start the testing phase at the beginning of next week, with bug hunting as main activity. As usual, work on additional tools and documentation can go on during testing. If discovered, important missing features from kamailio 1.5 will be considered bugs. Cheers, Daniel -- Daniel-Constantin Mierla * http://www.asipto.com/

2 1

git:master: modules_k/imc: added "extra_hdrs" module variable
by Juha Heinanen 09 Sep '09

09 Sep '09

Module: sip-router Branch: master Commit: f884abbb574bdbfee99e234d0d3876f589c8d9dd URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f884abb… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Wed Sep 9 09:54:38 2009 +0300 modules_k/imc: added "extra_hdrs" module variable Added "extra_hdrs" module variable that can be used to inject extra headers to messages send out from IMC server. --- modules_k/imc/README | 231 ++++++++++++++++++++++++-------------- modules_k/imc/doc/imc_admin.xml | 21 ++++ modules_k/imc/imc.c | 22 ++++ modules_k/imc/imc.h | 2 + modules_k/imc/imc_cmd.c | 35 +++--- 5 files changed, 208 insertions(+), 103 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=f88…

1 0

← Newer
1
...
13
14
15
16
17
18
19
20
21
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2009