THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#24 - Module drouting, address routeid as string
User who did this - Daniel-Constantin Mierla (miconda)
----------
as a side comment, probably this should be migrated to an event_route in the future, kind of:
event_route[drouting:id]
where id is given in db table column. It can be, for example:
event_route[drouting:match]
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=24#comment22
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#24 - Module drouting, address routeid as string
User who did this - Daniel-Constantin Mierla (miconda)
----------
The module can run a route block when a match happens. That is given in route_id column. In 1.5 that is integer as the definition of routes takes only integer id as index. But in 3.0 that is string, so a lookup on name is needed to get the integer index.
Or I am missing something obvious after the parties in the last days :-) ?
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=24#comment21
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#24 - Module drouting, address routeid as string
User who did this - Raúl Alexis Betancor Santana (rbetancor)
----------
Hi Daniel,
I'm reviewing the patch, I'm trying to guest what is the advange of using named route_id's on the module, because It's not related with named route blocks, so I don't see the improvement on this.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=24#comment20
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#24 - Module drouting, address routeid as string
User who did this - Daniel-Constantin Mierla (miconda)
----------
Hi Raul, thanks for update and your new work. The new version will be in next major release, I suppose, 3.0.0 being schedule to happen in a week or so.
The patch fixes the support to lookup route names. In kamailio 1.5 the route names were only integers, now they can be string. The patch looks ok, imo, if you have time to review and commit before 3.0.0 would be good. It still needs update of db table definition.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=24#comment19
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.