sr-dev November 2010

sr-dev@lists.kamailio.org

17 participants
108 discussions

[tracker] User took ownership: $Ts returns wrong timestamp
by sip-router 26 Nov '10

26 Nov '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Daniel-Constantin Mierla has taken ownership of the following task: FS#105 - $Ts returns wrong timestamp More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=105 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: $Ts returns wrong timestamp
by sip-router 26 Nov '10

26 Nov '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#105 - $Ts returns wrong timestamp User who did this - Alex Hermann (axlh) ---------- Changed my mind, I still don't understand the first case. In failure_route I would expect $Ts is either the same as $Ts in request_route for the same request or the same as $Ts in reply_route, certainly not yet another value. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=105#comment138 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: $Ts returns wrong timestamp
by sip-router 26 Nov '10

26 Nov '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#105 - $Ts returns wrong timestamp User who did this - Alex Hermann (axlh) ---------- Ok, the first case I can understand if the timestamp is strictly bound to the message, not the request. I can workaround it by storing the timestamp in an avp while handling the initial message. But the 2nd case (the locally generated reply) seems to point to a serious failure to initialize memory locations. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=105#comment137 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task opened: $Ts returns wrong timestamp
by sip-router 26 Nov '10

26 Nov '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Alex Hermann (axlh) Attached to Project - sip-router Summary - $Ts returns wrong timestamp Task Type - Bug Report Category - Core Status - Assigned Assigned To - Andrei Pelinescu-Onciul Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - According to the docs on the wiki, $Ts should always return the same time for the same message. It doesn't, it returns the same time as $TS in most cases. It gets worse if the reply is locally generated (408), then the timestamp of the previous request handled by that process is returned. Reproduce: <code> route { xlog("Ts:$Ts TS:$TS request"); t_on_reply(REPLY); t_on_failure(FAILURE); t_relay(); } on_reply_route[REPLY] { xlog("Ts:$Ts TS:$TS reply"); } failure_route[FAILURE] { sleep(1); xlog("Ts:$Ts TS:$TS failure"); } </code> Log: First call: <code> Nov 26 14:10:08 wsproxy1[29897]: ERROR: <script>: Ts:1290777008 TS:1290777008 request Nov 26 14:10:08 wsproxy1[29901]: ERROR: <script>: Ts:1290777008 TS:1290777008 reply Nov 26 14:10:09 wsproxy1[29901]: ERROR: <script>: Ts:1290777009 TS:1290777009 failure </code> Expected would be that $Ts would always read 1290777008 for this call. As in failure_route the original request is handled, the expected value of $Ts would be the same as the initial value. Next call: <code> Nov 26 14:10:09 wsproxy1[29908]: ERROR: <script>: Ts:1290777009 TS:1290777009 failure </code> Last call: <code> Nov 26 14:10:15 wsproxy1[29900]: ERROR: <script>: Ts:1290777015 TS:1290777015 request <timeout> Nov 26 14:10:16 wsproxy1[29908]: ERROR: <script>: Ts:1290777009 TS:1290777016 failure </code> Expected would be that $Ts would always read 1290777015 for this call, certainly not 1290777009. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=105 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Assignee added: $Ts returns wrong timestamp
by sip-router 26 Nov '10

26 Nov '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#105 - $Ts returns wrong timestamp User who did this - Alex Hermann (axlh) http://sip-router.org/tracker/index.php?do=details&task_id=105 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: topoh: option to bind to sanity for parsing checks
by Daniel-Constantin Mierla 26 Nov '10

26 Nov '10

Module: sip-router Branch: master Commit: 6d8a726754799cb4e7e312a1436f79da7ee91646 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6d8a726… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Nov 26 14:26:27 2010 +0100 topoh: option to bind to sanity for parsing checks - the module can bind to sanity to perform parsing checks before proceeding to encoding/decoding of received requests - new parameter 'sanity_checks' --- modules/topoh/README | 18 ++++++++++++++++++ modules/topoh/doc/topoh_admin.xml | 22 ++++++++++++++++++++++ modules/topoh/topoh_mod.c | 31 +++++++++++++++++++++++++++++++ 3 files changed, 71 insertions(+), 0 deletions(-) diff --git a/modules/topoh/README b/modules/topoh/README index 0ed980f..0cc398b 100644 --- a/modules/topoh/README +++ b/modules/topoh/README @@ -33,6 +33,7 @@ Daniel-Constantin Mierla 3.6. vparam_name (str) 3.7. vparam_prefix (str) 3.8. callid_prefix (str) + 3.9. sanity_checks (integer) 4. Exported Functions @@ -48,6 +49,7 @@ Daniel-Constantin Mierla 1.6. Set vparam_name parameter 1.7. Set vparam_prefix parameter 1.8. Set callid_prefix parameter + 1.9. Set sanity_checks parameter Chapter 1. Admin Guide @@ -69,6 +71,7 @@ Chapter 1. Admin Guide 3.6. vparam_name (str) 3.7. vparam_prefix (str) 3.8. callid_prefix (str) + 3.9. sanity_checks (integer) 4. Exported Functions @@ -117,6 +120,7 @@ Chapter 1. Admin Guide 3.6. vparam_name (str) 3.7. vparam_prefix (str) 3.8. callid_prefix (str) + 3.9. sanity_checks (integer) 3.1. mask_key (str) @@ -212,6 +216,20 @@ modparam("topoh", "vparam_prefix", "xyz") modparam("topoh", "callid_prefix", "***") ... +3.9. sanity_checks (integer) + + If set to 1, topoh module will bind to sanity module in order to + perform sanity checks over received SIP request. Default sanity checks + are done. It is useful to check if received request is well formated + before proceeding to encoding/decoding. + + Default value is 0 (do not bind to sanity module). + + Example 1.9. Set sanity_checks parameter +... +modparam("topoh", "sanity_checks", 1) +... + 4. Exported Functions 4.1. diff --git a/modules/topoh/doc/topoh_admin.xml b/modules/topoh/doc/topoh_admin.xml index d028437..152de2d 100644 --- a/modules/topoh/doc/topoh_admin.xml +++ b/modules/topoh/doc/topoh_admin.xml @@ -225,6 +225,28 @@ modparam("topoh", "callid_prefix", "***") </programlisting> </example> </section> + <section> + <title><varname>sanity_checks</varname> (integer)</title> + <para> + If set to 1, topoh module will bind to sanity module in order + to perform sanity checks over received SIP request. Default + sanity checks are done. It is useful to check if received request + is well formated before proceeding to encoding/decoding. + </para> + <para> + <emphasis> + Default value is 0 (do not bind to sanity module). + </emphasis> + </para> + <example> + <title>Set <varname>sanity_checks</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("topoh", "sanity_checks", 1) +... +</programlisting> + </example> + </section> </section> <section> diff --git a/modules/topoh/topoh_mod.c b/modules/topoh/topoh_mod.c index 87a8a13..bc7ea8e 100644 --- a/modules/topoh/topoh_mod.c +++ b/modules/topoh/topoh_mod.c @@ -47,6 +47,8 @@ #include "../../parser/parse_to.h" #include "../../parser/parse_from.h" +#include "../../modules/sanity/api.h" + #include "th_mask.h" #include "th_msg.h" @@ -69,6 +71,9 @@ str th_uri_prefix = {0, 0}; int th_param_mask_callid = 0; +int th_sanity_checks = 0; +sanity_api_t scb; + int th_msg_received(void *data); int th_msg_sent(void *data); @@ -84,6 +89,7 @@ static param_export_t params[]={ {"vparam_name", STR_PARAM, &th_vparam_name.s}, {"vparam_prefix", STR_PARAM, &th_vparam_prefix.s}, {"callid_prefix", STR_PARAM, &th_callid_prefix.s}, + {"sanity_checks", INT_PARAM, &th_sanity_checks}, {0,0,0} }; @@ -109,6 +115,14 @@ struct module_exports exports= { */ static int mod_init(void) { + if(th_sanity_checks!=0) + { + if(sanity_load_api(&scb)<0) + { + LM_ERR("cannot bind to sanity module\n"); + goto error; + } + } th_cookie_name.len = strlen(th_cookie_name.s); th_ip.len = strlen(th_ip.s); if(th_ip.len<=0) @@ -175,6 +189,9 @@ error: return -1; } +/** + * + */ int th_prepare_msg(sip_msg_t *msg) { if (parse_msg(msg->buf, msg->len, msg)!=0) @@ -198,6 +215,9 @@ int th_prepare_msg(sip_msg_t *msg) return 0; } +/** + * + */ int th_msg_received(void *data) { sip_msg_t msg; @@ -223,6 +243,14 @@ int th_msg_received(void *data) th_cookie_value.len = 2; if(msg.first_line.type==SIP_REQUEST) { + if(th_sanity_checks!=0) + { + if(scb.check_defaults(&msg)<1) + { + LM_ERR("sanity checks failed\n"); + goto done; + } + } dialog = (get_to(&msg)->tag_value.len>0)?1:0; if(dialog) { @@ -280,6 +308,9 @@ done: return 0; } +/** + * + */ int th_msg_sent(void *data) { sip_msg_t msg;

1 0

git:3.1: modules/topoh : If a message contains a bad CSEQ, skip processing it.
by Marius Zbihlei 26 Nov '10

26 Nov '10

Module: sip-router Branch: 3.1 Commit: a72e59d23d4b104af6d7f30d1dc02a5fe175f3af URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a72e59d… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Fri Nov 26 10:59:12 2010 +0200 modules/topoh : If a message contains a bad CSEQ, skip processing it. This would likely cause a segmentation fault when receiving messages with bad CSEQs. (cherry picked from commit 29990057d8b17cf0ded395438465c6cb2c38207f) --- modules/topoh/th_msg.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/modules/topoh/th_msg.c b/modules/topoh/th_msg.c index 5304b1e..5f87971 100644 --- a/modules/topoh/th_msg.c +++ b/modules/topoh/th_msg.c @@ -1040,6 +1040,11 @@ int th_route_direction(sip_msg_t *msg) int th_skip_msg(sip_msg_t *msg) { + if (!get_cseq(msg)) { + LM_WARN("Invalid/Unparsed CSeq in message. Skipping."); + return 1; + } + if((get_cseq(msg)->method_id)&(METHOD_REGISTER|METHOD_PUBLISH)) return 1;

1 0

[tracker] Task closed: Segfault in allow_trusted2
by sip-router 26 Nov '10

26 Nov '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#102 - Segfault in allow_trusted2 User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Committed on master and 3.1 More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=102 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: [regression] avp_print() does not print anything
by sip-router 26 Nov '10

26 Nov '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#104 - [regression] avp_print() does not print anything User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Committed to master and 3.1 More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=104 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: [regression] avp_print() does not print anything
by sip-router 26 Nov '10

26 Nov '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#104 - [regression] avp_print() does not print anything User who did this - Daniel-Constantin Mierla (miconda) ---------- Should be fixed now. Starting with v3.0, there are couple of avp lists, the one used by Kamailio-style avps in From URI list and in this case it was From User list. Thanks. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=104#comment136 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2010