sr-dev February 2010

sr-dev@lists.kamailio.org

31 participants
250 discussions

git:tmp/k3.0_sr_backports: uac(k): use header types for detection

by Andrei Pelinescu-Onciul

Module: sip-router Branch: tmp/k3.0_sr_backports Commit: d3ca20fb9f4ca45930fc38552fa9dddb7a0aa636 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d3ca20f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Sun Jan 24 21:21:59 2010 +0100 uac(k): use header types for detection (cherry picked from commit 369d7598244c60c2c8e4d601e166a03cb211128c) --- modules_k/uac/auth.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules_k/uac/auth.c b/modules_k/uac/auth.c index 78f51d5..0fb3e25 100644 --- a/modules_k/uac/auth.c +++ b/modules_k/uac/auth.c @@ -232,9 +232,9 @@ static inline struct hdr_field *get_autenticate_hdr(struct sip_msg *rpl, } for( hdr=rpl->headers ; hdr ; hdr=hdr->next ) { - if((rpl_code==WWW_AUTH_CODE && hdr->type==HDR_WWW_AUTHENTICATE_T) - || (rpl_code==PROXY_AUTH_CODE - && hdr->type==HDR_PROXY_AUTHENTICATE_T)) + if ( rpl_code==WWW_AUTH_CODE && hdr->type==HDR_WWW_AUTHENTICATE_T ) + return hdr; + if ( rpl_code==PROXY_AUTH_CODE && hdr->type==HDR_PROXY_AUTHENTICATE_T ) return hdr; }

15 years

git:tmp/k3.0_sr_backports: core: use dlflags to load modules

by Andrei Pelinescu-Onciul

Module: sip-router Branch: tmp/k3.0_sr_backports Commit: b549cf4aad129e403bbf63bb5591b4dfce4c3657 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b549cf4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Sat Jan 30 17:02:37 2010 +0100 core: use dlflags to load modules - dlflags var used for dlopen function (cherry picked from commit 055915a558a485cda17c9bb1c8e43aca12d116b5) --- sr_module.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sr_module.c b/sr_module.c index b8db2c7..d5dc322 100644 --- a/sr_module.c +++ b/sr_module.c @@ -384,7 +384,7 @@ int load_module(char* mod_path) retries=2; dlflags=RTLD_NOW; reload: - handle=dlopen(path, RTLD_NOW); /* resolve all symbols now */ + handle=dlopen(path, dlflags); /* resolve all symbols now */ if (handle==0){ LOG(L_ERR, "ERROR: load_module: could not open module <%s>: %s\n", path, dlerror());

15 years

git:tmp/k3.0_sr_backports: uac(k): proper test for send failure

by Andrei Pelinescu-Onciul

Module: sip-router Branch: tmp/k3.0_sr_backports Commit: f97be2652f037b28e545bfd3372d002a184ff0e7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f97be26… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Sun Jan 24 21:20:02 2010 +0100 uac(k): proper test for send failure (cherry picked from commit 1479cd808ea8e5025bfa8400a257e3f89db4ab68) --- modules_k/uac/uac_send.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/uac/uac_send.c b/modules_k/uac/uac_send.c index 9a1f2b9..b77317d 100644 --- a/modules_k/uac/uac_send.c +++ b/modules_k/uac/uac_send.c @@ -398,7 +398,7 @@ int uac_req_send(struct sip_msg *msg, char *s1, char *s2) (_uac_req.s_ouri.len<=0)?NULL:&_uac_req.s_ouri /* outbound uri */ ); - if(ret!=0) + if(ret<0) return -1; return 1; }

15 years

git:master: test:unit Fixed unixodbc tests (tested with mysql connector)

by Marius Zbihlei

Module: sip-router Branch: master Commit: d5a382d95db57093a8e35f2018d18c998979005a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d5a382d… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Wed Feb 3 14:19:51 2010 +0200 test:unit Fixed unixodbc tests (tested with mysql connector) --- test/unit/38.sh | 4 ++-- test/unit/39.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/unit/38.sh b/test/unit/38.sh index eff3b28..29dd758 100755 --- a/test/unit/38.sh +++ b/test/unit/38.sh @@ -36,7 +36,7 @@ echo "loadmodule \"db_unixodbc/db_unixodbc.so\"" >> $CFG echo "modparam(\"$DB_ALL_MOD\", \"db_url\", \"unixodbc://openserro:openserro@localhost/openser\")" >> $CFG # start -../$BIN -w . -f $CFG > /dev/null +$BIN -w . -f $CFG > /dev/null ret=$? sleep 1 @@ -45,4 +45,4 @@ $KILL mv $CFG.bak $CFG rm -f dispatcher.list -exit $ret \ No newline at end of file +exit $ret diff --git a/test/unit/39.sh b/test/unit/39.sh index d14cfff..9e8e2d6 100755 --- a/test/unit/39.sh +++ b/test/unit/39.sh @@ -45,7 +45,7 @@ COUNTER=0 CNT=0 while [ $COUNTER -lt $NR ]; do COUNTER=$(($COUNTER+1)) - echo -e "insert into location (id, username, domain, contact, user_agent) values ('$CNT', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$CNT+1', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$CNT+2', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$CNT+3', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$CNT+4', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$CNT+5', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, c ontact, user_agent) values ('$CNT+6', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$CNT+7', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$CNT+8', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$CNT+9', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n " | $ISQL > /dev/null + echo -e "insert into location (id, username, domain, contact, user_agent) values ('$CNT', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$(($CNT+1))', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$(($CNT+2))', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$(($CNT+3))', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$(($CNT+4))', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$(($CNT+5))', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$(($CNT+6))', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$(($CNT+7))', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$(($CNT+8))', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___'); \n insert into location (id, username, domain, contact, user_agent) values ('$(($CNT+9))', 'foobar-$RANDOM', '$DOMAIN', 'foobar-$RANDOM@$DOMAIN', '___test___');" | $ISQL CNT=$(($CNT+10)) done

15 years

git:master: modules_k/siptutils : Fixed small typo

by Marius Zbihlei

Module: sip-router Branch: master Commit: 5402db476a57a0f840e21b53291911b51a06d14a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5402db4… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Wed Feb 3 14:25:18 2010 +0200 modules_k/siptutils : Fixed small typo --- modules_k/siputils/siputils.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/siputils/siputils.c b/modules_k/siputils/siputils.c index 2b3aec8..25e5f33 100644 --- a/modules_k/siputils/siputils.c +++ b/modules_k/siputils/siputils.c @@ -165,7 +165,7 @@ static int mod_init(void) return -1; } - if(cfg_declare("siptutils", siputils_cfg_def, &default_siputils_cfg, cfg_sizeof(siputils), &siputils_cfg)){ + if(cfg_declare("siputils", siputils_cfg_def, &default_siputils_cfg, cfg_sizeof(siputils), &siputils_cfg)){ LM_ERR("Fail to declare the configuration\n"); return -1; }

15 years

sip_msg changes - proposal

by Daniel-Constantin Mierla

Hello, some months ago (iirc) we had a discussion about the sip_msg structure and the fact that it has too many header hooks, some for pretty uncommon or not really used inside sip router code. I spotted - subject - accept_language - content_disposition - accept_disposition - unsupported - organization - diversion (expired draft?) The list can continue a bit ... I was thinking to replace them with a call of get_hdr_by_name|type() kind of function. The benefit will be lower structure. On the other hand, I would add a new field to hold the pid of the process that received the message. There are some potential races by using only id to identify a message, especially in serial forking. Opinions? Daniel -- Daniel-Constantin Mierla eLearning class for Kamailio 3.0.0 Starting Feb 8, 2010 * http://www.asipto.com/

15 years

git:ebaixas/fixing_seas: Fixes in seas module to work with sip-router

by Elias Baixas

Module: sip-router Branch: ebaixas/fixing_seas Commit: ce08563a4701fd81759d500a7345b9fa26a9dc58 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ce08563… Author: Elias Baixas <elias(a)eresmas.net> Committer: Elias Baixas <elias(a)eresmas.net> Date: Mon Jan 25 12:32:14 2010 +0100 Fixes in seas module to work with sip-router --- Makefile.defs | 1 + modules/tm/dlg.c | 19 +++ modules/tm/dlg.h | 8 ++ modules/tm/h_table.h | 4 + modules/tm/t_cancel.c | 110 ++++++++++++++++++- modules/tm/t_cancel.h | 8 ++ modules/tm/t_msgbuilder.c | 111 ++++++++++++++++++ modules/tm/t_msgbuilder.h | 12 +- modules/tm/t_reply.c | 41 ++++---- modules/tm/t_reply.h | 6 +- modules/tm/tm_load.c | 2 + modules/tm/tm_load.h | 2 + modules_k/seas/encode_header.c | 4 + modules_k/seas/encode_parameters.c | 16 +++ modules_k/seas/event_dispatcher.c | 71 +++++++----- modules_k/seas/event_dispatcher.h | 6 +- modules_k/seas/seas.c | 18 ++-- modules_k/seas/seas_action.c | 222 ++++++++++++++++++++++------------- modules_k/seas/seas_action.h | 13 +- modules_k/seas/statistics.c | 2 +- modules_k/seas/statistics.h | 2 + 21 files changed, 516 insertions(+), 162 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=ce0…

15 years

git:kamailio_3.0: core: new param to give outbut buffer size

by Daniel-Constantin Mierla

Module: sip-router Branch: kamailio_3.0 Commit: a765213ffa3769577dd7438c95737cb6b98bff74 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a765213… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Feb 2 15:06:34 2010 +0100 core: new param to give outbut buffer size - int2strbuf requires now outbut buffer size as parameter - safer against misuses, suggested by Andrei Pelinescu-Onciul - if size is less than INT2STR_MAX_LEN, return null pointer --- ut.h | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/ut.h b/ut.h index 3e4d7a6..3d98e11 100644 --- a/ut.h +++ b/ut.h @@ -294,10 +294,15 @@ static inline char* int2str_base(unsigned int l, int* len, int base) /* print int to asciiz in a string buffer * - be sure result buffer is at least INT2STR_MAX_LEN in size */ -static inline char* int2strbuf(unsigned int l, char *r, int* len) +static inline char* int2strbuf(unsigned int l, char *r, int r_size, int* len) { int i; - + + if(unlikely(r_size<INT2STR_MAX_LEN)) { + if (len) + *len = 0; + return 0; /* => if someone misuses it => crash (feature no. 1) */ + } i=INT2STR_MAX_LEN-2; r[INT2STR_MAX_LEN-1]=0; /* null terminate */ do{ @@ -316,7 +321,7 @@ extern char ut_buf_int2str[INT2STR_MAX_LEN]; /* returns a pointer to a static buffer containing l in asciiz & sets len */ static inline char* int2str(unsigned long l, int* len) { - return int2strbuf(l, ut_buf_int2str, len); + return int2strbuf(l, ut_buf_int2str, INT2STR_MAX_LEN, len); } /* Signed INTeger-TO-STRing: convers a long to a string

15 years

SF.net SVN: openser:[5979] tags/1.4.5/

by Daniel-Constantin Mierla

Revision: 5979 http://openser.svn.sourceforge.net/openser/?rev=5979&view=rev Author: miconda Date: 2010-02-02 21:31:30 +0000 (Tue, 02 Feb 2010) Log Message: ----------- Tagging the 1.4.5 release Added Paths: ----------- tags/1.4.5/ This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

15 years

SF.net SVN: openser:[5978] tags/1.5.4/

by Daniel-Constantin Mierla

Revision: 5978 http://openser.svn.sourceforge.net/openser/?rev=5978&view=rev Author: miconda Date: 2010-02-02 21:30:47 +0000 (Tue, 02 Feb 2010) Log Message: ----------- Tagging the 1.5.4 release Added Paths: ----------- tags/1.5.4/ This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

15 years

← Newer
1
...
15
16
17
18
19
20
21
...
25
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2010