Revision: 6022
http://openser.svn.sourceforge.net/openser/?rev=6022&view=rev
Author: henningw
Date: 2010-07-23 11:48:35 +0000 (Fri, 23 Jul 2010)
Log Message:
-----------
* also update README after doc change
Modified Paths:
--------------
branches/1.5/modules/dialog/README
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
Module: sip-router
Branch: kamailio_3.0
Commit: 12894357413fe9fc91fc115d28d7fd523c1955f6
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1289435…
Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro>
Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro>
Date: Fri Jul 23 11:32:25 2010 +0300
modules_k/pv : Fixed a bug in pv transformation (tobody transformation), that caused a segmentation fault.
The bug was caused by a incorrect error handling of the parse_to() method (defined in parser/parse_to.c).
The function returns a char* (pointer to the last character parsed), in case of error it updates an error status.
On incorrect to params, a segmentation fault happened after some time.(Because of a double pkg_free).
(cherry picked from commit e7096bf24310b71623520a3b963ddc50c111827c)
---
modules_k/pv/pv_trans.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/modules_k/pv/pv_trans.c b/modules_k/pv/pv_trans.c
index d9120de..f8e7347 100644
--- a/modules_k/pv/pv_trans.c
+++ b/modules_k/pv/pv_trans.c
@@ -950,7 +950,8 @@ int tr_eval_tobody(struct sip_msg *msg, tr_param_t *tp, int subtype,
/* parse params */
sv = _tr_tobody_str;
- if (parse_to(sv.s, sv.s + sv.len + 2, &_tr_tobody)<0)
+ parse_to(sv.s, sv.s + sv.len + 2, &_tr_tobody);
+ if (_tr_tobody.error == PARSE_ERROR)
{
memset(&_tr_tobody, 0, sizeof(struct to_body));
pkg_free(_tr_tobody_str.s);
Hi, it would be very useful if custom variables could be attached to a
dialog, and also the possibility of retreving, via MI, the list of
dialogs with a specific variable value and also terminating it.
In my case when my kamailio handles a call it sets it a "client_name"
profile which is enough to list/terminate all the calls belonging to
such client.
But sometimes I need to terminate those calls with a specific CLI, and
the CLI is not the From username but a custon PAI inserted by
Kamailio. This info is not stored with the dialog.
A workaround could be settting the dialog in two profiles: client_name
and PAI, but I think it's not very elegant.
Also I think that storing custom variables within each dialog could be
very useful for other subjects.
Opinions? Thanks.
--
Iñaki Baz Castillo
<ibc(a)aliax.net>
Module: sip-router
Branch: master
Commit: e7096bf24310b71623520a3b963ddc50c111827c
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e7096bf…
Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro>
Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro>
Date: Fri Jul 23 11:32:25 2010 +0300
modules_k/pv : Fixed a bug in pv transformation (tobody transformation), that caused a segmentation fault.
The bug was caused by a incorrect error handling of the parse_to() method (defined in parser/parse_to.c).
The function returns a char* (pointer to the last character parsed), in case of error it updates an error status.
On incorrect to params, a segmentation fault happened after some time.(Because of a double pkg_free).
---
modules_k/pv/pv_trans.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/modules_k/pv/pv_trans.c b/modules_k/pv/pv_trans.c
index dbe2ab7..5d60d04 100644
--- a/modules_k/pv/pv_trans.c
+++ b/modules_k/pv/pv_trans.c
@@ -987,7 +987,8 @@ int tr_eval_tobody(struct sip_msg *msg, tr_param_t *tp, int subtype,
/* parse params */
sv = _tr_tobody_str;
- if (parse_to(sv.s, sv.s + sv.len + 2, &_tr_tobody)<0)
+ parse_to(sv.s, sv.s + sv.len + 2, &_tr_tobody);
+ if (_tr_tobody.error == PARSE_ERROR)
{
memset(&_tr_tobody, 0, sizeof(struct to_body));
pkg_free(_tr_tobody_str.s);