sr-dev July 2010

sr-dev@lists.kamailio.org

29 participants
223 discussions

by axlh＠users.sourceforge.net

Revision: 6030 http://openser.svn.sourceforge.net/openser/?rev=6030&view=rev Author: axlh Date: 2010-07-27 17:48:46 +0000 (Tue, 27 Jul 2010) Log Message: ----------- Fix transformation tobody.params when parameter list ends with a quoted value. The resulting string was truncated by 2 characters. Solution is to store the entire parameter list as a string in the to_body struct. Modified Paths: -------------- branches/1.5/modules/pv/pv_trans.c branches/1.5/parser/parse_to.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

14 years, 3 months

git:kamailio_3.0: auth_db(k): proper initialization for the default column

by Henning Westerholt

Module: sip-router Branch: kamailio_3.0 Commit: 4215ccd295c1f04ce22ef043887f24f4bb686fe8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4215ccd… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Tue Jul 27 18:51:07 2010 +0200 auth_db(k): proper initialization for the default column (cherry picked from commit 42a27402b74d44eebd702bcd5b5afa598205b520) --- modules_k/auth_db/authdb_mod.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/auth_db/authdb_mod.c b/modules_k/auth_db/authdb_mod.c index e3df1f5..48f7516 100644 --- a/modules_k/auth_db/authdb_mod.c +++ b/modules_k/auth_db/authdb_mod.c @@ -177,7 +177,7 @@ static int mod_init(void) user_column.len = strlen(user_column.s); domain_column.len = strlen(domain_column.s); pass_column.len = strlen(pass_column.s); - pass_column_2.len = strlen(pass_column.s); + pass_column_2.len = strlen(pass_column_2.s); /* Find a database module */ if (db_bind_mod(&db_url, &auth_dbf) < 0){

14 years, 3 months

git:master: auth_db(k): proper initialization for the default column

by Henning Westerholt

Module: sip-router Branch: master Commit: 42a27402b74d44eebd702bcd5b5afa598205b520 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=42a2740… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Tue Jul 27 18:51:07 2010 +0200 auth_db(k): proper initialization for the default column --- modules_k/auth_db/authdb_mod.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/auth_db/authdb_mod.c b/modules_k/auth_db/authdb_mod.c index f7eb782..fa15447 100644 --- a/modules_k/auth_db/authdb_mod.c +++ b/modules_k/auth_db/authdb_mod.c @@ -179,7 +179,7 @@ static int mod_init(void) user_column.len = strlen(user_column.s); domain_column.len = strlen(domain_column.s); pass_column.len = strlen(pass_column.s); - pass_column_2.len = strlen(pass_column.s); + pass_column_2.len = strlen(pass_column_2.s); /* Find a database module */ if (db_bind_mod(&db_url, &auth_dbf) < 0){

14 years, 3 months

SF.net SVN: openser:[6028] branches/1.5/modules/auth_db/authdb_mod.c

by Henning Westerholt

Revision: 6028 http://openser.svn.sourceforge.net/openser/?rev=6028&view=rev Author: henningw Date: 2010-07-27 16:49:58 +0000 (Tue, 27 Jul 2010) Log Message: ----------- * proper initialization for the default column Modified Paths: -------------- branches/1.5/modules/auth_db/authdb_mod.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

14 years, 3 months

[ openser-Patches-3035382 ] Fix transformation tobody.params

by SourceForge.net

Patches item #3035382, was opened at 2010-07-27 18:11 Message generated for change (Settings changed) made by axlh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035382&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) >Summary: Fix transformation tobody.params Initial Comment: The transofrmation tobody.params can't handle quoted parameters well. If the last parameter is quoted, the output of the transofrmation is truncated by 2 characters.. Attached patch fixes this. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035382&group_…

14 years, 3 months

[ openser-Patches-3035382 ] Fix transofrmation toboyd.params

by SourceForge.net

Patches item #3035382, was opened at 2010-07-27 18:11 Message generated for change (Tracker Item Submitted) made by axlh You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035382&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Fix transofrmation toboyd.params Initial Comment: The transofrmation tobody.params can't handle quoted parameters well. If the last parameter is quoted, the output of the transofrmation is truncated by 2 characters.. Attached patch fixes this. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743022&aid=3035382&group_…

14 years, 3 months

git:master: modules_k/dialog: Prevent "unable to find dialog" WARN messages

by Timo Reimann

Module: sip-router Branch: master Commit: 9b7f25d7196e41cbcc77c1d6e316cb1a8664ed81 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9b7f25d… Author: Timo Reimann <timo.reimann(a)1und1.de> Committer: Timo Reimann <timo.reimann(a)1und1.de> Date: Tue Jul 27 14:37:06 2010 +0200 modules_k/dialog: Prevent "unable to find dialog" WARN messages caused by accessing a dialog in the "deleted" state (often happens with simultaneous BYE requests when both UAs hang up at the same time). - Move POINTER_CLOSED_MARKER from dlg_cb.c into dlg_hash.h for common usage. - in lookup_dlg() and internal_get_dlg(), return POINTER_CLOSED_MARKER when dialog is found but in the DLG_STATE_DELETED state. - in dlg_onroute(), abort request processing if dialog is found to be in the "deleted" state. --- modules_k/dialog/dlg_cb.c | 2 -- modules_k/dialog/dlg_handlers.c | 6 +++++- modules_k/dialog/dlg_hash.c | 7 ++++--- modules_k/dialog/dlg_hash.h | 2 ++ 4 files changed, 11 insertions(+), 6 deletions(-) diff --git a/modules_k/dialog/dlg_cb.c b/modules_k/dialog/dlg_cb.c index 24b3b39..464083e 100644 --- a/modules_k/dialog/dlg_cb.c +++ b/modules_k/dialog/dlg_cb.c @@ -43,8 +43,6 @@ static struct dlg_head_cbl* load_cbs = 0; static struct dlg_cb_params params = {NULL, DLG_DIR_NONE, NULL, NULL}; -#define POINTER_CLOSED_MARKER ((void *)(-1)) - static void run_load_callback(struct dlg_callback *cb); diff --git a/modules_k/dialog/dlg_handlers.c b/modules_k/dialog/dlg_handlers.c index 976ac0f..a3610cc 100644 --- a/modules_k/dialog/dlg_handlers.c +++ b/modules_k/dialog/dlg_handlers.c @@ -824,7 +824,11 @@ void dlg_onroute(struct sip_msg* req, str *route_params, void *param) return; dlg = lookup_dlg( h_entry, h_id); - if (dlg==0) { + if (dlg == POINTER_CLOSED_MARKER) { + LM_DBG("dialog marked for destruction, ignoring\n"); + return; + } + else if (dlg==0) { LM_WARN("unable to find dialog for %.*s " "with route param '%.*s' [%u:%u]\n", req->first_line.u.request.method.len, diff --git a/modules_k/dialog/dlg_hash.c b/modules_k/dialog/dlg_hash.c index 6df21e3..b3d626b 100644 --- a/modules_k/dialog/dlg_hash.c +++ b/modules_k/dialog/dlg_hash.c @@ -378,7 +378,8 @@ struct dlg_cell* lookup_dlg( unsigned int h_entry, unsigned int h_id) if (dlg->h_id == h_id) { if (dlg->state==DLG_STATE_DELETED) { dlg_unlock( d_table, d_entry); - goto not_found; + LM_DBG("dialog id=%u on entry %u marked for deletion\n", h_id, h_entry); + return POINTER_CLOSED_MARKER; } dlg->ref++; LM_DBG("ref dlg %p with 1 -> %d\n", dlg, dlg->ref); @@ -418,8 +419,9 @@ static inline struct dlg_cell* internal_get_dlg(unsigned int h_entry, /* Check callid / fromtag / totag */ if (match_dialog( dlg, callid, ftag, ttag, dir)==1) { if (dlg->state==DLG_STATE_DELETED) { + LM_DBG("dialog callid='%.*s' marked for deletion\n", callid->len, callid->s); dlg_unlock( d_table, d_entry); - goto not_found; + return POINTER_CLOSED_MARKER; } dlg->ref++; LM_DBG("ref dlg %p with 1 -> %d\n", dlg, dlg->ref); @@ -432,7 +434,6 @@ static inline struct dlg_cell* internal_get_dlg(unsigned int h_entry, dlg_unlock( d_table, d_entry); -not_found: LM_DBG("no dialog callid='%.*s' found\n", callid->len, callid->s); return 0; } diff --git a/modules_k/dialog/dlg_hash.h b/modules_k/dialog/dlg_hash.h index 889a318..6aa6db5 100644 --- a/modules_k/dialog/dlg_hash.h +++ b/modules_k/dialog/dlg_hash.h @@ -83,6 +83,8 @@ #define DLG_DIR_DOWNSTREAM 1 /*!< dialog has downstream direction */ #define DLG_DIR_UPSTREAM 2 /*!< dialog has upstream direction */ +#define POINTER_CLOSED_MARKER ((void *)(-1)) + /*! entries in the dialog list */ struct dlg_cell

14 years, 3 months

git:master: reg(k): extend notes about the case_sensitive parameter

by Henning Westerholt

Module: sip-router Branch: master Commit: b0c6ef43a57f5fd209bf743af0eb32611449667a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b0c6ef4… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Tue Jul 27 14:53:57 2010 +0200 reg(k): extend notes about the case_sensitive parameter --- modules_k/registrar/README | 7 ++++--- modules_k/registrar/doc/registrar_admin.xml | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/modules_k/registrar/README b/modules_k/registrar/README index 2dcdfbc..55968f0 100644 --- a/modules_k/registrar/README +++ b/modules_k/registrar/README @@ -375,9 +375,10 @@ modparam("registrar", "aor_avp", "$avp(i:3223)") 3.9. case_sensitive (integer) - If set to 1 then AOR comparison will be case sensitive, if set to 0 - then AOR comparison will be case insensitive--This is recommended.This - parameter can be modified via ser config framework. + If set to 1 then AOR comparison and also storing will be case + sensitive, if set to 0 then AOR comparison and storing will be case + insensitive--This is recommended. This parameter can be modified via + ser config framework. Default value is 0. diff --git a/modules_k/registrar/doc/registrar_admin.xml b/modules_k/registrar/doc/registrar_admin.xml index 282e22e..ec553ed 100644 --- a/modules_k/registrar/doc/registrar_admin.xml +++ b/modules_k/registrar/doc/registrar_admin.xml @@ -309,9 +309,10 @@ modparam("registrar", "aor_avp", "$avp(i:3223)") <section> <title><varname>case_sensitive</varname> (integer)</title> <para> - If set to 1 then <acronym>AOR</acronym> comparison will be case - sensitive, if set to 0 then <acronym>AOR</acronym> comparison will - be case insensitive--This is recommended.This parameter can be modified via ser config framework. + If set to 1 then <acronym>AOR</acronym> comparison and also + storing will be case sensitive, if set to 0 then <acronym>AOR</acronym> + comparison and storing will be case insensitive--This is recommended. + This parameter can be modified via ser config framework. </para> <para> <emphasis>

14 years, 3 months

[tracker] Comment added: patch to add method masking to xlog function

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#81 - patch to add method masking to xlog function User who did this - Daniel-Constantin Mierla (miconda) ---------- It affects all configs, maybe it does not require changes in config to get it, but there is impact on every xlog function. Anyhow, back to subject, you can call existing functions from new function, so no copy of existing code -- by having an extra parameter, like flags (i.e., log level, flag, message), you can control everything. I don't think a search/replace is a big stopper for one that wants to enable such filtering in his config. Is what I do for cases where I want to print the cfg name and line -- there was added a new function called xlogl(). The case now is not only about method based filtering, this is really a particular case for your specific needs. Tomorrow someone else might come and say he wants to extend the filtering with other rules (source ip, time of the day, user, etc...). Furthermore, enabling it makes no option of printing messages -- say I want to print a message for each incoming request (e.g., tracing everything for security reasons) but then skip the rest of messages which can be just for troubleshooting. I think there must be the basic function available, as it is since 2003, small wrappers around them harm less than making these functions too heavy. And since we got in this discussion, there is a pretty nice solution already for your case: - say $shv(request_filter) is the shared variable holding the methods mask - use: xlog("$var(log)", "your message"); - at the top of your main route do: if($shv(request_filter) & $rm) $var(log) = 0; # or your desired log level (see the readme of xlog) else $var(log) = 100; # the message won't be printed by exceeding 'debug' value So you are set, the all xlog functions using $var(log) as parameter will not print anything if the bitmask is matched. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=81#comment103 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

14 years, 3 months

SF.net SVN: openser:[6027] branches/1.5/modules/dialog

by Timo Reimann

Revision: 6027 http://openser.svn.sourceforge.net/openser/?rev=6027&view=rev Author: timoreimann Date: 2010-07-27 13:48:22 +0000 (Tue, 27 Jul 2010) Log Message: ----------- modules/dialog: Prevent "unable to find dialog" WARN messages caused by accessing a dialog in the "deleted" state (often happens with simultaneous BYE requests when both UAs hang up at the same time). - Move POINTER_CLOSED_MARKER from dlg_cb.c into dlg_hash.h for common usage. - in lookup_dlg() and internal_get_dlg(), return POINTER_CLOSED_MARKER when dialog is found but in the DLG_STATE_DELETED state. - in dlg_onroute(), abort request processing if dialog is found to be in the "deleted" state. Modified Paths: -------------- branches/1.5/modules/dialog/dlg_cb.c branches/1.5/modules/dialog/dlg_handlers.c branches/1.5/modules/dialog/dlg_hash.c branches/1.5/modules/dialog/dlg_hash.h This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

14 years, 3 months

← Newer
1
...
4
5
6
7
8
9
10
...
23
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2010