THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#87 - make install fails with a bash syntax error
User who did this - Daniel-Constantin Mierla (miconda)
----------
What exactly was wrong?
I see you added a whitespace, the patch is harmless, but same constructi is used for target "install-sr-man", do you get error there as well (when man pages are installed)?
Remove the '@' in front of that 'for' and do 'make install-cfg'. It will print the shell script to be executed, paste it here to see what is potentially wrong.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=87#comment122
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#87 - make install fails with a bash syntax error
User who did this - Dmitry Goncharov (Dmitry)
----------
I figured out what was wrong. Please, have a look at this patch.
----------
One or more files have been attached.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=87#comment121
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task is now closed:
FS#85 - Bug in dispatcher module and fix
User who did this - Daniel-Constantin Mierla (miconda)
Reason for closing: Fixed
Additional comments about closing: Re-open if the fix mentioned in previous comment didn't do it.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=85
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#87 - make install fails with a bash syntax error
User who did this - Daniel-Constantin Mierla (miconda)
----------
Maybe the error comes from missing whitespace between ""; . Can you try with:
@for r in $(C_INSTALL_CFGS) "" ; do \
There are lot of 'for' that have the 'do' on the same line, they should fail as well if that is the problem.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=87#comment120
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
Module: sip-router
Branch: master
Commit: 7560e490b643642e79ed8dd95c575c08906e0608
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7560e49…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: Tue Sep 7 21:28:39 2010 +0200
dispatcher(k): updated docs with default value for ds_ping_interval
- in source code is 0
- reported by Klaus Darilion
---
modules_k/dispatcher/README | 9 +++++----
modules_k/dispatcher/doc/dispatcher_admin.xml | 7 ++++---
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/modules_k/dispatcher/README b/modules_k/dispatcher/README
index 35b73c3..b458910 100644
--- a/modules_k/dispatcher/README
+++ b/modules_k/dispatcher/README
@@ -456,11 +456,12 @@ Note
3.18. ds_ping_interval (int)
- With this Method you can define the interval for sending a request to a
- failed gateway. This parameter is only used, when the TM-Module is
- loaded. If set to “0”, the pinging of failed requests is disabled.
+ With this parameter you can define the interval for sending a request
+ to a gateway marked as inactive upon a failed request routing to it.
+ This parameter is only used, when the TM-Module is loaded. If set to
+ “0”, the pinging of inactive gateway is disabled.
- Default value is “10”.
+ Default value is “0”.
Example 1.19. Set the “ds_ping_interval” parameter
...
diff --git a/modules_k/dispatcher/doc/dispatcher_admin.xml b/modules_k/dispatcher/doc/dispatcher_admin.xml
index e7d7012..592e7f9 100644
--- a/modules_k/dispatcher/doc/dispatcher_admin.xml
+++ b/modules_k/dispatcher/doc/dispatcher_admin.xml
@@ -456,13 +456,14 @@ modparam("dispatcher", "force_dst", 1)
<section>
<title><varname>ds_ping_interval</varname> (int)</title>
<para>
- With this Method you can define the interval for sending a request to a failed gateway.
+ With this parameter you can define the interval for sending a request
+ to a gateway marked as inactive upon a failed request routing to it.
This parameter is only used, when the TM-Module is loaded.
- If set to <quote>0</quote>, the pinging of failed requests is disabled.
+ If set to <quote>0</quote>, the pinging of inactive gateway is disabled.
</para>
<para>
<emphasis>
- Default value is <quote>10</quote>.
+ Default value is <quote>0</quote>.
</emphasis>
</para>
<example>
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#56 - Cfg parsing error for alias/listen and custom global parameter
User who did this - Andrei Pelinescu-Onciul (andrei)
----------
It happens because of an ambiguity in the grammar with alias and listen followed by a config var.
Both alias and listen can have an unquoted host list as value. An unquoted host is a list of
IDs separated by '.'. Since EOL is not taken into account (it's considered normal whitespace), alias=foo.bar followed by myvar.msg="..." is interpreted as:
alias=foo.bar myvar.msg
="..." <- error
An workaround for this (besides not having config variables after alias or host) is to add ';' after alias.
E.g.:
alias="foo.bar";
myvar.msg="...."
I don't think it can be fixed without adding an incompatible config syntax change.
We could add a special prefix for config vars. (e.g cfgvar myvar.msg="..."), document it as the right way and add an "obsolete" warning for cfg. vars declared without this prefix.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=56#comment119
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab.
FS#56 - Cfg parsing error for alias/listen and custom global parameter
User who did this: Andrei Pelinescu-Onciul (andrei)
Severity: Medium -> Very Low
Priority: Normal -> Low
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=56
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#87 - make install fails with a bash syntax error
User who did this - Dmitry Goncharov (Dmitry)
----------
Yes, the change is moving 'do' to the next line.
This small bash session demonstrates the problem.
$
$ git remote -v
origin git://git.sip-router.org/sip-router (fetch)
origin git://git.sip-router.org/sip-router (push)
$ git br
* kamailio_3.0
master
$ git st
# On branch kamailio_3.0
nothing to commit (working directory clean)
$ make install-cfg
Makefile.defs defs skipped
/bin/sh: -c: line 18: syntax error near unexpected token `fi'
/bin/sh: -c: line 18: ` fi ; \'
make: *** [install-cfg] Error 1
$ patch -p1 < ../kamailio-3.0.3-makefile.diff
patching file Makefile
$ git diff | cat
diff --git a/Makefile b/Makefile
index 210d277..90f6b21 100644
--- a/Makefile
+++ b/Makefile
@@ -918,7 +918,8 @@ install-cfg: $(cfg_prefix)/$(cfg_dir)
fi; \
fi
@# other configs
- @for r in $(C_INSTALL_CFGS) ""; do \
+ @for r in $(C_INSTALL_CFGS) ""; \
+ do \
if [ -n "$$r" ]; then \
if [ -f "$$r" ]; then \
n=`basename "$$r"` ; \
$ make install-cfg
Makefile.defs defs skipped
# radius dictionary
touch //etc/kamailio//dictionary.kamailio
install -m 644 etc/dictionary.kamailio //etc/kamailio/
$
$
$
$ bash --version
GNU bash, version 4.1.7(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
$ make --version
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
This program built for x86_64-pc-linux-gnu
$
This reproduces on two x86_64 gentoo.
This does not reproduce on i686 gentoo with same bash and make.
Also, this does not reproduce with bash 3.2.39(1)-release and the same make on i686 ubuntu.
Maybe something is broken on both of my x86_64.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=87#comment118
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.