THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#165 - crash/segfault on shutdown since commit 7b3a6ec
User who did this - Daniel-Constantin Mierla (miconda)
----------
Also, maybe you can paste here the log messages when the shutdown start (with debug=3)
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=165#comment296
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#165 - crash/segfault on shutdown since commit 7b3a6ec
User who did this - Daniel-Constantin Mierla (miconda)
----------
Can you reproduce it every time? I tried combinations and shut down was fine. I used -M 6 and killed the main process or all processes (killall). How do you stop it?
Crashing at that line is a bit weird, since it is printing a static string to syslog, which is not dynamic allocated value, thus not in pkg.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=165#comment295
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
Module: sip-router
Branch: master
Commit: 20599670ead5e94f9b3716eaf6e05324eb99b39d
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2059967…
Author: Juha Heinanen <jh(a)tutpro.com>
Committer: Juha Heinanen <jh(a)tutpro.com>
Date: Thu Oct 6 21:25:38 2011 +0300
modules/lcr/utils/lcr_upgrade_from_3.1.sh: upgraded also lcr_gw index.
---
modules/lcr/utils/lcr_upgrade_from_3.1.sh | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/modules/lcr/utils/lcr_upgrade_from_3.1.sh b/modules/lcr/utils/lcr_upgrade_from_3.1.sh
index 3db7022..b8d30ee 100644
--- a/modules/lcr/utils/lcr_upgrade_from_3.1.sh
+++ b/modules/lcr/utils/lcr_upgrade_from_3.1.sh
@@ -45,9 +45,12 @@ function upgrade_lcr_gw_table() {
or die("Failed to alter 'ser/lcr_gw' table!\n");
mysql_query("ALTER TABLE lcr_gw ADD COLUMN tag VARCHAR(64) DEFAULT NULL AFTER prefix")
or die("Failed to alter 'ser/lcr_gw' table!\n");
+ mysql_query("ALTER TABLE lcr_gw DROP INDEX lcr_id_ip_addr_port_hostname_idx")
+ or die ("Failed to drop 'ser/lcr_gw' index\n");
+ mysql_query("ALTER TABLE lcr_gw ADD INDEX lcr_id_idx (lcr_id)")
+ or die ("Failed to add 'ser/lcr_gw' index\n");
mysql_query("UPDATE version SET table_version=2 WHERE table_name='lcr_gw'")
or die ("Failed to update into 'ser/version' table\n");
-
db_disconnect();
echo "Table 'ser/lcr_gw' upgraded\n";
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task is now closed:
FS#164 - core keyword 'method'broken in onreply_route
User who did this - Daniel-Constantin Mierla (miconda)
Reason for closing: Fixed
Additional comments about closing: Actually this seems to be a feature enhancement, since it was this way from the beginning (at least I checked 1.5). But it is confusing enough if does not work in reply route to be considered a bug. Commit to fix it in in master. Reopen if does not work.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=164
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
Daniel-Constantin Mierla has taken ownership of the following task:
FS#164 - core keyword 'method'broken in onreply_route
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=164
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A new Flyspray task has been opened. Details are below.
User who did this - Alex Hermann (axlh)
Attached to Project - sip-router
Summary - crash/segfault on shutdown since commit 7b3a6ec
Task Type - Bug Report
Category - Core
Status - Assigned
Assigned To - Andrei Pelinescu-Onciul
Operating System - All
Severity - Low
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - On my git master installations, Kamailio segfaults on logging "Thanks
for flying Kamailio" on shutdown (backtrace below). A bisection on
the repository pointed to the following commit as the culprit:
commit 7b3a6eca7bb6dd1ca2a1395ca1e5821808ec85cd
Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org>
Date: Tue Apr 12 21:54:07 2011 +0200
core: pkg mem size configurable form the cmd line
The pkg mem size used can be configured by using the "-M"
parameter on the command line, e.g.:
ser -M 8 -f test.cfg # start ser with 8mb of pkg memory
The default remains 4Mb.
The following patch works around the issue, but maybe someone more
knowledgable in this part of the code can create a real fix.
commit 73cbfbba811b964b6a8db1096d97b4af503c030a
Author: Alex Hermann <alex(a)speakup.nl>
Date: Thu Sep 1 14:07:59 2011 +0200
core: disable logging on shutdown after killing children, causing segfault
diff --git a/main.c b/main.c
index 45f0a6a..28adbe0 100644
--- a/main.c
+++ b/main.c
@@ -701,7 +701,6 @@ void handle_sigs()
DBG("SIGTERM received, program terminates\n");
/* shutdown/kill all the children */
shutdown_children(SIGTERM, 1);
- LOG(L_NOTICE, "Thank you for flying " NAME "\n");
exit(0);
break;
Backtrace:
Core was generated by `/usr/sbin/kamailio -f /home/alex/balancer/kamailio.cfg -m 64 -M 6 -u'.
Program terminated with signal 11, Segmentation fault.
#0 __strlen_sse2 () at ../sysdeps/x86_64/multiarch/../strlen.S:31
31 ../sysdeps/x86_64/multiarch/../strlen.S: No such file or directory.
in ../sysdeps/x86_64/multiarch/../strlen.S
(gdb) bt full
#0 __strlen_sse2 () at ../sysdeps/x86_64/multiarch/../strlen.S:31
No locals.
#1 0x00007f7cdd820aee in *__GI_fputs_unlocked (str=0x7f7cdd1fc480 <Address 0x7f7cdd1fc480 out of bounds>, fp=0x1dcf2d0) at iofputs_u.c:37
result = <value optimized out>
#2 0x00007f7cdd8831eb in *__GI___vsyslog_chk (pri=<value optimized out>, flag=-1, fmt=<value optimized out>, ap=0x7fffb73d9bb0) at ../misc/syslog.c:207
now_tm = {tm_sec = 44, tm_min = 54, tm_hour = 10, tm_mday = 1, tm_mon = 8, tm_year = 111, tm_wday = 4, tm_yday = 243, tm_isdst = 1, tm_gmtoff = 7200, tm_zone = 0x1d3fde0 "CEST"}
now = 1314867284
fd = <value optimized out>
f = <value optimized out>
buf = 0x0
bufsize = 0
msgoff = <value optimized out>
saved_errno = 10
failbuf = "\000\000\000\000\000\000\000\000\377\377\377\377\000\000\000\000\340\241~\335|\177\000\000\r\241~\335|"
clarg = {buf = 0x1, oldaction = 0x2000}
#3 0x00007f7cdd8837d0 in __syslog (pri=-585120640, fmt=0x15 <Address 0x15 out of bounds>) at ../misc/syslog.c:119
ap = {{gp_offset = 16, fp_offset = 48, overflow_arg_area = 0x7fffb73d9c90, reg_save_area = 0x7fffb73d9bd0}}
#4 0x0000000000460744 in handle_sigs () at main.c:704
chld = <value optimized out>
chld_status = <value optimized out>
memlog = <value optimized out>
#5 0x0000000000462736 in main_loop () at main.c:1709
i = 8
pid = <value optimized out>
si = 0x0
si_desc = "udp receiver child=7 sock=xxx.xxx.xxx.xxx:8060\000\000\030E#\335|\177\000\000\005\000\000\000\002\000\000\000\003", '\000' <repeats 15 times>"\240, =\214", '\000' <repeats 29 times>"\240, \277=\267\377\177\000\000GNJ\000\000\000\000"
#6 0x0000000000463dd3 in main (argc=1, argv=0x7fffb73d9f18) at main.c:2471
cfg_stream = <value optimized out>
c = <value optimized out>
r = <value optimized out>
tmp = 0x7fffb73dbf8b ""
tmp_len = 0
port = <value optimized out>
proto = <value optimized out>
ret = <value optimized out>
seed = 1436424957
rfd = <value optimized out>
debug_save = 0
debug_flag = 0
dont_fork_cnt = 0
n_lst = 0x0
p = <value optimized out>
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=165
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A user has added themself to the list of users assigned to this task.
FS#165 - crash/segfault on shutdown since commit 7b3a6ec
User who did this - Alex Hermann (axlh)
http://sip-router.org/tracker/index.php?do=details&task_id=165
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A new Flyspray task has been opened. Details are below.
User who did this - Alex Hermann (axlh)
Attached to Project - sip-router
Summary - core keyword 'method'broken in onreply_route
Task Type - Bug Report
Category - Core
Status - Assigned
Assigned To - Andrei Pelinescu-Onciul
Operating System - All
Severity - Low
Priority - Normal
Reported Version - Development
Due in Version - Undecided
Due Date - Undecided
Details - The core keyword 'method' is broken in onreply_route.
There is no limitation on route type mentioned in the docs. In failure_route it works correctly.
See example below:
route {
xlog("Request method: $rm");
if (is_method("INVITE")) {
xlog("is_method(\"INVITE\") == 1");
}
if (method == "INVITE") {
xlog("method == \"INVITE\" == 1");
}
t_on_reply(DEFAULT);
t_relay();
}
onreply_route[DEFAULT] {
xlog("Reply method: $rm");
if (is_method("INVITE")) {
xlog("is_method(\"INVITE\") == 1");
}
if (method == "INVITE") {
xlog("method == \"INVITE\" == 1");
}
}
Result:
Oct 6 13:26:07 devprx01 proxy3[24356]: ERROR: Request method: INVITE
Oct 6 13:26:07 devprx01 proxy3[24356]: ERROR: is_method("INVITE") == 1
Oct 6 13:26:07 devprx01 proxy3[24356]: ERROR: method == "INVITE" == 1
Oct 6 13:26:08 devprx01 proxy3[24358]: ERROR: Reply method: INVITE
Oct 6 13:26:08 devprx01 proxy3[24358]: ERROR: is_method("INVITE") == 1
<missing log line because of failed method test>
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=164
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.