sr-dev November 2011

sr-dev@lists.kamailio.org

31 participants
341 discussions

git:master: auth: added new error code to auth API
by Daniel-Constantin Mierla 15 Nov '11

15 Nov '11

Module: sip-router Branch: master Commit: 7ea685c439f5081e9bf7f9e37c62cdcfb2638bcb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7ea685c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Nov 14 22:07:50 2011 +0100 auth: added new error code to auth API - AUTH_USER_MISMATCH = -8 -- to be returned when auth user mistmach from/to header user --- modules/auth/api.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/auth/api.h b/modules/auth/api.h index 976a547..9e21c0c 100644 --- a/modules/auth/api.h +++ b/modules/auth/api.h @@ -44,6 +44,7 @@ * return codes to config by auth functions */ typedef enum auth_cfg_result { + AUTH_USER_MISMATCH = -8, /*!< Auth user != From/To user */ AUTH_NONCE_REUSED = -6, /*!< Returned if nonce is used more than once */ AUTH_NO_CREDENTIALS = -5, /*!< Credentials missing */ AUTH_STALE_NONCE = -4, /*!< Stale nonce */

3 5

[tracker] Comment added: Kamailio 3.2.0 postgresql 9.1.1 connection problems.
by sip-router 15 Nov '11

15 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#178 - Kamailio 3.2.0 postgresql 9.1.1 connection problems. User who did this - Nick Altmann (nikbyte) ---------- 0(435) ERROR: db_postgres [km_pg_con.c:82]: connection pointer is NULL 0(435) ERROR: db_postgres [km_pg_con.c:95]: cleaning up 0x7fb7c8970e10=pkg_free() 0(435) ERROR: <core> [db.c:302]: could not add connection to the pool 0(435) ERROR: usrloc [ul_mod.c:360]: child(0): failed to connect to database 0(435) ERROR: <core> [sr_module.c:882]: init_mod_child(): Error while initializing module usrloc (//lib64/kamailio/modules_k/usrloc.so) 0(435) ERROR: <core> [main.c:1388]: ERROR: main_dontfork: init_child(PROC_MAIN) -- exiting ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=178#comment359 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Kamailio 3.2.0 postgresql 9.1.1 connection problems.
by sip-router 15 Nov '11

15 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#178 - Kamailio 3.2.0 postgresql 9.1.1 connection problems. User who did this - Nick Altmann (nikbyte) ---------- I had working server with 3.2.0 and postgresql 9.0. Fedora 14. SELinux disabled, firewall has not rate limit rules. Postgresql on the same server. Mysql also connected to this configuration. Nothing changes. I upgraded to postgresql 9.1.1 and kamailio doesn't start. :-( I tries to disable module by module and when I disable usrloc it starts. After, I upgrade kamailio to 3.3.0 from git and it starts and works. No changes in configuration. 3.2.0 doesn't start, 3.3.0 does start. Mystical problem. :-) ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=178#comment358 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:treimann/master_tm-extend-callbacks: tm: Pass transaction as parameter to callback for CANCEL request.
by Timo Reimann 14 Nov '11

14 Nov '11

Module: sip-router Branch: treimann/master_tm-extend-callbacks Commit: 958328f023cc5a150c7860d98bf5e682a0a5c1e9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=958328f… Author: Timo Reimann <sr(a)foo-lounge.de> Committer: Timo Reimann <sr(a)foo-lounge.de> Date: Tue Nov 15 00:37:48 2011 +0100 tm: Pass transaction as parameter to callback for CANCEL request. --- modules/tm/t_cancel.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/tm/t_cancel.c b/modules/tm/t_cancel.c index 7c225e8..1a37213 100644 --- a/modules/tm/t_cancel.c +++ b/modules/tm/t_cancel.c @@ -328,9 +328,9 @@ int cancel_branch( struct cell *t, int branch, DBG("DEBUG: cancel_branch: sending cancel...\n"); if (SEND_BUFFER( crb )>=0){ if (unlikely (has_tran_tmcbs(t, TMCB_REQUEST_OUT))) - run_trans_callbacks_with_buf(TMCB_REQUEST_OUT, crb, 0, 0, TMCB_LOCAL_F); + run_trans_callbacks_with_buf(TMCB_REQUEST_OUT, crb, t->uas.request, 0, TMCB_LOCAL_F); if (unlikely (has_tran_tmcbs(t, TMCB_REQUEST_SENT))) - run_trans_callbacks_with_buf(TMCB_REQUEST_SENT, crb, 0, 0, TMCB_LOCAL_F); + run_trans_callbacks_with_buf(TMCB_REQUEST_SENT, crb, t->uas.request, 0, TMCB_LOCAL_F); } /*sets and starts the FINAL RESPONSE timer */ if (start_retr( crb )!=0)

1 0

git:treimann/master_tm-extend-callbacks: tm: Execute TMCB_ACK_NEG_IN callback on reception of a local ACK as
by Timo Reimann 14 Nov '11

14 Nov '11

Module: sip-router Branch: treimann/master_tm-extend-callbacks Commit: 86a921a3a28d86eb66dc3c4e481b27ebb2cfff70 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=86a921a… Author: Timo Reimann <sr(a)foo-lounge.de> Committer: Timo Reimann <sr(a)foo-lounge.de> Date: Tue Nov 15 00:41:47 2011 +0100 tm: Execute TMCB_ACK_NEG_IN callback on reception of a local ACK as well. --- modules/tm/t_reply.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c index c2021e7..d1af221 100644 --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -2081,6 +2081,14 @@ int reply_received( struct sip_msg *p_msg ) run_trans_callbacks_off_params(TMCB_REQUEST_SENT, t, &onsend_params); } + if (unlikely(has_tran_tmcbs(t, TMCB_ACK_NEG_IN))){ + INIT_TMCB_ONSEND_PARAMS(onsend_params, + t->uas.request, p_msg, &uac->request, + &uac->request.dst, ack, ack_len, + TMCB_LOCAL_F, branch, TYPE_LOCAL_ACK); + run_trans_callbacks_off_params(TMCB_ACK_NEG_IN, t, + &onsend_params); + } shm_free(ack); } } else if (is_local(t) /*&& 200 <= msg_status < 300*/) {

1 0

[tracker] Comment added: Double Free -- Crash/Coredump and possible security vulnerability
by sip-router 14 Nov '11

14 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#173 - Double Free -- Crash/Coredump and possible security vulnerability User who did this - Timo Reimann (tr) ---------- Hey Bayan, sorry for not replying any sooner. I was quite busy in the last couple of days and couldn't dedicate too much time to the project. Your issue is quite on the top of my priority list, however, and I'll try to get to it as soon as I can. The dump you gave me looks different this time -- will scrutinze it further. What would prove really helpful as well (if your resources permit to do so) is a SIP trace (using ngrep for example) together with another dump and more debug-level logging. That way, I could possibly correlate the dump content to the failing dialog and figure out what lead to the faulty situation. If setting log verbosity to DEBUG is too heavy for you, what you can do alternatively is change all "LM_DBG" strings in modules_k/dialog/*.{h,c} to LM_<whatever level you usually log>. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=173#comment357 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Double Free -- Crash/Coredump and possible security vulnerability
by sip-router 14 Nov '11

14 Nov '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#173 - Double Free -- Crash/Coredump and possible security vulnerability User who did this - Bayan Towfiq (btowfiq) ---------- Hi Timo, Kamailio is still crashing frequently. Have you had a chance to look into it? Would you like any other tests? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=173#comment356 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: Makefile: dev version increased to 3.3.0-dev2
by Daniel-Constantin Mierla 14 Nov '11

14 Nov '11

Module: sip-router Branch: master Commit: 29642534fa9ae12a74ffaabbf5a14349310ab32f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2964253… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Nov 14 22:43:28 2011 +0100 Makefile: dev version increased to 3.3.0-dev2 --- Makefile.defs | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index 067e0cd..49f2f82 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -162,7 +162,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 3 PATCHLEVEL = 3 SUBLEVEL = 0 -EXTRAVERSION = -dev1 +EXTRAVERSION = -dev2 # memory debugger switcher # 0 - off (release mode)

1 0

git:master: auth: new function auth_challenge()
by Daniel-Constantin Mierla 14 Nov '11

14 Nov '11

Module: sip-router Branch: master Commit: ef6bb4541687862f2f2cc09a5a784a7b7045672f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ef6bb45… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Nov 14 22:39:24 2011 +0100 auth: new function auth_challenge() - combines www_challenge() and proxy_challenge() by calling the first for REGISTER and the second for the rest of request types - it is usefull to simplify the config file for default auth handling --- modules/auth/README | 46 ++++++++++++++++++++++++++++----------- modules/auth/auth_mod.c | 44 ++++++++++++++++++++++++++++++++++++++ modules/auth/doc/functions.xml | 29 ++++++++++++++++++++++++- 3 files changed, 105 insertions(+), 14 deletions(-) diff --git a/modules/auth/README b/modules/auth/README index 04d7594..a29bcf5 100644 --- a/modules/auth/README +++ b/modules/auth/README @@ -15,7 +15,7 @@ Daniel-Constantin Mierla asipto.com <miconda(a)gmail.com> - Copyright © 2002, 2003 FhG FOKUS + Copyright � 2002, 2003 FhG FOKUS __________________________________________________________________ 1.1. Overview @@ -43,8 +43,9 @@ Daniel-Constantin Mierla 1.4.1. consume_credentials() 1.4.2. www_challenge(realm, flags) 1.4.3. proxy_challenge(realm, flags) - 1.4.4. pv_www_authenticate(realm, passwd, flags) - 1.4.5. pv_proxy_authenticate(realm, passwd, flags) + 1.4.4. auth_challenge(realm, flags) + 1.4.5. pv_www_authenticate(realm, passwd, flags) + 1.4.6. pv_proxy_authenticate(realm, passwd, flags) 1.1. Overview @@ -66,7 +67,7 @@ Daniel-Constantin Mierla 1.3. Parameters -1.3.1. auth_checks_register, auth_checks_no_dlg, and auth_checks_in_dlg +1.3.1. auth_checks_register, auth_checks_no_dlg, and auth_checks_in_dlg (flags) These three module parameters control which optional integrity checks @@ -514,7 +515,7 @@ if (www_authenticate("realm", "subscriber)) { }; ... -1.4.2. www_challenge(realm, flags) +1.4.2. www_challenge(realm, flags) The function challenges a user agent. It will generate a WWW-Authorize header field containing a digest challenge, it will put the header @@ -528,7 +529,7 @@ if (www_authenticate("realm", "subscriber)) { * realm - Realm is a opaque string that the user agent should present to the user so he can decide what username and password to use. Usually this is domain of the host the server is running on. - It must not be empty string “”. In case of REGISTER requests To + It must not be empty string "". In case of REGISTER requests To header field domain (e.g., variable $td) can be used (because this header field represents the user being registered), for all other messages From header field domain can be used (e.g., variable $fd). @@ -550,7 +551,7 @@ if (!www_authenticate("$td", "subscriber")) { } ... -1.4.3. proxy_challenge(realm, flags) +1.4.3. proxy_challenge(realm, flags) The function challenges a user agent. It will generate a Proxy-Authorize header field containing a digest challenge, it will put @@ -567,12 +568,31 @@ if (!www_authenticate("$td", "subscriber")) { Example 16. proxy_challenge usage ... -if (!proxy_authenticate("$fd", "subscriber)) { +if (!proxy_authenticate("$fd", "subscriber")) { proxy_challenge("$fd", "1"); }; ... -1.4.4. pv_www_authenticate(realm, passwd, flags) +1.4.4. auth_challenge(realm, flags) + + The function challenges a user agent for authentication. It combines + the functions www_challenge() and proxy_challenge(), by calling + internally the first one for REGISTER requests and the second one for + the rest of the request types. + + Meaning of the parameters the same as for function www_challenge(realm, + flags) + + This function can be used from REQUEST_ROUTE. + + Example 17. proxy_challenge usage +... +if (!auth_check("$fd", "subscriber", "1")) { + auth_challenge("$fd", "1"); +}; +... + +1.4.5. pv_www_authenticate(realm, passwd, flags) The function verifies credentials according to RFC2617. If the credentials are verified successfully then the function will succeed @@ -596,7 +616,7 @@ if (!proxy_authenticate("$fd", "subscriber)) { * realm - Realm is a opaque string that the user agent should present to the user so he can decide what username and password to use. Usually this is domain of the host the server is running on. - It must not be empty string “”. In case of REGISTER requests To + It must not be empty string "". In case of REGISTER requests To header field domain (e.g., varibale $td) can be used (because this header field represents a user being registered), for all other messages From header field domain can be used (e.g., varibale $fd). @@ -616,14 +636,14 @@ if (!proxy_authenticate("$fd", "subscriber)) { This function can be used from REQUEST_ROUTE. - Example 17. pv_www_authenticate usage + Example 18. pv_www_authenticate usage ... if (!pv_www_authenticate("$td", "123abc", "0")) { www_challenge("$td", "1"); }; ... -1.4.5. pv_proxy_authenticate(realm, passwd, flags) +1.4.6. pv_proxy_authenticate(realm, passwd, flags) The function verifies credentials according to RFC2617. If the credentials are verified successfully then the function will succeed @@ -638,7 +658,7 @@ if (!pv_www_authenticate("$td", "123abc", "0")) { This function can be used from REQUEST_ROUTE. - Example 18. pv_proxy_authenticate usage + Example 19. pv_proxy_authenticate usage ... $avp(password)="xyz"; if (!pv_proxy_authenticate("$fd", "$avp(password)", "0")) { diff --git a/modules/auth/auth_mod.c b/modules/auth/auth_mod.c index a28c2ba..4dabc10 100644 --- a/modules/auth/auth_mod.c +++ b/modules/auth/auth_mod.c @@ -87,6 +87,7 @@ static int fixup_pv_auth(void **param, int param_no); static int proxy_challenge(struct sip_msg *msg, char* realm, char *flags); static int www_challenge(struct sip_msg *msg, char* realm, char *flags); +static int w_auth_challenge(struct sip_msg *msg, char* realm, char *flags); static int fixup_auth_challenge(void **param, int param_no); @@ -138,6 +139,8 @@ static cmd_export_t cmds[] = { fixup_auth_challenge, REQUEST_ROUTE}, {"proxy_challenge", (cmd_function)proxy_challenge, 2, fixup_auth_challenge, REQUEST_ROUTE}, + {"auth_challenge", (cmd_function)w_auth_challenge, 2, + fixup_auth_challenge, REQUEST_ROUTE}, {"pv_www_authorize", (cmd_function)pv_www_authenticate, 3, fixup_pv_auth, REQUEST_ROUTE}, {"pv_www_authenticate", (cmd_function)pv_www_authenticate, 3, @@ -750,6 +753,47 @@ error: } /** + * + */ +static int w_auth_challenge(struct sip_msg *msg, char* realm, char *flags) +{ + int vflags = 0; + str srealm = {0, 0}; + + if((msg->REQ_METHOD == METHOD_ACK) || (msg->REQ_METHOD == METHOD_CANCEL)) { + return 1; + } + + if(get_str_fparam(&srealm, msg, (fparam_t*)realm) < 0) { + LM_ERR("failed to get realm value\n"); + goto error; + } + + if(srealm.len==0) { + LM_ERR("invalid realm value - empty content\n"); + goto error; + } + + if(get_int_fparam(&vflags, msg, (fparam_t*)flags) < 0) { + LM_ERR("invalid flags value\n"); + goto error; + } + + if(msg->REQ_METHOD==METHOD_REGISTER) + return auth_challenge(msg, &srealm, vflags, HDR_AUTHORIZATION_T); + else + return auth_challenge(msg, &srealm, vflags, HDR_PROXYAUTH_T); + +error: + if(!(vflags&4)) { + if(auth_send_reply(msg, 500, "Internal Server Error", 0, 0) <0 ) + return -4; + } + return -1; +} + + +/** * @brief fixup function for {www,proxy}_challenge */ static int fixup_auth_challenge(void **param, int param_no) diff --git a/modules/auth/doc/functions.xml b/modules/auth/doc/functions.xml index d328def..f094e44 100644 --- a/modules/auth/doc/functions.xml +++ b/modules/auth/doc/functions.xml @@ -126,7 +126,7 @@ if (!www_authenticate("$td", "subscriber")) { <title>proxy_challenge usage</title> <programlisting format="linespecific"> ... -if (!proxy_authenticate("$fd", "subscriber)) { +if (!proxy_authenticate("$fd", "subscriber")) { proxy_challenge("$fd", "1"); }; ... @@ -134,6 +134,33 @@ if (!proxy_authenticate("$fd", "subscriber)) { </example> </section> + <section id="auth_challenge"> + <title> + <function moreinfo="none">auth_challenge(realm, flags)</function> + </title> + <para> + The function challenges a user agent for authentication. It combines + the functions www_challenge() and proxy_challenge(), by calling + internally the first one for REGISTER requests and the second one for + the rest of the request types. + </para> + <para>Meaning of the parameters the same as for function + www_challenge(realm, flags)</para> + <para> + This function can be used from REQUEST_ROUTE. + </para> + <example> + <title>proxy_challenge usage</title> + <programlisting format="linespecific"> +... +if (!auth_check("$fd", "subscriber", "1")) { + auth_challenge("$fd", "1"); +}; +... +</programlisting> + </example> + </section> + <section id="pv_www_authenticate"> <title> <function moreinfo="none">pv_www_authenticate(realm, passwd, flags)</function>

1 0

git:master: pua: fixed wrong docbook tag name
by Daniel-Constantin Mierla 14 Nov '11

14 Nov '11

Module: sip-router Branch: master Commit: 96c35ff6afeca6320d7299cf9ecebc721d246e30 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=96c35ff… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Nov 14 22:07:08 2011 +0100 pua: fixed wrong docbook tag name --- modules_k/pua/doc/pua_admin.xml | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules_k/pua/doc/pua_admin.xml b/modules_k/pua/doc/pua_admin.xml index bd22321..4c553f8 100644 --- a/modules_k/pua/doc/pua_admin.xml +++ b/modules_k/pua/doc/pua_admin.xml @@ -24,13 +24,13 @@ <para> It can be used with the following modules: pua_mi and pua_usrloc, pua_bla and pua_xmpp. - The <emphasize>pua_mi</emphasize> offer the possibility to publish any kind of information + The <emphasis>pua_mi</emphasis> offer the possibility to publish any kind of information or subscribing to a resource through the manager interface. - The <emphasize>pua_usrloc</emphasize> module calls a function exported by pua modules to publish + The <emphasis>pua_usrloc</emphasis> module calls a function exported by pua modules to publish elementary presence information, such as basic status "open" or "closed", for clients that do not implement client-to-server presence. - Through <emphasize>pua_bla</emphasize> , BRIDGED LINE APPEARANCE features are added to openser. - The <emphasize>pua_xmpp</emphasize> module represents a gateway between SIP and XMPP, so that + Through <emphasis>pua_bla</emphasis> , BRIDGED LINE APPEARANCE features are added to openser. + The <emphasis>pua_xmpp</emphasis> module represents a gateway between SIP and XMPP, so that jabber and SIP clients can exchange presence information. </para> <para>

1 0

← Newer
1
...
18
19
20
21
22
23
24
...
35
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2011