sr-dev December 2011

sr-dev@lists.kamailio.org

32 participants
230 discussions

[tracker] Task opened: bad sotket after re-register in location table
by sip-router 14 Dec '11

14 Dec '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - David Kovarik (kovik) Attached to Project - sip-router Summary - bad sotket after re-register in location table Task Type - Bug Report Category - usrloc (k) Status - Assigned Assigned To - Daniel-Constantin Mierla Operating System - Linux Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - This happened after re-register mysql query log: socket='udp:81.31.45.57\0\0060' in table udp:81.31.45.57060 instead of udp:81.31.45.57:5060 Query update location set expires='2011-12-14 15:00:47',q=-1.00 ,cseq=4,flags=0,cflags=192,user_agent='Well T20 hw7.0.0.54 fw9.60.9.5 00:15:65:15:ae:b2',received='sip:85.135.106.202:4078',path=NULL,socket='udp:81.31.45.57\0\0060',methods=16383,last_modified='2011-12-14 14:58:47' where username='300169' AND contact='sip:300169@192.168.2.101:5062' AND callid='1248885213(a)192.168.2.101' More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=191 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Assignee added: bad sotket after re-register in location table
by sip-router 14 Dec '11

14 Dec '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#191 - bad sotket after re-register in location table User who did this - David Kovarik (kovik) http://sip-router.org/tracker/index.php?do=details&task_id=191 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: tls: rpc tls.info prints the limit and opened tls connections
by Daniel-Constantin Mierla 13 Dec '11

13 Dec '11

Module: sip-router Branch: master Commit: 94204ce852d16c9c9d620b7bd194737519f59c0f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=94204ce… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Dec 13 23:08:50 2011 +0100 tls: rpc tls.info prints the limit and opened tls connections --- modules/tls/tls_rpc.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/modules/tls/tls_rpc.c b/modules/tls/tls_rpc.c index 1dfa6ac..956154b 100644 --- a/modules/tls/tls_rpc.c +++ b/modules/tls/tls_rpc.c @@ -29,6 +29,7 @@ #include "../../rpc.h" #include "../../tcp_conn.h" +#include "../../tcp_info.h" #include "../../timer.h" #include "../../cfg/cfg.h" #include "tls_init.h" @@ -191,9 +192,14 @@ static const char* tls_info_doc[2] = { static void tls_info(rpc_t* rpc, void* c) { + struct tcp_gen_info ti; void* handle; + + tcp_get_info(&ti); rpc->add(c, "{", &handle); - rpc->struct_add(handle, "d", + rpc->struct_add(handle, "ddd", + "max_connections", ti.tls_max_connections, + "opened_connections", ti.tls_connections_no, "clear_text_write_queued_bytes", tls_ct_wq_total_bytes()); }

1 0

git:master: core/tcp/tls: added tls_max_connections global parameter
by Daniel-Constantin Mierla 13 Dec '11

13 Dec '11

Module: sip-router Branch: master Commit: 61f8b970416124efcdae38943af6ec48bf27f751 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=61f8b97… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Dec 13 23:01:48 2011 +0100 core/tcp/tls: added tls_max_connections global parameter - set a limit to active tls connections - its management is done in tcp code, as tls is encryption layer over tcp - tls connections are still counted as tcp connections, thus this limit cannot exceed tcp_max_connections - default value 2048 - core.tcp_options lists also the tls connections number --- cfg.lex | 3 ++ cfg.y | 9 ++++++++ core_cmd.c | 7 ++++- globals.h | 3 +- tcp_info.h | 4 ++- tcp_init.h | 4 ++- tcp_main.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++- tcp_options.c | 6 ++++- tcp_options.h | 3 +- 9 files changed, 92 insertions(+), 8 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=61f…

1 0

[tracker] Task closed: textopsx:msg_apply_changes() can corrupt incoming TCP message buffer
by sip-router 13 Dec '11

13 Dec '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#185 - textopsx:msg_apply_changes() can corrupt incoming TCP message buffer User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Backported to branch 3.2 as well. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=185 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: core: added core.tcp_list rpc command
by Daniel-Constantin Mierla 13 Dec '11

13 Dec '11

Module: sip-router Branch: master Commit: e567b3fde3165fd752d72a86de3b13d5bdf76ddd URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e567b3f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Dec 13 15:02:02 2011 +0100 core: added core.tcp_list rpc command - print details about tcp connections --- core_cmd.c | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 85 insertions(+), 0 deletions(-) diff --git a/core_cmd.c b/core_cmd.c index c023b59..6f55e12b 100644 --- a/core_cmd.c +++ b/core_cmd.c @@ -40,6 +40,7 @@ #include "pt.h" #include "ut.h" #include "tcp_info.h" +#include "tcp_conn.h" #include "tcp_options.h" #include "core_cmd.h" #include "cfg_core.h" @@ -739,6 +740,89 @@ static void core_tcp_options(rpc_t* rpc, void* c) } +static const char* core_tcp_list_doc[] = { + "Returns tcp connections details.", /* Documentation string */ + 0 /* Method signature(s) */ +}; + +extern gen_lock_t* tcpconn_lock; +extern struct tcp_connection** tcpconn_id_hash; + +static void core_tcp_list(rpc_t* rpc, void* c) +{ +#ifdef USE_TCP + char src_ip[IP_ADDR_MAX_STR_SIZE]; + char dst_ip[IP_ADDR_MAX_STR_SIZE]; + void* handle; + char* state; + char* type; + struct tcp_connection* con; + int i, len, timeout; + + TCPCONN_LOCK; + for(i = 0; i < TCP_ID_HASH_SIZE; i++) { + for (con = tcpconn_id_hash[i]; con; con = con->id_next) { + rpc->add(c, "{", &handle); + /* tcp data */ + if (con->rcv.proto == PROTO_TCP) + type = "TCP"; + else if (con->rcv.proto == PROTO_TCP) + type = "TLS"; + else + type = "UNKNOWN"; + + if ((len = ip_addr2sbuf(&con->rcv.src_ip, src_ip, sizeof(src_ip))) + == 0) + BUG("failed to convert source ip"); + src_ip[len] = 0; + if ((len = ip_addr2sbuf(&con->rcv.dst_ip, dst_ip, sizeof(dst_ip))) + == 0) + BUG("failed to convert destination ip"); + dst_ip[len] = 0; + timeout = TICKS_TO_S(con->timeout - get_ticks_raw()); + switch(con->state) { + case S_CONN_ERROR: + state = "CONN_ERROR"; + break; + case S_CONN_BAD: + state = "CONN_BAD"; + break; + case S_CONN_OK: + state = "CONN_OK"; + break; + case S_CONN_INIT: + state = "CONN_INIT"; + break; + case S_CONN_EOF: + state = "CONN_EOF"; + break; + case S_CONN_ACCEPT: + state = "CONN_ACCEPT"; + break; + case S_CONN_CONNECT: + state = "CONN_CONNECT"; + break; + default: + state = "UNKNOWN"; + } + rpc->struct_add(handle, "dssdsdsd", + "id", con->id, + "type", type, + "state", state, + "timeout", timeout, + "src_ip", src_ip, + "src_port", con->rcv.src_port, + "dst_ip", dst_ip, + "dst_port", con->rcv.dst_port); + } + } + TCPCONN_UNLOCK; +#else + rpc->fault(c, 500, "tcp support not compiled"); +#endif +} + + static const char* core_sctp_options_doc[] = { "Returns active sctp options. With one parameter" @@ -920,6 +1004,7 @@ static rpc_export_t core_rpc_methods[] = { #endif {"core.tcp_info", core_tcpinfo, core_tcpinfo_doc, 0}, {"core.tcp_options", core_tcp_options, core_tcp_options_doc,0}, + {"core.tcp_list", core_tcp_list, core_tcp_list_doc,0}, {"core.sctp_options", core_sctp_options, core_sctp_options_doc, 0}, {"core.sctp_info", core_sctpinfo, core_sctpinfo_doc, 0},

2 1

[tracker] Task closed: tls module error on initialization when used together with the dialog module
by sip-router 13 Dec '11

13 Dec '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#183 - tls module error on initialization when used together with the dialog module User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Commit done to master branch. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=183 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: tls module error on initialization when used together with the dialog module
by sip-router 13 Dec '11

13 Dec '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#183 - tls module error on initialization when used together with the dialog module User who did this - Daniel-Constantin Mierla (miconda) ---------- I committed the patch with some safety checks for shutdown at init time (when there is an error during startup). If you can give a try to tls and postgres together in such deployments and let me know if works, then I can backport to 3.2 sooner, I expect it will take me time to do it, since I am not using postgres I need to setup some new test environment. Anyhow, I am closing this item, reopen if issues appear. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=183#comment462 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: tls: do TLS pre-init operations at the time of loading module
by Daniel-Constantin Mierla 13 Dec '11

13 Dec '11

Module: sip-router Branch: master Commit: 517d38ed02586bc9fc88ea0d3ceb8b81f510ade5 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=517d38e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Dec 13 13:00:50 2011 +0100 tls: do TLS pre-init operations at the time of loading module - makes sure that it sets the memory managing functions and the locks before other modules may start using libssl - reported by Øyvind Kolbu, FS#183 --- modules/tls/tls_init.c | 50 +++++++++++++++++++++++++++++++---------------- modules/tls/tls_init.h | 5 ++++ modules/tls/tls_mod.c | 10 +++++++++ 3 files changed, 48 insertions(+), 17 deletions(-) diff --git a/modules/tls/tls_init.c b/modules/tls/tls_init.c index a57772e..cc16598 100644 --- a/modules/tls/tls_init.c +++ b/modules/tls/tls_init.c @@ -74,6 +74,9 @@ #include "tls_ct_wrq.h" #include "tls_cfg.h" +/* will be set to 1 when the TLS env is initialized to make destroy safe */ +static int tls_mod_initialized = 0; + #if OPENSSL_VERSION_NUMBER < 0x00907000L # warning "" # warning "===============================================================" @@ -148,7 +151,6 @@ const SSL_METHOD* ssl_methods[TLS_USE_SSLv23 + 1]; #define NULL_GRACE_PERIOD 10U */ - inline static char* buf_append(char* buf, char* end, char* str, int str_len) { if ( (buf+str_len)<end){ @@ -442,6 +444,32 @@ end: } +/** + * tls pre-init function + */ +int tls_pre_init(void) +{ + /* + * this has to be called before any function calling CRYPTO_malloc, + * CRYPTO_malloc will set allow_customize in openssl to 0 + */ +#ifdef TLS_MALLOC_DBG + if (!CRYPTO_set_mem_ex_functions(ser_malloc, ser_realloc, ser_free)) { +#else + if (!CRYPTO_set_mem_functions(ser_malloc, ser_realloc, ser_free)) { +#endif + ERR("Unable to set the memory allocation functions\n"); + return -1; + } + + if (tls_init_locks()<0) + return -1; + + init_tls_compression(); + + return 0; +} + /* * First step of TLS initialization */ @@ -538,21 +566,7 @@ int init_tls_h(void) " enabled. Possible unstable configuration\n"); } } - /* - * this has to be called before any function calling CRYPTO_malloc, - * CRYPTO_malloc will set allow_customize in openssl to 0 - */ -#ifdef TLS_MALLOC_DBG - if (!CRYPTO_set_mem_ex_functions(ser_malloc, ser_realloc, ser_free)) { -#else - if (!CRYPTO_set_mem_functions(ser_malloc, ser_realloc, ser_free)) { -#endif - ERR("Unable to set the memory allocation functions\n"); - return -1; - } - if (tls_init_locks()<0) - return -1; - init_tls_compression(); + #ifdef TLS_KSSL_WORKARROUND /* if openssl compiled with kerberos support, and openssl < 0.9.8e-dev * or openssl between 0.9.9-dev and 0.9.9-beta1 apply workaround for @@ -623,6 +637,7 @@ int init_tls_h(void) SSL_library_init(); SSL_load_error_strings(); init_ssl_methods(); + tls_mod_initialized = 1; return 0; } @@ -655,7 +670,8 @@ int tls_check_sockets(tls_domains_cfg_t* cfg) void destroy_tls_h(void) { DBG("tls module final tls destroy\n"); - ERR_free_strings(); + if(tls_mod_initialized > 0) + ERR_free_strings(); /* TODO: free all the ctx'es */ tls_destroy_cfg(); tls_destroy_locks(); diff --git a/modules/tls/tls_init.h b/modules/tls/tls_init.h index f234df7..7101949 100644 --- a/modules/tls/tls_init.h +++ b/modules/tls/tls_init.h @@ -61,6 +61,11 @@ extern const SSL_METHOD* ssl_methods[]; /* + * just once, pre-initialize the tls subsystem + */ +int tls_pre_init(void); + +/* * just once, initialize the tls subsystem */ int init_tls_h(void); diff --git a/modules/tls/tls_mod.c b/modules/tls/tls_mod.c index 0f1df72..2f7d626 100644 --- a/modules/tls/tls_mod.c +++ b/modules/tls/tls_mod.c @@ -57,6 +57,7 @@ #include "../../timer.h" /* ticks_t */ #include "../../tls_hooks.h" #include "../../ut.h" +#include "../../shm_init.h" #include "../../rpc_lookup.h" #include "../../cfg/cfg.h" #include "tls_init.h" @@ -269,7 +270,16 @@ static tls_domains_cfg_t* tls_use_modparams(void) } #endif +int mod_register(char *path, int *dlflags, void *p1, void *p2) +{ + /* shm is used, be sure it is initialized */ + if(!shm_initialized() && init_shm()<0) + return -1; + if(tls_pre_init()<0) + return -1; + return 0; +} static int mod_init(void) {

1 0

db_fetch_next problem with Postgres?
by Paul Pankhurst 13 Dec '11

13 Dec '11

I am having problems with the db_fetch_next routine and Postgres. I can’t see any problem with my code that calls it, and as far as I can tell the problem appears to be in the db_postgres_fetch_result routine. On the first invocation of db_postgres_fetch_result it allocates a result structure and gives me the first 5 rows of the 198 that match my query after calling db_postgres_convert_rows. On the 2nd invocation it fails to retrieve the next 5 rows because CON_RESULT(_con) is NULL ! Anyone got any suggestions? Paul Pankhurst Engineering Director Crocodile RCS Ltd Tel: 01489 668620 DDI: 01489 668622 www.crocodile-rcs.com

2 1

← Newer
1
...
10
11
12
13
14
15
16
...
23
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2011