sr-dev December 2011

sr-dev@lists.kamailio.org

32 participants
230 discussions

[tracker] Comment added: Kamailio 3.2.1 Dialog Crash
by sip-router 01 Dec '11

01 Dec '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#186 - Kamailio 3.2.1 Dialog Crash User who did this - Daniel-Constantin Mierla (miconda) ---------- Btw, I applied the patch suggested by Jasmin. Thanks. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=186#comment441 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Kamailio 3.2.1 Dialog Crash
by sip-router 01 Dec '11

01 Dec '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#186 - Kamailio 3.2.1 Dialog Crash User who did this - Daniel-Constantin Mierla (miconda) ---------- Well, at least you can provide all the details again from same core file. Otherwise does not help at all. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=186#comment440 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Kamailio 3.2.1 Dialog Crash
by sip-router 01 Dec '11

01 Dec '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#186 - Kamailio 3.2.1 Dialog Crash User who did this - Brandon Armstead (CRYY2010) ---------- Daniel - I am sorry I should have mentioned that... I am crashing so frequently that I've cleared out core files... this was from a DIFFERENT core file. @Jasmin - this change did not resolve it (still crashing) ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=186#comment439 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:3.2: dialog(k): give dir parameter to get_dlg()
by Daniel-Constantin Mierla 01 Dec '11

01 Dec '11

Module: sip-router Branch: 3.2 Commit: 31c99120ba9f13630b03ce43d9d76b7c322da0d6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=31c9912… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 2 00:37:18 2011 +0100 dialog(k): give dir parameter to get_dlg() - initialized to DLG_DIR_NONE to fix accessing NULL pointer for searching dialog by msg attributes - patch by Jasmin Schnatterbeck (cherry picked from commit fc0f544b25c157147f8b813be6ba594b20ee6757) --- modules_k/dialog/dlg_handlers.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/modules_k/dialog/dlg_handlers.c b/modules_k/dialog/dlg_handlers.c index 9c4686a..2a1e494 100644 --- a/modules_k/dialog/dlg_handlers.c +++ b/modules_k/dialog/dlg_handlers.c @@ -975,8 +975,9 @@ dlg_cell_t *dlg_get_msg_dialog(sip_msg_t *msg) { dlg_cell_t *dlg = NULL; str callid; - str ftag; - str ttag; + str ftag; + str ttag; + unsigned int dir; /* Retrieve the current dialog */ dlg = dlg_get_ctx_dialog(); @@ -985,7 +986,8 @@ dlg_cell_t *dlg_get_msg_dialog(sip_msg_t *msg) if (pre_match_parse(msg, &callid, &ftag, &ttag, 0)<0) return NULL; - dlg = get_dlg(&callid, &ftag, &ttag, NULL); + dir = DLG_DIR_NONE; + dlg = get_dlg(&callid, &ftag, &ttag, &dir); if (dlg==NULL){ LM_DBG("dlg with callid '%.*s' not found\n", msg->callid->body.len, msg->callid->body.s);

1 0

git:master: dialog(k): give dir parameter to get_dlg()
by Daniel-Constantin Mierla 01 Dec '11

01 Dec '11

Module: sip-router Branch: master Commit: fc0f544b25c157147f8b813be6ba594b20ee6757 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fc0f544… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 2 00:37:18 2011 +0100 dialog(k): give dir parameter to get_dlg() - initialized to DLG_DIR_NONE to fix accessing NULL pointer for searching dialog by msg attributes - patch by Jasmin Schnatterbeck --- modules_k/dialog/dlg_handlers.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/modules_k/dialog/dlg_handlers.c b/modules_k/dialog/dlg_handlers.c index 9c4686a..2a1e494 100644 --- a/modules_k/dialog/dlg_handlers.c +++ b/modules_k/dialog/dlg_handlers.c @@ -975,8 +975,9 @@ dlg_cell_t *dlg_get_msg_dialog(sip_msg_t *msg) { dlg_cell_t *dlg = NULL; str callid; - str ftag; - str ttag; + str ftag; + str ttag; + unsigned int dir; /* Retrieve the current dialog */ dlg = dlg_get_ctx_dialog(); @@ -985,7 +986,8 @@ dlg_cell_t *dlg_get_msg_dialog(sip_msg_t *msg) if (pre_match_parse(msg, &callid, &ftag, &ttag, 0)<0) return NULL; - dlg = get_dlg(&callid, &ftag, &ttag, NULL); + dir = DLG_DIR_NONE; + dlg = get_dlg(&callid, &ftag, &ttag, &dir); if (dlg==NULL){ LM_DBG("dlg with callid '%.*s' not found\n", msg->callid->body.len, msg->callid->body.s);

1 0

[tracker] Comment added: Kamailio 3.2.1 Dialog Crash
by sip-router 01 Dec '11

01 Dec '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#186 - Kamailio 3.2.1 Dialog Crash User who did this - Daniel-Constantin Mierla (miconda) ---------- Dialog in 3.2.1 is pretty much the same as in dlgnewref branch -- it has an extra check for ref counter, which is not involved in this case. Back to the backtraces, are printings of dlg and d_entry from the same core? in the first backtrace, the h_entry value is 3635: #0 0x00007f5b8b927f65 in internal_get_dlg (h_entry=3635, callid=0x7fff970b86c0, ftag=0x7fff970b86b0, ttag=0x7fff970b86a0, dir=0x0) at dlg_hash.c:511 But the printing of dlg structure shows 3251: (gdb) p *dlg $4 = {ref = 1, next = 0x0, prev = 0x0, h_id = 866464492, h_entry = 3251, ... Otherwise, the content of dlg look good for me (at this time). ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=186#comment438 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Kamailio 3.2.1 Dialog Crash
by sip-router 01 Dec '11

01 Dec '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#186 - Kamailio 3.2.1 Dialog Crash User who did this - Jasmin Schnatterbeck (jasmin) ---------- I had a similar problem, in "dlg_handlers.c", function "dlg_get_msg_dialog": dlg = get_dlg(&callid, &ftag, &ttag, NULL); so "NULL" for direction... and in file "dlg_hash.h", function "match_dialog": if (*dir==DLG_DIR_DOWNSTREAM) { but dir is NULL... I changed "dlg_handlers.c", function "dlg_get_msg_dialog" to: dlg_cell_t *dlg_get_msg_dialog(sip_msg_t *msg) { dlg_cell_t *dlg = NULL; str callid; str ftag; str ttag; unsigned int dir = DLG_DIR_NONE; /* Retrieve the current dialog */ dlg = dlg_get_ctx_dialog(); if(dlg!=NULL) return dlg; if (pre_match_parse(msg, &callid, &ftag, &ttag, 0)<0) return NULL; dlg = get_dlg(&callid, &ftag, &ttag, &dir); if (dlg==NULL){ LM_DBG("dlg with callid '%.*s' not found\n", msg->callid->body.len, msg->callid->body.s); return NULL; } return dlg; } and it seems to work now... Jasmin ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=186#comment437 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Kamailio 3.2.1 Dialog Crash
by sip-router 01 Dec '11

01 Dec '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#186 - Kamailio 3.2.1 Dialog Crash User who did this - Bayan Towfiq (btowfiq) ---------- I have not upgraded to 3.2.1 and still using dlgnewref branch, which has not caused any crashes for me. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=186#comment436 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Kamailio 3.2.1 Dialog Crash
by sip-router 01 Dec '11

01 Dec '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#186 - Kamailio 3.2.1 Dialog Crash User who did this - Brandon Armstead (CRYY2010) ---------- (gdb) p d_entry $1 = (struct dlg_entry *) 0x7fdcd54105d8 (gdb) p *d_entry $2 = {first = 0x7fdcd5482b00, last = 0x7fdcd5482b00, next_id = 866464492, lock_idx = 1203} (gdb) p dlg $3 = (struct dlg_cell *) 0x7fdcd5482b00 (gdb) p *dlg $4 = {ref = 1, next = 0x0, prev = 0x0, h_id = 866464492, h_entry = 3251, state = 1, lifetime = 3600, start_ts = 0, dflags = 512, sflags = 0, toroute = 0, toroute_name = {s = 0x0, len = 0}, from_rr_nb = 1, tl = {next = 0x0, prev = 0x0, timeout = 0}, callid = {s = 0x7fdcd5482c58 "5bd1d1c1-df04e551@192.168.0.119sip:URI@HOST:5078sip:XXXXXX@HOSTNAME:5078sip:+1360XXXXXX@67.231.0.87:5060", len = 31}, from_uri = { s = 0x7fdcd5482c77 "sip:URI@HOST:5078sip:XXXXXX@URI@HOST:5078sip:URI@PSTN:5060", len = 49}, to_uri = { s = 0x7fdcd5482ca8 "sip:XXXXXX@HOSTNAME:5078sip:+1360XXXXXX@67.231.0.87:5060", len = 46}, req_uri = {s = 0x7fdcd5482cd6 "sip:+1360XXXXXX@67.231.0.87:5060", len = 33}, tag = {{ s = 0x7fdcd5450178 "4a3a67014e135111o0sip:3604279364@IP:5078;nat=yes<sip:KAMAILIO-REGISTRAR:5078;lr=on;ftag=4a3a67014e135111o0>>", len = 18}, {s = 0x0, len = 0}}, cseq = {{s = 0x7fdcd564e250 "102FZ\006", len = 3}, {s = 0x0, len = 0}}, route_set = {{s = 0x7fdcd54501b4 "<sip:KAMAILIO-REGISTRAR:5078;lr=on;ftag=4a3a67014e135111o0>>", len = 53}, {s = 0x0, len = 0}}, contact = {{ s = 0x7fdcd545018a "sip:3604279364@IP:5078;nat=yes<sip:KAMAILIO-REGISTRAR:5078;lr=on;ftag=4a3a67014e135111o0>>", len = 42}, {s = 0x0, len = 0}}, bind_addr = {0x7fdced775670, 0x0}, cbs = {first = 0x0, types = 0}, profile_links = 0x0, vars = 0x0} ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=186#comment435 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Kamailio 3.2.1 Dialog Crash
by sip-router 01 Dec '11

01 Dec '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#186 - Kamailio 3.2.1 Dialog Crash User who did this - Timo Reimann (tr) ---------- the crashing line maps to this for loop: for( dlg = d_entry->first ; dlg ; dlg = dlg->next ) { I suspect the d_entry structure to mess up some time during looping. Brandon, can you please show the output of the following commands in gdb: p d_entry p *d_entry p dlg p *dlg ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=186#comment434 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2011