sr-dev March 2011

sr-dev@lists.kamailio.org

25 participants
194 discussions

dialog module: callbacks with FAKED_REPLY response message

by Timo Reimann

Hi all, I got a question regarding dialog module handling of tm callbacks where the SIP response message is set to FAKED_REPLY. Specifically, dialog's dlg_onreply() takes the response message given in the tmcb_params structure and passes it onwards to all dialog callbacks. One major problem with this in case of a FAKED_REPLY (e.g., 408) is that dialog callback users cannot access PVs anymore which, to my knowledge, requires access to a transaction's message, either request- or response-wise. Moreover, dialog users will have to check for FAKED_REPLY to prevent seg-faulting, a tm detail that should be hidden on the dialog level IMHO. I (and Marius) have been thinking about ways to resolve this. Here's a list of what we have come up with: (1) Instead of passing FAKED_REPLY, pass the response that would be sent to the caller (e.g., 408). I took a look at the tm module to see if this is even remotely possible, but frankly, that module is voodoo to me. Hopefully, someone else can provide some feedback. (2) Similar to tm callbacks, store both request and response messages in dialog's analog of tmcb_params (called dlg_cb_params). The dialog callback user then gets to pick the message to be appropriate for his use case. (3) In cases where the response is FAKED_REPLY, pass the request to dialog callbacks instead. The last solution is probably the least favorable as it changes the semantics of the callback: Where you expected a (possibly FAKED_REPLY) response to be given when the callback is executed, it may now be a request in certain situations. (2) is easy to implement but still requires the callback user to be aware of the existence of FAKED_REPLY. (1) makes most sense to me but I wonder if there were good reasons why it wasn't done like this in the first place. Ideas? Cheers, --Timo

13 years, 8 months

looks like development of sip-router is over

by Juha Heinanen

$ eg push xx(a)git.sip-router.org's password: Counting objects: 9, done. Delta compression using up to 2 threads. Compressing objects: 100% (5/5), done. Writing objects: 100% (5/5), 811 bytes, done. Total 5 (delta 4), reused 0 (delta 0) error: file write error (No space left on device) fatal: unable to write sha1 file error: unpack failed: unpacker exited with error code To ssh://jh@git.sip-router.org/sip-router ! [remote rejected] master -> master (n/a (unpacker error)) error: failed to push some refs to 'ssh://jh@git.sip-router.org/sip-router' -- juha

13 years, 8 months

git:3.1: modules/auth: fixed checking and calculating of nonce count (nc) value

by Juha Heinanen

Module: sip-router Branch: 3.1 Commit: 63e528a36299eca625e204a1834ab8502aa1cf27 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=63e528a… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Fri Mar 18 15:06:16 2011 +0200 modules/auth: fixed checking and calculating of nonce count (nc) value --- modules/auth/nonce.c | 29 +++++++++++++++++++++++------ 1 files changed, 23 insertions(+), 6 deletions(-) diff --git a/modules/auth/nonce.c b/modules/auth/nonce.c index 369a41d..e20c2f2 100644 --- a/modules/auth/nonce.c +++ b/modules/auth/nonce.c @@ -276,7 +276,24 @@ int calc_nonce(char* nonce, int *nonce_len, int cfg, int since, int expires, */ #define is_bin_nonce_stale(b_nonce, t) (get_bin_nonce_expire(b_nonce) < (t)) +static inline int l8hex2int(char* _s, unsigned int *_r) +{ + unsigned int i, res = 0; + for(i = 0; i < 8; i++) { + res *= 16; + if ((_s[i] >= '0') && (_s[i] <= '9')) { + res += _s[i] - '0'; + } else if ((_s[i] >= 'a') && (_s[i] <= 'f')) { + res += _s[i] - 'a' + 10; + } else if ((_s[i] >= 'A') && (_s[i] <= 'F')) { + res += _s[i] - 'A' + 10; + } else return -1; + } + + *_r = res; + return 0; +} /** Check whether the nonce returned by UA is valid. @@ -404,12 +421,12 @@ int check_nonce(auth_body_t* auth, str* secret1, str* secret2, /* if nounce-count checks enabled & auth. headers has nc */ if (nc_enabled && (pf & NF_VALID_NC_ID) && auth->digest.nc.s && auth->digest.nc.len){ - if (str2int(&auth->digest.nc, &nc)!=0){ - /* error, bad nc */ - ERR("FIXME:check_nonce: bad nc value %.*s\n", - auth->digest.nc.len, auth->digest.nc.s); - return 5; /* invalid nc */ - } + if ((auth->digest.nc.len != 8) || + l8hex2int(auth->digest.nc.s, &nc) != 0) { + ERR("check_nonce: bad nc value %.*s\n", + auth->digest.nc.len, auth->digest.nc.s); + return 5; /* invalid nc */ + } switch(nc_check_val(n_id, pf & NF_POOL_NO_MASK, nc)){ case NC_OK: /* don't perform extra checks or one-time nonce checks

13 years, 8 months

git:master: modules/auth: fixed checking and calculating of nonce count (nc ) value

by Juha Heinanen

Module: sip-router Branch: master Commit: 59cfef003b0314f802123c42238737c1b281b42e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=59cfef0… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Fri Mar 18 08:08:23 2011 +0200 modules/auth: fixed checking and calculating of nonce count (nc) value --- modules/auth/nonce.c | 29 ++++++++++++++++++++++++++--- 1 files changed, 26 insertions(+), 3 deletions(-) diff --git a/modules/auth/nonce.c b/modules/auth/nonce.c index 1611876..467271b 100644 --- a/modules/auth/nonce.c +++ b/modules/auth/nonce.c @@ -278,6 +278,27 @@ int calc_nonce(char* nonce, int *nonce_len, int cfg, int since, int expires, +/** Utility to convert 8 hex digit string to int */ +static inline int l8hex2int(char* _s, unsigned int *_r) +{ + unsigned int i, res = 0; + + for(i = 0; i < 8; i++) { + res *= 16; + if ((_s[i] >= '0') && (_s[i] <= '9')) { + res += _s[i] - '0'; + } else if ((_s[i] >= 'a') && (_s[i] <= 'f')) { + res += _s[i] - 'a' + 10; + } else if ((_s[i] >= 'A') && (_s[i] <= 'F')) { + res += _s[i] - 'A' + 10; + } else return -1; + } + + *_r = res; + return 0; +} + + /** Check whether the nonce returned by UA is valid. * This function checks whether the nonce string returned by UA @@ -405,9 +426,11 @@ int check_nonce(auth_body_t* auth, str* secret1, str* secret2, /* if nounce-count checks enabled & auth. headers has nc */ if (nc_enabled && (pf & NF_VALID_NC_ID) && auth->digest.nc.s && auth->digest.nc.len){ - if (str2int(&auth->digest.nc, &nc)!=0){ - /* error, bad nc */ - return 5; /* invalid nc */ + if ((auth->digest.nc.len != 8) || + l8hex2int(auth->digest.nc.s, &nc) != 0) { + ERR("check_nonce: bad nc value %.*s\n", + auth->digest.nc.len, auth->digest.nc.s); + return 5; /* invalid nc */ } switch(nc_check_val(n_id, pf & NF_POOL_NO_MASK, nc)){ case NC_OK:

13 years, 8 months

[tracker] Task opened: db_mysql fails to load on centos 5 due to bad simbol ref

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Costin Radu (ctradu) Attached to Project - sip-router Summary - db_mysql fails to load on centos 5 due to bad simbol ref Task Type - Bug Report Category - Core Status - Assigned Assigned To - Andrei Pelinescu-Onciul Operating System - Linux Severity - Medium Priority - Normal Reported Version - 3.1 Due in Version - Undecided Due Date - Undecided Details - When trying to compile kamailio with mysql support via db_mysql, the build fails with: <code> ERROR load_module: could not open module </usr/local/lib/kamailio/modules/db_mysql.so>: /usr/local/lib/kamailio/modules/db_mysql.so: undefined symbol: log </code> The compile procedure is as follows: <code> wget http://www.kamailio.org/pub/kamailio/latest/src/kamailio-3.1.2_src.tar.gz tar xzvf kamailio-3.1.2_src.tar.gz make FLAVOUR=kamailio include_modules="db_mysql dialplan xlog" cfg make all make install </code> The error has been reported in [[http://lists.sip-router.org/pipermail/sr-users/2010-April/027608.html|Failu… to load module db_mysql.so due to undefined symbol: log]] as well, but it hasn't been fixed yet. The solution proposed there is working, but it is a year already, and in the main source tree a solution has not been provided. Working [[http://lists.sip-router.org/pipermail/sr-users/2010-April/027665.html|solut… by Marius Zbihlei]]: <code> In modules/db_mysql/Makefile add a -lm (link the math library) to the LIBS variable (right after -lz) </code> More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=118 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years, 8 months

[tracker] Assignee added: db_mysql fails to load on centos 5 due to bad simbol ref

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A user has added themself to the list of users assigned to this task. FS#118 - db_mysql fails to load on centos 5 due to bad simbol ref User who did this - Costin Radu (ctradu) http://sip-router.org/tracker/index.php?do=details&task_id=118 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

13 years, 8 months

git:master: modules_k/acc: added 'failed_filter' module parameter

by Juha Heinanen

Module: sip-router Branch: master Commit: 959ab319903b9625ead7292cc9638a20146e1cca URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=959ab31… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Fri Mar 18 07:51:55 2011 +0200 modules_k/acc: added 'failed_filter' module parameter Added 'failed_filter' module parameter that can be used to control based on SIP response code, which failed transactions are accounted, when 'failed_transaction_flag' is set. --- modules_k/acc/README | 426 ++++++++++++++++++++------------------- modules_k/acc/acc.h | 2 + modules_k/acc/acc_logic.c | 88 +++------ modules_k/acc/acc_mod.c | 76 +++++--- modules_k/acc/acc_mod.h | 3 +- modules_k/acc/doc/acc_admin.xml | 32 ++- 6 files changed, 325 insertions(+), 302 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=959…

13 years, 8 months

git:master: extend documentation

by Klaus Darilion

Module: sip-router Branch: master Commit: 40f5cb3a85bec9b1ad5f9a0eb4ec63a592b595c5 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=40f5cb3… Author: root <root(a)relay.labs.nic.at> Committer: Klaus Darilion <klaus.mailinglists(a)pernau.at> Date: Thu Mar 17 11:26:43 2011 +0100 extend documentation --- modules_k/textops/doc/textops_admin.xml | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/modules_k/textops/doc/textops_admin.xml b/modules_k/textops/doc/textops_admin.xml index b978f36..efe208b 100644 --- a/modules_k/textops/doc/textops_admin.xml +++ b/modules_k/textops/doc/textops_admin.xml @@ -1024,7 +1024,9 @@ if(is_method("OPTION|UPDATE")) <function moreinfo="none">remove_hf(hname)</function> </title> <para> - Remove from message all headers with name <quote>hname</quote> + Remove from message all headers with name <quote>hname</quote>. + Header matching is case-insensitive. Matches and removes also + the compact header forms. </para> <para> Returns true if at least one header is found and removed. @@ -1048,6 +1050,10 @@ if(remove_hf("User-Agent")) { # User Agent header removed } +# compact form: remove "Contact" or "m" header +remove_hf("Contact") +# compact form: remove "Contact" or "m" header +remove_hf("m") ... </programlisting> </example>

13 years, 8 months

git:master: Merge branch 'master' of ssh://git.sip-router.org/sip-router

by Carsten Bock

Module: sip-router Branch: master Commit: 905894f66ffbbb0e4a3b582c22050e76a4a02869 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=905894f… Author: Carsten Bock <carsten(a)bock.info> Committer: Carsten Bock <carsten(a)bock.info> Date: Thu Mar 17 10:50:14 2011 +0100 Merge branch 'master' of ssh://git.sip-router.org/sip-router ---

13 years, 8 months

git:master: - updated RTPProxy-Patch

by Carsten Bock

Module: sip-router Branch: master Commit: 8778302ac862c301e46c690dc3e186d20215d6f2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8778302… Author: Carsten Bock <carsten(a)bock.info> Committer: Carsten Bock <carsten(a)bock.info> Date: Thu Mar 17 10:48:02 2011 +0100 - updated RTPProxy-Patch - the provided RTP-Proxy timeout socket in the config has to contain a port. (thanks to Alexandre Abreu for helping with troubleshooting) --- modules/rtpproxy/test/exec_rtpproxy.txt | 2 +- modules/rtpproxy/test/rtpproxy.patch | 7569 +------------------------------ 2 files changed, 43 insertions(+), 7528 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=877…

13 years, 8 months

← Newer
1
...
6
7
8
9
10
11
12
...
20
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2011