Module: sip-router
Branch: master
Commit: a92001d430b897e79139580d21995ec7e5d7b417
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a92001d…
Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org>
Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org>
Date: Thu Aug 11 16:58:12 2011 +0200
tm: keep internal retr. intervals in ms
When using ticks to keep the retransmission intervals, any
rounding error (when converting from ms to ticks) is increased
with each doubling of the retransmission interval. In the standard
configuration this means that the last retransmission before t2
kicks in, has an error up to 4 times bigger then the initial one
(the rounding error is max. 1 tick/62.5ms for the initial interval
=> up to 250 ms for the last retransmission before t2).
By keeping the retransmission intervals in ms instead of ticks,
this problem is avoided, and the timing error is always < 1 tick
(62.5 ms) + system timer error (< 10 ms usually).
---
modules/tm/config.c | 8 ++--
modules/tm/config.h | 4 +-
modules/tm/h_table.h | 9 ++---
modules/tm/t_funcs.h | 10 +++--
modules/tm/t_lookup.c | 55 +++++++++++++++++---------------
modules/tm/timer.c | 85 ++++++++++++++++++++++++++++---------------------
modules/tm/timer.h | 60 ++++++++++++++++++----------------
modules/tm/tm.c | 4 +-
modules/tm/uac.c | 4 +-
9 files changed, 130 insertions(+), 109 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=a92…
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#144 - sl problem what is causing that E2E ACK is not logged in kamailio 3.1.4 siptrace modul
User who did this - Mészáros Mihály (bakfitty)
----------
So E2E ack sent out stateless way.
Aug 11 11:42:06 hal /usr/sbin/kamailio[24381]: DEBUG: tm [t_lookup.c:528]: t_lookup_request: start searching: hash=63155, isACK=1
Aug 11 11:42:06 hal /usr/sbin/kamailio[24381]: DEBUG: tm [t_lookup.c:564]: DEBUG: proceeding to pre-RFC3261 transaction matching
Aug 11 11:42:06 hal /usr/sbin/kamailio[24381]: DEBUG: tm [t_lookup.c:720]: DEBUG: t_lookup_request: e2e proxy ACK found
Aug 11 11:42:06 hal /usr/sbin/kamailio[24381]: DEBUG: tm [t_reply.c:301]: DEBUG: totag for e2e ACK found: 0
Aug 11 11:42:06 hal /usr/sbin/kamailio[24381]: DEBUG: tm [t_hooks.c:288]: DBG: trans=0xb2954a38, callback type 4, id 0 entered
Aug 11 11:42:06 hal /usr/sbin/kamailio[24381]: DEBUG: tm [t_funcs.c:315]: SER: forwarding ACK statelessly
i fully understood E2E ACK is a new transaction but can't see the sent out E2E ACK in the sip trace!
even though I flag every incoming route request, as siptracebale request.
----------
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=144#comment247
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task is now closed:
FS#144 - sl problem what is causing that E2E ACK is not logged in kamailio 3.1.4 siptrace modul
User who did this - Daniel-Constantin Mierla (miconda)
Reason for closing: Not a bug
Additional comments about closing: E2E ACK are not filtered by SL, they get in route block and and route based on Route header/R-URI.
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=144
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
Daniel-Constantin Mierla has taken ownership of the following task:
FS#144 - sl problem what is causing that E2E ACK is not logged in kamailio 3.1.4 siptrace modul
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=144
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A new Flyspray task has been opened. Details are below.
User who did this - Mészáros Mihály (bakfitty)
Attached to Project - sip-router
Summary - sl problem what is causing that E2E ACK is not logged in kamailio 3.1.4 siptrace modul
Task Type - Bug Report
Category - Module
Status - Unconfirmed
Assigned To -
Operating System - Linux
Severity - High
Priority - Normal
Reported Version - 3.1
Due in Version - Undecided
Due Date - Undecided
Details - The problem AFAIK is the following:
SIP trace is registering a SLCB_ACK_FILTERED callback to log/trace SIP ACK messages.
In SL modul
in sl_funcs.c
in Function int sl_filter_ACK(struct sip_msg *msg, unsigned int flags, void *bar )
if the ACK is E2E the following will be called:
/*check the timeout value*/
if ( *(sl_timeout)<= get_ticks() )
{
DBG("DEBUG : sl_filter_ACK: to late to be a local ACK!\n");
goto pass_it;
And so callback is skipped, and this way sip trace can't log E2E ACK.
So
sl_run_callbacks(SLCB_ACK_FILTERED, msg, 0, 0, 0, 0);
is not called at all if the ACK is not locally generated.
Please add this call of callback functions, to this E2E ACK case too, before you go to pass_it label.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=144
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
i noticed that in active_watchers schema callid has size
<size>&callid_len;</size>
but pua has call_id size
<size>&uri_len;</size>
i guess the latter should be changed.
-- juha