sr-dev September 2011

sr-dev@lists.kamailio.org

40 participants
299 discussions

rfc: things about RPC/MI child initialization
by Daniel-Constantin Mierla 06 Sep '11

06 Sep '11

Hello, currently there is a known issue with the processes initialized for processing MI commands when using event_route[tm:local-request]. Since the child init function for other modules is not executed for such processes, functions from various modules (especially with database interaction) cannot be executed, for example: calling acc_db_request() for BYE generated through MI dlg_end_dlg. On another hand, MI functions cannot be called properly via RPC (through mi_rpc module) when using XMLRPC. The reason is that XMLRPC is handled by SIP workers, which do not execute mi_child_init function. These may render obsolete the mi_init_child function, since it should be merged in the normal child_init function. Moreover, the rank PROC_RPC applies to SIP worker processes when XMLRPC module is loaded. Thus I think some RPC commands don't work properly over XMLRPC (cc-ed Jan and Andrei for more comments here). It should be also like a RPC flag per process than only type One option to solve is to add a new parameter to child init function, flags, where to tell whether the process is going to handle MI/RPC requests. Based on that, call mi_child_init if still requires. PROC_RPC needs to stay also as rank for specially forked processes. This change will require to touch all modules, and they are a lot, so maybe somebody here finds other solution. Cheers, Daniel -- Daniel-Constantin Mierla -- http://www.asipto.com Kamailio Advanced Training, Oct 10-13, Berlin: http://asipto.com/u/kat http://linkedin.com/in/miconda -- http://twitter.com/miconda

1 0

Re: [sr-dev] [SR-Users] db_mysql "Commands out of sync; you can't run this command now "
by Alex Hermann 06 Sep '11

06 Sep '11

On Sunday 28 August 2011, MÉSZÁROS Mihály wrote: > I attached the log file. > If you need detailed log/higher log level, then please let me know. usrloc seems to be using the same connection from multiple processes: pid: 18389 and 18391, connection: 0xb7387d5c Aug 28 12:40:10 hal /usr/sbin/kamailio[18389]: INFO: db_mysql [km_dbase.c:83]: submit_query: con: 0xb7387d5c table: location query: select contact,expires,q,callid,cseq,flags,cflags,user_agent,received,path,socket,methods,last_modified from location where username='mutf-hd' order by q Aug 28 12:40:10 hal /usr/sbin/kamailio[18391]: INFO: db_mysql [km_dbase.c:83]: submit_query: con: 0xb7387d5c table: location query: select contact,expires,q,callid,cseq,flags,cflags,user_agent,received,path,socket,methods,last_modified from location where username='ppke-vjk' order by q Aug 28 12:40:10 hal /usr/sbin/kamailio[18389]: INFO: db_mysql [km_dbase.c:177]: store_result: con: 0xb7387d5c table: location Aug 28 12:40:10 hal /usr/sbin/kamailio[18389]: INFO: db_mysql [km_dbase.c:83]: submit_query: con: 0xb7387d5c table: location query: update location set expires='2011-08-28 12:45:10',q=-1.00 ,cseq=2,flags=0,cflags=0,user_agent='Polycom HDX 8000 HD (Release - 3.0.2.1-17007)',received=NULL,path=NULL,socket='tcp:195.111.192.7:5060',methods=24575,last_modified='2011-08-28 12:40:10' where username='mutf-hd' AND contact='sip:mutf-hd@193.225.216.28:5060;transport=tcp' AND callid='3533311123-1752' Aug 28 12:40:10 hal /usr/sbin/kamailio[18391]: INFO: db_mysql [km_dbase.c:177]: store_result: con: 0xb7387d5c table: location Aug 28 12:40:10 hal /usr/sbin/kamailio[18391]: INFO: db_mysql [km_dbase.c:83]: submit_query: con: 0xb7387d5c table: location query: insert into location Aug 28 12:40:10 hal /usr/sbin/kamailio[18389]: INFO: db_mysql [km_dbase.c:83]: submit_query: con: 0xb7387d5c table: location query: select contact,expires,q,callid,cseq,flags,cflags,user_agent,received,path,socket,methods,last_modified from location where username='de-tek-hpc' order by q Aug 28 12:40:10 hal /usr/sbin/kamailio[18389]: ERROR: db_mysql [km_dbase.c:131]: driver error on query: Commands out of sync; you can't run this command now It probably needs a fix like below because mod_init has also created a db connection which is inherited by at least one child and ul_dbh is not 0 anymore. That process needs to be excluded from opening a database connection, all other childs need to open their own DB connection. I just don't know what rank mod_init is run as and thus don't know which process to exclude. Maybe some other dev can jump in. diff --git a/modules_k/usrloc/ul_mod.c b/modules_k/usrloc/ul_mod.c index b3a9499..ca50b01 100644 --- a/modules_k/usrloc/ul_mod.c +++ b/modules_k/usrloc/ul_mod.c @@ -378,7 +378,7 @@ static int child_init(int _rank) break; } - if (!ul_dbh) + if (rank != PROC_MAIN) ul_dbh = ul_dbf.init(&db_url); /* Get a new database connection */ if (!ul_dbh) { LM_ERR("child(%d): failed to connect to database\n", _rank);

3 13

[tracker] Comment added: alias_db: support user to alias conversion
by sip-router 05 Sep '11

05 Sep '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#110 - alias_db: support user to alias conversion User who did this - Henning Westerholt (henningw) ---------- Hello Tristan, do you managed around to create a patch, as you mentioned? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=110#comment260 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Gentoo ebuild/pkg
by sip-router 05 Sep '11

05 Sep '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#134 - Gentoo ebuild/pkg User who did this - Henning Westerholt (henningw) ---------- Ok, i've moved the ebuild to the ser directory and also fixed one of the siprouter renaming in the Makefile. The remaining 'siprouter' ones (in siprouter.init, siprouter.confd including the content) needs to fixed by the original submitter, otherwise the package will be broken. I already asked Claudio about his plan about updates for 3.2 earlier today, so lets see what he thinks. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=134#comment259 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: pgk: add symlink to kamailio directory for new gentoo ebuild
by Henning Westerholt 05 Sep '11

05 Sep '11

Module: sip-router Branch: master Commit: a89e2b1a2f71c932f38c0bfdcceb2fa1880431f5 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a89e2b1… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Mon Sep 5 21:50:23 2011 +0200 pgk: add symlink to kamailio directory for new gentoo ebuild --- pkg/kamailio/gentoo | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/pkg/kamailio/gentoo b/pkg/kamailio/gentoo new file mode 120000 index 0000000..6cd8d42 --- /dev/null +++ b/pkg/kamailio/gentoo @@ -0,0 +1 @@ +../ser/gentoo/ \ No newline at end of file

1 0

git:master: pkg: also remove Makefile.defs.diff from calling files
by Henning Westerholt 05 Sep '11

05 Sep '11

Module: sip-router Branch: master Commit: 4c201e8c08e607f60efe695b5b9bb22042b7dbbe URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4c201e8… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Mon Sep 5 21:46:12 2011 +0200 pkg: also remove Makefile.defs.diff from calling files --- pkg/ser/gentoo/Manifest | 1 - pkg/ser/gentoo/sip-router-3.1.2.ebuild | 3 --- pkg/ser/gentoo/sip-router-3.1.3.ebuild | 3 --- pkg/ser/gentoo/sip-router-3.1.4-r1.ebuild | 3 --- pkg/ser/gentoo/sip-router-3.1.4.ebuild | 3 --- 5 files changed, 0 insertions(+), 13 deletions(-) diff --git a/pkg/ser/gentoo/Manifest b/pkg/ser/gentoo/Manifest index 033e40e..15ed9dd 100644 --- a/pkg/ser/gentoo/Manifest +++ b/pkg/ser/gentoo/Manifest @@ -1,4 +1,3 @@ -AUX Makefile.defs.diff 280 RMD160 b45541a28f0d7abf816785503733a5856ec99f9d SHA1 c7f5a827705a798dace6b0f2a1d76c6b6b7bb72e SHA256 b8e90c4f7515eff038d08019cd949090f6e960aca32ec35505f44f155bfbedf1 AUX siprouter.confd 496 RMD160 1bbdc51c80a1622b0d2cf17540c572590d35a0ad SHA1 deadd28c437edd3cd5a2f7c2ad7add39275d5845 SHA256 f01307979d2ef07b53889a6d17a2b65313ff109ac15bcb16446fb08cf390ee4a AUX siprouter.init 793 RMD160 6bc17c6d454c0c57a0c8720ac0ec34c3548a2431 SHA1 794dc51028151d2b312c1c9d1c085d68dcbc1b45 SHA256 e4755430ca44e1d7dff7049b130a4a08d99e3149e3842dc4a822795367c5ae88 DIST kamailio-3.1.2_src.tar.gz 6936249 RMD160 8811bc7b1310e4ca550b40d108002f6a36cd6ab8 SHA1 76b417f9b54575d8ec179558c16953a8e6510809 SHA256 03396f7a202507075d8c81fd1bbc689cedc8bf96941faaa570e007164f2f9550 diff --git a/pkg/ser/gentoo/sip-router-3.1.2.ebuild b/pkg/ser/gentoo/sip-router-3.1.2.ebuild index fd1fcc6..13bca39 100644 --- a/pkg/ser/gentoo/sip-router-3.1.2.ebuild +++ b/pkg/ser/gentoo/sip-router-3.1.2.ebuild @@ -106,9 +106,6 @@ src_unpack() { use ipv6 || \ sed -i -e "s/-DUSE_IPV6//g" Makefile.defs || die - - # Patch for sip-router flavour binaries names - epatch "${FILESDIR}/Makefile.defs.diff" } src_compile() { diff --git a/pkg/ser/gentoo/sip-router-3.1.3.ebuild b/pkg/ser/gentoo/sip-router-3.1.3.ebuild index fd1fcc6..13bca39 100644 --- a/pkg/ser/gentoo/sip-router-3.1.3.ebuild +++ b/pkg/ser/gentoo/sip-router-3.1.3.ebuild @@ -106,9 +106,6 @@ src_unpack() { use ipv6 || \ sed -i -e "s/-DUSE_IPV6//g" Makefile.defs || die - - # Patch for sip-router flavour binaries names - epatch "${FILESDIR}/Makefile.defs.diff" } src_compile() { diff --git a/pkg/ser/gentoo/sip-router-3.1.4-r1.ebuild b/pkg/ser/gentoo/sip-router-3.1.4-r1.ebuild index 1d8fb85..ccf4083 100644 --- a/pkg/ser/gentoo/sip-router-3.1.4-r1.ebuild +++ b/pkg/ser/gentoo/sip-router-3.1.4-r1.ebuild @@ -115,9 +115,6 @@ src_unpack() { use ipv6 || \ sed -i -e "s/-DUSE_IPV6//g" Makefile.defs || die - - # Patch for sip-router flavour binaries names - epatch "${FILESDIR}/Makefile.defs.diff" } src_compile() { diff --git a/pkg/ser/gentoo/sip-router-3.1.4.ebuild b/pkg/ser/gentoo/sip-router-3.1.4.ebuild index 2d5d670..2ade9c4 100644 --- a/pkg/ser/gentoo/sip-router-3.1.4.ebuild +++ b/pkg/ser/gentoo/sip-router-3.1.4.ebuild @@ -106,9 +106,6 @@ src_unpack() { use ipv6 || \ sed -i -e "s/-DUSE_IPV6//g" Makefile.defs || die - - # Patch for sip-router flavour binaries names - epatch "${FILESDIR}/Makefile.defs.diff" } src_compile() {

1 0

git:master: pkg: remove Makefile.defs.diff file, which set special daemon name - use the default
by Henning Westerholt 05 Sep '11

05 Sep '11

Module: sip-router Branch: master Commit: 65340ae5b19f20d904d6a80b2e80711c93d44f7d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=65340ae… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Mon Sep 5 21:42:03 2011 +0200 pkg: remove Makefile.defs.diff file, which set special daemon name - use the default --- pkg/ser/gentoo/files/Makefile.defs.diff | 11 ----------- 1 files changed, 0 insertions(+), 11 deletions(-) diff --git a/pkg/ser/gentoo/files/Makefile.defs.diff b/pkg/ser/gentoo/files/Makefile.defs.diff deleted file mode 100644 index 3c2d430..0000000 --- a/pkg/ser/gentoo/files/Makefile.defs.diff +++ /dev/null @@ -1,11 +0,0 @@ ---- Makefile.defs~ 2011-03-22 14:57:24.759454311 -0300 -+++ Makefile.defs 2011-03-23 10:06:57.997000132 -0300 -@@ -133,7 +133,7 @@ - - ifeq ($(FLAVOUR),sip-router) - # main binary name --MAIN_NAME=ser -+MAIN_NAME=siprouter - else ifeq ($(FLAVOUR),ser) - # main binary name - MAIN_NAME=ser

1 0

git:master: pkg: move gentoo ebuild to ser directory, remove obselete 0.8. X ebuild
by Henning Westerholt 05 Sep '11

05 Sep '11

Module: sip-router Branch: master Commit: e9771b7dd11287b48f8684d3603b4e0b61d0b462 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e9771b7… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Mon Sep 5 21:33:21 2011 +0200 pkg: move gentoo ebuild to ser directory, remove obselete 0.8.X ebuild --- pkg/{sip-router => ser}/gentoo/ChangeLog | 0 pkg/{sip-router => ser}/gentoo/Manifest | 0 .../gentoo/files/Makefile.defs.diff | 0 .../gentoo/files/siprouter.confd | 0 .../gentoo/files/siprouter.init | 0 pkg/{sip-router => ser}/gentoo/metadata.xml | 0 pkg/ser/gentoo/ser-0.8.10.ebuild | 68 ------------- pkg/ser/gentoo/ser-0.8.11.ebuild | 106 -------------------- pkg/ser/gentoo/ser-0.8.12.ebuild | 106 -------------------- pkg/ser/gentoo/ser-0.8.14.ebuild | 106 -------------------- pkg/ser/gentoo/ser-0.8.9.ebuild | 59 ----------- pkg/ser/gentoo/ser.init | 33 ------ .../gentoo/sip-router-3.1.2.ebuild | 0 .../gentoo/sip-router-3.1.3.ebuild | 0 .../gentoo/sip-router-3.1.4-r1.ebuild | 0 .../gentoo/sip-router-3.1.4.ebuild | 0 16 files changed, 0 insertions(+), 478 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=e97…

1 0

[tracker] Comment added: Gentoo ebuild/pkg
by sip-router 05 Sep '11

05 Sep '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#134 - Gentoo ebuild/pkg User who did this - Daniel-Constantin Mierla (miconda) ---------- I do not think the way it was done is ok. It introduces a new naming scheme based on no proper analysis. The last thing we need right now is introducing a new flavour ad-hoc, no matter on which OS -- we have enough confusion out there with Kamailio and SER, what is this sip-router in some places and siprouter in others?!? I think is better to keep SER flavour as big environment (thus add this gentoo folder there) and then Kamailio a subset of it focusing on kamailio originated modules. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=134#comment258 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task reopened: Gentoo ebuild/pkg
by sip-router 05 Sep '11

05 Sep '11

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been re-opened: FS#134 - Gentoo ebuild/pkg User who did this - Daniel-Constantin Mierla (miconda) More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=134 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
...
23
24
25
26
27
28
29
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2011