sr-dev January 2012

sr-dev@lists.kamailio.org

25 participants
166 discussions

New commits on branch 3.2
by Daniel-Constantin Mierla 04 Jan '12

04 Jan '12

URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=17098e4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Jan 3 18:02:39 2012 +0100 pua: is_dialog() returns 1 if there is a temporary dialog - reported by Laura Testi (cherry picked from commit 5f1e2caac5e6d68629a1a0956861bf7da6e05e31) Conflicts: modules_k/pua/pua_db.c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a84f93d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Dec 29 16:22:28 2011 +0100 pua: check if totag len >0 before comparing it - more on proper free of dlg_t structure - patch by Laura Testi (cherry picked from commit e1128c45dacf5b622c18f1cb8db0c45d8e6c9600) Conflicts: modules_k/pua/pua.c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=85b15c8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 23 13:16:46 2011 +0100 pua(k): use dedicated function to free tm dlg (cherry picked from commit 464897bd3d4713e7a30c4e505449942e4251b328) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=37f3c85… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Dec 29 10:10:26 2011 +0100 mediaproxy: handle DLGCB_CONFIRMED event - ACKs may have SDP - patch by Jasmin Schnatterbeck (FS195) (cherry picked from commit e5ae5137ce6fef73f366b725f16c84dc15721141) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2c22e1d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Dec 29 09:40:07 2011 +0100 pua_dialogingo: handle DLGCB_CONFIRMED_NA - patch by Tomek Kotecki (FS#187), Jasmin Schnatterbeck (FS#195) (cherry picked from commit 66d204b37b48127ac25632811e189b3af3b4fb14) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e4a2a0f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 23 12:48:42 2011 +0100 pua: fix commit conflick by cherry-pick of 1b3cfa6 - free rr in dlg_t structure URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=dd7b6af… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 23 09:34:00 2011 +0100 tm: rest the pointer of hash table after free to avoid double free on false start (cherry picked from commit 7728464362af67eff4dc105f16a1d42c72407cca) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3b4aa07… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Dec 22 14:06:08 2011 +0100 core: log message about slow timer printed now as warning (cherry picked from commit 566c30dd38f7e29903810472c5e1e9cde41297c7) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4233f6d… Author: Marius Bucur <marius(a)marius-bucur.ro> Date: Thu Dec 22 11:47:41 2011 +0200 Removed the constraint in siptrace to have the tm and sl modules loaded beforehand. The explicitly module specifies these dependencies as being optional. (cherry picked from commit 68d282e2898db7b00de473a943af900f6659ce54) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=69c219d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Dec 20 22:34:26 2011 +0100 core/tcp: define option TCP_CLONE_RCVBUF to turn off/on tcp rcv buffer cloning - cloning is on by default, to be safe for topoh and msg_apply_changes() (cherry picked from commit a510d17d7005fa47d4f2a672b4ceb94fbda9c9ba) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ddcee85… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Tue Nov 22 12:55:39 2011 +0100 tcp: fix for ENOTCONN on newer FreeBSDs Newer FreeBSDs return ENOTCONN instead of EAGAIN/EWOULDBLOCK when trying to send on a non-blocking socket which is not yet fully connected (the connect is still pending). Reported-by: Dmitry Petrakoff dimon dprs-consulting com (cherry picked from commit 3d4a59421a284afbf8bdf8e87357f07d9cd554e0) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=74607f3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Dec 17 21:32:22 2011 +0100 tls: use pkg-config to get cflags and libs for compilation (cherry picked from commit 62b824b10b6ff9a18e336ff20c55d2d6ea6cba3c) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1fca550… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 16 13:17:22 2011 +0100 lib/binrpc: fixed compile warnings - reported by Juha Heinanen (cherry picked from commit 304fe28c1f299db8a36fe6953da3c3b9afa24c12) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c32b663… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Dec 13 13:00:50 2011 +0100 tls: do TLS pre-init operations at the time of loading module - makes sure that it sets the memory managing functions and the locks before other modules may start using libssl - reported by Øyvind Kolbu, FS#183 (cherry picked from commit 517d38ed02586bc9fc88ea0d3ceb8b81f510ade5) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=249436f… Author: Jason Penton <jason.penton(a)gmail.com> Date: Wed Dec 7 14:32:45 2011 +0200 xmlrpc: Removed define for Solaris compilations - This define breaks on Solaris and is not required (cherry picked from commit 3552f22bbe89124eedca268fcd16bc9097fbb0b1) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=98da664… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Nov 30 15:19:35 2011 +0100 parser: remove old URI parser and structure (cherry picked from commit f65d060bb471070dca743905092afb60e5119bb6) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e56b64d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Nov 30 15:17:46 2011 +0100 lib/srdb1: helper functions to handle easier fetch capability (cherry picked from commit 09c9abb0f7907132d9afee4580f0475a2e46cadc) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=35fa51c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Nov 29 11:58:45 2011 +0100 tm: proper increment of lightweight parsing for call-id - a pretty much harmless fix to increment with 3 instead of 7 when parsing Call-ID name in lightweight parser - reported and patch by Walter Doekes, FS#168 (cherry picked from commit 21346f47f7712d08369e45e970a6ffec3eab0a3c) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9d3794d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Nov 29 11:36:36 2011 +0100 sanity: allow doing the checks in reply routes - use wrapper function for sending replies, to skip doing it for SIP replies - reported by Bayan Towfiq, FS#177 (cherry picked from commit 54c99da0de46c59cd85363dca1eed324dbb6b495)

1 0

Re: [sr-dev] [SR-Users] No memory left in send_subscribe (PUA) from update_pua while building the tm dlg_t structure
by Daniel-Constantin Mierla 04 Jan '12

04 Jan '12

Hello Laura, I applied most of the patches, apart the second one for hash.c, related to checking for temporary dialog. I need to look a bit more at it, since there was some work in this regard: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=b93… If I understood right, it is about NOTIFY getting processed faster than 200OK for SUBSCRIBE. Do I remember correctly, you are running 3.1.x? It might not be in branch 3.1. Cheers, Daniel On 12/28/11 6:15 PM, laura testi wrote: > Hi Daniel, > Yes, all patches are related to the PUA module. Please find the > attachments for both diff files and new files with applied patches If > you thinks they are useful. Now the old files should be the latest > version of the master branch ;-) Unfortunately I can not use git here. > We have tested the patches, now no memory leak any more; and no more > error for NOTIFY (dialog not found)...Please note, our use case is the > pua_xmpp, now it works fine. I don't know if rls has the same problem. > Thank you veru much for your helps again. > > Some explanations: > > In the send_subscribe.c, > - I just comment out the line 1172 so that the pua_free_tm_dlg(td) > do the right job later as you done also in this case. > > In the hash.c, > - in the get_dialog function, I add the check of "p->to_tag.len> 0" > in the string compare conditions; > > - in the is_dialog function, instead of check only the real dialog, > the check of also the temporary dialog is added, this also helps to > avoid the error of no dialog found for the NOTIFY if the NOTIFY is > received before the 202/200 OK of the SUBSCRIBE. > > in the pua.c, > - a few changes in the update_pua function: > - apply the same kind of free td and td->route_set, unfortunately > I can not re-use pua_free_tm_dlg which is local for send_subscribe.c. > - change from goto error to goto done > > > Best Regards, > Laura > > > > On Wed, Dec 28, 2011 at 2:39 PM, Daniel-Constantin Mierla > <miconda(a)gmail.com> wrote: >> Hello, >> >> >> On 12/27/11 1:51 PM, laura testi wrote: >> >> Hi Daniel, >> I tried the patch, it works partially. There are stil memory leak. >> Based on your patch, I did find different places need the same kind of >> patch both in send_subscribe,c and in pua,c >> >> >> ok, thanks, I will look over. But how did you do the patches, since it does >> not take my latest patch, seems to be against an older version, because the >> indentation is not there? >> >> I cannot apply it like this, maybe you can tell the files and lines you >> changed, otherwise is hard to track. >> >> Are both patches to the pua module? You are doing the patch with files only, >> it is more convenient to call the diff with path to the module, in this way >> is easy to spot in which module to apply the path -- i.e., use diff from >> root folder of kamailio, like: >> >> diff -u modules/abc/oldfile modules/abc/newfile >> >> Since you are sending a lot of patches, maybe it will work better if you >> just clone the git, make the patch against the master branch -- change the >> file in the master branch and then just do: >> >> git diff> path/to/save/patch.file >> >> Some info that could be useful for working with git and patches, including >> backporting, at: >> >> http://www.kamailio.org/wiki/devel/backporting-to-3.2.x >> >> Cheers, >> Daniel >> >> >> >> >> Please find the modified version of these files. >> >> Following are the differences: >> # diff -u send_subscribe.c.orig send_subscribe.c >> --- send_subscribe.c.orig 2011-12-27 13:31:06.000000000 +0100 >> +++ send_subscribe.c 2011-12-27 13:31:51.000000000 +0100 >> @@ -1151,7 +1151,6 @@ >> if (dbmode!=PUA_DB_ONLY) >> >> lock_release(&HashT->p_records[hash_code].lock); >> ret= -1; >> - pkg_free(td); >> goto done; >> } >> if (dbmode!=PUA_DB_ONLY) >> >> >> >> >> >> # diff -u pua.c.orig pua.c >> --- pua.c.orig 2011-12-27 13:15:47.000000000 +0100 >> +++ pua.c 2011-12-27 13:26:33.000000000 +0100 >> @@ -673,106 +673,145 @@ >> >> int update_pua(ua_pres_t* p) >> { >> - str* str_hdr= NULL; >> - int expires; >> - int result; >> - uac_req_t uac_r; >> - >> - if(p->desired_expires== 0) >> - expires= 3600; >> - else >> - expires= p->desired_expires- (int)time(NULL); >> + str* str_hdr= NULL; >> + ua_pres_t* cb_param = NULL; >> >> - if(p->watcher_uri== NULL) >> - { >> - str met= {"PUBLISH", 7}; >> - ua_pres_t* cb_param; >> - >> - str_hdr = publ_build_hdr(expires, get_event(p->event), NULL, >> -&p->etag, p->extra_headers, 0); >> - if(str_hdr == NULL) >> - { >> - LM_ERR("while building extra_headers\n"); >> - goto error; >> - } >> - LM_DBG("str_hdr:\n%.*s\n ", str_hdr->len, str_hdr->s); >> - >> - cb_param= build_uppubl_cbparam(p); >> - if(cb_param== NULL) >> - { >> - LM_ERR("while constructing publ callback param\n"); >> - goto error; >> - } >> - >> - set_uac_req(&uac_r,&met, str_hdr, 0, 0, >> TMCB_LOCAL_COMPLETED, >> - publ_cback_func, (void*)cb_param); >> - >> - result= tmb.t_request(&uac_r, >> - p->pres_uri, >> /* Request-URI */ >> - p->pres_uri, >> /* To */ >> - p->pres_uri, >> /* From */ >> -&outbound_proxy >> /* Outbound proxy*/ >> - ); >> - if(result< 0) >> - { >> - LM_ERR("in t_request function\n"); >> - shm_free(cb_param); >> - goto error; >> - } >> - >> - } >> - else >> - { >> - str met= {"SUBSCRIBE", 9}; >> - dlg_t* td= NULL; >> - ua_pres_t* cb_param= NULL; >> - >> - td= pua_build_dlg_t(p); >> - if(td== NULL) >> - { >> - LM_ERR("while building tm dlg_t structure"); >> - goto error; >> - }; >> - >> - str_hdr= subs_build_hdr(&p->contact, >> expires,p->event,p->extra_headers); >> - if(str_hdr== NULL || str_hdr->s== NULL) >> - { >> - LM_ERR("while building extra headers\n"); >> - pkg_free(td); >> - return -1; >> - } >> - cb_param= subs_cbparam_indlg(p, expires, REQ_ME); >> - if(cb_param== NULL) >> - { >> - LM_ERR("while constructing subs callback param\n"); >> - goto error; >> - >> - } >> - >> - set_uac_req(&uac_r,&met, str_hdr, 0, td, >> TMCB_LOCAL_COMPLETED, >> - subs_cback_func, (void*)cb_param); >> - >> - result= tmb.t_request_within(&uac_r); >> - if(result< 0) >> - { >> - LM_ERR("in t_request function\n"); >> - shm_free(cb_param); >> - pkg_free(td); >> - goto error; >> - } >> - >> - pkg_free(td); >> - td= NULL; >> - } >> - >> - pkg_free(str_hdr); >> - return 0; >> - >> -error: >> - if(str_hdr) >> - pkg_free(str_hdr); >> - return -1; >> + int expires; >> + int result = 0; >> + uac_req_t uac_r; >> + str met = {NULL, 0}; >> + int ret_code = 0; >> + dlg_t* td = NULL; >> + >> + >> + if(p->desired_expires== 0) >> + expires= default_expires; >> + else >> + expires= p->desired_expires- (int)time(NULL); >> + >> + if(p->watcher_uri== NULL) >> + { >> + >> + str_hdr = publ_build_hdr(expires, get_event(p->event), NULL, >> +&p->etag, p->extra_headers, 0); >> + >> + if(str_hdr == NULL) >> + { >> + LM_ERR("while building extra_headers\n"); >> + ret_code = -1; >> + goto done; >> + } >> + LM_DBG("str_hdr:\n%.*s\n ", str_hdr->len, str_hdr->s); >> + >> + cb_param= build_uppubl_cbparam(p); >> + if(cb_param== NULL) >> + { >> + LM_ERR("while constructing publ callback param\n"); >> + ret_code = -1; >> + goto done; >> + } >> + >> + met.s = (char*)pkg_malloc(8*sizeof(char)); >> + if(met.s == NULL) { >> + LM_ERR("no memory for met.s(PUBLISH)\n"); >> + ret_code = -1; >> + goto done; >> + } >> + memset(met.s, 0, 8); >> + memcpy(met.s, "PUBLISH", 7); >> + met.len = 7; >> + set_uac_req(&uac_r,&met, str_hdr, 0, 0, TMCB_LOCAL_COMPLETED, >> + publ_cback_func, (void*)cb_param); >> + >> + result= tmb.t_request(&uac_r, >> + p->pres_uri, /* Request-URI */ >> + p->pres_uri, /* To */ >> + p->pres_uri, /* From */ >> +&outbound_proxy /* Outbound proxy*/ >> + ); >> + if(result< 0) >> + { >> + LM_ERR("in t_request function\n"); >> + shm_free(cb_param); >> + cb_param = NULL; >> + ret_code = -1; >> + goto done; >> + } >> + } >> + else >> + { >> + td= pua_build_dlg_t(p); >> + if(td== NULL) >> + { >> + LM_ERR("while building tm dlg_t structure"); >> + ret_code = -1; >> + goto done; >> + }; >> + >> + str_hdr= subs_build_hdr(&p->contact, >> expires,p->event,p->extra_headers); >> + if(str_hdr== NULL || str_hdr->s== NULL) >> + { >> + if(p->event!=0) >> + LM_ERR("while building extra headers\n"); >> + >> + ret_code = -1; >> + goto done; >> + } >> + >> + cb_param= subs_cbparam_indlg(p, expires, REQ_ME); >> + if(cb_param== NULL) >> + { >> + LM_ERR("while constructing subs callback param\n"); >> + ret_code = -1; >> + goto done; >> + } >> + >> + met.s = (char*)pkg_malloc(10*sizeof(char)); >> + if(met.s == NULL) { >> + LM_ERR("no memory for met.s(SUBSCRIBE)\n"); >> + ret_code = -1; >> + goto done; >> + } >> + memset(met.s, 0, 10); >> + memcpy(met.s, "SUBSCRIBE", 9); >> + met.len = 9; >> + set_uac_req(&uac_r,&met, str_hdr, 0, td, TMCB_LOCAL_COMPLETED, >> + subs_cback_func, (void*)cb_param); >> + >> + result= tmb.t_request_within(&uac_r); >> + if(result< 0) >> + { >> + LM_ERR("in t_request function\n"); >> + ret_code = -1; >> + shm_free(cb_param); >> + cb_param = NULL; >> + goto done; >> + } >> + } >> + >> + >> +done: >> + if(td!=NULL) >> + { >> + if(td->route_set) >> + free_rr(&td->route_set); >> + >> + pkg_free(td); >> + td= NULL; >> + } >> + >> + if(met.s != NULL) { >> + pkg_free(met.s); >> + met.s = NULL; >> + met.len = 0; >> + } >> + >> + if(str_hdr != NULL) { >> + pkg_free(str_hdr); >> + str_hdr = NULL; >> + } >> >> + return ret_code; >> } >> >> static void db_update(unsigned int ticks,void *param) >> >> >> It seems a lot of change, but there are only a few lines changed, >> probably in the file I modify I have convert the TAB to Space and the >> diff does not recognize them. Another thing is I use dynamic memory >> for the str SUBSCRIBE and PUBLISH. >> >> >> >> >> Another thing for the management of NOTIFY arrives before the 202/200 >> OK of SUBSCRIBE, in addition to the patches done previously, maybe the >> hash.c need to patch for the is_dialog function which is called for >> the NOTIFY in PUA_XMPP module: >> >> # diff -u hash.c.orig hash.c >> --- hash.c.orig 2011-12-27 13:38:06.000000000 +0100 >> +++ hash.c 2011-12-27 13:38:38.000000000 +0100 >> @@ -487,10 +487,11 @@ >> hash_code= core_hash(dialog->pres_uri, dialog->watcher_uri, >> HASH_SIZE); >> lock_get(&HashT->p_records[hash_code].lock); >> >> - if(get_dialog(dialog, hash_code)== NULL) >> - ret_code= -1; >> - else >> + if(get_dialog(dialog, hash_code) || >> get_temporary_dialog(dialog, hash_code)) >> ret_code= 0; >> + else >> + ret_code= -1; >> + >> lock_release(&HashT->p_records[hash_code].lock); >> >> return ret_code; >> >> >> Best Regards, >> Laura >> >> On Fri, Dec 23, 2011 at 5:10 PM, laura testi<lau.testi(a)gmail.com> wrote: >> >> Ok, I'll try it. >> >> Thank you very much! >> >> >> >> >> On Fri, Dec 23, 2011 at 1:20 PM, Daniel-Constantin Mierla >> <miconda(a)gmail.com> wrote: >> >> Hello, >> >> can you try with this patch: >> >> http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1b3cfa6… >> >> Cheers, >> Daniel >> >> >> On 12/23/11 12:36 PM, Daniel-Constantin Mierla wrote: >> >> Hello, >> >> looks like a leak in a module that is storing record-routes and use them >> later, perhaps pua module, I will check it soon. >> >> Cheers, >> Daniel >> >> On 12/23/11 11:31 AM, laura testi wrote: >> >> Hi Daniel, >> I just follow the instruction in the link you sent >> (http://www.asipto.com/pub/kamailio-devel-guide/#c04troubleshooting) >> to use gdb to print PKG fragments. When I got the error in PUA: >> >> Dec 23 11:10:53 /.../sbin/kamailio[23276]: ERROR: pua >> [send_subscribe.c:158]: No memory left for size:439 >> Dec 23 11:10:53 /.../sbin/kamailio[23276]: ERROR: pua [pua.c:747]: >> while building tm dlg_t structure >> Dec 23 11:10:53 /.../sbin/kamailio[23276]: ERROR: pua [pua.c:652]: >> while updating record >> >> >> The I run the command >> gdb /.../sbin/kamailio 23276 >> and write the following commands in the gdb: >> >> set $i=0 >> set $a = mem_block->first_frag >> while($i<10000) >> if($i>2000) >> if($a->u.is_free==0) >> p *$a >> end >> end >> set $a = ((struct qm_frag*)((char*)($a)+sizeof(struct >> qm_frag)+((struct qm_frag*)$a)->size+sizeof(struct qm_frag_end))) >> set $i = $i + 1 >> end >> ... >> >> after a while I got a lot of prints on the screen like these: >> >> func = 0x5d7b00 "do_parse_rr_body", line = 74, check = 4042322160} >> $1348 = {size = 72, u = {nxt_free = 0x0, is_free = 0}, >> file = 0x5d76c9 "<core>: parser/parse_rr.c", >> func = 0x5d7b00 "do_parse_rr_body", line = 74, check = 4042322160} >> $1349 = {size = 72, u = {nxt_free = 0x0, is_free = 0}, >> file = 0x5d76c9 "<core>: parser/parse_rr.c", >> func = 0x5d7b00 "do_parse_rr_body", line = 74, check = 4042322160} >> $1350 = {size = 72, u = {nxt_free = 0x0, is_free = 0}, >> file = 0x5d76c9 "<core>: parser/parse_rr.c", >> func = 0x5d7b00 "do_parse_rr_body", line = 74, check = 4042322160} >> $1351 = {size = 104, u = {nxt_free = 0x0, is_free = 0}, >> file = 0x5d76c9 "<core>: parser/parse_rr.c", >> func = 0x5d7b00 "do_parse_rr_body", line = 74, check = 4042322160} >> $1352 = {size = 104, u = {nxt_free = 0x0, is_free = 0}, >> file = 0x5d76c9 "<core>: parser/parse_rr.c", >> func = 0x5d7b00 "do_parse_rr_body", line = 74, check = 4042322160} >> $1353 = {size = 72, u = {nxt_free = 0x0, is_free = 0}, >> file = 0x5d76c9 "<core>: parser/parse_rr.c", >> func = 0x5d7b00 "do_parse_rr_body", line = 74, check = 4042322160} >> $1354 = {size = 72, u = {nxt_free = 0x0, is_free = 0}, >> ---Type<return> to continue, or q<return> to quit--- >> >> ... >> >> >> But I don't understand if these are normal or something goes wrong.... >> >> Can you help >> >> >> Best Regards, >> Laura >> >> On Wed, Dec 21, 2011 at 12:18 PM, Daniel-Constantin Mierla >> <miconda(a)gmail.com> wrote: >> >> Hello, >> >> pkg.stats was added in 3.2.0, iirc. For 3.1, you can walk the packets in >> memory with gdb -- 3.1 has memory debug on, so you don't need to >> recompile >> (unless you turned it off). >> >> Just attach to the pid of a sip worker (gdb /path/to/kamailio >> _pid_value_) >> and run the gdb script. >> >> Cheers, >> Daniel >> >> >> On 12/21/11 11:58 AM, laura testi wrote: >> >> Hi Daniel, >> I try the sercmd for pkg memory but it return 500 error: >> >> >> # sercmd >> sercmd 0.2 >> Copyright 2006 iptelorg GmbH >> This is free software with ABSOLUTELY NO WARRANTY. >> For details type `warranty'. >> sercmd> pkg.stats >> error: 500 - command pkg.stats not found >> sercmd> >> >> >> >> Is it available only for 3.2.x and master branch? Because we are using >> 3.1.5. But take the PUA module from master branch for the fetch_row >> parameter you have patched ;-) >> >> >> core.shmmem is ok. >> >> >> >> Thanks a lot >> >> Laura >> >> On Wed, Dec 21, 2011 at 10:58 AM, Daniel-Constantin Mierla >> <miconda(a)gmail.com> wrote: >> >> Hello, >> >> you can see the available pkg via sercmd, sending command pkg.stats >> (match >> the entry for the pid printing the error). If there is no free memory, >> then >> might be a leak. >> >> You can attach with gdb to the pid printing these errors and walk to >> pkg, >> you see the commands for gdb at: >> >> http://www.asipto.com/pub/kamailio-devel-guide/#c04troubleshooting >> >> See if you have lot of allocated chunks from same place in source code >> (ignore those at the beginning, mainly related to cfg parsing) and >> send >> the >> details here. >> >> Cheers, >> Daniel >> >> >> On 12/21/11 10:44 AM, laura testi wrote: >> >> Hi, >> we are using the PUA_XMPP and PUA modules from the master branch. When >> the modules are started, everything are ok, the presence events from >> XMPP are sent to kamailio SIP servers (PUBLISH/SUBSCRIBE) and cached >> in the hash. But when there are several thousands records in the hash >> tabel, the update_pua function called in the hashT_clean gives a lot >> of "No memory left" error when the hashT_clean is waked up from the >> time: >> >> ERROR: pua [send_subscribe.c]: No memory left >> ERROR: pua [pua.c]: while building tm dlg_t structure >> >> The failed call is: >> td = (dlg_t*)pkg_malloc(size); >> if(td == NULL) >> { >> LM_ERR("No memory left\n"); >> return NULL; >> } >> >> in dlg_t* pua_build_dlg_t(ua_pres_t* presentity) function in >> send_subscribe.c. The size is about 400 and something... It's >> strange..... >> >> Is it the memory leak in the PUA module? >> >> >> >> I also try to increase the pkg_memory from 4MB default to 16MB, but it >> doesn't help. >> >> >> Any Idea? >> >> Thanks in advanced >> >> Laura >> >> _______________________________________________ >> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing >> list >> sr-users(a)lists.sip-router.org >> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users >> >> >> -- >> Daniel-Constantin Mierla -- http://www.asipto.com >> http://linkedin.com/in/miconda -- http://twitter.com/miconda >> >> _______________________________________________ >> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list >> sr-users(a)lists.sip-router.org >> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users >> >> -- >> Daniel-Constantin Mierla -- http://www.asipto.com >> http://linkedin.com/in/miconda -- http://twitter.com/miconda >> >> -- >> Daniel-Constantin Mierla -- http://www.asipto.com >> http://linkedin.com/in/miconda -- http://twitter.com/miconda >> >> >> >> _______________________________________________ >> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list >> sr-users(a)lists.sip-router.org >> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users >> >> >> -- >> Daniel-Constantin Mierla -- http://www.asipto.com >> http://linkedin.com/in/miconda -- http://twitter.com/miconda >> >> >> _______________________________________________ >> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list >> sr-users(a)lists.sip-router.org >> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users -- Daniel-Constantin Mierla -- http://www.asipto.com http://linkedin.com/in/miconda -- http://twitter.com/miconda

2 3

git:master: pua: is_dialog() returns 1 if there is a temporary dialog
by Daniel-Constantin Mierla 03 Jan '12

03 Jan '12

Module: sip-router Branch: master Commit: 5f1e2caac5e6d68629a1a0956861bf7da6e05e31 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5f1e2ca… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Jan 3 18:02:39 2012 +0100 pua: is_dialog() returns 1 if there is a temporary dialog - reported by Laura Testi --- modules_k/pua/hash.c | 14 +++++++++++--- modules_k/pua/pua_db.c | 6 +++++- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/modules_k/pua/hash.c b/modules_k/pua/hash.c index ab8d145..85aa6fa 100644 --- a/modules_k/pua/hash.c +++ b/modules_k/pua/hash.c @@ -475,6 +475,9 @@ int get_record_id(ua_pres_t* dialog, str** rec_id) return 0; } +/** + * return -1 on not found, 0 on established dialog, 1 on temporary dialog + */ int is_dialog(ua_pres_t* dialog) { int ret_code= 0; @@ -488,10 +491,15 @@ int is_dialog(ua_pres_t* dialog) hash_code= core_hash(dialog->pres_uri, dialog->watcher_uri, HASH_SIZE); lock_get(&HashT->p_records[hash_code].lock); - if(get_dialog(dialog, hash_code)== NULL) - ret_code= -1; - else + if(get_dialog(dialog, hash_code)==NULL) + { + if(get_temporary_dialog(dialog, hash_code)==NULL) + ret_code= -1; + else + ret_code= 1; + } else { ret_code= 0; + } lock_release(&HashT->p_records[hash_code].lock); return ret_code; diff --git a/modules_k/pua/pua_db.c b/modules_k/pua/pua_db.c index 54e11c0..44c5fbc 100644 --- a/modules_k/pua/pua_db.c +++ b/modules_k/pua/pua_db.c @@ -761,7 +761,11 @@ int is_dialog_puadb(ua_pres_t *pres) /* no need to return here - drop thro */ } - return(0); + /* established dialog */ + if(pres->to_tag.len>0) + return 0; + /* temporary dialog */ + return 1; } /******************************************************************************/

1 0

New Year, New Module: app_mono - embedded execution of managed code
by Daniel-Constantin Mierla 03 Jan '12

03 Jan '12

Hello, the first committed module in 2012 is app_mono, which offers embedded execution of manage code (e.g., C#/.NET) via Mono project (http://www.mono-project.com/). The readme of the new module is available at: * http://kamailio.org/docs/modules/devel/modules/app_mono.html Current API which exported by SIP server for usage in C# application is documented at: * http://www.kamailio.org/wiki/embeddedapi/devel/mono Besides C#, app_mono should be able to run managed code compiled from applications written in other languages such as VisualBasic.NET, Java, Java Script, Python, ... more are listed at: * http://www.mono-project.com/Languages A primary use is integration with several widely used Microsoft technologies and APIs, for example C# having up-to-date libraries to connect to Active Directory LDAP service or MS SQL Server. Happy 2012, Daniel -- Daniel-Constantin Mierla -- http://www.asipto.com http://linkedin.com/in/miconda -- http://twitter.com/miconda

1 0

git:master: Makefile: added app_mono module to exclude_modules list
by Daniel-Constantin Mierla 03 Jan '12

03 Jan '12

Module: sip-router Branch: master Commit: b2740f62d775de3bd2d5ae4a99ac43eea8c4927a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b2740f6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jan 2 23:44:09 2012 +0100 Makefile: added app_mono module to exclude_modules list --- Makefile | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 1ea0050..0a59f95 100644 --- a/Makefile +++ b/Makefile @@ -285,6 +285,9 @@ module_group_kjson=json jsonrpc-c # K redis module module_group_kredis=ndb_redis +# K mono module +module_group_kmono=app_mono + # if not set on the cmd. line, env or in the modules.lst (cfg_group_include) # exclude the below modules. ifneq ($(group_include)$(cfg_group_include),) @@ -326,6 +329,8 @@ else exclude_modules+= json jsonrpc-c # depends on libhiredis exclude_modules+= ndb_redis + # depends on mono-devel + exclude_modules+= app_mono # depends on tm being compiled with -DWITH_AS_SUPPORT support ifeq (,$(findstring -DWITH_AS_SUPPORT, $(C_DEFS))) exclude_modules+= seas

1 0

git:master: app_mono: new module to run managed code embedded
by Daniel-Constantin Mierla 03 Jan '12

03 Jan '12

Module: sip-router Branch: master Commit: fa893fb17b703c47be9437e114481f188c62aede URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fa893fb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jan 2 23:39:56 2012 +0100 app_mono: new module to run managed code embedded - embeds the mono project interpreter - allows execution of manged code from config file, such as assemblies for C#/.NET, Java, a.s.o. - can load the assembly at startup or read it every time before execution --- modules/app_mono/Makefile | 22 + modules/app_mono/README | 218 +++++++ modules/app_mono/app_mono_api.c | 945 +++++++++++++++++++++++++++++++ modules/app_mono/app_mono_api.h | 63 ++ modules/app_mono/app_mono_mod.c | 223 ++++++++ modules/app_mono/doc/Makefile | 4 + modules/app_mono/doc/app_mono.xml | 36 ++ modules/app_mono/doc/app_mono_admin.xml | 231 ++++++++ modules/app_mono/lib/SR.cs | 41 ++ 9 files changed, 1783 insertions(+), 0 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=fa8…

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2012