sr-dev April 2012

sr-dev@lists.kamailio.org

29 participants
346 discussions

Using t_suspend()/t_continue() multiple times on the same transaction

by Peter Dunkley

Hi, I am trying to use t_suspend()/t_continue() multiple times on the same transaction. Calling t_suspend() more than once works, but the second time I call t_continue() the transaction is killed and a 500 response is sent. It is the "if (branch == t->nr_of_outgoings)" check from the code fragment below (from t_suspend.c:t_continue()) that results in the transaction being killed - you can see the debug/error line I added to determine this in the fragment. Is using t_suspend()/t_continue() multiple times something that should work? Thanks, Peter if (t->uas.status < 200) { /* No final reply has been sent yet. * Check whether or not there is any pending branch. */ for ( branch = 0; branch < t->nr_of_outgoings; branch++ ) { if ((t->uac[branch].request.buffer != NULL) && (t->uac[branch].last_received < 200) ) break; } if (branch == t->nr_of_outgoings) { /* There is not any open branch so there is * no chance that a final response will be received. */ ret = 0; LM_ERR("branch == t->nr_of_outgoings\n"); goto kill_trans; } } -- Peter Dunkley Technical Director Crocodile RCS Ltd

10 years, 4 months

git:master: modules_k/presence: RFC 4827 (presence hard-state) support

by Peter Dunkley

Module: sip-router Branch: master Commit: 37812cef5fb1ee2022592de24bbae48352e17524 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=37812ce… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Tue Apr 10 18:05:10 2012 +0100 modules_k/presence: RFC 4827 (presence hard-state) support - Hard-state presence documents are stored as pidf-manipulation documents in the integrated XCAP server. - When one of these documents is put/deleted/changed it can be "published" using the new pres_update_presentity() exported function. - Because the original document is in XCAP a client can download it and manipulate it directly. - Hard-state documents have an expiry time of -1 and never expire (the clean function in presence has been updated to make sure of this). - The filename of the document is used as the ETag value in the presentity table. This enables multiple hard-state documents (with different filenames) to be uploaded for each subscriber. - Hard-state is useful for permanently setting an avatar, or an out-of-office message, etc. --- modules_k/presence/README | 302 ++++++++++++++++++----------- modules_k/presence/doc/presence_admin.xml | 99 ++++++++++ modules_k/presence/presence.c | 128 ++++++++++++- modules_k/presence/presence.h | 5 + modules_k/presence/presentity.c | 87 ++++++--- modules_k/presence/publish.c | 200 +++++++++++++++++++- modules_k/presence/publish.h | 2 +- 7 files changed, 679 insertions(+), 144 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=378…

12 years, 5 months

runtime pv evaluation

by Jasmin Schnatterbeck

Hello, currently I am looking for an option to evaluate a string with pseudo-variables at script runtime. For example when reading the following string (in script) from database "from is $fu and to-uri-user is $(tu{uri.user}) and cl is $cl" into a pseudo-variable $var(tmp) I want kamailio to parse the _content_ of $var(tmp): replace the "inside"-pvs with their values and perform transformations. Is there a function exported to script, that could do that? (Background: I would like to make the lcr-module a bit more flexible: read "template"-string for fromuri, touri, ruri from database instead of ruri-strip, ruri-prefix etc.) Kind Regards Jasmin

12 years, 6 months

[tracker] Task opened: Kamailio looses track of location entries

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Jon Tsiros (CiscoGeek) Attached to Project - sip-router Summary - Kamailio looses track of location entries Task Type - Bug Report Category - Core Status - Unconfirmed Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - Over a period of time, location entries in memory become out of sync with entries in the database. I managed to capture the MySQL queries that attempt to update a particular entry after it is deleted from the database: 5 Query update location set expires='2012-04-27 05:21:55',q=0.80 ,cseq=393,flags=0,cflags=0,user_agent='PolycomSoundPointIP-SPIP_550-UA/3.2.4.0267',received='sip:xx.xx.xx.xx:5060',path='<sip:xx.xx.xx.xx;lr;received=\"sip:xx.xx.xx.xx:5060\">',socket='udp:xx.xx.xx.xx:5060',methods=8159,last_modified='2012-04-27 05:16:18' where username='2012049699' AND contact='sip:2012049699@xx.xx.xx.xx:5060' AND callid='54f18079-9ca165bc-9eed12e3(a)192.168.1.7' 5 Query update location set expires='2012-04-27 05:26:36',q=0.80 ,cseq=395,flags=0,cflags=0,user_agent='PolycomSoundPointIP-SPIP_550-UA/3.2.4.0267',received='sip:xx.xx.xx.xx:5060',path='<sip:xx.xx.xx.xx;lr;received=\"sip:xx.xx.xx.xx:5060\">',socket='udp:xx.xx.xx.xx:5060',methods=8159,last_modified='2012-04-27 05:20:59' where username='2012049699' AND contact='sip:2012049699@xx.xx.xx.xx:5060' AND callid='54f18079-9ca165bc-9eed12e3(a)192.168.1.7' 5 Query insert into location (username,contact,expires,q,callid,cseq,flags,cflags,user_agent,received,path,socket,methods,last_modified ) values ('2012049699','sip:2012049699@xx.xx.xx.xx:5060','2012-04-27 05:31:16',0.80 ,'54f18079-9ca165bc-9eed12e3(a)192.168.1.7',396,0,0,'PolycomSoundPointIP-SPIP_550-UA/3.2.4.0267','sip:xx.xx.xx.xx:5060','<sip:xx.xx.xx.xx;lr;received=\"sip:xx.xx.xx.xx:5060\">','udp:xx.xx.xx.xx:5060',8159,'2012-04-27 05:25:39') 5 Query delete from location where username='2012049699' AND contact='sip:2012049699@xx.xx.xx.xx:5060' AND callid='54f18079-9ca165bc-9eed12e3(a)192.168.1.7' 5 Query insert into location (username,contact,expires,q,callid,cseq,flags,cflags,user_agent,received,path,socket,methods,last_modified ) values ('2012049699','sip:2012049699@xx.xx.xx.xx:5060','2012-04-27 05:35:53',0.80,'54f18079-9ca165bc-9eed12e3(a)192.168.1.7',398,0,0,'PolycomSoundPointIP-SPIP_550-UA/3.2.4.0267','sip:xx.xx.xx.xx:5060','<sip:xx.xx.xx.xx;lr;received=\"sip:xx.xx.xx.xx:5060\">','udp:xx.xx.xx.xx:5060',8159,'2012-04-27 05:30:16') 5 Query delete from location where username='2012049699' AND contact='sip:2012049699@xx.xx.xx.xx:5060' AND callid='54f18079-9ca165bc-9eed12e3(a)192.168.1.7' 5 Query update location set expires='2012-04-27 05:40:30',q=0.80 ,cseq=399,flags=0,cflags=0,user_agent='PolycomSoundPointIP-SPIP_550-UA/3.2.4.0267',received='sip:xx.xx.xx.xx:5060',path='<sip:xx.xx.xx.xx;lr;received=\"sip:xx.xx.xx.xx:5060\">',socket='udp:xx.xx.xx.xx:5060',methods=8159,last_modified='2012-04-27 05:34:53' where username='2012049699' AND contact='sip:2012049699@xx.xx.xx.xx:5060' AND callid='54f18079-9ca165bc-9eed12e3(a)192.168.1.7' 5 Query update location set expires='2012-04-27 05:45:07',q=0.80 ,cseq=401,flags=0,cflags=0,user_agent='PolycomSoundPointIP-SPIP_550-UA/3.2.4.0267',received='sip:xx.xx.xx.xx:5060',path='<sip:xx.xx.xx.xx;lr;received=\"sip:xx.xx.xx.xx:5060\">',socket='udp:xx.xx.xx.xx:5060',methods=8159,last_modified='2012-04-27 05:39:30' where username='2012049699' AND contact='sip:2012049699@xx.xx.xx.xx:5060' AND callid='54f18079-9ca165bc-9eed12e3(a)192.168.1.7' More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=226 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 6 months

out of pkg memory is not reported

by Juha Heinanen

i started sr on amd64 architecture and it didn't start with exactly same configuration file that works ok on i386 architecture. syslog got these error messages: Not starting sip-proxy: invalid configuration file! 0(11601) : <core> [cfg.y:3591]: parse error in config file /etc/sip-proxy/sip-proxy.cfg, line 4918, column 18-22: internal error: failed to create rval expr 0(11601) : <core> [cfg.y:3591]: parse error in config file /etc/sip-proxy/sip-proxy.cfg, line 4918, column 18-22: '('')' expected (function call) 0(11601) : <core> [cfg.y:3591]: parse error in config file /etc/sip-proxy/sip-proxy.cfg, line 4918, column 18-22: internal error: failed to create rval expr 0(11601) : <core> [cfg.y:3594]: parse error in config file /etc/sip-proxy/sip-proxy.cfg, line 4918, column 28: bad expression 0(11601) : <core> [cfg.y:3594]: parse error in config file /etc/sip-proxy/sip-proxy.cfg, line 4918, column 28: invalid route statement 0(11601) : <core> [cfg.y:3594]: parse error in config file /etc/sip-proxy/sip-proxy.cfg, line 4918, column 31: ERROR: bad config file (6 errors) sr started fine then i increased the amount of pkg memory, i.e., there was no syntax error in the config. this is pretty confusing for new users. it would good if the real reason for the failure would be reported. -- juha

12 years, 6 months

git:master: lib/srdb1/schema/lcr_rule.xml: upgraded version number

by admin＠sip-router.org

Module: sip-router Branch: master Commit: 6362f26d4bac5258f949d78ee4a3b26c997cb476 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6362f26… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Mon Apr 30 23:24:19 2012 +0300 lib/srdb1/schema/lcr_rule.xml: upgraded version number - When request_uri column was added, version number was not incremented in schema. --- lib/srdb1/schema/lcr_rule.xml | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/srdb1/schema/lcr_rule.xml b/lib/srdb1/schema/lcr_rule.xml index 7727f75..a1f117e 100644 --- a/lib/srdb1/schema/lcr_rule.xml +++ b/lib/srdb1/schema/lcr_rule.xml @@ -9,7 +9,7 @@ <table id="lcr_rule" xmlns:db="http://docbook.org/ns/docbook"> <name>lcr_rule</name> - <version>1</version> + <version>2</version> <type db="mysql">&MYSQL_TABLE_TYPE;</type> <description> <db:para>This table is used by the lcr (Least Cost Routing)

12 years, 6 months

[tracker] Comment added: Double Free -- Crash/Coredump and possible security vulnerability

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#173 - Double Free -- Crash/Coredump and possible security vulnerability User who did this - bayram (forza198419) ---------- Hi Daniel, Is this fix solved in 3.2.3 version? we face this problem in 3.2.0 and updated to 3.2.3 # kamailio -V version: kamailio 3.2.3 (x86_64/linux) flags: STATS: Off, USE_IPV6, USE_TCP, USE_TLS, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, DBG_QM_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 4MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 14:19:25 Apr 19 2012 with gcc 4.4.5 ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=173#comment635 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

12 years, 7 months

git:master: registrar(k): realm prefix initialized to NULL instead of empty string

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: a3db4686f286e4f04a416b84423d355d2ad69056 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a3db468… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Apr 29 15:30:28 2012 +0200 registrar(k): realm prefix initialized to NULL instead of empty string - it refers inside a cfg structure and might be the reason for sigbus on solaris/sparc - anyhow, it avoids an strlen() over empty string, behaviour being the same as before --- modules_k/registrar/common.c | 4 ++-- modules_k/registrar/config.c | 4 ++-- modules_k/registrar/config.h | 2 +- modules_k/registrar/reg_mod.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/modules_k/registrar/common.c b/modules_k/registrar/common.c index 9d878f2..3cd235f 100644 --- a/modules_k/registrar/common.c +++ b/modules_k/registrar/common.c @@ -93,8 +93,8 @@ int extract_aor(str* _uri, str* _a, sip_uri_t *_pu) if (user_len) aor_buf[_a->len++] = '@'; /* strip prefix (if defined) */ - realm_prefix.s = cfg_get(registrar, registrar_cfg, realm_pref); - realm_prefix.len = strlen(realm_prefix.s); + realm_prefix.s = cfg_get(registrar, registrar_cfg, realm_pref).s; + realm_prefix.len = cfg_get(registrar, registrar_cfg, realm_pref).len; if (realm_prefix.len && realm_prefix.len<puri->host.len && (memcmp(realm_prefix.s, puri->host.s, realm_prefix.len)==0) ) { memcpy(aor_buf + _a->len, puri->host.s + realm_prefix.len, diff --git a/modules_k/registrar/config.c b/modules_k/registrar/config.c index f187c1a..038a68c 100644 --- a/modules_k/registrar/config.c +++ b/modules_k/registrar/config.c @@ -40,7 +40,7 @@ struct cfg_group_registrar default_registrar_cfg = { 0, /* case_sensitive */ Q_UNSPECIFIED, /* default_q */ 1, /* append_branches */ - "" /* realm_pref */ + STR_NULL /* realm_pref */ }; void *registrar_cfg = &default_registrar_cfg; @@ -64,7 +64,7 @@ cfg_def_t registrar_cfg_def[] = { "The parameter represents default q value for new contacts."}, /* Q_UNSPECIFIED is -1 */ {"append_branches", CFG_VAR_INT , 0, 0, 0, 0, "If set to 1(default), lookup will put all contacts found in msg structure"}, - {"realm_pref", CFG_VAR_STRING , 0, 0, 0, 0, + {"realm_pref", CFG_VAR_STR, 0, 0, 0, 0, "Realm prefix to be removed. Default is \"\""}, {0, 0, 0, 0, 0, 0} }; diff --git a/modules_k/registrar/config.h b/modules_k/registrar/config.h index 06b1390..f2708d6 100644 --- a/modules_k/registrar/config.h +++ b/modules_k/registrar/config.h @@ -36,7 +36,7 @@ struct cfg_group_registrar { unsigned int case_sensitive; qvalue_t default_q; unsigned int append_branches; - char* realm_pref; + str realm_pref; }; extern struct cfg_group_registrar default_registrar_cfg; diff --git a/modules_k/registrar/reg_mod.c b/modules_k/registrar/reg_mod.c index de3870a..a38b00a 100644 --- a/modules_k/registrar/reg_mod.c +++ b/modules_k/registrar/reg_mod.c @@ -202,7 +202,7 @@ static param_export_t params[] = { {"append_branches", INT_PARAM, &default_registrar_cfg.append_branches }, {"case_sensitive", INT_PARAM, &default_registrar_cfg.case_sensitive }, /* {"tcp_persistent_flag",INT_PARAM, &tcp_persistent_flag }, */ - {"realm_prefix", STR_PARAM, &default_registrar_cfg.realm_pref }, + {"realm_prefix", PARAM_STR, &default_registrar_cfg.realm_pref }, {"min_expires", INT_PARAM, &default_registrar_cfg.min_expires }, {"max_expires", INT_PARAM, &default_registrar_cfg.max_expires }, {"received_param", STR_PARAM, &rcv_param },

12 years, 7 months

git:master: dialog(k): propagate internal flags from context to dlg structure

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 5194b4c7776d24b88be51f799e67af7ddaf3da1a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5194b4c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Apr 29 15:33:18 2012 +0200 dialog(k): propagate internal flags from context to dlg structure - moved condition on DLG_STATE_CONFIRMED in request handling, as it is set for ACK processing - related to keep-alive initialization for dlg --- modules_k/dialog/dialog.c | 2 +- modules_k/dialog/dlg_handlers.c | 7 ++++--- modules_k/dialog/dlg_hash.c | 9 ++++++++- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/modules_k/dialog/dialog.c b/modules_k/dialog/dialog.c index 1691ba7..3a404d1 100644 --- a/modules_k/dialog/dialog.c +++ b/modules_k/dialog/dialog.c @@ -694,7 +694,7 @@ static int child_init(int rank) if(rank==PROC_MAIN && dlg_ka_timer>0 && dlg_ka_interval>0) { if(fork_sync_timer(PROC_TIMER, "Dialog KA Timer", 1 /*socks flag*/, - dlg_ka_timer_exec, NULL, dlg_ka_interval /*sec*/)<0) { + dlg_ka_timer_exec, NULL, dlg_ka_timer /*sec*/)<0) { LM_ERR("failed to start ka timer routine as process\n"); return -1; /* error */ } diff --git a/modules_k/dialog/dlg_handlers.c b/modules_k/dialog/dlg_handlers.c index 6f87826..0b528a0 100644 --- a/modules_k/dialog/dlg_handlers.c +++ b/modules_k/dialog/dlg_handlers.c @@ -476,9 +476,6 @@ static void dlg_onreply(struct cell* t, int type, struct tmcb_params *param) goto done; } - if (new_state==DLG_STATE_CONFIRMED && old_state!=DLG_STATE_CONFIRMED) - dlg_ka_add(dlg); - if (new_state==DLG_STATE_CONFIRMED_NA && old_state!=DLG_STATE_CONFIRMED_NA && old_state!=DLG_STATE_CONFIRMED ) { LM_DBG("dialog %p confirmed (ACK pending)\n",dlg); @@ -853,6 +850,7 @@ int dlg_new_dialog(sip_msg_t *req, struct cell *t, const int run_initial_cbs) s.len = strlen(s.s); dlg_set_toroute(dlg, &s); dlg->sflags |= _dlg_ctx.flags; + dlg->iflags |= _dlg_ctx.iflags; if (dlg_send_bye!=0 || _dlg_ctx.to_bye!=0) dlg->iflags |= DLG_IFLAG_TIMEOUTBYE; @@ -1209,6 +1207,9 @@ void dlg_onroute(struct sip_msg* req, str *route_params, void *param) } } + if (new_state==DLG_STATE_CONFIRMED && old_state!=DLG_STATE_CONFIRMED) + dlg_ka_add(dlg); + /* run actions for the transition */ if (event==DLG_EVENT_REQBYE && new_state==DLG_STATE_DELETED && old_state!=DLG_STATE_DELETED) { diff --git a/modules_k/dialog/dlg_hash.c b/modules_k/dialog/dlg_hash.c index 9405350..e4d4f7c 100644 --- a/modules_k/dialog/dlg_hash.c +++ b/modules_k/dialog/dlg_hash.c @@ -150,9 +150,10 @@ int dlg_ka_add(dlg_cell_t *dlg) if(*dlg_ka_list_tail!=NULL) (*dlg_ka_list_tail)->next = dka; if(*dlg_ka_list_head==NULL) - *dlg_ka_list_tail = dka; + *dlg_ka_list_head = dka; *dlg_ka_list_tail = dka; lock_release(dlg_ka_list_lock); + LM_DBG("added dlg[%d,%d] to KA list\n", dlg->h_entry, dlg->h_id); return 0; } @@ -176,6 +177,12 @@ int dlg_ka_run(ticks_t ti) return 0; } dka = *dlg_ka_list_head; +#if 0 + LM_DBG("dlg ka timer at %lu for" + " dlg[%u,%u] on %lu\n", (unsigned long)ti, + dka->iuid.h_entry, dka->iuid.h_id, + (unsigned long)dka->katime); +#endif if(dka->katime>ti) { lock_release(dlg_ka_list_lock); return 0;

12 years, 7 months

how does it work?

by Grégoire Vandendeurpel

Hi, I'm using Siremis 3.2 ans Kamailio 3.2.3 I would like to know how Siremis and Kamailio work together? Like: If I decide to set a protocol in the acl trusted in Siremis like TLS, ok, it works well !! But I need to know the different links between siremis and kamailio to working well.. Why? Cause I need to implement in Siremis a choise form about the sdpops module, and it has to work well of course with the database of ser! So.. What are the diffrent steps to do this? - Create new table sdpops in ser - create the form in siremis and view .. - what in kamailio.cfg?? Thanks in advance Best regards -- *Grégoire Vandendeurpel, * * * *IT Sector*

12 years, 7 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2012