sr-dev June 2012

sr-dev@lists.kamailio.org

31 participants
251 discussions

git:master: modules_k/presence: Fixed presence hard-state implementation
by Peter Dunkley 01 Jun '12

01 Jun '12

Module: sip-router Branch: master Commit: 258bc7e2f9d147679c0434782f376afe2c3f02a4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=258bc7e… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Fri Jun 1 11:50:17 2012 +0100 modules_k/presence: Fixed presence hard-state implementation - Removed modparams added when I did this originally - Hard-state is still "publish"ed to the presentity table (with expiry of -1) - Removed exported function for updating hard-state presentity and added a new type to pres_refresh_watchers instead (also updated refreshWatchers MI command) - Hard-state presentity now fetched using the event->get_pidf_doc() function instead of directly from the database - Also fixed two bugs (from my notifier work) found during testing: - query_db_notify() sends NOTIFY requests immediately (instead of through notifier tasks) - segmentation fault in update_pw_dialogs_dbonlymode() when there are no matching dialogs --- modules_k/presence/README | 386 ++++++++++++----------------- modules_k/presence/doc/presence_admin.xml | 157 +++--------- modules_k/presence/event_list.c | 3 +- modules_k/presence/event_list.h | 2 + modules_k/presence/notify.c | 57 +++-- modules_k/presence/presence.c | 241 ++++++++---------- modules_k/presence/presence.h | 5 - modules_k/presence/presentity.c | 2 +- modules_k/presence/publish.c | 153 ++---------- modules_k/presence/publish.h | 3 +- 10 files changed, 371 insertions(+), 638 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=258…

1 0

git:master: modules_k/presence_xml: pidf-manipulation now fetched using event->get_pidf_doc()
by Peter Dunkley 01 Jun '12

01 Jun '12

Module: sip-router Branch: master Commit: c5f3bc49bcfb42083ee4622a0d5f9b77f177aecd URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c5f3bc4… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Fri Jun 1 11:48:29 2012 +0100 modules_k/presence_xml: pidf-manipulation now fetched using event->get_pidf_doc() - Part of the fix to the way presence hard-state works. - Removed the, now unused, pidf_manipulation modparam --- modules_k/presence_xml/README | 90 ++++++++------------- modules_k/presence_xml/add_events.c | 1 + modules_k/presence_xml/doc/presence_xml_admin.xml | 24 ------ modules_k/presence_xml/notify_body.c | 36 +-------- modules_k/presence_xml/presence_xml.c | 2 - modules_k/presence_xml/xcap_auth.c | 76 ++++++++++++------ modules_k/presence_xml/xcap_auth.h | 3 +- 7 files changed, 90 insertions(+), 142 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=c5f…

1 0

git:master: nathelper(k): remove maddr param in fix_nated_contact()
by Daniel-Constantin Mierla 01 Jun '12

01 Jun '12

Module: sip-router Branch: master Commit: c3caaa4c12f76c77381c6a0afc8688bc38b16999 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c3caaa4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jun 1 11:34:20 2012 +0200 nathelper(k): remove maddr param in fix_nated_contact() - if maddr exists, it makes no sense anymore if the contact uri is changed by the proxy - reported by Morten Isaksen --- modules_k/nathelper/nathelper.c | 23 +++++++++++++++++++++-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/modules_k/nathelper/nathelper.c b/modules_k/nathelper/nathelper.c index 6c84962..bec490c 100644 --- a/modules_k/nathelper/nathelper.c +++ b/modules_k/nathelper/nathelper.c @@ -728,6 +728,8 @@ fix_nated_contact_f(struct sip_msg* msg, char* str1, char* str2) struct lump *anchor; struct sip_uri uri; str hostport; + str params1 = {0}; + str params2 = {0}; if (get_contact_uri(msg, &uri, &c) == -1) return -1; @@ -756,8 +758,25 @@ fix_nated_contact_f(struct sip_msg* msg, char* str1, char* str2) temp[0] = hostport.s[0]; temp[1] = c->uri.s[c->uri.len]; c->uri.s[c->uri.len] = hostport.s[0] = '\0'; - len1 = snprintf(buf, len, "%s%s:%d%s", c->uri.s, cp, msg->rcv.src_port, - hostport.s + hostport.len); + if(uri.maddr.len<=0) { + len1 = snprintf(buf, len, "%s%s:%d%s", c->uri.s, cp, msg->rcv.src_port, + hostport.s + hostport.len); + } else { + /* skip maddr parameter - makes no sense anymore */ + LM_DBG("removing maddr parameter from contact uri: [%.*s]\n", + uri.maddr.len, uri.maddr.s); + params1.s = hostport.s + hostport.len; + params1.len = uri.maddr.s - params1.s; + while(params1.len>0 + && (params1.s[params1.len-1]==' ' + || params1.s[params1.len-1]=='\t' + || params1.s[params1.len-1]==';')) + params1.len--; + params2.s = uri.maddr.s + uri.maddr.len; + params2.len = c->uri.s + c->uri.len - params2.s; + len1 = snprintf(buf, len, "%s%s:%d%.*s%.*s", c->uri.s, cp, msg->rcv.src_port, + params1.len, params1.s, params2.len, params2.s); + } if (len1 < len) len = len1; hostport.s[0] = temp[0];

1 0

[tracker] Comment added: dialog doesn't clear calls that were re-INVITEd shortly after ACK
by sip-router 01 Jun '12

01 Jun '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#206 - dialog doesn't clear calls that were re-INVITEd shortly after ACK User who did this - Andrew Pogrebennyk (marduk) ---------- Daniel, as I understand there are good chances it would go away in the latest master branch, but I can't try it out at the moment. I should be able to do this in about 3 weeks time. I think you can ignore this for now, or even resolve this issue and I'll reopen it in case master/3.3 branch is still affected. Thanks. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=206#comment663 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: dialog doesn't clear calls that were re-INVITEd shortly after ACK
by sip-router 01 Jun '12

01 Jun '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#206 - dialog doesn't clear calls that were re-INVITEd shortly after ACK User who did this - Daniel-Constantin Mierla (miconda) ---------- Any update on this item? Was it fixed with latest dialog version? Trying to clear out issues before v3.3.0... ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=206#comment662 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task changed: tcp_async=yes breaks connect_timeout (no effect) and TCP reject detection
by sip-router 01 Jun '12

01 Jun '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#136 - tcp_async=yes breaks connect_timeout (no effect) and TCP reject detection User who did this: Daniel-Constantin Mierla (miconda) Severity: Low -> Very Low More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=136 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: Error parsing Via parameter with space before semicolon
by sip-router 01 Jun '12

01 Jun '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#127 - Error parsing Via parameter with space before semicolon User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=127 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Error parsing Via parameter with space before semicolon
by sip-router 01 Jun '12

01 Jun '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#127 - Error parsing Via parameter with space before semicolon User who did this - Daniel-Constantin Mierla (miconda) ---------- Should be fixed now in master branch, with commit GIT#362b6f134c5ab408d6bb492e2492bcfc5bab4996. Reopen if still occurs. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=127#comment661 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: core: Via parser allows generic parameters without value separated by white spaces and semicolon
by Daniel-Constantin Mierla 01 Jun '12

01 Jun '12

Module: sip-router Branch: master Commit: 362b6f134c5ab408d6bb492e2492bcfc5bab4996 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=362b6f1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jun 1 09:06:33 2012 +0200 core: Via parser allows generic parameters without value separated by white spaces and semicolon - reported by Iñaki Baz Castillo, closes FS#127 --- parser/parse_via.c | 11 ++++------- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/parser/parse_via.c b/parser/parse_via.c index 1ed1004..48ef466 100644 --- a/parser/parse_via.c +++ b/parser/parse_via.c @@ -1127,13 +1127,10 @@ static /*inline*/ char* parse_via_param(char* p, char* end, goto endofvalue; #endif case L_VALUE: - if (param->type==FIN_RPORT){ - param->value.len=0; - param->value.s=0; /* null value */ - state=F_PARAM; - goto endofvalue; - }; - /* no break */ + param->value.len=0; + param->value.s=0; /* null value */ + state=F_PARAM; + goto endofvalue; default: LOG(L_ERR, "ERROR: parse_via: invalid char <%c>" " in state %d\n", *tmp, state);

1 0

[tracker] Task closed: bad sotket after re-register in location table
by sip-router 01 Jun '12

01 Jun '12

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#191 - bad sotket after re-register in location table User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=191 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2012