Module: sip-router
Branch: master
Commit: e6ad428f6699621b7ee622984eeea3e3e2f6cb80
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e6ad428…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: Mon Dec 24 10:03:10 2012 +0100
usrloc(k): option to store xavp per contact
- stored only in memory for the moment
- the xavp can contain a list of xavps
- new config parameter to specify the name of xavp
---
modules_k/usrloc/README | 107 +++++++++++++++++++--------------
modules_k/usrloc/doc/usrloc_admin.xml | 21 +++++++
modules_k/usrloc/ucontact.c | 46 ++++++++++++++
modules_k/usrloc/ul_mod.c | 6 ++
modules_k/usrloc/ul_mod.h | 1 +
modules_k/usrloc/usrloc.h | 9 +++
6 files changed, 144 insertions(+), 46 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=e6a…
Hello,
please check the two patches I committed to your recently added function:
1) this is for trying all protocols in SRV -- if I didn't get it wrong,
that should be done when no protocol is set. It seemed that was done
when a protocol is set. Check it to be sure I haven't misunderstood.
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=17b3c70…
2) catch ip addresses - your function was replacing
srv_sip_resolvehost(), which catches IP addresses.
no_naptr_srv_sip_resolvehost() is wrapper of srv_sip_resolvehost() only
for no-cache mode, for cache mode it calls dns_srv_get_he(). I haven't
gotten deep in the code, but Juha reported a dns related error when
trying to resolve IP addresses. The only change seems to be the new
function introduced.
http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b2e5040…
Cheers,
Daniel
--
Daniel-Constantin Mierla - http://www.asipto.comhttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
when reading mediaproxy module ice related sections, i found this:
5.7. ice_candidate_avp (string)
Specification of the AVP which holds the ICE candidate that will be
inserted in the SDP. The value specified in this AVP will override the
value in ice_candidate module parameter. Note that if use_media_proxy()
and end_media_session() functions are being used, the AVP will not be
available in the reply route unless you set onreply_avp_mode from the
tm module to '1', and if the AVP is not set, the default value will be
used.
kamailio tm module does not have onreply_avp_mode parameter. is it so
that avps are automatically available in kamailio onreply_routes? if
so, i'll fix the above text.
-- juha
ps. how mediaproxy module/madiaproxy handle ice makes sense to me,
because it avoids the need for a separate turn server with its
authentication problems.
Hi,
When working on the outbound support I noticed that this Contact header
(as per RFC 5626):
Contact:
<sip:foo@192.168.1.18:5061>;reg-id=1;+sip.instance="<urn:uuid:00000000-0000-1000-8000-AABBCCDDEEFF>"
does not get parsed properly (specifically, the param_hooks_t.hooks.reg_id
is not filled in by parse_params()).
However, some investigation showed that:
Contact:
<sip:foo@192.168.1.18:5061;reg-id=1;+sip.instance="<urn:uuid:00000000-0000-1000-8000-AABBCCDDEEFF>">
It looks like Kamailio is treating reg-id (and probably +sip.instance)
parameters as Contact-URI parameters instead of Contact header parameters.
Regards,
Peter
--
Peter Dunkley
Technical Director
Crocodile RCS Ltd
Hello,
when using dns failover (SRV records) with kamailio 3.2 I noticed, that
the failover sip message (to the failover host specified by DNS) is sent
from a different socket.
For example:
incoming sip message is on socket ip1:5060
=> send socket for relayed message (original) is ip1:5060
but send socket for relayed message (failover) is ip2:5060
reparse_on_dns_failover is left on its default value (1).
In the the relayed message (failover):
Reord-Route-Header is as in original message (ip1:5060) - correct
Via-Header is ip2:5060 (matching the send socket) - incorrect
This is exactly the opposite case regarding the README:
"Disadvantage: only the via header is replaced in the message buffer, so
the outgoing socket address is not corrected in any other part of the
message. It is dangerous on multihomed hosts: when the new SIP request
after the DNS failover is sent via different interface than the first
request, the message can contain incorrect ip address in the
Record-Route header for instance."
I think the message was rebuilt, because only VIA header and send socket
changed.
Looking into forward.c:
598 #ifdef USE_DNS_FAILOVER
599 if (prev_send_sock!=send_info->send_sock){
600 /* rebuild the message only if the
send_sock changed */
But I did not change the send socket... any ideas why this condition is
true?
Cheers and a happy new 2013
Jasmin
Hello,
using v4.0.0 for the next major release was proposed and debated at
previous development IRC meeting. First was about the addition of a new
transport layer (websockets) along with other important new features.
During the debate was touched the completion of kamailio-ser integration
(no more duplicated modules) as another milestone for increasing the
first digit (which was finished just before the end of last year). Now
we also have the IMS modules, pushed in the GIT master branch few days ago.
It seems that there are lot of good reasons for numbering the next major
version 4.0.0. Other comments, opinions?
Have a great and happy year ahead,
Daniel
--
Daniel-Constantin Mierla - http://www.asipto.comhttp://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda