sr-dev October 2013

sr-dev@lists.kamailio.org

33 participants
254 discussions

[tracker] Comment added: registrar: process expired contacts first
by sip-router 08 Oct '13

08 Oct '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#351 - registrar: process expired contacts first User who did this - Víctor Seva (linuxmaniac) ---------- There is none AFAIK. I thought it was more rational to process the expires first. The problem here is that the returned contact of ul.get_ucontact_by_instance is the new contact at the the second contact process, not the one with 52132 port. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=351#comment1110 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: ims_charging: removed session unlock function call when no lock was acquired
by Carlos Ruiz Diaz 08 Oct '13

08 Oct '13

Module: sip-router Branch: master Commit: 2dc78738af4a0693e0a4d3f77e2174586d53d90b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2dc7873… Author: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Committer: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Date: Tue Oct 8 15:52:09 2013 -0300 ims_charging: removed session unlock function call when no lock was acquired --- modules/ims_charging/dialog.c | 2 +- modules/ims_charging/ims_ro.c | 13 +++++++------ modules/ims_charging/ro_timer.c | 6 ++++-- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/modules/ims_charging/dialog.c b/modules/ims_charging/dialog.c index caac6c7..c592bda 100644 --- a/modules/ims_charging/dialog.c +++ b/modules/ims_charging/dialog.c @@ -80,7 +80,7 @@ void dlg_reply(struct dlg_cell *dlg, int type, struct dlg_cb_params *_params) { // ro_session_unlock(ro_session_table, ro_session_entry); cdpb.AAAStartChargingCCAccSession(cdp_session); - cdpb.AAASessionsUnlock(cdp_session->hash); +// cdpb.AAASessionsUnlock(cdp_session->hash); // unref_ro_session(session, 1); DONT need this anymore because we don't do lookup so no addition to ref counter } diff --git a/modules/ims_charging/ims_ro.c b/modules/ims_charging/ims_ro.c index 609a143..d0c67ac 100644 --- a/modules/ims_charging/ims_ro.c +++ b/modules/ims_charging/ims_ro.c @@ -698,8 +698,8 @@ error: if (ro_cca_data) Ro_free_CCA(ro_cca_data); - if (ro_cca_data) - cdpb.AAAFreeMessage(&cca); +// if (ro_cca_data) + cdpb.AAAFreeMessage(&cca); if (i_req) { i_req->credit_valid_for = 0; @@ -861,15 +861,14 @@ static void resume_on_termination_ccr(int is_timeout, void *param, AAAMessage *c LM_DBG("Valid CCA response for STOP record\n"); } - Ro_free_CCA(ro_cca_data); - cdpb.AAAFreeMessage(&cca); +// Ro_free_CCA(ro_cca_data); +// cdpb.AAAFreeMessage(&cca); update_stat(successful_final_ccrs, 1); - return; - error: Ro_free_CCA(ro_cca_data); + cdpb.AAAFreeMessage(&cca); } @@ -1112,6 +1111,8 @@ error0: LM_DBG("Trying to reserve credit on initial INVITE failed on cdp callback\n"); create_cca_return_code(error_code); + cdpb.AAAFreeMessage(&cca); + if (t) tmb.unref_cell(t); diff --git a/modules/ims_charging/ro_timer.c b/modules/ims_charging/ro_timer.c index 9344cd1..e2ee233 100644 --- a/modules/ims_charging/ro_timer.c +++ b/modules/ims_charging/ro_timer.c @@ -363,10 +363,12 @@ void ro_session_ontimeout(struct ro_tl *tl) { LM_ERR("Can't find a session. This is bad"); return; } - + +// LM_ALERT("LOCKING... "); ro_session_entry = &(ro_session_table->entries[ro_session->h_entry]); ro_session_lock(ro_session_table, ro_session_entry); - +// LM_ALERT("LOCKED!"); + LM_DBG("event-type=%d", ro_session->event_type); switch (ro_session->event_type) {

1 0

[tracker] Task changed: registrar: process expired contacts first
by sip-router 08 Oct '13

08 Oct '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#351 - registrar: process expired contacts first User who did this: Daniel-Constantin Mierla (miconda) Task details edited: ------- UAC sends a REGISTER with 2 Contacts: <code> Via: SIP/2.0/UDP 10.15.20.162:54667;rport;branch=z9hG4bKPjQFCRK5QGClx345YZHUg1-rMU1FRJULr. Max-Forwards: 70 From: "Danieltest" <sip:danieltest@10.15.20.30>;tag=bjZ1xFGW9PBJHZ1AUBU-lXxU6YKidOdH To: "Danieltest" <sip:danieltest@10.15.20.30> Call-ID: WHc4QlBGgOHBuSVhjzAZEIYBmBpJWlnV CSeq: 57560 REGISTER User-Agent: Bria iOS 2.5.0 Supported: outbound, path Contact: "Danieltest" <sip:danieltest@10.15.20.162:54667;ob>;reg-id=1;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>" Contact: "Danieltest" <sip:danieltest@10.15.20.162:52132;ob>;expires=0 Expires: 120 Allow: PRACK, INVITE, ACK, BYE, CANCEL, UPDATE, INFO, SUBSCRIBE, NOTIFY, REFER, MESSAGE, OPTIONS Content-Length: 0 </code> This results in: - creating a new contact for 54667 port ( Contact[0] processed ) - deleting this new created contact ( Contact[1] processed. * ) If we process the expires contacts first this is fixed. *: ul.get_ucontact_by_instance returns the new created contact ------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=351 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: registrar: process expired contacts first
by sip-router 08 Oct '13

08 Oct '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#351 - registrar: process expired contacts first User who did this - Daniel-Constantin Mierla (miconda) ---------- Is there a rule in rfc saying that the contact headers with expires=0 have to be processed first? ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=351#comment1109 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: ims_charging: Merge branch 'ims_charging' into Master.
by Carsten Bock 08 Oct '13

08 Oct '13

Module: sip-router Branch: master Commit: dcce66b2a3db3aeaa5de1a87429320731ab3795c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=dcce66b… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Tue Oct 8 18:43:14 2013 +0200 ims_charging: Merge branch 'ims_charging' into Master. ---

1 0

[tracker] Task opened: registrar: process expired contacts first (Attachment added)
by sip-router 08 Oct '13

08 Oct '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Víctor Seva (linuxmaniac) Attached to Project - sip-router Summary - registrar: process expired contacts first Task Type - Bug Report Category - Module Status - New Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - UAC sends a REGISTER with 2 Contacts: Via: SIP/2.0/UDP 10.15.20.162:54667;rport;branch=z9hG4bKPjQFCRK5QGClx345YZHUg1-rMU1FRJULr. Max-Forwards: 70 From: "Danieltest" <sip:danieltest@10.15.20.30>;tag=bjZ1xFGW9PBJHZ1AUBU-lXxU6YKidOdH To: "Danieltest" <sip:danieltest@10.15.20.30> Call-ID: WHc4QlBGgOHBuSVhjzAZEIYBmBpJWlnV CSeq: 57560 REGISTER User-Agent: Bria iOS 2.5.0 Supported: outbound, path Contact: "Danieltest" <sip:danieltest@10.15.20.162:54667;ob>;reg-id=1;+sip.instance="<urn:uuid:C3DD6013-20E8-40E3-8EA2-5849B02ED0C4>" Contact: "Danieltest" <sip:danieltest@10.15.20.162:52132;ob>;expires=0 Expires: 120 Allow: PRACK, INVITE, ACK, BYE, CANCEL, UPDATE, INFO, SUBSCRIBE, NOTIFY, REFER, MESSAGE, OPTIONS Content-Length: 0 This results in: - creating a new contact for 54667 port ( Contact[0] processed ) - deleting this new created contact ( Contact[1] processed. * ) If we process the expires contacts first this is fixed. *: ul.get_ucontact_by_instance returns the new created contact One or more files have been attached. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=351 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: presence_dialoginfo -> force_single doesn't sent most relevant xml
by sip-router 08 Oct '13

08 Oct '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#341 - presence_dialoginfo -> force_single doesn't sent most relevant xml User who did this - Daniel-Constantin Mierla (miconda) ---------- Patches existing in tracker at the date of freeze are still eligible for merging, specially when they solve issues with UAs. Add the new patch here as soon as possible. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=341#comment1108 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: presence_dialoginfo -> force_single doesn't sent most relevant xml
by sip-router 08 Oct '13

08 Oct '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#341 - presence_dialoginfo -> force_single doesn't sent most relevant xml User who did this - Devs Voicenter (voicenter) ---------- cleaned up and fix the code. gonna test it for a while and apply later, anyway you froze for next release, didn't you? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=341#comment1107 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: presence_dialoginfo -> force_single doesn't sent most relevant xml
by sip-router 08 Oct '13

08 Oct '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#341 - presence_dialoginfo -> force_single doesn't sent most relevant xml User who did this - Devs Voicenter (voicenter) ---------- cleaned up and fix the code. gonna test it for a while and apply later, anyway you froze for next release, didn't you? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=341#comment1106 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: pua_reginfo: Duplicate contacts in the location table
by sip-router 08 Oct '13

08 Oct '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#350 - pua_reginfo: Duplicate contacts in the location table User who did this - Wonbin Cho (wbcho) ---------- The original code used an AOR in full URI form (all the time) to determine the retrieved contact exists in the location table. In the following line: <code>result = ul.get_urecord(domain, &aor, &ul_record);</code> The "aor" here refers to "sip:alice@example.com" whereas the same contact already exists with an AOR "alice" in the location table. (if `use_domain` param is disabled) This results in inserting the same contacts repeatedly. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=350#comment1105 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
...
14
15
16
17
18
19
20
...
26
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2013