Module: sip-router
Branch: tteras/mohqueue
Commit: 753e93d3ad1658c104963c208c4e36b23c1dd307
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=753e93d…
Author: Robert Boisvert <rdboisvert(a)gmail.com>
Committer: Timo Teräs <timo.teras(a)iki.fi>
Date: Thu Oct 3 09:22:54 2013 +0300
modules/mohqueue: pull changes from upstream
Merges up to upstream commit a3f679430d853d5b1b71ba92d8547ca2c86509ec.
Changes in code:
* fixes RTP stop not being sent
* use pcbp->req instead of -> in rtp_destroy
* fixed uninitialized varbs
* use close_call () for no response on INVITE
* changed to return handled if reINVITE sent
* switched to using fixup_svpe functions
Documentation:
* added comment about rtpproxy limit
* adjusted to remove hold sequence in transfer out
---
modules/mohqueue/doc/mohqueue_admin.xml | 16 +-
modules/mohqueue/mohq.c | 41 +----
modules/mohqueue/mohq.h | 7 +-
modules/mohqueue/mohq_common.h | 2 +
modules/mohqueue/mohq_funcs.c | 337 +++++--------------------------
modules/mohqueue/mohq_funcs.h | 6 +-
6 files changed, 74 insertions(+), 335 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=753…
From: Joseph Watson <joseph.watson(a)veranetworks.com>
To: jh(a)tutpro.com
Subject: unmatched_cancel documentation
Date: Wed, 2 Oct 2013 18:00:18 -0400
Hello,
I just wanted to take a moment to notify you that we found a mistake in the
tm module documentation for the 4.x and stable docmentation.
According to the documentation for unmatched_cancel the option in the param
is a string which would require surounding quotes. However we found that
the paramater is expecting an intiger instead of a string.
You may want to verify this and modify your documentation.
Thanks,
Joseph Watson
A few comments:
I think the module name should be "queue". The moh-part is a just a nice way of handling the queue...
From reading the docs:
- The example on 3.4. moh_maxcalls illustrates usage of mohdir.
- Change "from the main (request) route" to "a request route". Routes can call routes.
I would love for this module to expose the queue in an xavp (as an alternative to the database) so I can manipulate weights and stuff. Queues need management. I would also like to be able to pick a call out of the queue at any point, regardless of position. But that's a future change. This is a very good contribution.
I don't think naming audio files after payload number is a good scheme. Payload numbers are dynamic for all new codecs and one should use the name tags. I think we should simply copy the file name extensions used by Asterisk for the codecs, like "alaw" for alaw. Or the names used in rtpmap. One of them - but not the numbers, that is not extensible enough as they are no longer assigned. Opus will not get a fixed number, just a name tag.
/O
couple of weeks ago there was discussion on this list regarding db_mysql
transaction implementation, but there has been no comments from authors
of the current code.
based on the earlier discussion, transactions in mysql should be
started with command
SET autocommit=0
instead of BEGIN or START TRANSACTION and ending or aborting of
transaction with COMMIT or ROLLBACK should be followed by command
SET autocommit=1
if authors agree, please commit the necessary changes.
-- juha