sr-dev November 2013

sr-dev@lists.kamailio.org

29 participants
221 discussions

[tracker] Comment added: Dialog callback on pua_dialoginfo after restart
by sip-router 05 Nov '13

05 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#360 - Dialog callback on pua_dialoginfo after restart User who did this - Daniel-Constantin Mierla (miconda) ---------- Thanks. First patch was applied. Second patch doesn't seem that it handles error cases, it returns NULL and dlginfo variable is lost - it was allocated in shared memory. The code seems to be like that from older versions, but it would be good to get fixed. Do you have time for it? If not, probably I will get back to it later when I get some spare time. Third patch - does it have relevance in the context of reported issue? It seems a feature enhancement. If yes, it will be pushed as we unfreeze from testing phase for v4.1 ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=360#comment1154 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: pua_dialoginfo: fixed code formatting
by Daniel-Constantin Mierla 05 Nov '13

05 Nov '13

Module: sip-router Branch: master Commit: 8d6a981543a044fddc3448c93dba9ed35afac0c0 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8d6a981… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Nov 5 10:15:13 2013 +0100 pua_dialoginfo: fixed code formatting - patch by Kristian Høgh, FS#360 --- modules/pua_dialoginfo/dialog_publish.c | 48 ++++++------ modules/pua_dialoginfo/pua_dialoginfo.c | 118 +++++++++++++++--------------- 2 files changed, 83 insertions(+), 83 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=8d6…

1 0

git:master: dispatcher: typo and ids to sections in documentation
by Daniel-Constantin Mierla 05 Nov '13

05 Nov '13

Module: sip-router Branch: master Commit: d48d36df40dee374e63ef9b6a6c1bafc4af0e8b0 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d48d36d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Nov 5 09:41:04 2013 +0100 dispatcher: typo and ids to sections in documentation --- modules/dispatcher/README | 8 +- modules/dispatcher/doc/dispatcher_admin.xml | 80 +++++++++++++------------- 2 files changed, 44 insertions(+), 44 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=d48…

1 0

Safe to change expires column in location table to type timestamp?
by Alistair Cunningham 04 Nov '13

04 Nov '13

Over the weekend, one of our customers in the USA suffered a mass de-registration of handsets during the daylight saving change. After one registration interval, they all re-registered, but inbound calls failed for one full registration interval of each handset. The same customer had this happen last year when they were running OpenSIPS. At that time, it was determined by the OpenSIPS developers that the problem was that the "expires" column in the location table (stored in MySQL, with db_mode 3) was of type "datetime", which does not handle daylight saving changes gracefully. They suggested changing the db_mode, but this isn't an option because other software reads the location table in real time to decide which SIP proxy machine the handset is registered to. We discussed changing this column (and last_modified which is also a datetime) to type "timestamp", but our customer switched to Kamailio before we could make a final decision on this. My question is therefore: can we safely do a MySQL "alter table" command to change these two columns to timestamps so that this problem won't happen again next year? -- Alistair Cunningham +1 888 468 3111 +44 20 799 39 799 http://integrics.com/

2 4

git:master: sl: fix startup detection of event route
by Daniel-Constantin Mierla 04 Nov '13

04 Nov '13

Module: sip-router Branch: master Commit: f33076415561d3efbfa9d804d00a4b0784898f50 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f330764… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Nov 4 21:46:34 2013 +0100 sl: fix startup detection of event route - patch by Sergey Okhapkin --- modules/sl/sl_funcs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/sl/sl_funcs.c b/modules/sl/sl_funcs.c index fd19e1c..c642249 100644 --- a/modules/sl/sl_funcs.c +++ b/modules/sl/sl_funcs.c @@ -90,7 +90,7 @@ void sl_lookup_event_routes(void) _sl_evrt_local_response = route_lookup(&event_rt, "sl:local-response"); if (_sl_evrt_local_response>=0 - && event_rt.rlist[_sl_evrt_local_response]!=NULL) + && event_rt.rlist[_sl_evrt_local_response]==NULL) _sl_evrt_local_response = -1; }

1 0

[tracker] Comment added: Dialog callback on pua_dialoginfo after restart (Attachment added)
by sip-router 04 Nov '13

04 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#360 - Dialog callback on pua_dialoginfo after restart User who did this - Kristian Høgh (kfhdk) ---------- I created a suggestion. Comments? First I cleanup whitespace/indent mismatch (patch 01-cleanup-whitespaces.patch) This patch changes no functionality. Then I add callback to DLGCB_LOADED. (02-add-loaded.patch) Created and loaded share a good part of code, so I split common parts into get_dialog_data. At this point, existing dialogs are loaded after reboot, but we don't know who to send publish to. The last patch (03-use-dialog-var.patch) saves pubruris_caller/pubruris_callee as dialog var when created. On restarting kamailio pubruris_caller/pubruris_callee are restored from database. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=360#comment1153 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: presence_dialoginfo -> force_single doesn't sent most relevant xml
by sip-router 04 Nov '13

04 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#341 - presence_dialoginfo -> force_single doesn't sent most relevant xml User who did this - Daniel-Constantin Mierla (miconda) ---------- It is only devel and your patch was merged with existing code for selecting the node. So the result is different that you have locally. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=341#comment1152 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: presence_dialoginfo -> force_single doesn't sent most relevant xml
by sip-router 04 Nov '13

04 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#341 - presence_dialoginfo -> force_single doesn't sent most relevant xml User who did this - Devs Voicenter (voicenter) ---------- I think i ignored and forgot other states as i needed it for devices with led indication of call state and most have 3 states: no calls,(same as all terminated) rigning incoming (early) talking (confirmed) I'll try to add other states as well. Is it pushed to 4.0.x as well or only to devel ? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=341#comment1151 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: presence_dialoginfo -> force_single doesn't sent most relevant xml
by sip-router 04 Nov '13

04 Nov '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#341 - presence_dialoginfo -> force_single doesn't sent most relevant xml User who did this - Daniel-Constantin Mierla (miconda) ---------- I pushed a re-worked patch in git master barnch that still keeps the previous node selection mechanism if winner node is still NULL after your criteria. That should keep safe all the states. If you need to work on it, use the branch master (the patch is not backported) and create a new patch from it. Also, testing would be recommended and appreciated. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=341#comment1150 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: presence_dialoginfo: check relevance of the state for single dialog notification
by Daniel-Constantin Mierla 04 Nov '13

04 Nov '13

Module: sip-router Branch: master Commit: 90227fbf44ddc67bfb49f8f7e8fd7e1b33189349 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=90227fb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Nov 4 14:26:19 2013 +0100 presence_dialoginfo: check relevance of the state for single dialog notification - rework from a patch in tracker, FS#341 --- modules/presence_dialoginfo/notify_body.c | 194 +++++++++++++++++++++++------ 1 files changed, 156 insertions(+), 38 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=902…

1 0

← Newer
1
...
15
16
17
18
19
20
21
22
23
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2013