sr-dev December 2013

sr-dev@lists.kamailio.org

30 participants
318 discussions

[tracker] Comment added: dialog variables caller/callee
by sip-router 12 Dec '13

12 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#302 - dialog variables caller/callee User who did this - Daniel-Constantin Mierla (miconda) ---------- $dlg(from_uri) is the URI from the From header in the initial INVITE and the $dlg(to_uri) is the URI from the To header in the initial INVITE. These are caller and callee. If are you looking for something else, then maybe you can store those values in dialog vars. For now I am closing this item, if is something that I misunderstood and is not possible (or not easy/convenient), you can reopen. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=302#comment1231 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Dialog callback on pua_dialoginfo after restart
by sip-router 12 Dec '13

12 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#360 - Dialog callback on pua_dialoginfo after restart User who did this - Daniel-Constantin Mierla (miconda) ---------- Looking at the 02-add-loaded.patch, it seems that dlginfo variable has to be freed in __dialog_created() and __dialog_loaded() to avoid leaks, or did I missed something? For the last patch, I think the storage in dialog vars should be optional, via module parameters. I don't see where they are used further in the module, but they are probably useful for configuration file logic. I suggest to make the names of dlg vars module parameters, default set to empty. When they are set to a value via modparam, then the module will store them (so default is not storing in variables). ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=360#comment1230 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:vseva/acc_pvar: acc: allow pvar as first parameter for functions. WIP.
by Victor Seva 12 Dec '13

12 Dec '13

Module: sip-router Branch: vseva/acc_pvar Commit: 7c83177a07037a80160eb5a89828a3d3874a9e62 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7c83177… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Thu Dec 12 17:35:16 2013 +0100 acc: allow pvar as first parameter for functions. WIP. --- modules/acc/acc_api.h | 1 + modules/acc/acc_logic.c | 50 ++++++++++++++++++++++++++++++++++++++++++---- modules/acc/acc_mod.c | 17 +++++++-------- 3 files changed, 54 insertions(+), 14 deletions(-) diff --git a/modules/acc/acc_api.h b/modules/acc/acc_api.h index aa51380..0660797 100644 --- a/modules/acc/acc_api.h +++ b/modules/acc/acc_api.h @@ -48,6 +48,7 @@ typedef struct acc_param { int code; str code_s; str reason; + pv_spec_t *spec; } acc_param_t; /* various acc variables */ diff --git a/modules/acc/acc_logic.c b/modules/acc/acc_logic.c index 50278fb..e7c754f 100644 --- a/modules/acc/acc_logic.c +++ b/modules/acc/acc_logic.c @@ -166,14 +166,45 @@ static inline int acc_preparse_req(struct sip_msg *req) return 0; } - +int acc_get_param_value(struct sip_msg *rq, struct acc_param *param) +{ + pv_value_t xvalue; + char *p; + if(param->spec!=NULL) { + if(pv_get_spec_value(rq, param->spec, &xvalue)==-1) { + LM_ERR("Can't get value for %.*s\n", param->reason.len, param->reason.s); + return -1; + } + if(!(xvalue.flags&(PV_VAL_STR))) { + LM_ERR("pvar %.*s is not a string", param->reason.len, param->reason.s); + return -1; + } + param->reason.s = xvalue.rs.s; + param->reason.len = xvalue.rs.len; + } + p = param->reason.s; + /* any code? */ + if (param->reason.len>=3 && isdigit((int)p[0]) + && isdigit((int)p[1]) && isdigit((int)p[2]) ) { + param->code = (p[0]-'0')*100 + (p[1]-'0')*10 + (p[2]-'0'); + param->code_s.s = p; + param->code_s.len = 3; + param->reason.s += 3; + for( ; isspace((int)param->reason.s[0]) ; param->reason.s++ ); + param->reason.len = strlen(param->reason.s); + } + return 0; +} int w_acc_log_request(struct sip_msg *rq, char *comment, char *foo) { + struct acc_param *param = (struct acc_param*)comment; if (acc_preparse_req(rq)<0) return -1; + if(acc_get_param_value(rq, param)<0) + return -1; env_set_to( rq->to ); - env_set_comment((struct acc_param*)comment); + env_set_comment(param); env_set_text( ACC_REQUEST, ACC_REQUEST_LEN); return acc_log_request(rq); } @@ -212,6 +243,7 @@ int acc_db_set_table_name(struct sip_msg *msg, void *param, str *table) int w_acc_db_request(struct sip_msg *rq, char *comment, char *table) { + struct acc_param *param = (struct acc_param*)comment; if (!table) { LM_ERR("db support not configured\n"); return -1; @@ -222,8 +254,10 @@ int w_acc_db_request(struct sip_msg *rq, char *comment, char *table) LM_ERR("cannot set table name\n"); return -1; } + if(acc_get_param_value(rq, param)<0) + return -1; env_set_to( rq->to ); - env_set_comment((struct acc_param*)comment); + env_set_comment(param); return acc_db_request(rq); } #endif @@ -232,10 +266,13 @@ int w_acc_db_request(struct sip_msg *rq, char *comment, char *table) #ifdef RAD_ACC int w_acc_rad_request(struct sip_msg *rq, char *comment, char *foo) { + struct acc_param *param = (struct acc_param*)comment; if (acc_preparse_req(rq)<0) return -1; + if(acc_get_param_value(rq, param)<0) + return -1; env_set_to( rq->to ); - env_set_comment((struct acc_param*)comment); + env_set_comment(param); return acc_rad_request(rq); } #endif @@ -244,10 +281,13 @@ int w_acc_rad_request(struct sip_msg *rq, char *comment, char *foo) #ifdef DIAM_ACC int w_acc_diam_request(struct sip_msg *rq, char *comment, char *foo) { + struct acc_param *param = (struct acc_param*)comment; if (acc_preparse_req(rq)<0) return -1; + if(acc_get_param_value(rq, param)<0) + return -1; env_set_to( rq->to ); - env_set_comment((struct acc_param*)comment); + env_set_comment(param); return acc_diam_request(rq); } #endif diff --git a/modules/acc/acc_mod.c b/modules/acc/acc_mod.c index 2fb9258..9d9b583 100644 --- a/modules/acc/acc_mod.c +++ b/modules/acc/acc_mod.c @@ -355,15 +355,14 @@ static int acc_fixup(void** param, int param_no) memset( accp, 0, sizeof(struct acc_param)); accp->reason.s = p; accp->reason.len = strlen(p); - /* any code? */ - if (accp->reason.len>=3 && isdigit((int)p[0]) - && isdigit((int)p[1]) && isdigit((int)p[2]) ) { - accp->code = (p[0]-'0')*100 + (p[1]-'0')*10 + (p[2]-'0'); - accp->code_s.s = p; - accp->code_s.len = 3; - accp->reason.s += 3; - for( ; isspace((int)accp->reason.s[0]) ; accp->reason.s++ ); - accp->reason.len = strlen(accp->reason.s); + if (p[0]=='$') { /* is a variable $xxxxx */ + accp->spec = pv_cache_get(&accp->reason); + if (accp->spec==0 || accp->spec->type==PVT_NULL || accp->spec->type==PVT_EMPTY) + { + LM_ERR("bad param 1; " + "expected : $pseudo-variable or str value\n"); + return E_UNSPEC; + } } *param = (void*)accp; #ifdef SQL_ACC

1 0

[tracker] Comment added: Unmet dependency for kamailio-perl-modules
by sip-router 12 Dec '13

12 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#361 - Unmet dependency for kamailio-perl-modules User who did this - Daniel-Constantin Mierla (miconda) ---------- Assigned to Victor, hopefully he is more familiar with packages constraint. One thing I noted, you say Debian 7.2 and the Squeeze. But that version number should be Wheezy, iirc. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=361#comment1229 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task changed: Unmet dependency for kamailio-perl-modules
by sip-router 12 Dec '13

12 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#361 - Unmet dependency for kamailio-perl-modules User who did this: Daniel-Constantin Mierla (miconda) Assigned To: [-] -> Víctor Seva More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=361 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: modules/mtree: mt_match RPC export
by sip-router 12 Dec '13

12 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#373 - modules/mtree: mt_match RPC export User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=373 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:4.1: snmpstats: fixe MIB file definitions
by Daniel-Constantin Mierla 12 Dec '13

12 Dec '13

Module: sip-router Branch: 4.1 Commit: 98ecf7d2c5753357fd2c1d1e8e72f425e4d48f9b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=98ecf7d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Dec 12 15:50:27 2013 +0100 snmpstats: fixe MIB file definitions - patch by takeshi, FS#363 (cherry picked from commit ab75785aa707f10fdbccfb0531a0f35e820f5ebc) --- modules/snmpstats/mibs/KAMAILIO-TC | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/modules/snmpstats/mibs/KAMAILIO-TC b/modules/snmpstats/mibs/KAMAILIO-TC index 81d1459..171c491 100644 --- a/modules/snmpstats/mibs/KAMAILIO-TC +++ b/modules/snmpstats/mibs/KAMAILIO-TC @@ -62,7 +62,7 @@ KamailioSIPTransportProtocol ::= TEXTUAL-CONVENTION tcp(2), sctp(3), tls(4), - sctp_tls(5), + sctptls(5), ws(6), wss(7) } @@ -79,14 +79,13 @@ KamailioSIPEntityRole ::= TEXTUAL-CONVENTION operation of a SIP outbound edge proxy node. Kamailio adds the role 'sipcaptureServer' for operation of a Homer SIPcapture node." - " SYNTAX BITS { other(0), userAgent(1), proxyServer(2), redirectServer(3), - registrarServer(4) - edgeproxyServer(5) + registrarServer(4), + edgeproxyServer(5), sipcaptureServer(6) }

1 0

git:master: mtree: added mi/ rpc command to match against records in memory trees
by Daniel-Constantin Mierla 12 Dec '13

12 Dec '13

Module: sip-router Branch: master Commit: 0620105b03dce2391b98374b1ec6d08f48040594 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0620105… Author: Seudin Kasumovic <seudin.kasumovic(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Dec 12 15:58:48 2013 +0100 mtree: added mi/rpc command to match against records in memory trees - FS#373 --- modules/mtree/README | 52 ++++- modules/mtree/doc/mtree_admin.xml | 48 +++++ modules/mtree/mtree.c | 424 ++++++++++++++++++++++++++++++++++++- modules/mtree/mtree.h | 8 +- modules/mtree/mtree_mod.c | 170 +++++++++++++++ 5 files changed, 689 insertions(+), 13 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=062…

1 0

git:master: snmpstats: fixe MIB file definitions
by Daniel-Constantin Mierla 12 Dec '13

12 Dec '13

Module: sip-router Branch: master Commit: ab75785aa707f10fdbccfb0531a0f35e820f5ebc URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ab75785… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Dec 12 15:50:27 2013 +0100 snmpstats: fixe MIB file definitions - patch by takeshi, FS#363 --- modules/snmpstats/mibs/KAMAILIO-TC | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/modules/snmpstats/mibs/KAMAILIO-TC b/modules/snmpstats/mibs/KAMAILIO-TC index 81d1459..171c491 100644 --- a/modules/snmpstats/mibs/KAMAILIO-TC +++ b/modules/snmpstats/mibs/KAMAILIO-TC @@ -62,7 +62,7 @@ KamailioSIPTransportProtocol ::= TEXTUAL-CONVENTION tcp(2), sctp(3), tls(4), - sctp_tls(5), + sctptls(5), ws(6), wss(7) } @@ -79,14 +79,13 @@ KamailioSIPEntityRole ::= TEXTUAL-CONVENTION operation of a SIP outbound edge proxy node. Kamailio adds the role 'sipcaptureServer' for operation of a Homer SIPcapture node." - " SYNTAX BITS { other(0), userAgent(1), proxyServer(2), redirectServer(3), - registrarServer(4) - edgeproxyServer(5) + registrarServer(4), + edgeproxyServer(5), sipcaptureServer(6) }

1 0

[tracker] Task closed: Errors in snmpstats KAMAILIO-TC
by sip-router 12 Dec '13

12 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#363 - Errors in snmpstats KAMAILIO-TC User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=363 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
32
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2013