THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#380 - fixes for memory leak in TLS module
User who did this - Klaus Darilion (klaus3000)
----------
I reviewed the patch and I think it should be fine, at least it should improve the situation much.
There is on thing were I am not sure if this works safe: In tls_server.c:
static int tls_complete_init(struct tcp_connection* c)
{
tls_domain_t* dom;
struct tls_extra_data* data = 0;
tls_domains_cfg_t* cfg;
enum tls_conn_states state;
if (LOW_MEM_NEW_CONNECTION_TEST()){
ERR("tls: ssl bug #1491 workaround: not enough memory for safe"
" operation: %lu\n", shm_available());
goto error2;
}
/* Get current TLS configuration and increase reference
* count immediately. There is no need to lock the structure
* here, because it does not get deleted immediately. When
* SER reloads TLS configuration it will put the old configuration
* on a garbage queue and delete it later, so we know here that
* the pointer we get from *tls_domains_cfg will be valid for a while,
* at least by the time this function finishes
*/
===> Above comment is not valid anymore and should be changed
lock_get(tls_domains_cfg_lock);
cfg = *tls_domains_cfg;
===> cfg points now to the current TLS config. But when is the tls_complete_init() function called? If the function is called after the TLS handshake, and during the TLS handshake the TLS config gets reloaded, then it may happen that the TLS handshake used the old TLS config but increases the refcount of the new TLS config.
----------
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=380#comment1217
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#373 - modules/mtree: mt_match RPC export
User who did this - Daniel-Constantin Mierla (miconda)
----------
Thanks, I will review and push it to the repo these days.
----------
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=373#comment1216
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A new Flyspray task has been opened. Details are below.
User who did this - Ding Ma (mading087)
Attached to Project - sip-router
Summary - fixes for memory leak in TLS module
Task Type - Bug Report
Category - tls
Status - Unconfirmed
Assigned To -
Operating System - Linux
Severity - High
Priority - Normal
Reported Version - 4.0
Due in Version - Undecided
Due Date - Undecided
Details - The current TLS module has a memory leak that will result in core dump after several tls.reload operations. The enclosed patch contains the fixes for the memory leak problem and some multithreading enhancements for the TLS module. The patch has been tested with 4.0.3, and can be applied to 4.1 directly.
One or more files have been attached.
More information can be found at the following URL:
https://sip-router.org/tracker/index.php?do=details&task_id=380
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task is now closed:
FS#378 - modules/usrloc deadlock on load/restart
User who did this - Daniel-Constantin Mierla (miconda)
Reason for closing: Fixed
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=378
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A new Flyspray task has been opened. Details are below.
User who did this - Robert Boisvert (rdboisvert)
Attached to Project - sip-router
Summary - Abort occurs in tm when make mode=debug
Task Type - Bug Report
Category - tm
Status - Unconfirmed
Assigned To -
Operating System - All
Severity - Medium
Priority - Normal
Reported Version - 4.1
Due in Version - Undecided
Due Date - Undecided
Details - If the code is compiled with extra debugging enabled (make mode=debug), store_reply () in modules/tm/t_reply.c, line 1675 aborts when a transaction branch has a reply set. This seems to be an invalid abort because t_should_relay_response (), line 1360 sets the reply but does not clear it before returning in line 1391.
The result is to cause an erroneous abort on what seems to be normal branch processing.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=379
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
A Project Manager has denied the request pending for the following task:
FS#247 - Kamailio version 3.1.2 crash when memory realloc
User who did this - Daniel-Constantin Mierla (miconda)
Reason for denial:
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=247
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.