sr-dev December 2013

sr-dev@lists.kamailio.org

30 participants
318 discussions

git:master: Makefile.defs: compiler optimization level made variable
by Daniel-Constantin Mierla 06 Dec '13

06 Dec '13

Module: sip-router Branch: master Commit: 0713c0de50f8c2f4da2ee0ef33b0505c37792392 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0713c0d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 6 16:33:04 2013 +0100 Makefile.defs: compiler optimization level made variable - allow using -O3 for clang, which gives error on the former default -O9 --- Makefile.defs | 32 +++++++++++++++++--------------- 1 files changed, 17 insertions(+), 15 deletions(-) diff --git a/Makefile.defs b/Makefile.defs index d0ce0c8..0db57fe 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -273,6 +273,7 @@ CC_LONGVER:=$(shell if $(CC) -v 2>/dev/null; then \ else \ $(CC) -V 2>&1 ; \ fi ) +CC_OPT ?= -O9 MKTAGS=ctags #find-out the compiler's name @@ -334,6 +335,7 @@ ifneq (, $(findstring clang, $(CC_LONGVER))) CC_FULLVER:=$(shell echo "$(CC_LONGVER)" | head -n 1 | sed -e 's/.*version $[0-9]\.[0-9]$.*/\1/g' ) CC_SHORTVER:=$(shell echo "$(CC_FULLVER)" | cut -d. -f1,2 ) CC_VER=$(CC) $(CC_FULLVER) + CC_OPT=-O3 MKDEP=$(CC) -MM endif @@ -887,7 +889,7 @@ ifeq ($(ARCH), i386) ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff - CFLAGS=-g -O9 -funroll-loops -Wcast-align $(PROFILE) + CFLAGS=-g $(CC_OPT) -funroll-loops -Wcast-align $(PROFILE) #if gcc 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) $(call set_if_empty,CPU,athlon64) @@ -945,8 +947,8 @@ ifeq ($(CC_NAME), clang) $(call set_if_empty,CPU,athlon64) C_DEFS+=-DCC_GCC_LIKE_ASM CFLAGS+=-m32 - -O9 \ - \ + $(CC_OPT) \ + \ -mtune=$(CPU) LDFLAGS+=-m32 else # CC_NAME, clang @@ -972,7 +974,7 @@ ifeq ($(ARCH), x86_64) ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff - CFLAGS=-g -O9 -funroll-loops -Wcast-align $(PROFILE) + CFLAGS=-g $(CC_OPT) -funroll-loops -Wcast-align $(PROFILE) #if gcc 4.5+ # don't add '-mtune=$(CPU)' - gcc failure ifeq ($(CC_SHORTVER), 4.5+) @@ -1041,7 +1043,7 @@ ifeq ($(CC_NAME), clang) $(call set_if_empty,CPU,opteron) C_DEFS+=-DCC_GCC_LIKE_ASM CFLAGS+=-m64 \ - -O9 + $(CC_OPT) LDFLAGS+=-m64 else # CC_NAME, clang ifeq ($(CC_NAME), icc) @@ -1066,7 +1068,7 @@ ifeq ($(ARCH), sparc64) ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM -DSPARC64_MODE #common stuff - CFLAGS=-g -O9 -funroll-loops $(PROFILE) \ + CFLAGS=-g $(CC_OPT) -funroll-loops $(PROFILE) \ #-Wcast-align \ #-Wmissing-prototypes #if gcc 4.5+ or 4.2+ @@ -1157,7 +1159,7 @@ ifeq ($(ARCH), sparc) ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff - CFLAGS=-g -O9 -funroll-loops $(PROFILE) \ + CFLAGS=-g $(CC_OPT) -funroll-loops $(PROFILE) \ #-Wcast-align \ #-Wmissing-prototypes #if gcc 4.5+ or 4.2+ @@ -1222,7 +1224,7 @@ ifeq ($(ARCH), arm) ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff - CFLAGS=-marm -march=armv5t -O9 -funroll-loops -fsigned-char $(PROFILE) + CFLAGS=-marm -march=armv5t $(CC_OPT) -funroll-loops -fsigned-char $(PROFILE) #if gcc 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+= -ftree-vectorize -fno-strict-overflow @@ -1270,7 +1272,7 @@ ifeq ($(ARCH), arm6) ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff - CFLAGS=-march=armv6 -O9 -funroll-loops -fsigned-char \ + CFLAGS=-march=armv6 $(CC_OPT) -funroll-loops -fsigned-char \ $(PROFILE) #if gcc 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) @@ -1317,7 +1319,7 @@ ifeq ($(ARCH), mips) ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff - CFLAGS=-O9 -funroll-loops $(PROFILE) + CFLAGS=$(CC_OPT) -funroll-loops $(PROFILE) #if gcc 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+=-march=r3000 -minline-all-stringops \ @@ -1364,7 +1366,7 @@ ifeq ($(ARCH), mips2) ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff - CFLAGS= -mips2 -O9 -funroll-loops $(PROFILE) + CFLAGS= -mips2 $(CC_OPT) -funroll-loops $(PROFILE) #if gcc 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+=-minline-all-stringops -ftree-vectorize \ @@ -1409,7 +1411,7 @@ ifeq ($(ARCH), mips64) ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff - CFLAGS= -mips64 -O9 -funroll-loops $(PROFILE) + CFLAGS= -mips64 $(CC_OPT) -funroll-loops $(PROFILE) #if gcc 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+=-minline-all-stringops -ftree-vectorize \ @@ -1454,7 +1456,7 @@ ifeq ($(ARCH), alpha) ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff - CFLAGS= -O9 -funroll-loops $(PROFILE) + CFLAGS= $(CC_OPT) -funroll-loops $(PROFILE) #if gcc 4.5 or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) CFLAGS+= -fno-strict-overflow @@ -1500,7 +1502,7 @@ ifeq ($(ARCH), ppc) ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff - CFLAGS= -O9 -funroll-loops -fsigned-char $(PROFILE) + CFLAGS= $(CC_OPT) -funroll-loops -fsigned-char $(PROFILE) #if gcc 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) $(call set_if_empty,CPU,powerpc) @@ -1549,7 +1551,7 @@ ifeq ($(ARCH), ppc64) ifeq ($(CC_NAME), gcc) C_DEFS+=-DCC_GCC_LIKE_ASM #common stuff - CFLAGS= -O9 -funroll-loops -fsigned-char $(PROFILE) + CFLAGS= $(CC_OPT) -funroll-loops -fsigned-char $(PROFILE) #if gcc 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+,$(CC_SHORTVER)))) $(call set_if_empty,CPU,powerpc64)

1 0

[tracker] Comment added: SQLOPS returns 0 for empty result set instead of $null
by sip-router 06 Dec '13

06 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#376 - SQLOPS returns 0 for empty result set instead of $null User who did this - Dmitry Davletbaev (ddomgn) ---------- Wiki page made it clear to me, thank you. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=376#comment1212 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[SDPOPS] sdp_get_line_startswith removes \r in messages
by Tuan Viet Nguyen 06 Dec '13

06 Dec '13

Hello, It seems that when calling the function sdp_get_line_startswith, it removes the \r (0d in hexa) from the SIP message before forwarding it. In the code (sdpops_mod.c) from line 1402 to 1406, we see that // remove ending \r\n if exists if (avp_val.s.s[line.len-2] == '\r' && avp_val.s.s[line.len-1] == '\n') { avp_val.s.s[line.len-2] = '\0'; avp_val.s.len -= 2; } As avp_val is a reference to the found line which is also a reference to the line in the message, all modification made to this var will also be applied to the message. Am I wrong? Thank you,

2 2

git:master: snmpstats: use install-cfg target to deploy MIBs
by Daniel-Constantin Mierla 06 Dec '13

06 Dec '13

Module: sip-router Branch: master Commit: a8d0d9e9224c2e7399c95c533dff67a6303891d2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a8d0d9e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 6 11:41:38 2013 +0100 snmpstats: use install-cfg target to deploy MIBs - existing target was no longer valid from v3.0 --- modules/snmpstats/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/snmpstats/Makefile b/modules/snmpstats/Makefile index 2fd7f6c..0778be1 100644 --- a/modules/snmpstats/Makefile +++ b/modules/snmpstats/Makefile @@ -42,7 +42,7 @@ SERLIBPATH=../../lib SER_LIBS+=$(SERLIBPATH)/kcore/kcore include ../../Makefile.modules -install_module_custom: +install-cfg: echo "installing mibs ..." mkdir -p $(INSTALLMIBDIR) $(INSTALL_CFG) mibs/KAMAILIO* $(INSTALLMIBDIR)

1 0

[tracker] Task changed: avpops: avp_copy add xavp
by sip-router 06 Dec '13

06 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#359 - avpops: avp_copy add xavp User who did this: Víctor Seva (linuxmaniac) Task details edited: ------- We have avp_copy on avpops module but we don't have anything to copy xavps. <code> // copy all the content of an avp to a xavp $xavp(a[0]=>b) = $(avp(x)[*]); // deleting left content $xavp(a[0]=>b[*]) = $(avp(x)[*]); // copy xavp to a xavp with index $xavp(a[0]) = $xavp(b[1]); // all $xavp(a[*]) = $xavp(b[*]); // copy all content of a xavp to a avp $avp(x) = $xavp(a[0]=>b[*]); </code> ------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=359 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task changed: avpops: avp_copy add xavp
by sip-router 06 Dec '13

06 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#359 - avpops: avp_copy add xavp User who did this: Víctor Seva (linuxmaniac) Task details edited: ------- We have avp_copy on avpops module but we don't have anything to copy xavps. // copy all the content of an avp to a xavp $xavp(a[0]=>b) = $(avp(x)[*]); // deleting left content $xavp(a[0]=>b[*]) = $(avp(x)[*]); // copy xavp to a xavp with index $xavp(a[0]) = $xavp(b[1]); // all $xavp(a[*]) = $xavp(b[*]); // copy all content of a xavp to a avp $avp(x) = $xavp(a[0]=>b[*]); ------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=359 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:4.1: sdpops: fix setting 0 instead of \r for sdp_get_line_startswith()
by Daniel-Constantin Mierla 06 Dec '13

06 Dec '13

Module: sip-router Branch: 4.1 Commit: c56e66287d4456692bdad0f2454896ffd342cf0d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c56e662… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 6 11:32:41 2013 +0100 sdpops: fix setting 0 instead of \r for sdp_get_line_startswith() - reported by Tuan Viet Nguyen (cherry picked from commit 041b12dc6e5ad88e981d44180436a90518cbcf0d) --- modules/sdpops/sdpops_mod.c | 156 +++++++++++++++++++++--------------------- 1 files changed, 78 insertions(+), 78 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=c56…

1 0

git:master: sdpops: fix setting 0 instead of \r for sdp_get_line_startswith ()
by Daniel-Constantin Mierla 06 Dec '13

06 Dec '13

Module: sip-router Branch: master Commit: 041b12dc6e5ad88e981d44180436a90518cbcf0d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=041b12d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Dec 6 11:32:41 2013 +0100 sdpops: fix setting 0 instead of \r for sdp_get_line_startswith() - reported by Tuan Viet Nguyen --- modules/sdpops/sdpops_mod.c | 156 +++++++++++++++++++++--------------------- 1 files changed, 78 insertions(+), 78 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=041…

1 0

[tracker] Comment added: SQLOPS returns 0 for empty result set instead of $null
by sip-router 06 Dec '13

06 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#376 - SQLOPS returns 0 for empty result set instead of $null User who did this - Daniel-Constantin Mierla (miconda) ---------- I added some notes on the wiki: * https://www.kamailio.org/wiki/install/upgrade/4.0.x-to-4.1.0?&#behaviour The result from database should still be null, just the comparison of $null with $var(...) is done different, which came actually as a fix. You should test as: <code> if($dbr(touser=>[0,0])!=$null) ... </code> ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=376#comment1211 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task opened: SQLOPS returns 0 for empty result set instead of $null
by sip-router 06 Dec '13

06 Dec '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Dmitry Davletbaev (ddomgn) Attached to Project - sip-router Summary - SQLOPS returns 0 for empty result set instead of $null Task Type - Bug Report Category - Module Status - Unconfirmed Assigned To - Operating System - Linux Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - **System**: Debian Wheezy **Kamailio version**: 4.1.0 I use SQLOPS module to query additional data in MySQL database. Script logic is based on user related DB records existence. I check wether records exist or not simply by assigning variable: $var(touser) = $dbr(touser=>[0,0]); if ($var(touser) != $null) { [...] } else { [...] } Above code works perfectly in Kamailio 4.0.3 and 4.0.4, but in 4.1.0 a zero is assigned to $var(touser), so I had to change 'if' statement to if ($var(touser) != 0) { I consider this behavior as a bug, because "no value" should be represented by $null, not 0. Correct me if I am wrong. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=376 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

2 1

← Newer
1
...
19
20
21
22
23
24
25
...
32
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2013