sr-dev February 2013

sr-dev@lists.kamailio.org

45 participants
200 discussions

git:master: modules/outbound: Fix core dump crash
by Peter Dunkley 20 Feb '13

20 Feb '13

Module: sip-router Branch: master Commit: 164b8167855415771a82715ef59a300af8c2bafa URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=164b816… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Wed Feb 20 09:59:56 2013 +0000 modules/outbound: Fix core dump crash - Reported by oej --- modules/outbound/ob_mod.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/outbound/ob_mod.c b/modules/outbound/ob_mod.c index caf10f4..775d0b6 100644 --- a/modules/outbound/ob_mod.c +++ b/modules/outbound/ob_mod.c @@ -294,7 +294,8 @@ int use_outbound(struct sip_msg *msg) /* Look for ;reg-id in REGISTER Contact-URIs and ;ob in any Contact-URIs */ - if (msg->contact || parse_headers(msg, HDR_CONTACT_F, 0) != -1) + if (msg->contact + || (parse_headers(msg, HDR_CONTACT_F, 0) != -1 && msg->contact)) { if (parse_contact(msg->contact) < 0) { @@ -324,7 +325,8 @@ int use_outbound(struct sip_msg *msg) } /* Check to see if the top Route-URI is me and has a ;ob parameter */ - if (msg->route || parse_headers(msg, HDR_ROUTE_F, 0) != -1) + if (msg->route + || (parse_headers(msg, HDR_ROUTE_F, 0) != -1 && msg->route)) { if (parse_rr(msg->route) < 0) {

1 0

git:master: modules/outbound: Fixes the crash but is logically incorrect for outbound
by Peter Dunkley 20 Feb '13

20 Feb '13

Module: sip-router Branch: master Commit: 8d10bcd44834fd6f2a0c41238fd2dc197143c06e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8d10bcd… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Wed Feb 20 09:49:44 2013 +0000 modules/outbound: Fixes the crash but is logically incorrect for outbound - Not sure why the crash happened at all - but this fix breaks the outbound logic Revert "outbound Fix core dump crash" This reverts commit 6369444761d44526ded2620e33438abb182d2bdc. --- modules/outbound/ob_mod.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/outbound/ob_mod.c b/modules/outbound/ob_mod.c index f7fd63f..caf10f4 100644 --- a/modules/outbound/ob_mod.c +++ b/modules/outbound/ob_mod.c @@ -294,7 +294,7 @@ int use_outbound(struct sip_msg *msg) /* Look for ;reg-id in REGISTER Contact-URIs and ;ob in any Contact-URIs */ - if (msg->contact && parse_headers(msg, HDR_CONTACT_F, 0) != -1) + if (msg->contact || parse_headers(msg, HDR_CONTACT_F, 0) != -1) { if (parse_contact(msg->contact) < 0) {

1 0

Licensing for app_* modules
by Olle E. Johansson 20 Feb '13

20 Feb '13

Hello from North Carolina where SIPit starts tomorrow! Reading through the docs on the app_* modules I wonder how the GPLv2 is handled here. By default, GPL is sticky, so any module linked in to Kamailio will be GPL-licensed. With app_mono, precompiled binaries are executed within Kamailio, but not "linked in" to the core. The question here is if we have a clear distinction here. If someone developes a Kamailio-based appliance and sells it - would the customer have the right to app_mono modules under the GPL? What about python, java and Lua? I don't think these environments precompile, but they still execute within a GPL environment. I think we need a clear statement about this in the README, like Asterisk has for AMI/AGI applications. Greetings! /O

5 4

Does t_continue () work with t_reply_with_body ()?
by Robert Boisvert 19 Feb '13

19 Feb '13

Hi! I read the documentation and searched through the archives but I couldn't find an answer to this question. I apologize if I missed something. I'm working on writing a module using Kamailio 3.3. While processing an INVITE I use t_reply_with_body () and send a 180 (Ringing) response, t_suspend () the transaction, process a PRACK and try to t_continue () but I notice the following results: - The callback I created before t_suspend () receives a TMCB_DESTROY before the PRACK arrives - I can use t_continue () but it never returns to the calling routine I appreciate any guidance you can provide, Bob

1 1

Tracking Sipdroid contributors - help!
by Daniel Pocock 19 Feb '13

19 Feb '13

I'm trying to make sure that all Sipdroid contributors are properly recognised for contributions that have ended up in Lumicall. I understand some developers are active with Kamailio and some of you may know these people. To properly recognise people in github, Google code SVN user IDs need to be mapped to email addresses associated with github accounts. Google code seems to hide the identities of some contributors by giving them fake Google IDs even if they don't use gmail - so github doesn't recognise them, I have no easy way to contact them and people can't see the contributors' work when looking at that person's github profile. Would anybody be able to help me complete the list of contributors for this purpose? The list I have already is at: https://github.com/opentelecoms-org/lumicall/blob/master/authors.txt Regards, Daniel

1 0

branching for v4.4.x and unfreezing development
by Daniel-Constantin Mierla 19 Feb '13

19 Feb '13

Hello, it is time to sketch the road to the next major release, my plan is: - create branch 4.4 on Wednesday, February 27, 2013 - that will unfreeze development, so personal branches and contributions kept in external repositories can be merged in master branch - consider to release v4.4.0 in first or second week of March Any other opinions? Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference, April 16-17, 2013, Berlin - http://conference.kamailio.com -

2 2

git:master: maxfwd The default value is not 256, it's 16 in the source code .
by Olle E. Johansson 18 Feb '13

18 Feb '13

Module: sip-router Branch: master Commit: 8524f32bc07bd121326369f432eb29a257856f41 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8524f32… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: Mon Feb 18 22:36:45 2013 +0100 maxfwd The default value is not 256, it's 16 in the source code. --- modules/maxfwd/README | 14 +++++++------- modules/maxfwd/doc/maxfwd_admin.xml | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/modules/maxfwd/README b/modules/maxfwd/README index 845a855..764f8f5 100644 --- a/modules/maxfwd/README +++ b/modules/maxfwd/README @@ -107,7 +107,7 @@ Chapter 1. Admin Guide MAX-FORWARDS value allowed by RFC 3261. The value can be changed at runtime. - Default value is "256". + Default value is "16". Example 1.1. Set max_limit parameter ... @@ -123,7 +123,7 @@ modparam("maxfwd", "max_limit", 32) 4.5. maxfwd_at_least(max_value) 4.6. mf_lowlimit(max_value) -4.1. maxfwd_process(max_value) +4.1. maxfwd_process(max_value) If no Max-Forward header is present in the received request, a header will be added having the original value equal with "max_value". If a @@ -158,15 +158,15 @@ if (!maxfwd_process("10") && $retcode==-1) { }; ... -4.2. mf_process_maxfwd_header(max_value) +4.2. mf_process_maxfwd_header(max_value) Same as maxfwd_process(max_value). -4.3. process_maxfwd(max_value) +4.3. process_maxfwd(max_value) Same as maxfwd_process(max_value). -4.4. is_maxfwd_lt(max_value) +4.4. is_maxfwd_lt(max_value) Checks if the Max-Forward header value is less then the "max_value" parameter value. It considers also the value of the new inserted header @@ -197,10 +197,10 @@ if ( is_maxfwd_lt("1") ) { }; ... -4.5. maxfwd_at_least(max_value) +4.5. maxfwd_at_least(max_value) Same as is_maxfwd_lt(max_value). -4.6. mf_lowlimit(max_value) +4.6. mf_lowlimit(max_value) Same as is_maxfwd_lt(max_value). diff --git a/modules/maxfwd/doc/maxfwd_admin.xml b/modules/maxfwd/doc/maxfwd_admin.xml index 5fbdc9f..f0f3463 100644 --- a/modules/maxfwd/doc/maxfwd_admin.xml +++ b/modules/maxfwd/doc/maxfwd_admin.xml @@ -78,7 +78,7 @@ </para> <para> <emphasis> - Default value is <quote>256</quote>. + Default value is <quote>16</quote>. </emphasis> </para> <example>

1 0

[tracker] Task opened: app_lua: add rpc reload command (Attachment added)
by sip-router 18 Feb '13

18 Feb '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Víctor Seva (linuxmaniac) Attached to Project - sip-router Summary - app_lua: add rpc reload command Task Type - Improvement Category - Module Status - Unconfirmed Assigned To - Operating System - All Severity - Very Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - I've been working in get in app_lua a rpc command to been able to reload the script loaded at runtime. This is my first experience writing stuff for kamailio, so comments and improvements are welcome. One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=270 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: dialog_ng: changed LM_ERR to LM_DBG in dlg_hash.c
by Richard Good 18 Feb '13

18 Feb '13

Module: sip-router Branch: master Commit: 3f05697f6503f682274fce7bd93eeeaaa9b58188 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3f05697… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Mon Feb 18 09:48:22 2013 +0200 dialog_ng: changed LM_ERR to LM_DBG in dlg_hash.c - dlg_set_leg_info() line 416 was incorrectly logged as ERR when it should be only DBG --- modules/dialog_ng/dlg_hash.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/dialog_ng/dlg_hash.c b/modules/dialog_ng/dlg_hash.c index ad462fa..97e1371 100644 --- a/modules/dialog_ng/dlg_hash.c +++ b/modules/dialog_ng/dlg_hash.c @@ -413,7 +413,7 @@ int dlg_set_leg_info(struct dlg_cell *dlg, str* tag, str *rr, str *contact, LM_DBG("Searching out dialog with to_tag '%.*s' (looking for %.*s\n", dlg_out->to_tag.len, dlg_out->to_tag.s, tag->len, tag->s); if (dlg_out->to_tag.len == tag->len && memcmp(dlg_out->to_tag.s, tag->s, dlg_out->to_tag.len) == 0) { - LM_ERR("Found dialog_out entry with correct to_tag - updating leg info\n"); + LM_DBG("Found dialog_out entry with correct to_tag - updating leg info\n"); if (contact->len > 0) { dlg_out->callee_contact.s = (char*) shm_malloc(contact->len);

1 0

git:master: modules/rtpproxy: rtpproxy_manage can now add ice relay candidates
by Juha Heinanen 16 Feb '13

16 Feb '13

Module: sip-router Branch: master Commit: 75fde552f1c4cdea736baa72ff1aa36e527e0215 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=75fde55… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Wed Jan 2 13:00:31 2013 +0200 modules/rtpproxy: rtpproxy_manage can now add ice relay candidates - The feature is activated by defining ice_candidate_priority_avp module parameter. --- modules/rtpproxy/README | 149 ++++++++++++++++++------------- modules/rtpproxy/doc/rtpproxy_admin.xml | 28 ++++++ modules/rtpproxy/rtpproxy.c | 139 ++++++++++++++++++++++++++++- 3 files changed, 250 insertions(+), 66 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=75f…

4 8

← Newer
1
...
8
9
10
11
12
13
14
...
20
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2013