sr-dev February 2013

sr-dev@lists.kamailio.org

45 participants
201 discussions

git:3.3: core: fixed bug in PV caching that broke the use of the $$ symbol
by Daniel-Constantin Mierla 25 Feb '13

25 Feb '13

Module: sip-router Branch: 3.3 Commit: 514f6cc66e5220779188aad15f3b3eeeace7aabf URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=514f6cc… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Jan 20 14:18:55 2013 +0000 core: fixed bug in PV caching that broke the use of the $$ symbol - Found and fixed by Hugh Waite @ Crocodile RCS (cherry picked from commit c059041a71a1b7175243c366316108ce370fffa7) --- pvapi.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/pvapi.c b/pvapi.c index 64878f2..5072f0f 100644 --- a/pvapi.c +++ b/pvapi.c @@ -120,6 +120,10 @@ int pv_locate_name(str *in) LM_ERR("missing pv marker [%.*s]\n", in->len, in->s); return -1; } + if(in->s[1]==PV_MARKER) + { + return 2; + } pcount = 0; if(in->s[1]==PV_LNBRACKET) {

1 0

Patch Fix-documentation-examples-for-XMLRPC
by Gareth Rylance 25 Feb '13

25 Feb '13

1 0

planning to release Kamailio v3.3.4
by Daniel-Constantin Mierla 24 Feb '13

24 Feb '13

Hello, I am considering packaging a new minor release for branch 3.3 next Monday, on February 25. Please backport any patches that you have to be part of v3.3.4 Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference, April 16-17, 2013, Berlin - http://conference.kamailio.com -

1 1

git:master: snmpstats Add missing SIP response codes
by Olle E. Johansson 24 Feb '13

24 Feb '13

Module: sip-router Branch: master Commit: 4547a28b077b5bdaf9128e98fd4e1ee9a8c11847 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4547a28… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: Sun Feb 24 17:53:27 2013 +0100 snmpstats Add missing SIP response codes And switch from Wikipedia to the IANA list as a master list. --- modules/snmpstats/snmpstats.c | 39 +++++++++++++++++++++++++++------------ 1 files changed, 27 insertions(+), 12 deletions(-) diff --git a/modules/snmpstats/snmpstats.c b/modules/snmpstats/snmpstats.c index 26240d8..18df08c 100644 --- a/modules/snmpstats/snmpstats.c +++ b/modules/snmpstats/snmpstats.c @@ -207,27 +207,35 @@ static struct sigaction old_sigchld_handler; * * http://en.wikipedia.org/wiki/SIP_Responses * + * Updated by oej to use the IETF reference page + * http://www.iana.org/assignments/sip-parameters/sip-parameters.xml#sip-param… + * * If there are more message codes added at a later time, they should be added * here, and to out_message_code_names below. * * The array is used to register the statistics keeping track of the number of * messages received with the response code X. + * */ char *in_message_code_names[] = { - "100_in", "180_in", "181_in", "182_in", "183_in", + "100_in", "180_in", "181_in", "182_in", "183_in", "199_in", - "200_in", "202_in", + "200_in", "202_in", "204_in", "300_in", "301_in", "302_in", "305_in", "380_in", "400_in", "401_in", "402_in", "403_in", "404_in", "405_in", "406_in", - "407_in", "408_in", "410_in", "413_in", "414_in", "415_in", "416_in", - "420_in", "421_in", "423_in", "480_in", "481_in", "482_in", "483_in", - "484_in", "485_in", "486_in", "487_in", "488_in", "491_in", "492_in", - "494_in", + "407_in", "408_in", "410_in", "412_in", "413_in", "414_in", "415_in", + "416_in", "417_in", "420_in", "421_in", "422_in", "423_in", "424_in", + "428_in", "429_in", "430_in", "433_in", "436_in", "437_in", "438_in", + "439_in", "440_in", "469_in", "470_in", "480_in", "481_in", "482_in", + "483_in", "484_in", "485_in", "486_in", "487_in", "488_in", "489_in", + "491_in", "492_in", "493_in", "494_in", "500_in", "501_in", "502_in", "503_in", "504_in", "505_in", "513_in", + "580_in", + "600_in", "603_in", "604_in", "606_in" }; @@ -235,6 +243,9 @@ char *in_message_code_names[] = * * http://en.wikipedia.org/wiki/SIP_Responses * + * Updated by oej to use the IETF reference page + * http://www.iana.org/assignments/sip-parameters/sip-parameters.xml#sip-param… + * * If there are more message codes added at a later time, they should be added * here, and to in_message_code_names above. * @@ -243,19 +254,23 @@ char *in_message_code_names[] = */ char *out_message_code_names[] = { - "100_out", "180_out", "181_out", "182_out", "183_out", + "100_out", "180_out", "181_out", "182_out", "183_out", "199_out", - "200_out", "202_out", + "200_out", "202_out", "204_out", "300_out", "301_out", "302_out", "305_out", "380_out", "400_out", "401_out", "402_out", "403_out", "404_out", "405_out", "406_out", - "407_out", "408_out", "410_out", "413_out", "414_out", "415_out", "416_out", - "420_out", "421_out", "423_out", "480_out", "481_out", "482_out", "483_out", - "484_out", "485_out", "486_out", "487_out", "488_out", "491_out", "492_out", - "494_out", + "407_out", "408_out", "410_out", "412_out", "413_out", "414_out", "415_out", + "416_out", "417_out", "420_out", "421_out", "422_out", "423_out", "424_out", + "428_out", "429_out", "430_out", "433_out", "436_out", "437_out", "438_out", + "439_out", "440_out", "469_out", "470_out", "480_out", "481_out", "482_out", + "483_out", "484_out", "485_out", "486_out", "487_out", "488_out", "489_out", + "491_out", "492_out", "493_out", "494_out", "500_out", "501_out", "502_out", "503_out", "504_out", "505_out", "513_out", + "580_out", + "600_out", "603_out", "604_out", "606_out" };

1 0

git:master: snmpstats add support for ws, wss and sctp transports
by Olle E. Johansson 24 Feb '13

24 Feb '13

Module: sip-router Branch: master Commit: 39bffdd7db9c3118045eae9640659997bac4bf4e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=39bffdd… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: Sun Feb 24 22:17:25 2013 +0100 snmpstats add support for ws, wss and sctp transports --- modules/snmpstats/snmpSIPPortTable.c | 34 ++++++++++++++++++++++++++++++++++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/modules/snmpstats/snmpSIPPortTable.c b/modules/snmpstats/snmpSIPPortTable.c index 3eb91ed..5d57c2e 100644 --- a/modules/snmpstats/snmpSIPPortTable.c +++ b/modules/snmpstats/snmpSIPPortTable.c @@ -5,6 +5,9 @@ * Copyright (C) 2006 SOMA Networks, INC. * Written by: Jeffrey Magder (jmagder(a)somanetworks.com) * + * Copyright (C) 2013 Edvina AB, Sollentuna, Sweden + * Modifications by: Olle E. Johansson (oej(a)edvina.net) + * * This file is part of Kamailio, a free SIP server. * * Kamailio is free software; you can redistribute it and/or modify it @@ -25,6 +28,7 @@ * History: * -------- * 2006-11-23 initial version (jmagder) + * 2013-02-24 Added WS, WSS and SCTP support (oej) * * Originally Generated with mib2c using mib2c.array-user.conf * @@ -183,6 +187,18 @@ void createRowsFromIPList(int *theList, int listSize, int protocol, { valueToAssign = TC_TRANSPORT_PROTOCOL_TLS; } + else if (protocol == PROTO_WS) + { + valueToAssign = TC_TRANSPORT_PROTOCOL_WS; + } + else if (protocol == PROTO_WSS) + { + valueToAssign = TC_TRANSPORT_PROTOCOL_WSS; + } + else if (protocol == PROTO_SCTP) + { + valueToAssign = TC_SIP_TRANSPORT_PROTOCOL_SCTP; + } else { valueToAssign = TC_TRANSPORT_PROTOCOL_OTHER; @@ -224,15 +240,24 @@ void init_kamailioSIPPortTable(void) int *UDPList = NULL; int *TCPList = NULL; int *TLSList = NULL; + int *WSList = NULL; + int *WSSList = NULL; + int *SCTPList = NULL; int numUDPSockets; int numTCPSockets; int numTLSSockets; + int numWSSockets; + int numWSSSockets; + int numSCTPSockets; /* Retrieve the list of the number of UDP and TCP sockets. */ numUDPSockets = get_socket_list_from_proto(&UDPList, PROTO_UDP); numTCPSockets = get_socket_list_from_proto(&TCPList, PROTO_TCP); numTLSSockets = get_socket_list_from_proto(&TLSList, PROTO_TLS); + numWSSockets = get_socket_list_from_proto(&WSList, PROTO_WS); + numWSSSockets = get_socket_list_from_proto(&WSSList, PROTO_WSS); + numSCTPSockets = get_socket_list_from_proto(&SCTPList, PROTO_SCTP); /* Generate all rows, using all retrieved interfaces. */ createRowsFromIPList(UDPList, numUDPSockets, PROTO_UDP, &curSNMPIndex); @@ -243,6 +268,15 @@ void init_kamailioSIPPortTable(void) curSNMPIndex = 0; createRowsFromIPList(TLSList, numTLSSockets, PROTO_TLS, &curSNMPIndex); + + curSNMPIndex = 0; + createRowsFromIPList(WSList, numWSSockets, PROTO_WS, &curSNMPIndex); + + curSNMPIndex = 0; + createRowsFromIPList(WSSList, numWSSSockets, PROTO_WSS, &curSNMPIndex); + + curSNMPIndex = 0; + createRowsFromIPList(SCTPList, numSCTPSockets, PROTO_SCTP, &curSNMPIndex); }

1 0

[tracker] Comment added: get_body_part2 (parse_body)
by sip-router 24 Feb '13

24 Feb '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#170 - get_body_part2 (parse_body) User who did this - Daniel-Constantin Mierla (miconda) ---------- There seems to be an issue in function: +int part_multipart_headers_cmp (char *buffer, + char *end_buffer, + unsigned short content_type, + unsigned short content_subtype, + char *content_id, + char *content_length) +{ + int error = 0; + char *error_msg = NULL; + + char *cpy_c = NULL; + char *cpy_d = NULL; + + char *value_ini = NULL; + char *value_fin = NULL; + unsigned int umime; + + int found = 0; + int found_content_type = 0; + int found_content_id = 0; + int found_content_length = 0; + + if ((buffer == NULL) || (end_buffer == NULL)) { + error = -1; + error_msg = "buffer and/or end_buffer are NULL"; + } else { + *cpy_c = buffer; + *cpy_d = end_buffer; cpy_c and cpy_d are initialized to NULL, but then values are stored at that address (the last two lines above). Did you want to have: + cpy_c = buffer; + cpy_d = end_buffer; ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=170#comment776 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

SNMPstats response code table
by Olle E. Johansson 24 Feb '13

24 Feb '13

Hi! Looking at the modules/snmpstats/snmpstats.c table over response codes, it's fairly old. I have updated it to the latest list from IANA - but the question is if this is considered a bug fix that can be committed to 4.0.0. I think so - do you? /O

2 1

SOS!! Kamailio 3.1.x Load Balancer doesn't work
by chanea 24 Feb '13

24 Feb '13

Dear All, I am trying to use Kamailio 3.1.x server (called LB here) as the Load Balancer for two other Kamailio server (called server01 and server02 here) . Client A -----> Kamailio LB -----> Kamailio server01 Client B -----> Kamailio LB -----> Kamailio server01 If I dont use LB here , and letting Client A and B connect to Kamailio server01 directly , all the communication is fine. While using Kamailio LB ,without luck, although the sip client A and B get 200 from server01 for Register, they cannot reach each other for "Message" and "Invite". It will be great appreciated if anyone can give a hint. my config for Kamailio LB is as below : ========================================== .... debug=2 # debug level (cmd line: -dddddddddd) fork=yes log_stderror=yes # (cmd line: -E) children=2 check_via=no # (cmd. line: -v) dns=off # (cmd. line: -r) rev_dns=off # (cmd. line: -R) port=5060 # for more info: sip_router -h # ------------------ module loading ---------------------------------- mpath="/usr/local/lib64/kamailio/modules_k/:/usr/local/lib64/kamailio/modules/" loadmodule "sl.so" loadmodule "tm.so" loadmodule "rr.so" loadmodule "maxfwd.so" loadmodule "usrloc.so" loadmodule "registrar.so" loadmodule "textops.so" loadmodule "mi_fifo.so" loadmodule "dispatcher.so" loadmodule "db_mysql.so" # ----------------- setting module-specific parameters --------------- # -- dispatcher params -- modparam("mi_fifo", "fifo_name", "/tmp/openser_fifo") modparam("dispatcher", "db_url","mysql://.........@........") modparam("usrloc", "db_mode", 0) modparam("rr", "enable_full_lr", 1) route{ if (!mf_process_maxfwd_header("10")) { sl_send_reply("483","Too Many Hops"); exit; }; # if (!method=="REGISTER") # record_route(); ds_select_dst("1","4"); forward(); exit; } .. ========================================== best regards, chanea

2 3

SIPit 30 summary
by Olle E. Johansson 24 Feb '13

24 Feb '13

Hi! I've spent five days at SIPit 30 testing Kamailio on a tiny Asus EEE-netbook. It's been great, and apart from the bug hitting me while using outbound, we've done great in all tests. During the proxy doom test today, the netbook processed way over 50.000 messages in a single INVITE transaction that spiralled and looped and behaved in funny ways, and the CPU still had a lot of power to do other things. The hub we used was the limiting factor. Kamailio 4.0.0 beta was involved in all multiparty tests, from TLS and RTCweb to forking, spiralling and proxy doom. We proved that we have a solid product that can handle all kind of scenarious, even TCP overflow attacks. Thanks for all the help over jabber, IRC and other means! Special thank you to Fred Posner who contributed a Big Fred Cookie! Have a great weekend! /O

3 5

git:master: snmpstats fix typo
by Olle E. Johansson 24 Feb '13

24 Feb '13

Module: sip-router Branch: master Commit: 7952711e6079e02a07ad027c6d8840e755c6e528 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7952711… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: Sun Feb 24 10:25:38 2013 +0100 snmpstats fix typo --- modules/snmpstats/snmpstats.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/snmpstats/snmpstats.c b/modules/snmpstats/snmpstats.c index 0fa7830..26240d8 100644 --- a/modules/snmpstats/snmpstats.c +++ b/modules/snmpstats/snmpstats.c @@ -49,7 +49,7 @@ * 4) mod_init() will initialize some interprocess communication buffers, as * well as callback mechanisms for the usrloc module. To understand what the * interprocess buffer and callbacks are and are for, please see the comments - * at the beginning of kamailioSIPRegUserTable.c + * at the beginning of snmpSIPRegUserTable.c */ /*!

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
21
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2013