sr-dev March 2013

sr-dev@lists.kamailio.org

36 participants
428 discussions

Using t_suspend()/t_continue() multiple times on the same transaction

by Peter Dunkley

Hi, I am trying to use t_suspend()/t_continue() multiple times on the same transaction. Calling t_suspend() more than once works, but the second time I call t_continue() the transaction is killed and a 500 response is sent. It is the "if (branch == t->nr_of_outgoings)" check from the code fragment below (from t_suspend.c:t_continue()) that results in the transaction being killed - you can see the debug/error line I added to determine this in the fragment. Is using t_suspend()/t_continue() multiple times something that should work? Thanks, Peter if (t->uas.status < 200) { /* No final reply has been sent yet. * Check whether or not there is any pending branch. */ for ( branch = 0; branch < t->nr_of_outgoings; branch++ ) { if ((t->uac[branch].request.buffer != NULL) && (t->uac[branch].last_received < 200) ) break; } if (branch == t->nr_of_outgoings) { /* There is not any open branch so there is * no chance that a final response will be received. */ ret = 0; LM_ERR("branch == t->nr_of_outgoings\n"); goto kill_trans; } } -- Peter Dunkley Technical Director Crocodile RCS Ltd

10 years, 4 months

default config: do loose_route() for in-dialog NOTIFY as per new RFC 6665

by Iñaki Baz Castillo

Hi, the new RFC 6665 mandates that the subscription dialog is made *after* the first NOTIFY from the UAS (rather than after the 200 to the initial SUBSCRIBE). This means that the UAC MUST take the route set from the *first* received NOTIFY (instead of taking it from the 200 to the initial SUBSCRIBE). Therefore a proxy compliant with RFC 6665 MUST always add RR to in-dialog NOTIFY requests and thus, I propose that the default SR script file implements it. Regards. -- Iñaki Baz Castillo <ibc(a)aliax.net>

10 years, 9 months

t_suspend and t_continue in tm module

by Richard Good

Hi We are using the t_suspend and t_continue functionality to asynchronously send Diameter messages. This works nicely when we suspend and resume on a SIP request. However in some circumstances we want to send a Diameter message on a SIP response. I have found that the SIP responses continue to be relayed despite being suspended and returning 0 to the cfg file. I am investigating the cause but before I get any deeper does anyone know if the t_suspend and t_continue functionality in the tm module can be used on a SIP response? Regards Richard. This email is subject to the disclaimer of Smile Communications (PTY) Ltd. at http://www.smilecoms.com/disclaimer

11 years, 4 months

git:master: modules_k/uac: uac_replace_from/to AUTO mode with dialog module

by Anca Vamanu

Module: sip-router Branch: master Commit: 0f702f6e236eb0cbb238bf83a0c4ae94d7b3cad8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0f702f6… Author: Anca Vamanu <anca.vamanu(a)1and1.ro> Committer: Anca Vamanu <anca.vamanu(a)1and1.ro> Date: Thu Jul 19 17:49:13 2012 +0300 modules_k/uac: uac_replace_from/to AUTO mode with dialog module Added a implementation for uac_replace_from/to() that uses the dialog module for AUTO mode. In this mode the URIs are stored as dialog variables. The change in tm module fixes a bug: if uac_replace_to() was called, the URI was not changed accordingly in Cancel. --- modules/tm/t_cancel.c | 5 +- modules_k/dialog/dialog.c | 2 + modules_k/dialog/dlg_load.h | 6 + modules_k/uac/README | 111 +++++++++++----- modules_k/uac/doc/uac_admin.xml | 68 +++++++++- modules_k/uac/replace.c | 292 ++++++++++++++++++++++++++++++--------- modules_k/uac/uac.c | 17 ++- 7 files changed, 393 insertions(+), 108 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=0f7…

11 years, 4 months

Segfault in presence module

by Richard Fuchs

Hello, I'm currently debugging a segfault in the presence module, which is caused by it recursively calling srdb1 functions on the same db handle, which at least under db_mysql doesn't work and causes segfault. I was wondering what the preferred fix would be: Fix presence module so it doesn't do that, or fix db_mysql so that recursive queries are possible. Personally I'd prefer the second option, but AFAICS it would require some changes to srdb1 itself. Any other options I'm not seeing? cheers

11 years, 7 months

Mediaproxy

by Olle E. Johansson

I think we need to make a decision regarding the mediaproxy module. The development team no longer supports Kamailio and I think the module doesn't support recent releases of the mediaproxy. Any thoughts? /O

11 years, 7 months

git:master: siptrace Fix bug in documentation

by Olle E. Johansson

Module: sip-router Branch: master Commit: 1c643eb26a25880669a719a29c1c8e984e32983d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1c643eb… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: Thu Feb 7 11:04:00 2013 +0100 siptrace Fix bug in documentation The default database URL was mysql, not "", which caused me some strange issues. --- modules/siptrace/README | 2 +- modules/siptrace/doc/siptrace_admin.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/siptrace/README b/modules/siptrace/README index 6875f0a..bb8bb67 100644 --- a/modules/siptrace/README +++ b/modules/siptrace/README @@ -191,7 +191,7 @@ Chapter 1. Admin Guide Database URL. - Default value is "". + Default value is "mysql://kamailio:kamailiorw@localhost/okamailio". Example 1.1. Set db_url parameter ... diff --git a/modules/siptrace/doc/siptrace_admin.xml b/modules/siptrace/doc/siptrace_admin.xml index 70a4abd..004f510 100644 --- a/modules/siptrace/doc/siptrace_admin.xml +++ b/modules/siptrace/doc/siptrace_admin.xml @@ -96,7 +96,7 @@ </para> <para> <emphasis> - Default value is "". + Default value is "mysql://kamailio:kamailiorw@localhost/okamailio". </emphasis> </para> <example>

11 years, 7 months

Help improving the modules readmes & docs

by Daniel-Constantin Mierla

Hello, I thought some people may have spare cycles and are willing to help with the documentation. Here is some updates I would like to get for modules: 1) adding ids for parameters, functions, and other sections of the docbook xml files. Now we generate the alphabetic indexes pointing to the online html readmes, would be better to point directly to the exact section. Practically, for example, sections such as next from async module: <section> <title><varname>workers</varname> (int)</title> should become: <section id="async.p.workers"> <title><varname>workers</varname> (int)</title> To get unique ids over all files, I suggest using following pattern: [module name] [dot] [type] [dot] [title] The [type] should be: - p - parameters - f - functions - m - mi commands - r - rpc commands - s - statistics 2) Add RPC commands to readmes -- some of modules already do, but many don't. There is a perl script that should get the list of RPC commands from source code, but it requires some patch to a perl lib, not working on all systems. Moreover, the output is quite minimalistic, not easy to improve the content or add examples. Last generated index is: - http://www.kamailio.org/docs/docbooks/3.4.x/rpc_list/rpc_list.html 3) Document selects -- although their name are quite suggestive, a bit of text around won't harm. - http://www.kamailio.org/wiki/cookbooks/devel/selects Because 1) and 2) requires git access, the easiest way to contribute is to provide patches to the xml files. If anyone commits to do an extensive work on these tasks in short term, we may eventually arrange for git access. The 3) is in the wiki, everyone can register an account and then update the pages. I would recommend these guidelines to be followed from now on by developers when adding new elements to the module documentation. Cheers, Daniel -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference, April 16-17, 2013, Berlin - http://conference.kamailio.com -

11 years, 7 months

[tracker] Comment added: OpenBSD5.2 Crash on t_relay()

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#280 - OpenBSD5.2 Crash on t_relay() User who did this - Jody Rudolph (jrudolph) ---------- If it's possible, I cant seem to find out how. Closing this out and giving up on OpenBSD-SPARC. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=280#comment815 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 7 months

git:master: dialog: SDP can be passed to MI/RPC dlg_bridge

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 2df6f560bcc54d2966732d397713a9cf3233d5fe URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2df6f56… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Mar 31 21:49:10 2013 +0200 dialog: SDP can be passed to MI/RPC dlg_bridge - rework from a patch of Patrick E. --- modules/dialog/dialog.c | 31 ++++++++++++++++++++++++++++--- modules/dialog/dlg_transfer.c | 11 ++++++++--- modules/dialog/dlg_transfer.h | 2 +- 3 files changed, 37 insertions(+), 7 deletions(-) diff --git a/modules/dialog/dialog.c b/modules/dialog/dialog.c index 804bc46..e560b4e 100644 --- a/modules/dialog/dialog.c +++ b/modules/dialog/dialog.c @@ -1097,7 +1097,7 @@ static int w_dlg_bridge(struct sip_msg *msg, char *from, char *to, char *op) return -1; } - if(dlg_bridge(&sf, &st, &so)!=0) + if(dlg_bridge(&sf, &st, &so, NULL)!=0) return -1; return 1; } @@ -1345,6 +1345,7 @@ struct mi_root * mi_dlg_bridge(struct mi_root *cmd_tree, void *param) str from = {0,0}; str to = {0,0}; str op = {0,0}; + str bd = {0,0}; struct mi_node* node; node = cmd_tree->node.kids; @@ -1374,9 +1375,23 @@ struct mi_root * mi_dlg_bridge(struct mi_root *cmd_tree, void *param) { return init_mi_tree(500, "Bad OP value", 12); } + if(op.len==1 && *op.s=='.') + { + op.s = NULL; + op.len = 0; + } + node= node->next; + if(node != NULL) + { + bd = node->value; + if(bd.len<=0 || bd.s==NULL) + { + return init_mi_tree(500, "Bad SDP value", 13); + } + } } - if(dlg_bridge(&from, &to, &op)!=0) + if(dlg_bridge(&from, &to, &op, &bd)!=0) return init_mi_tree(500, MI_INTERNAL_ERR_S, MI_INTERNAL_ERR_LEN); return init_mi_tree(200, MI_OK_S, MI_OK_LEN); @@ -1676,6 +1691,7 @@ static void rpc_dlg_bridge(rpc_t *rpc, void *c) { str from = {NULL,0}; str to = {NULL,0}; str op = {NULL,0}; + str bd = {NULL,0}; int n; n = rpc->scan(c, "SS", &from, &to); @@ -1687,9 +1703,18 @@ static void rpc_dlg_bridge(rpc_t *rpc, void *c) { if(rpc->scan(c, "*S", &op)<1) { op.s = NULL; op.len = 0; + } else { + if(op.len==1 && *op.s=='.') { + op.s = NULL; + op.len = 0; + } + if(rpc->scan(c, "*S", &bd)<1) { + bd.s = NULL; + bd.len = 0; + } } - dlg_bridge(&from, &to, &op); + dlg_bridge(&from, &to, &op, &bd); } static rpc_export_t rpc_methods[] = { diff --git a/modules/dialog/dlg_transfer.c b/modules/dialog/dlg_transfer.c index 25d9e8d..7245435 100644 --- a/modules/dialog/dlg_transfer.c +++ b/modules/dialog/dlg_transfer.c @@ -311,7 +311,7 @@ error: } -int dlg_bridge(str *from, str *to, str *op) +int dlg_bridge(str *from, str *to, str *op, str *bd) { dlg_transfer_ctx_t *dtc; int ret; @@ -350,8 +350,13 @@ int dlg_bridge(str *from, str *to, str *op) LM_DBG("bridge <%.*s> to <%.*s>\n", dtc->from.len, dtc->from.s, dtc->to.len, dtc->to.s); - s_body.s = DLG_HOLD_SDP; - s_body.len = DLG_HOLD_SDP_LEN; + if(bd!=NULL && bd->s!=NULL && bd->len>0) { + s_body.s = bd->s; + s_body.len = bd->len; + } else { + s_body.s = DLG_HOLD_SDP; + s_body.len = DLG_HOLD_SDP_LEN; + } memset(&uac_r, '\0', sizeof(uac_req_t)); uac_r.method = &s_method; diff --git a/modules/dialog/dlg_transfer.h b/modules/dialog/dlg_transfer.h index ef05eeb..5337f38 100644 --- a/modules/dialog/dlg_transfer.h +++ b/modules/dialog/dlg_transfer.h @@ -32,7 +32,7 @@ typedef struct _dlg_transfer_ctx { struct dlg_cell *dlg; } dlg_transfer_ctx_t; -int dlg_bridge(str *from, str *to, str *op); +int dlg_bridge(str *from, str *to, str *op, str *bd); int dlg_transfer(struct dlg_cell *dlg, str *to, int side); int dlg_bridge_init_hdrs(void); void dlg_bridge_destroy_hdrs(void);

11 years, 7 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2013