sr-dev March 2013

sr-dev@lists.kamailio.org

36 participants
428 discussions

[tracker] Comment added: not able to compile Kamailio 3.3.4

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#274 - not able to compile Kamailio 3.3.4 User who did this - Julian (juquinte) ---------- Hi Daniel Yes libc dev package is already installed: Note, selecting 'libc0.1-dev' instead of 'libc-dev' libc0.1-dev is already the newest version. libc0.1-dev set to manually installed. 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded. Regards ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=274#comment784 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 8 months

[tracker] Task closed: rtpproxy module: rtpproxy_manage(flags, ip) puts garbage into SDP

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#273 - rtpproxy module: rtpproxy_manage(flags, ip) puts garbage into SDP User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Thanks for testing! More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=273 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 8 months

[tracker] Comment added: rtpproxy module: rtpproxy_manage(flags, ip) puts garbage into SDP

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#273 - rtpproxy module: rtpproxy_manage(flags, ip) puts garbage into SDP User who did this - Markus Bucher (MarkCDSys) ---------- Works great, thank you! ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=273#comment783 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 8 months

git:4.0: rtpproxy: proper fixup function for rtpproxy_manage(...)

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.0 Commit: 0d6e0778ef4d86ebd06671333f86f45fc2ec375d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0d6e077… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Mar 1 18:12:23 2013 +0100 rtpproxy: proper fixup function for rtpproxy_manage(...) - second parameter was resolved as spve type, although fixed as str - reported by Markus Bucher, FS#273 (cherry picked from commit b23510e0adb6060a257c8662700450ed7faef080) --- modules/rtpproxy/rtpproxy.c | 20 ++++++++++++++++---- 1 files changed, 16 insertions(+), 4 deletions(-) diff --git a/modules/rtpproxy/rtpproxy.c b/modules/rtpproxy/rtpproxy.c index 016a9a1..783eff9 100644 --- a/modules/rtpproxy/rtpproxy.c +++ b/modules/rtpproxy/rtpproxy.c @@ -411,7 +411,7 @@ static cmd_export_t cmds[] = { fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, {"rtpproxy_manage", (cmd_function)rtpproxy_manage2, 2, - fixup_spve_str, fixup_free_spve_str, + fixup_spve_spve, fixup_free_spve_spve, ANY_ROUTE}, {0, 0, 0, 0, 0, 0} }; @@ -2037,7 +2037,11 @@ static int rtpproxy_manage1(struct sip_msg *msg, char *flags, char *ip) { str flag_str; - fixup_get_svalue(msg, (gparam_p)flags, &flag_str); + if(fixup_get_svalue(msg, (gparam_p)flags, &flag_str)<0) + { + LM_ERR("invalid flags parameter\n"); + return -1; + } return rtpproxy_manage(msg, flag_str.s, 0); } @@ -2046,8 +2050,16 @@ rtpproxy_manage2(struct sip_msg *msg, char *flags, char *ip) { str flag_str; str ip_str; - fixup_get_svalue(msg, (gparam_p)flags, &flag_str); - fixup_get_svalue(msg, (gparam_p)ip, &ip_str); + if(fixup_get_svalue(msg, (gparam_p)flags, &flag_str)<0) + { + LM_ERR("invalid flags parameter\n"); + return -1; + } + if(fixup_get_svalue(msg, (gparam_p)ip, &ip_str)<0) + { + LM_ERR("invalid IP parameter\n"); + return -1; + } return rtpproxy_manage(msg, flag_str.s, ip_str.s); }

11 years, 8 months

[tracker] Comment added: rtpproxy module: rtpproxy_manage(flags, ip) puts garbage into SDP

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#273 - rtpproxy module: rtpproxy_manage(flags, ip) puts garbage into SDP User who did this - Daniel-Constantin Mierla (miconda) ---------- Your patch is reverting partially what was added by Peter Dunkley to allow variables in the parameters of the rtpproxy_manage() -- that results pretty much in the version of rtpproxy_manage(flags, ip) from kamailio 3.3.x. Apparently the problem was with the expected type of second parameter. I pushed a patch (master and 4.0 branches), but didn't test it. Give it a try and report back if works fine. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=273#comment782 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 8 months

git:master: rtpproxy: proper fixup function for rtpproxy_manage(...)

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: b23510e0adb6060a257c8662700450ed7faef080 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b23510e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Mar 1 18:12:23 2013 +0100 rtpproxy: proper fixup function for rtpproxy_manage(...) - second parameter was resolved as spve type, although fixed as str - reported by Markus Bucher, FS#273 --- modules/rtpproxy/rtpproxy.c | 20 ++++++++++++++++---- 1 files changed, 16 insertions(+), 4 deletions(-) diff --git a/modules/rtpproxy/rtpproxy.c b/modules/rtpproxy/rtpproxy.c index 016a9a1..783eff9 100644 --- a/modules/rtpproxy/rtpproxy.c +++ b/modules/rtpproxy/rtpproxy.c @@ -411,7 +411,7 @@ static cmd_export_t cmds[] = { fixup_spve_null, fixup_free_spve_null, ANY_ROUTE}, {"rtpproxy_manage", (cmd_function)rtpproxy_manage2, 2, - fixup_spve_str, fixup_free_spve_str, + fixup_spve_spve, fixup_free_spve_spve, ANY_ROUTE}, {0, 0, 0, 0, 0, 0} }; @@ -2037,7 +2037,11 @@ static int rtpproxy_manage1(struct sip_msg *msg, char *flags, char *ip) { str flag_str; - fixup_get_svalue(msg, (gparam_p)flags, &flag_str); + if(fixup_get_svalue(msg, (gparam_p)flags, &flag_str)<0) + { + LM_ERR("invalid flags parameter\n"); + return -1; + } return rtpproxy_manage(msg, flag_str.s, 0); } @@ -2046,8 +2050,16 @@ rtpproxy_manage2(struct sip_msg *msg, char *flags, char *ip) { str flag_str; str ip_str; - fixup_get_svalue(msg, (gparam_p)flags, &flag_str); - fixup_get_svalue(msg, (gparam_p)ip, &ip_str); + if(fixup_get_svalue(msg, (gparam_p)flags, &flag_str)<0) + { + LM_ERR("invalid flags parameter\n"); + return -1; + } + if(fixup_get_svalue(msg, (gparam_p)ip, &ip_str)<0) + { + LM_ERR("invalid IP parameter\n"); + return -1; + } return rtpproxy_manage(msg, flag_str.s, ip_str.s); }

11 years, 8 months

[tracker] Comment added: not able to compile Kamailio 3.3.4

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#274 - not able to compile Kamailio 3.3.4 User who did this - Daniel-Constantin Mierla (miconda) ---------- Have you installed libc dev package? All should work fine on squeeze as we generate even packages for it. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=274#comment781 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 8 months

[tracker] Task opened: not able to compile Kamailio 3.3.4

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Julian (juquinte) Attached to Project - sip-router Summary - not able to compile Kamailio 3.3.4 Task Type - Bug Report Category - Core Status - Unconfirmed Assigned To - Operating System - Linux Severity - Medium Priority - Normal Reported Version - 3.3 Due in Version - Undecided Due Date - Undecided Details - Hi when I compile( make all) I am receive the following error resolve.h:471:4: error: #error neither gethostbyname2 or getipnodebyname present make: *** [action.o] Error 1 I am using debian squeeze, from resolve.h file it seems that is IPV6 related, maybe a header mising or compilation issue More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=274 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 8 months

[tracker] Task opened: rtpproxy module: rtpproxy_manage(flags, ip) puts garbage into SDP (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Markus Bucher (MarkCDSys) Attached to Project - sip-router Summary - rtpproxy module: rtpproxy_manage(flags, ip) puts garbage into SDP Task Type - Bug Report Category - Module Status - Unconfirmed Assigned To - Operating System - All Severity - High Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - Hi, I tried to use rtpproxy_manage() specifying flags and an IP, but the command seemed to have put binary data into the SDP instead of the specified IP, thus corrupting the SDP-data. I found that rtpproxy_manage() processes it's parameters differently than rtpproxy_offer() does. Is this intended? Anyway, using parameter conversion the way rtpproxy_offer() does (which actually means doing none at all) seems to fix the issue (see attached patch). I do not have much experience with the parameter procession of kamailio, so I do not know if my patch opens any memory leaks or other problems. So please take a closer look at the section. Best Regards, Markus One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=273 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 8 months

git:jason.penton/ims_ro_interface: modules/ims_ro: cleanup and fixes

by Jason Penton

Module: sip-router Branch: jason.penton/ims_ro_interface Commit: 42fcc68916d9f76b85dedd09cebf0f21c69f7ab8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=42fcc68… Author: Jason Penton <jason.penton(a)smilecoms.com> Committer: Jason Penton <jason.penton(a)smilecoms.com> Date: Fri Mar 1 15:18:03 2013 +0200 modules/ims_ro: cleanup and fixes --- modules/ims_ro/Ro_data.c | 41 +----------- modules/ims_ro/Ro_data.h | 19 ------ modules/ims_ro/ccr.c | 119 +++++++++++++++-------------------- modules/ims_ro/config.h | 68 +------------------- modules/ims_ro/diameter_ro.c | 54 ---------------- modules/ims_ro/diameter_ro.h | 55 ---------------- modules/ims_ro/ims_ro.c | 143 +++++++++++++----------------------------- modules/ims_ro/ims_ro.h | 55 ---------------- modules/ims_ro/mod.c | 118 +++++++++++++++++++++++++--------- 9 files changed, 187 insertions(+), 485 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=42f…

11 years, 8 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2013