sr-dev April 2013

sr-dev@lists.kamailio.org

38 participants
401 discussions

git:master: Makefile.groups: proper fixing of all modules list
by Daniel-Constantin Mierla 21 Apr '13

21 Apr '13

Module: sip-router Branch: master Commit: 325aa35f76f7727abe010b03a0dd03b5f487e26a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=325aa35… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Apr 21 13:38:30 2013 +0200 Makefile.groups: proper fixing of all modules list - reported by Vicente Hernando --- Makefile.groups | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.groups b/Makefile.groups index 79fff6d..ff2aa57 100644 --- a/Makefile.groups +++ b/Makefile.groups @@ -172,7 +172,7 @@ mod_list_all=$(sort $(mod_list_basic) $(mod_list_extra) \ $(mod_list_iptrtpproxy) $(mod_list_mi_xmlrpc) \ $(mod_list_outbound) $(mod_list_osp) \ $(mod_list_java) $(mod_list_stun) \ - $(mod_list_dnssec) + $(mod_list_dnssec))

1 0

git:master: Makefile.groups: fixed typo
by Daniel-Constantin Mierla 21 Apr '13

21 Apr '13

Module: sip-router Branch: master Commit: edd7f8ed5b8b893276c86bb054e6f7523ad69f33 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=edd7f8e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Apr 19 22:50:26 2013 +0200 Makefile.groups: fixed typo --- Makefile.groups | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.groups b/Makefile.groups index 7808e65..6aa8ac4 100644 --- a/Makefile.groups +++ b/Makefile.groups @@ -172,7 +172,7 @@ mod_list_all=$(sort $(mod_list_basic) $(mod_list_extra) \ $(mod_list_iptrtpproxy) $(mod_list_mi_xmlrpc) \ $(mod_list_outbound) $(mod_list_osp) \ $(mod_list_java) $(mod_list_stun)) \ - $(mod_list_dnssec)) + $(mod_list_dnssec)

2 2

git:master: Makefile.groups: fixed another type of double parenthesis
by Daniel-Constantin Mierla 21 Apr '13

21 Apr '13

Module: sip-router Branch: master Commit: fc80791c65fa46389168bd5e16af6b33c1bbc36c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fc80791… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Apr 21 13:09:43 2013 +0200 Makefile.groups: fixed another type of double parenthesis - reported by Vicente Hernando --- Makefile.groups | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.groups b/Makefile.groups index 6aa8ac4..79fff6d 100644 --- a/Makefile.groups +++ b/Makefile.groups @@ -171,7 +171,7 @@ mod_list_all=$(sort $(mod_list_basic) $(mod_list_extra) \ $(mod_list_cassandra) $(mod_list_oracle) \ $(mod_list_iptrtpproxy) $(mod_list_mi_xmlrpc) \ $(mod_list_outbound) $(mod_list_osp) \ - $(mod_list_java) $(mod_list_stun)) \ + $(mod_list_java) $(mod_list_stun) \ $(mod_list_dnssec)

1 0

DNSsec in 4.0
by Olle E. Johansson 19 Apr '13

19 Apr '13

Hi! I checked out 4.0 and got the dnssec module. I did not expect a new module in that release, only in trunk. /O

1 1

outbound rfc question
by Juha Heinanen 19 Apr '13

19 Apr '13

in section 4.3. Sending Non-REGISTER Requests of outbound rfc 5626: If the UAC is using a Globally Routable UA URI (GRUU) [RFC5627] that was instantiated using a Contact header field value that included an "ob" parameter, the UAC sends the request over the flow used for registration, and subsequent requests will arrive over that same flow. what does 'that was instantiated using a Contact header field value that included an "ob" parameter' mean? which request the referred Contact header belongs to? -- juha

1 0

git:master: modules/rr: if outbound request is outgoing, do nothing outbound
by Juha Heinanen 19 Apr '13

19 Apr '13

Module: sip-router Branch: master Commit: 752de05cc567c7502b1e723a09e350ce8d447664 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=752de05… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Fri Apr 19 13:24:52 2013 +0300 modules/rr: if outbound request is outgoing, do nothing outbound specific in loose_route() --- modules/rr/loose.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/modules/rr/loose.c b/modules/rr/loose.c index 71f2465..e1d0571 100644 --- a/modules/rr/loose.c +++ b/modules/rr/loose.c @@ -550,7 +550,11 @@ static inline int process_outbound(struct sip_msg *_m, str flow_token, rcv->src_ip.af == AF_INET6 ? "]" : "", rcv->src_port, get_proto_name(rcv->proto)); - } + } else { + LM_DBG("outbound \"outgoing\" request found - " + "Not using flow-token for routing\n"); + return 0; + } return 1; } @@ -787,6 +791,8 @@ static inline int after_loose(struct sip_msg* _m, int preloaded) return FLOW_TOKEN_BROKEN; } + LM_DBG("process_outbound returned <%d>\n", use_ob); + /* IF the URI was added by me, remove it */ if (uri_is_myself>0) {

2 7

git:master: modules/outbound: downgraded one INFO to DGB
by Juha Heinanen 19 Apr '13

19 Apr '13

Module: sip-router Branch: master Commit: ea964748dc638af82d2363317ca2eade98a279ac URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ea96474… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Fri Apr 19 17:39:05 2013 +0300 modules/outbound: downgraded one INFO to DGB --- modules/outbound/ob_mod.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/outbound/ob_mod.c b/modules/outbound/ob_mod.c index 5f2a708..69ac1e0 100644 --- a/modules/outbound/ob_mod.c +++ b/modules/outbound/ob_mod.c @@ -327,7 +327,7 @@ static int use_outbound_non_reg(struct sip_msg *msg) /* Check if Supported: outbound is included */ if (parse_supported(msg) == 0) { if (!(get_supported(msg) & F_OPTION_TAG_OUTBOUND)) { - LM_INFO("outbound is not supported and thus not used\n"); + LM_DBG("outbound is not supported and thus not used\n"); return 0; } }

1 0

git:master: modules/outbound: for non-reg requests, check if outbound is supported
by Juha Heinanen 19 Apr '13

19 Apr '13

Module: sip-router Branch: master Commit: 7a96d912032939b8eb108e0e84b70bbf0642e2ab URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7a96d91… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Fri Apr 19 17:36:27 2013 +0300 modules/outbound: for non-reg requests, check if outbound is supported 4.3. Sending Non-REGISTER Requests ... UAs that support this specification SHOULD include the outbound option tag in a Supported header field in a request that is not a REGISTER request. --- modules/outbound/ob_mod.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/modules/outbound/ob_mod.c b/modules/outbound/ob_mod.c index 25edf15..5f2a708 100644 --- a/modules/outbound/ob_mod.c +++ b/modules/outbound/ob_mod.c @@ -35,6 +35,7 @@ #include "../../parser/contact/parse_contact.h" #include "../../parser/parse_rr.h" #include "../../parser/parse_uri.h" +#include "../../parser/parse_supported.h" #include "api.h" #include "config.h" @@ -323,6 +324,14 @@ static int use_outbound_non_reg(struct sip_msg *msg) int ret; struct receive_info *rcv = NULL; + /* Check if Supported: outbound is included */ + if (parse_supported(msg) == 0) { + if (!(get_supported(msg) & F_OPTION_TAG_OUTBOUND)) { + LM_INFO("outbound is not supported and thus not used\n"); + return 0; + } + } + /* Check to see if the top Route-URI is me and has a ;ob parameter */ if (msg->route || (parse_headers(msg, HDR_ROUTE_F, 0) != -1 && msg->route))

1 0

git:3.2: rr: use port. len to check for buffer overflow instead of max port len
by Henning Westerholt 19 Apr '13

19 Apr '13

Module: sip-router Branch: 3.2 Commit: 91d231b85aea2d118f779de1310b623c1e79352b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=91d231b… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: Fri Apr 19 11:01:56 2013 +0200 rr: use port.len to check for buffer overflow instead of max port len - reported by Kevin Wojtysiak (from commit 28a8b87885e373bee8cc81985277ae718973fdfd) --- modules_k/rr/loose.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules_k/rr/loose.c b/modules_k/rr/loose.c index 16cab74..3f19cc7 100644 --- a/modules_k/rr/loose.c +++ b/modules_k/rr/loose.c @@ -363,7 +363,7 @@ static inline int get_maddr_uri(str *uri, struct sip_uri *puri) return 0; /* sip: + maddr + : + port */ - if( (puri->maddr_val.len) > (127 - 10) ) + if( (puri->maddr_val.len) > (127 - 6 - puri->port.len) ) { LM_ERR( "Too long maddr parameter\n"); return RR_ERROR;

1 0

git:3.2: parser: safety check for max port length in URI
by Henning Westerholt 19 Apr '13

19 Apr '13

Module: sip-router Branch: 3.2 Commit: fbd0339f916ed46c634a4212e3b8e18607ec3ebe URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fbd0339… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Henning Westerholt <hw(a)kamailio.org> Date: Tue Apr 9 00:18:35 2013 +0200 parser: safety check for max port length in URI - can't be longer than 5, a port being 16b value - reported by Kevin Wojtysiak (cherry picked from commit 13fd48f89555f5421e8285669e303bcefe44f149) --- parser/parse_uri.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/parser/parse_uri.c b/parser/parse_uri.c index affe44f..2cea1d1 100644 --- a/parser/parse_uri.c +++ b/parser/parse_uri.c @@ -1145,6 +1145,10 @@ int parse_uri(char* buf, int len, struct sip_uri* uri) goto error_bad_uri; break; /* do nothing, avoids a compilation warning */ } + + if(uri->port.len>5) + goto error_invalid_port; + #ifdef EXTRA_DEBUG /* do stuff */ DBG("parsed uri:\n type=%d user=<%.*s>(%d)\n passwd=<%.*s>(%d)\n" @@ -1208,6 +1212,10 @@ error_bad_port: *p, state, (int)(p-buf), ZSW(buf), (int)(p-buf), len, ZSW(buf), len); goto error_exit; +error_invalid_port: + DBG("parse_uri: bad port in uri: [%.*s] in <%.*s>\n", + uri->port.len, uri->port.s, len, ZSW(buf)); + goto error_exit; error_bad_uri: DBG("parse_uri: bad uri, state %d" " parsed: <%.*s> (%d) / <%.*s> (%d)\n",

1 0

← Newer
1
...
15
16
17
18
19
20
21
...
41
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2013