sr-dev April 2013

sr-dev@lists.kamailio.org

38 participants
402 discussions

[tracker] Comment added: usrloc: Add missing RPC commands (Attachment added)
by sip-router 30 Apr '13

30 Apr '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#290 - usrloc: Add missing RPC commands User who did this - Víctor Seva (linuxmaniac) ---------- Fix q param type on ul.add RPC command. Thanks Juha Heinanen <jh(a)tutpro.com> ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=290#comment864 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

2 1

[tracker] Task opened: usrloc: Add missing RPC commands (Attachment added)
by sip-router 30 Apr '13

30 Apr '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Víctor Seva (linuxmaniac) Attached to Project - sip-router Summary - usrloc: Add missing RPC commands Task Type - Improvement Category - usrloc (k) Status - Unconfirmed Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - Added commands: - ul.rm - ul.rm_contact - ul.flush - ul.add One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=290 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

3 6

[tracker] Comment added: Dialog bugs
by sip-router 30 Apr '13

30 Apr '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#282 - Dialog bugs User who did this - Eduardo Lejarreta (lejarreta.e) ---------- Good evening Daniel. I've been busy these days. Our version is dialog 3.2 which has the same problem to 3.3 http://kamailio.org/docs/modules/3.2.x/modules_k/dialog.html#id2555392 -> search for $dlg_ctx(timeout_bye) = 1; (kamailio.cfg) These flag is in dlg_hash.h: ----> #define DLG_FLAG_TOBYE (1<<3) /*!< flag from dialog context */ We use this flag on kamailio.cfg on authenticated INVITEs route to "flag" contextually these dialogs to be finished when dialog timeout occurs. On ther other hand, talking about dialog_ng and dialog Kamailio 4. When we started this issue there was not dialog_ng nor dialog 4 because kamailio 4 wasn't released. I should test these new modules but in a fast "dialog 4" check (not dialog_ng) I'm still finding dlg_handlers.c error. On dlg_db_handler.c it seems that dlg->lifetime has been corrected and there are new data loaded from DB as sflags and iflags (I should check for this but I've to find a gap, may be on May month) Best regards. Eduardo Lejarreta. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=282#comment863 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: data_lump return a comment back to it's owner
by Torrey Searle 30 Apr '13

30 Apr '13

Module: sip-router Branch: master Commit: 878b343f374a62d7ea5ebe5e85b00c391956b623 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=878b343… Author: Torrey Searle <tsearle(a)gmail.com> Committer: Torrey Searle <tsearle(a)gmail.com> Date: Tue Apr 30 12:01:00 2013 +0200 data_lump return a comment back to it's owner --- data_lump.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/data_lump.h b/data_lump.h index 88a1f0d..d4b24f0 100644 --- a/data_lump.h +++ b/data_lump.h @@ -75,11 +75,11 @@ struct lump* insert_cond_lump_after(struct lump* after, enum lump_conditions c, struct lump* insert_cond_lump_before(struct lump* after, enum lump_conditions c, enum _hdr_types_t type); -/*! \brief removes an already existing header */ /* set an anchor if there is no existing one at the given offset, * otherwise return the existing anchor */ struct lump* anchor_lump2(struct sip_msg* msg, int offset, int len, enum _hdr_types_t type, int *is_ref); +/*! \brief removes an already existing header */ struct lump* del_lump(struct sip_msg* msg, int offset, int len, enum _hdr_types_t type); /*! \brief set an anchor */ struct lump* anchor_lump(struct sip_msg* msg, int offset, int len, enum _hdr_types_t type);

1 0

del_lump comment got separated from it's method
by Torrey Searle 30 Apr '13

30 Apr '13

I was looking at data_lump.h and one of the comments was seeming contradictory and then I realized that the for del_lump got separated from it's comment when the function "anchor_lump2" got added. Attached is a patch to move the comment back to it's rightful owner. Let me guys know if you think it's ok.

2 1

git:richard.good/diameter_rx_media: modules/ims_qos: Use new TM suspend for Rx calling
by Richard Good 30 Apr '13

30 Apr '13

Module: sip-router Branch: richard.good/diameter_rx_media Commit: 331bc6077ef98e79b237a6069ed2dfe5a0a97710 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=331bc60… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Tue Apr 30 11:44:54 2013 +0200 modules/ims_qos: Use new TM suspend for Rx calling Updating Rx calling to use the TM functions (in tm_async_reply_support branch) to suspend and continue on SIP replies. --- modules/ims_qos/mod.c | 12 ++++++++++-- modules/ims_qos/rx_aar.c | 2 +- modules/ims_qos/rx_aar.h | 1 + 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/modules/ims_qos/mod.c b/modules/ims_qos/mod.c index 46a5e9e..52d661b 100644 --- a/modules/ims_qos/mod.c +++ b/modules/ims_qos/mod.c @@ -505,6 +505,14 @@ static int w_rx_aar(struct sip_msg *msg, char* str1, char* bar) { memcpy(saved_t_data->ftag.s, ftag.s, ftag.len); saved_t_data->ftag.len = ftag.len; + //store branch + int branch; + if (tmb.t_check( msg , &branch )==-1){ + LOG(L_ERR, "ERROR: t_suspend: failed find UAC branch\n"); + return CSCF_RETURN_ERROR; + } + saved_t_data->branch = branch; + //Check that we dont already have an auth session for this specific dialog //if not we create a new one and attach it to the dialog (via session ID). enum dialog_direction dlg_direction = get_dialog_direction(direction); @@ -553,7 +561,7 @@ static int w_rx_aar(struct sip_msg *msg, char* str1, char* bar) { } LM_DBG("Suspending SIP TM transaction\n"); - if (tmb.t_suspend(msg, &saved_t_data->tindex, &saved_t_data->tlabel) < 0) { + if (tmb.t_suspend_reply(msg, &saved_t_data->tindex, &saved_t_data->tlabel) < 0) { LM_ERR("failed to suspend the TM processing\n"); free_saved_transaction_global_data(saved_t_data); return CSCF_RETURN_ERROR; @@ -564,7 +572,7 @@ static int w_rx_aar(struct sip_msg *msg, char* str1, char* bar) { if (!ret) { LM_ERR("Failed to send AAR\n"); - tmb.t_cancel_suspend(saved_t_data->tindex, saved_t_data->tlabel); + tmb.t_cancel_suspend_reply(saved_t_data->tindex, saved_t_data->tlabel, saved_t_data->branch); goto error; diff --git a/modules/ims_qos/rx_aar.c b/modules/ims_qos/rx_aar.c index f80fc00..ad8db69 100644 --- a/modules/ims_qos/rx_aar.c +++ b/modules/ims_qos/rx_aar.c @@ -165,7 +165,7 @@ done: if (aaa) cdpb.AAAFreeMessage(&aaa); - tmb.t_continue(data->tindex, data->tlabel, data->act); + tmb.t_continue_reply(data->tindex, data->tlabel, data->act, data->branch); free_saved_transaction_global_data(data); } diff --git a/modules/ims_qos/rx_aar.h b/modules/ims_qos/rx_aar.h index b578db5..f986ce5 100644 --- a/modules/ims_qos/rx_aar.h +++ b/modules/ims_qos/rx_aar.h @@ -82,6 +82,7 @@ typedef struct saved_transaction { str callid; str ftag; str ttag; + int branch; } saved_transaction_t; typedef struct saved_transaction_local {

1 0

git:tmp/tm_async_reply_support: modules/tm: added separate methods to suspend reply
by Richard Good 30 Apr '13

30 Apr '13

Module: sip-router Branch: tmp/tm_async_reply_support Commit: 3104e2d1a13a3728f1c71912bf223dc2097b8e24 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3104e2d… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Tue Apr 30 11:40:25 2013 +0200 modules/tm:added separate methods to suspend reply Added separate method t_suspend_reply, t_cancel_suspend_reply, t_continue_reply and exposed them through TM API. This leaves existing TM suspend/continue functionality unchanged. --- modules/tm/h_table.h | 5 +- modules/tm/t_suspend.c | 465 +++++++++++++++++++++++++----------------------- modules/tm/t_suspend.h | 15 ++ modules/tm/tm_load.c | 3 + modules/tm/tm_load.h | 3 + 5 files changed, 262 insertions(+), 229 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=310…

1 0

git:master: modules/websocket: fixed mandatory headers check
by Peter Dunkley 29 Apr '13

29 Apr '13

Module: sip-router Branch: master Commit: 8f74c57605fdd1d31c7808a3b8afc79cc981b370 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8f74c57… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Mon Apr 29 20:54:52 2013 +0100 modules/websocket: fixed mandatory headers check --- modules/websocket/ws_handshake.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules/websocket/ws_handshake.c b/modules/websocket/ws_handshake.c index 40dfbb3..a719919 100644 --- a/modules/websocket/ws_handshake.c +++ b/modules/websocket/ws_handshake.c @@ -306,7 +306,8 @@ int ws_handle_handshake(struct sip_msg *msg) /* Final check that all required headers/values were found */ sub_protocol &= ws_sub_protocols; - if (hdr_flags != REQUIRED_HEADERS || sub_protocol == 0) + if ((hdr_flags & REQUIRED_HEADERS) != REQUIRED_HEADERS + || sub_protocol == 0) { LM_WARN("required headers not present\n");

1 0

git:master: modules/websocket: doubled the size of the buffer for adding headers to WebSocket handshake responses
by Peter Dunkley 29 Apr '13

29 Apr '13

Module: sip-router Branch: master Commit: a2e7f65ee8b86d37a6772619ae10087a05219192 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a2e7f65… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Mon Apr 29 20:38:06 2013 +0100 modules/websocket: doubled the size of the buffer for adding headers to WebSocket handshake responses --- modules/websocket/ws_handshake.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/websocket/ws_handshake.c b/modules/websocket/ws_handshake.c index d43c9e9..40dfbb3 100644 --- a/modules/websocket/ws_handshake.c +++ b/modules/websocket/ws_handshake.c @@ -86,7 +86,7 @@ static str str_status_upgrade_required = str_init("Upgrade Required"); static str str_status_internal_server_error = str_init("Internal Server Error"); static str str_status_service_unavailable = str_init("Service Unavailable"); -#define HDR_BUF_LEN (256) +#define HDR_BUF_LEN (512) static char headers_buf[HDR_BUF_LEN]; static char key_buf[base64_enc_len(SHA_DIGEST_LENGTH)];

1 0

git:master: websocket: added "cors_mode" parameter to enable " Cross-origin resource sharing" on WebSocket handshakes
by Peter Dunkley 29 Apr '13

29 Apr '13

Module: sip-router Branch: master Commit: 3d5c66997e77ae4f4c181e5a77c943156a7db00a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3d5c669… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Committer: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Mon Apr 29 20:34:36 2013 +0100 websocket: added "cors_mode" parameter to enable "Cross-origin resource sharing" on WebSocket handshakes - I don't know of any WebSocket clients that require this (yet). But having it in there won't break anything. --- modules/websocket/README | 137 +++++++++++++++++------------ modules/websocket/doc/websocket_admin.xml | 36 ++++++++ modules/websocket/ws_handshake.c | 43 +++++++++- modules/websocket/ws_handshake.h | 5 + modules/websocket/ws_mod.c | 11 ++- 5 files changed, 171 insertions(+), 61 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=3d5…

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2013