sr-dev May 2013

sr-dev@lists.kamailio.org

29 participants
317 discussions

Outbound flow failure handling merged to master

by Hugh Waite

Hello, As you will see I have merged my branch back into master. These changes add a new event route [tm:branch-failure] to the tm module which is run when any failure response is received on a transaction. The event_route uses a new route type BRANCH_ROUTE which limits the functions that can be run in the route. The functions t_check_status(), t_next_contact_flow(), t_relay() and unregister() can be used in this route. A new pv $T_reply_ruid is accessible in this route which can be used to unregister a single contact entry. The following example route can be used on a registrar to handle failed or invalid flows: event_route[tm:branch-failure] { xlog("L_INFO", "event_route[tm:branch-failure]\n"); if (t_check_status("430|403")) { if (!unregister("location", "$tu", "$T_reply_ruid")) { xlog("L_WARN", "failed to unregister $tu with ruid $T_reply_ruid\n"); } if (!t_next_contact_flow()) { xlog("L_INFO", "No more flows\n"); } else { xlog("L_INFO", "Next flow\n"); t_relay(); } } } Any bugs, memory leaks etc. let me know! Hugh -- Hugh Waite Principal Design Engineer Crocodile RCS Ltd.

8 years, 1 month

Using t_suspend()/t_continue() multiple times on the same transaction

by Peter Dunkley

Hi, I am trying to use t_suspend()/t_continue() multiple times on the same transaction. Calling t_suspend() more than once works, but the second time I call t_continue() the transaction is killed and a 500 response is sent. It is the "if (branch == t->nr_of_outgoings)" check from the code fragment below (from t_suspend.c:t_continue()) that results in the transaction being killed - you can see the debug/error line I added to determine this in the fragment. Is using t_suspend()/t_continue() multiple times something that should work? Thanks, Peter if (t->uas.status < 200) { /* No final reply has been sent yet. * Check whether or not there is any pending branch. */ for ( branch = 0; branch < t->nr_of_outgoings; branch++ ) { if ((t->uac[branch].request.buffer != NULL) && (t->uac[branch].last_received < 200) ) break; } if (branch == t->nr_of_outgoings) { /* There is not any open branch so there is * no chance that a final response will be received. */ ret = 0; LM_ERR("branch == t->nr_of_outgoings\n"); goto kill_trans; } } -- Peter Dunkley Technical Director Crocodile RCS Ltd

10 years, 6 months

default config: do loose_route() for in-dialog NOTIFY as per new RFC 6665

by Iñaki Baz Castillo

Hi, the new RFC 6665 mandates that the subscription dialog is made *after* the first NOTIFY from the UAS (rather than after the 200 to the initial SUBSCRIBE). This means that the UAC MUST take the route set from the *first* received NOTIFY (instead of taking it from the 200 to the initial SUBSCRIBE). Therefore a proxy compliant with RFC 6665 MUST always add RR to in-dialog NOTIFY requests and thus, I propose that the default SR script file implements it. Regards. -- Iñaki Baz Castillo <ibc(a)aliax.net>

10 years, 10 months

json and jsonrpc-c modules

by Matthew Williams

Hi, The Flowroute development team is pleased to announce a complete overhaul of the json and jsonrpc-c modules, originally authored two years ago. Credit should first and foremost go to Joe Hillenbrand who did most of the new development. Jordan Levy (our CTO) and I were also involved in the updates and QA to a lesser extent. The updated modules are available in the mgw/json branch. In addition to the Kamailio modules, we have developed a Twisted Python library to complement the jsonrpc-c module: https://github.com/flowroute/txjason We would be interested in any critiques of the API, documentation, and code. Please let us know if you use these modules and especially if you find any bugs. We hope to merge this into master once we have had it in production for awhile and (ideally) have received some feedback from other users. Feel free to contact either Joe (joe(a)flowroute.com) or me directly with any questions or comments. -- Matthew Williams Flowroute LLC http://www.flowroute.com/

11 years, 3 months

t_suspend and t_continue in tm module

by Richard Good

Hi We are using the t_suspend and t_continue functionality to asynchronously send Diameter messages. This works nicely when we suspend and resume on a SIP request. However in some circumstances we want to send a Diameter message on a SIP response. I have found that the SIP responses continue to be relayed despite being suspended and returning 0 to the cfg file. I am investigating the cause but before I get any deeper does anyone know if the t_suspend and t_continue functionality in the tm module can be used on a SIP response? Regards Richard. This email is subject to the disclaimer of Smile Communications (PTY) Ltd. at http://www.smilecoms.com/disclaimer

11 years, 5 months

git:master: modules_k/uac: uac_replace_from/to AUTO mode with dialog module

by Anca Vamanu

Module: sip-router Branch: master Commit: 0f702f6e236eb0cbb238bf83a0c4ae94d7b3cad8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=0f702f6… Author: Anca Vamanu <anca.vamanu(a)1and1.ro> Committer: Anca Vamanu <anca.vamanu(a)1and1.ro> Date: Thu Jul 19 17:49:13 2012 +0300 modules_k/uac: uac_replace_from/to AUTO mode with dialog module Added a implementation for uac_replace_from/to() that uses the dialog module for AUTO mode. In this mode the URIs are stored as dialog variables. The change in tm module fixes a bug: if uac_replace_to() was called, the URI was not changed accordingly in Cancel. --- modules/tm/t_cancel.c | 5 +- modules_k/dialog/dialog.c | 2 + modules_k/dialog/dlg_load.h | 6 + modules_k/uac/README | 111 +++++++++++----- modules_k/uac/doc/uac_admin.xml | 68 +++++++++- modules_k/uac/replace.c | 292 ++++++++++++++++++++++++++++++--------- modules_k/uac/uac.c | 17 ++- 7 files changed, 393 insertions(+), 108 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=0f7…

11 years, 6 months

git:master: DB scheme: as discussed on sr-users list, change default mysql engine to InnoDB

by Henning Westerholt

Module: sip-router Branch: master Commit: fa49fe070adadfff893b338f2a2d69776c043653 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fa49fe0… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: Wed May 29 11:49:59 2013 +0200 DB scheme: as discussed on sr-users list, change default mysql engine to InnoDB --- lib/srdb1/schema/entities.xml | 2 +- utils/kamctl/mysql/acc-create.sql | 4 ++-- utils/kamctl/mysql/alias_db-create.sql | 2 +- utils/kamctl/mysql/auth_db-create.sql | 2 +- utils/kamctl/mysql/avpops-create.sql | 2 +- utils/kamctl/mysql/carrierroute-create.sql | 8 ++++---- utils/kamctl/mysql/cpl-create.sql | 2 +- utils/kamctl/mysql/dialog-create.sql | 4 ++-- utils/kamctl/mysql/dialplan-create.sql | 2 +- utils/kamctl/mysql/dispatcher-create.sql | 2 +- utils/kamctl/mysql/domain-create.sql | 4 ++-- utils/kamctl/mysql/domainpolicy-create.sql | 2 +- utils/kamctl/mysql/drouting-create.sql | 8 ++++---- utils/kamctl/mysql/group-create.sql | 4 ++-- utils/kamctl/mysql/htable-create.sql | 2 +- utils/kamctl/mysql/imc-create.sql | 4 ++-- utils/kamctl/mysql/lcr-create.sql | 6 +++--- utils/kamctl/mysql/matrix-create.sql | 2 +- utils/kamctl/mysql/msilo-create.sql | 2 +- utils/kamctl/mysql/mtree-create.sql | 4 ++-- utils/kamctl/mysql/pdt-create.sql | 2 +- utils/kamctl/mysql/permissions-create.sql | 4 ++-- utils/kamctl/mysql/pipelimit-create.sql | 2 +- utils/kamctl/mysql/presence-create.sql | 10 +++++----- utils/kamctl/mysql/purple-create.sql | 2 +- utils/kamctl/mysql/registrar-create.sql | 2 +- utils/kamctl/mysql/rls-create.sql | 4 ++-- utils/kamctl/mysql/rtpproxy-create.sql | 2 +- utils/kamctl/mysql/sca-create.sql | 2 +- utils/kamctl/mysql/siptrace-create.sql | 2 +- utils/kamctl/mysql/speeddial-create.sql | 2 +- utils/kamctl/mysql/standard-create.sql | 2 +- utils/kamctl/mysql/uac-create.sql | 2 +- utils/kamctl/mysql/uid_auth_db-create.sql | 2 +- utils/kamctl/mysql/uid_avp_db-create.sql | 2 +- utils/kamctl/mysql/uid_domain-create.sql | 4 ++-- utils/kamctl/mysql/uid_gflags-create.sql | 2 +- utils/kamctl/mysql/uid_uri_db-create.sql | 4 ++-- utils/kamctl/mysql/uri_db-create.sql | 2 +- utils/kamctl/mysql/userblacklist-create.sql | 4 ++-- utils/kamctl/mysql/usrloc-create.sql | 4 ++-- 41 files changed, 65 insertions(+), 65 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=fa4…

11 years, 7 months

git:4.0: pua: release lock on not finding temp dialog

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.0 Commit: 3a64a12e056670766da7e49a0275c1240d6d229a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3a64a12… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri May 31 17:05:40 2013 +0200 pua: release lock on not finding temp dialog - patch by Halina Nowak (cherry picked from commit 09cc2207b265d51dcbc28279623bf9c597fa3b46) --- modules/pua/hash.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/modules/pua/hash.c b/modules/pua/hash.c index 9ad169b..e3dea99 100644 --- a/modules/pua/hash.c +++ b/modules/pua/hash.c @@ -334,8 +334,10 @@ int convert_temporary_dialog(ua_pres_t *dialog) temp_dialog = get_temporary_dialog(dialog, hash_code); if (temp_dialog) delete_htable(temp_dialog, hash_code); - else + else { + lock_release(&HashT->p_records[hash_code].lock); return -1; + } insert_htable(dialog, hash_code);

11 years, 7 months

git:master: pua: release lock on not finding temp dialog

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 09cc2207b265d51dcbc28279623bf9c597fa3b46 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=09cc220… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri May 31 17:05:40 2013 +0200 pua: release lock on not finding temp dialog - patch by Halina Nowak --- modules/pua/hash.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/modules/pua/hash.c b/modules/pua/hash.c index 9ad169b..e3dea99 100644 --- a/modules/pua/hash.c +++ b/modules/pua/hash.c @@ -334,8 +334,10 @@ int convert_temporary_dialog(ua_pres_t *dialog) temp_dialog = get_temporary_dialog(dialog, hash_code); if (temp_dialog) delete_htable(temp_dialog, hash_code); - else + else { + lock_release(&HashT->p_records[hash_code].lock); return -1; + } insert_htable(dialog, hash_code);

11 years, 7 months

[tracker] Comment added: modules/debugger: be able to log assign actions

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#299 - modules/debugger: be able to log assign actions User who did this - Daniel-Constantin Mierla (miconda) ---------- The hash table for caching in the debug module is actually an array, i haven't seen code that allows adding more than one item in a slot, but looks like is always overwriting the one in slot. Obviously, it is missing the 'next' file in item structure. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=299#comment917 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 7 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2013