sr-dev May 2013

sr-dev@lists.kamailio.org

29 participants
317 discussions

[tracker] Comment added: Incorrect outbound interface used in Via and Record-Route
by sip-router 16 May '13

16 May '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#241 - Incorrect outbound interface used in Via and Record-Route User who did this - Daniel-Constantin Mierla (miconda) ---------- Default is to use the first one -- you can enable mhomed for multiple interfaces where the outbound interface has to be selected ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=241#comment870 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: usrloc module stops updating some records in db_mode 2
by sip-router 16 May '13

16 May '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#278 - usrloc module stops updating some records in db_mode 2 User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=278 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: UAC generates messages with a NULL body which failes in SANITY module check
by sip-router 16 May '13

16 May '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#295 - UAC generates messages with a NULL body which failes in SANITY module check User who did this - Daniel-Constantin Mierla (miconda) ---------- Looked a bit over the code and should not set any message body in this case. Can you paste such message to see exactly how it looks? ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=295#comment869 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task changed: force_send_socket() doesnt set the source IP address reliably when using uac_req_send()
by sip-router 16 May '13

16 May '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#294 - force_send_socket() doesnt set the source IP address reliably when using uac_req_send() User who did this: Daniel-Constantin Mierla (miconda) Task Type: Bug Report -> Improvement More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=294 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: force_send_socket() doesnt set the source IP address reliably when using uac_req_send()
by sip-router 16 May '13

16 May '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#294 - force_send_socket() doesnt set the source IP address reliably when using uac_req_send() User who did this - Daniel-Constantin Mierla (miconda) ---------- force_send_socket() sets the socket in the current SIP message structure, but uac_req() creates a completely new one. This is more an enhancement, requiring to add something like $uac_req(send_socket) ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=294#comment868 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: modules/usrloc: ul.dump RPC command doesn't dump the right q value
by sip-router 16 May '13

16 May '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#291 - modules/usrloc: ul.dump RPC command doesn't dump the right q value User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Fixed Additional comments about closing: Patch applied. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=291 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: usrloc: use 6th param on add function to set the contact path
by sip-router 16 May '13

16 May '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#292 - usrloc: use 6th param on add function to set the contact path User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented Additional comments about closing: Applied. Don't forget to add a note about it in wiki at: http://www.kamailio.org/wiki/features/new-in-devel More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=292 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: utils/kamctl: add contact path parameter
by sip-router 16 May '13

16 May '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#293 - utils/kamctl: add contact path parameter User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Implemented Additional comments about closing: Applied. Don't forget to add a note about it in the wiki: http://www.kamailio.org/wiki/features/new-in-devel More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=293 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: modules/usrloc: use 6th param to set the contact path
by Daniel-Constantin Mierla 16 May '13

16 May '13

Module: sip-router Branch: master Commit: ad0e5daa8865024440ea37a9e978eeeb7577602f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ad0e5da… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu May 2 18:30:50 2013 +0200 modules/usrloc: use 6th param to set the contact path --- modules/usrloc/README | 4 ++-- modules/usrloc/doc/usrloc_admin.xml | 6 ++---- modules/usrloc/ul_mi.c | 8 +++++--- modules/usrloc/ul_rpc.c | 23 +++++++++++++++-------- 4 files changed, 24 insertions(+), 17 deletions(-) diff --git a/modules/usrloc/README b/modules/usrloc/README index 4b8daeb..05b8535 100644 --- a/modules/usrloc/README +++ b/modules/usrloc/README @@ -814,7 +814,7 @@ modparam("usrloc", "db_ops_ruid", 1) * contact - contact string to be added * expires - expires value of the contact * Q - Q value of the contact - * unused - unused attribute (kept for backword compatibility) + * path value of the contact * flags - internal USRLOC flags of the contact * cflags - per branch flags of the contact * methods - mask with supported requests of the contact @@ -887,7 +887,7 @@ modparam("usrloc", "db_ops_ruid", 1) * contact - contact string to be added * expires - expires value of the contact * Q - Q value of the contact - * unused - unused attribute (kept for backword compatibility) + * path value of the contact * flags - internal USRLOC flags of the contact * cflags - per branch flags of the contact * methods - mask with supported requests of the contact diff --git a/modules/usrloc/doc/usrloc_admin.xml b/modules/usrloc/doc/usrloc_admin.xml index 0a8b15f..78be5e8 100644 --- a/modules/usrloc/doc/usrloc_admin.xml +++ b/modules/usrloc/doc/usrloc_admin.xml @@ -986,8 +986,7 @@ modparam("usrloc", "db_ops_ruid", 1) <emphasis>Q</emphasis> - Q value of the contact </para></listitem> <listitem><para> - <emphasis>unused</emphasis> - unused attribute (kept for - backword compatibility) + <emphasis>path</emphasis> value of the contact </para></listitem> <listitem><para> <emphasis>flags</emphasis> - internal USRLOC flags of the @@ -1142,8 +1141,7 @@ modparam("usrloc", "db_ops_ruid", 1) <emphasis>Q</emphasis> - Q value of the contact </para></listitem> <listitem><para> - <emphasis>unused</emphasis> - unused attribute (kept for - backword compatibility) + <emphasis>path</emphasis> value of the contact </para></listitem> <listitem><para> <emphasis>flags</emphasis> - internal USRLOC flags of the diff --git a/modules/usrloc/ul_mi.c b/modules/usrloc/ul_mi.c index 3f88a71..3e12bf1 100644 --- a/modules/usrloc/ul_mi.c +++ b/modules/usrloc/ul_mi.c @@ -491,8 +491,8 @@ struct mi_root* mi_usrloc_flush(struct mi_root *cmd, void *param) * \brief Add a new contact for an address of record * \param cmd mi_root containing the parameter * \param param not used - * \note Expects 7 nodes: table name, AOR, contact, expires, Q, - * useless - backward compatible, flags, cflags, methods + * \note Expects 9 nodes: table name, AOR, contact, expires, Q, + * path, flags, cflags, methods * \return mi_root with the result */ struct mi_root* mi_usrloc_add(struct mi_root *cmd, void *param) @@ -540,8 +540,10 @@ struct mi_root* mi_usrloc_add(struct mi_root *cmd, void *param) if (str2q( &ci.q, node->value.s, node->value.len) < 0) goto bad_syntax; - /* unused value (param 6) FIXME */ + /* path value (param 6) */ node = node->next; + if(strncmp(node->value.s, "0", 1) != 0 && node->value.len > 1) + ci.path = &node->value; /* flags value (param 7) */ node = node->next; diff --git a/modules/usrloc/ul_rpc.c b/modules/usrloc/ul_rpc.c index f21bbbf..7c10584 100644 --- a/modules/usrloc/ul_rpc.c +++ b/modules/usrloc/ul_rpc.c @@ -524,14 +524,15 @@ static const char* ul_rpc_flush_doc[2] = { /*! * \brief Add a new contact for an address of record * \note Expects 9 parameters: table name, AOR, contact, expires, Q, - * useless - backward compatible, flags, cflags, methods + * path, flags, cflags, methods */ static void ul_rpc_add(rpc_t* rpc, void* ctx) { str table = {0, 0}; str aor = {0, 0}; str contact = {0, 0}; - str useless = {0, 0}; + str path = {0, 0}; + str temp = {0, 0}; double dtemp; ucontact_info_t ci; urecord_t* r; @@ -541,18 +542,24 @@ static void ul_rpc_add(rpc_t* rpc, void* ctx) memset( &ci, 0, sizeof(ucontact_info_t)); - ret = rpc->scan(ctx, "SSSdf.Sddd", &table, &aor, &contact, &ci.expires, - &dtemp, &useless, &ci.flags, &ci.cflags, &ci.methods); - LM_DBG("ret: %d table:%.*s aor:%.*s contact:%.*s expires:%d dtemp:%f useless:%.*s flags:%d bflags:%d methods:%d\n", + ret = rpc->scan(ctx, "SSSdfSddd", &table, &aor, &contact, &ci.expires, + &dtemp, &path, &ci.flags, &ci.cflags, &ci.methods); + if(path.len==1 && (strncmp(temp.s, "0", 1)==0)) { + LM_DBG("path == 0 -> unset\n"); + } + else { + ci.path = &path; + } + LM_DBG("ret: %d table:%.*s aor:%.*s contact:%.*s expires:%d dtemp:%f path:%.*s flags:%d bflags:%d methods:%d\n", ret, table.len, table.s, aor.len, aor.s, contact.len, contact.s, - (int) ci.expires, dtemp, useless.len, useless.s, ci.flags, ci.cflags, (int) ci.methods); + (int) ci.expires, dtemp, ci.path->len, ci.path->s, ci.flags, ci.cflags, (int) ci.methods); if ( ret != 9) { rpc->fault(ctx, 500, "Not enough parameters or wrong format"); return; } ci.q = double2q(dtemp); - useless.s = q2str(ci.q, (unsigned int*)&useless.len); - LM_DBG("q:%.*s\n", useless.len, useless.s); + temp.s = q2str(ci.q, (unsigned int*)&temp.len); + LM_DBG("q:%.*s\n", temp.len, temp.s); /* look for table */ dom = rpc_find_domain( &table ); if (dom == NULL) {

1 0

git:master: utils/kamctl: Add contact path parameter
by Daniel-Constantin Mierla 16 May '13

16 May '13

Module: sip-router Branch: master Commit: a4fb559b5634f91259bb96af991c5574719e6871 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a4fb559… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri May 3 09:21:04 2013 +0200 utils/kamctl: Add contact path parameter --- utils/kamctl/kamctl | 9 ++++++++- utils/kamctl/kamctl.8 | 3 +++ utils/kamctl/kamctl.ctlbase | 11 ++++++----- 3 files changed, 17 insertions(+), 6 deletions(-) diff --git a/utils/kamctl/kamctl b/utils/kamctl/kamctl index 9e6b0ba..01c99c9 100755 --- a/utils/kamctl/kamctl +++ b/utils/kamctl/kamctl @@ -2281,10 +2281,17 @@ usrloc() { UL_EXPIRES=0 UL_FLAGS=0 BR_FLAGS=0 + UL_PATH=0 elif [ $# -eq 4 ] ; then UL_EXPIRES=$4 UL_FLAGS=0 BR_FLAGS=0 + UL_PATH=0 + elif [ $# -eq 5 ] ; then + UL_EXPIRES=$4 + UL_FLAGS=0 + BR_FLAGS=0 + UL_PATH="$5" else usage_usrloc exit 1 @@ -2317,7 +2324,7 @@ usrloc() { fi $CTLCMD ul_add "$USRLOC_TABLE" "$OSERUSER@$OSERDOMAIN" "$2" \ -"$UL_EXPIRES" "1.00" "0" "$UL_FLAGS" "$BR_FLAGS" "$ALL_METHODS" +"$UL_EXPIRES" "1.00" "$UL_PATH" "$UL_FLAGS" "$BR_FLAGS" "$ALL_METHODS" exit $? ;; rm) diff --git a/utils/kamctl/kamctl.8 b/utils/kamctl/kamctl.8 index 61fc55f..83db5d7 100644 --- a/utils/kamctl/kamctl.8 +++ b/utils/kamctl/kamctl.8 @@ -169,6 +169,9 @@ Introduce a permanent usrloc entry .TP .B ul add <username> <uri> <expires> Introduce a temporary usrloc entry +.TP +.B ul add <username> <uri> <expires> <path> +Introduce a temporary usrloc entry including a path .TP 16 .I Fifo commands: diff --git a/utils/kamctl/kamctl.ctlbase b/utils/kamctl/kamctl.ctlbase index a5ddf72..a605b10 100644 --- a/utils/kamctl/kamctl.ctlbase +++ b/utils/kamctl/kamctl.ctlbase @@ -67,11 +67,12 @@ usage_usrloc() { mecho " -- command 'ul|alias' - manage user location or aliases" echo cat <<EOF - ul show [<username>]................ show in-RAM online users - ul show --brief..................... show in-RAM online users in short format - ul rm <username> [<contact URI>].... delete user's usrloc entries - ul add <username> <uri> ............ introduce a permanent usrloc entry - ul add <username> <uri> <expires> .. introduce a temporary usrloc entry + ul show [<username>]................... show in-RAM online users + ul show --brief........................ show in-RAM online users in short format + ul rm <username> [<contact URI>]....... delete user's usrloc entries + ul add <username> <uri> ............... introduce a permanent usrloc entry + ul add <username> <uri> <expires> ..... introduce a temporary usrloc entry + ul add <user> <uri> <expires> <path> .. introduce a temporary usrloc entry EOF } USAGE_FUNCTIONS="$USAGE_FUNCTIONS usage_usrloc"

1 0

← Newer
1
...
18
19
20
21
22
23
24
...
32
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2013