sr-dev May 2013

sr-dev@lists.kamailio.org

29 participants
317 discussions

git:4.0: kamailio/utils/sercmd: remove unused but set variable
by Ovidiu Sas 07 May '13

07 May '13

Module: sip-router Branch: 4.0 Commit: 24e4d3dbd79ccb2e42aabcaaa17e391dc60d36d9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=24e4d3d… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Wed Mar 20 13:13:27 2013 -0400 kamailio/utils/sercmd: remove unused but set variable (cherry picked from commit ff94115921a08ba4da29baf2761db47bd0b7f8f5) --- utils/sercmd/sercmd.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/utils/sercmd/sercmd.c b/utils/sercmd/sercmd.c index 1e5606b..49b76b5 100644 --- a/utils/sercmd/sercmd.c +++ b/utils/sercmd/sercmd.c @@ -2158,7 +2158,6 @@ int main(int argc, char** argv) int sock_type; int s; struct binrpc_cmd cmd; - int rec; struct id_list* sock_id; char* format; int interactive; @@ -2169,7 +2168,6 @@ int main(int argc, char** argv) format=0; line=0; interactive=0; - rec=1; s=-1; sock_name=0; port_no=0;

1 0

git:4.0: p_usrloc: commenting out unused db_timer_udomain() to get rid of compiler warnings
by Ovidiu Sas 07 May '13

07 May '13

Module: sip-router Branch: 4.0 Commit: 5f9d169e797425b0501de42ba2af196018166c71 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5f9d169… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Wed Mar 20 13:23:49 2013 -0400 p_usrloc: commenting out unused db_timer_udomain() to get rid of compiler warnings --- modules/p_usrloc/udomain.c | 2 ++ modules/p_usrloc/udomain.h | 2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/modules/p_usrloc/udomain.c b/modules/p_usrloc/udomain.c index 73824d7..a1ab4d9 100644 --- a/modules/p_usrloc/udomain.c +++ b/modules/p_usrloc/udomain.c @@ -589,6 +589,7 @@ done: * \param _d cleaned domain * \return 0 on success, -1 on failure */ +/* int db_timer_udomain(udomain_t* _d) { db_key_t keys[2]; @@ -611,6 +612,7 @@ int db_timer_udomain(udomain_t* _d) //if (ul_db_layer_delete(_d, NULL, NULL, keys, ops, vals, 2) < 0) { //FIXME return 0; } +*/ diff --git a/modules/p_usrloc/udomain.h b/modules/p_usrloc/udomain.h index bbdda0f..c46a121 100644 --- a/modules/p_usrloc/udomain.h +++ b/modules/p_usrloc/udomain.h @@ -95,7 +95,9 @@ void print_udomain(FILE* _f, udomain_t* _d); * \param _d cleaned domain * \return 0 on success, -1 on failure */ +/* int db_timer_udomain(udomain_t* _d); +*/ /*!

1 0

git:4.0: tls: fix compiler warning
by Ovidiu Sas 07 May '13

07 May '13

Module: sip-router Branch: 4.0 Commit: 56b8856f84aebd86c4e78232f8f2f37fead7b4f3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=56b8856… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Sat Apr 13 15:37:18 2013 -0400 tls: fix compiler warning - tls_config.c:61:19: warning: �t.val.s� is used uninitialized in this function [-Wuninitialized] --- modules/tls/tls_config.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/tls/tls_config.c b/modules/tls/tls_config.c index fc4a9c0..0083893 100644 --- a/modules/tls/tls_config.c +++ b/modules/tls/tls_config.c @@ -58,13 +58,13 @@ static int parse_ipv6(struct ip_addr* ip, cfg_token_t* token, struct ip_addr* ipv6; str ip6_str; - ip6_str.s = t.val.s; while(1) { ret = cfg_get_token(&t, st, 0); if (ret != 0) goto err; if (t.type == ']') break; if (t.type != CFG_TOKEN_ALPHA && t.type != ':') goto err; } + ip6_str.s = t.val.s; ip6_str.len = (int)(long)(t.val.s - ip6_str.s); ipv6 = str2ip6(&ip6_str);

1 0

git:4.0: auth_diameter: remove unused but set variable
by Daniel-Constantin Mierla 07 May '13

07 May '13

Module: sip-router Branch: 4.0 Commit: 3a18564eb905d93b85b9e0527fa40cd85eb2e3b7 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3a18564… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Mar 20 13:02:16 2013 -0400 auth_diameter: remove unused but set variable (cherry picked from commit 387adace552c22eaf15a049b23694bcd79cea3a8) --- modules/auth_diameter/authorize.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/modules/auth_diameter/authorize.c b/modules/auth_diameter/authorize.c index 7b4f67c..6660057 100644 --- a/modules/auth_diameter/authorize.c +++ b/modules/auth_diameter/authorize.c @@ -295,7 +295,7 @@ int authorize(struct sip_msg* msg, pv_elem_t* realm, int hftype) int diameter_authorize(struct hdr_field* hdr, str* p_method, struct sip_uri uri, struct sip_uri ruri, unsigned int m_id, rd_buf_t* rb) { - str method, user_name; + str user_name; AAAMessage *req; AAA_AVP *avp, *position; int name_flag, port_flag; @@ -316,8 +316,6 @@ int diameter_authorize(struct hdr_field* hdr, str* p_method, struct sip_uri uri, else cred = NULL; - method = *p_method; - if(!cred) { /* Username AVP */

1 0

git:4.0: auth_diameter: remove unused but set variable
by Daniel-Constantin Mierla 07 May '13

07 May '13

Module: sip-router Branch: 4.0 Commit: 68021c3247b096fabc287fc6d129bce463cbfa97 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=68021c3… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Mar 20 13:00:27 2013 -0400 auth_diameter: remove unused but set variable (cherry picked from commit 941c48ae6909994ae090c9d52766cd4dd5d4f938) --- modules/auth_diameter/auth_diameter.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/modules/auth_diameter/auth_diameter.c b/modules/auth_diameter/auth_diameter.c index 5dc73ff..e17e067 100644 --- a/modules/auth_diameter/auth_diameter.c +++ b/modules/auth_diameter/auth_diameter.c @@ -212,13 +212,10 @@ int diameter_www_authorize(struct sip_msg* _msg, char* _realm, char* _s2) static int group_fixup(void** param, int param_no) { - void* ptr; str* s; if (param_no == 1) { - ptr = *param; - if (!strcasecmp((char*)*param, "Request-URI")) { *param = (void*)1; @@ -245,8 +242,6 @@ static int group_fixup(void** param, int param_no) LM_ERR("unsupported Header Field identifier\n"); return E_UNSPEC; - - //pkg_free(ptr); } if (param_no == 2) @@ -257,14 +252,12 @@ static int group_fixup(void** param, int param_no) LM_ERR("no pkg memory left\n"); return E_UNSPEC; } - ptr = *param; s->s = (char*)*param; s->len = strlen(s->s); *param = (void*)s; } end: -// pkg_free(ptr); return 0; }

1 0

git:4.0: seas: fix compiler warning [-Wunused-but-set-variable]
by Daniel-Constantin Mierla 07 May '13

07 May '13

Module: sip-router Branch: 4.0 Commit: d3999770dec8628a214423bcdcc510d90a39dc40 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d399977… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Apr 18 16:01:16 2013 -0400 seas: fix compiler warning [-Wunused-but-set-variable] (cherry picked from commit c0f4b6cf664ac552d0c994e99adb13991a37ef28) --- modules/seas/statistics.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/modules/seas/statistics.c b/modules/seas/statistics.c index 0dfb66f..31a44c6 100644 --- a/modules/seas/statistics.c +++ b/modules/seas/statistics.c @@ -169,8 +169,10 @@ static inline int assignIndex(int i) */ inline void action_stat(struct cell *t) { - unsigned int seas_dispatch,as_delay; - struct timeval *t1,*t2,*t3; + unsigned int seas_dispatch; + //unsigned int as_delay; + struct timeval *t1,*t2; + //struct timeval *t3; struct statscell *s; struct totag_elem *to; if(t==0) @@ -194,9 +196,9 @@ inline void action_stat(struct cell *t) return; t1=&(s->u.uas.as_relay); t2=&(s->u.uas.event_sent); - t3=&(s->u.uas.action_recvd); + //t3=&(s->u.uas.action_recvd); seas_dispatch = (t2->tv_sec - t1->tv_sec)*1000 + (t2->tv_usec-t1->tv_usec)/1000; - as_delay = (t3->tv_sec - t2->tv_sec)*1000 + (t3->tv_usec-t2->tv_usec)/1000; + //as_delay = (t3->tv_sec - t2->tv_sec)*1000 + (t3->tv_usec-t2->tv_usec)/1000; lock_get(seas_stats_table->mutex); {

1 0

git:4.0: seas: fix warning [-Wunused-result]
by Daniel-Constantin Mierla 07 May '13

07 May '13

Module: sip-router Branch: 4.0 Commit: b654a0d650af61bd4ec7212b48d71ccf7243e473 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b654a0d… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Apr 18 16:03:50 2013 -0400 seas: fix warning [-Wunused-result] - ignoring return value of write, declared with attribute warn_unused_result [-Wunused-result] (cherry picked from commit e3c0a3abb6045e841fbb4b1b61a518b2b87a217d) --- modules/seas/seas_action.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/modules/seas/seas_action.c b/modules/seas/seas_action.c index 7e2e4f1..d1267d5 100644 --- a/modules/seas/seas_action.c +++ b/modules/seas/seas_action.c @@ -1410,7 +1410,9 @@ int as_action_fail_resp(int uac_id,int sip_error,char *err_buf,int i) k+=i; ev_len=htonl(k); memcpy(msg,&ev_len,4); - write(my_as->u.as.action_fd,msg,k); + if(write(my_as->u.as.action_fd,msg,k)<=0){ + LM_DBG("Ignoring error write\n"); + } return 0; }

1 0

git:4.0: seas: fix compiler warning [-Wunused-but-set-variable]
by Daniel-Constantin Mierla 07 May '13

07 May '13

Module: sip-router Branch: 4.0 Commit: 3141c87bc4270ca2534250500dfdefa66c79a48f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3141c87… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Apr 18 15:54:14 2013 -0400 seas: fix compiler warning [-Wunused-but-set-variable] (cherry picked from commit 12cd241d95b8d38cea6e60676b752f8ef8a2ed8c) --- modules/seas/seas_action.c | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/modules/seas/seas_action.c b/modules/seas/seas_action.c index bad30e4..7e2e4f1 100644 --- a/modules/seas/seas_action.c +++ b/modules/seas/seas_action.c @@ -811,11 +811,11 @@ int ac_sl_msg(as_p the_as,unsigned char processor_id,unsigned int flags,char *ac str *uri; struct proxy_l *proxy; rr_t *my_route; - int i,k,retval; + int k,retval; //enum sip_protos proto; my_msg=NULL; - i=k=0; + k=0; proxy=0; @@ -936,7 +936,7 @@ int ac_uac_req(as_p the_as,unsigned char processor_id,unsigned int flags,char *a struct cseq_body *cseqb; struct as_uac_param *the_param; dlg_t *my_dlg; - int i,k,retval,uac_id,sip_error,ret,err_ret; + int k,retval,uac_id,sip_error,ret,err_ret; long clen; str headers,body,fake_uri; uac_req_t uac_r; @@ -945,7 +945,7 @@ int ac_uac_req(as_p the_as,unsigned char processor_id,unsigned int flags,char *a my_dlg=NULL; my_msg=NULL; the_param=NULL; - i=k=clen=0; + k=clen=0; net2hostL(uac_id,action,k); @@ -1480,11 +1480,9 @@ void uac_cb(struct cell* t, int type,struct tmcb_params *rcvd_params) as_msg_p my_as_ev=0; int mylen,code,i; struct as_uac_param *ev_info; - struct sip_msg *msg; char *buffer; ev_info=(struct as_uac_param*)*rcvd_params->param; - msg=rcvd_params->rpl; code=rcvd_params->code; buffer=0; if(!ev_info || !ev_info->who){

1 0

git:4.0: seas: fix compiler warning:
by Daniel-Constantin Mierla 07 May '13

07 May '13

Module: sip-router Branch: 4.0 Commit: 250b90ed1ec6ee34e883a4cbf6ff55865752a2d9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=250b90e… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Apr 18 15:50:25 2013 -0400 seas: fix compiler warning: - warning: variable flags set but not used [-Wunused-but-set-variable] (cherry picked from commit 2abf2d4a42c05004319e682d2ad07d69bf2fc89e) --- modules/seas/encode_via.c | 10 +++------- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/modules/seas/encode_via.c b/modules/seas/encode_via.c index 8661055..fa661ef 100644 --- a/modules/seas/encode_via.c +++ b/modules/seas/encode_via.c @@ -69,10 +69,9 @@ int encode_via_body(char *hdr,int hdrlen,struct via_body *via_parsed,unsigned char *where) { int i=0,k,via_offset; - unsigned char flags,tmp[500]; + unsigned char tmp[500]; struct via_body *myvia; - flags=0; if(via_parsed) for(via_offset=0,i=0,myvia=via_parsed;myvia;myvia=myvia->next,i++){ if((k=encode_via(hdr,hdrlen,myvia,&tmp[via_offset]))<0){ @@ -152,10 +151,9 @@ int encode_via(char *hdrstart,int hdrlen,struct via_body *body,unsigned char *wh int print_encoded_via_body(FILE *fd,char *hdr,int hdrlen,unsigned char *payload,int paylen,char *prefix) { - unsigned char flags, numvias; + unsigned char numvias; int i,offset; - flags=payload[0]; fprintf(fd,"%s",prefix); for(i=0;i<paylen;i++) fprintf(fd,"%s%d%s",i==0?"ENCODED VIA BODY:[":":",payload[i],i==paylen-1?"]\n":""); @@ -226,11 +224,9 @@ int print_encoded_via(FILE *fd,char *hdr,int hdrlen,unsigned char* payload,int p int dump_via_body_test(char *hdr,int hdrlen,unsigned char *payload,int paylen,FILE* fd,char segregationLevel) { - unsigned char flags, numvias; + unsigned char numvias; int i,offset; - flags=payload[0]; - if(!segregationLevel){ return dump_standard_hdr_test(hdr,hdrlen,payload,paylen,fd); }

1 0

git:4.0: seas: fix compiler warning [-Wunused-but-set-variable]
by Daniel-Constantin Mierla 07 May '13

07 May '13

Module: sip-router Branch: 4.0 Commit: 2fe9c5d1f7b0640b1e50976f4187d7362d6a3343 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2fe9c5d… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Apr 18 15:51:50 2013 -0400 seas: fix compiler warning [-Wunused-but-set-variable] (cherry picked from commit 21e51107a5a08b182abc7bffbac1fec1be27950b) --- modules/seas/event_dispatcher.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/seas/event_dispatcher.c b/modules/seas/event_dispatcher.c index eb73055..d10cffe 100644 --- a/modules/seas/event_dispatcher.c +++ b/modules/seas/event_dispatcher.c @@ -896,8 +896,8 @@ error: */ int process_unbind_action(as_p as,unsigned char processor_id,unsigned int flags,char *payload,int len) { - int i,k; - k=0; + int i; + for(i=0;i<as->num_binds;i++){ if(as->bound_processor[i] == processor_id) break;

1 0

← Newer
1
...
25
26
27
28
29
30
31
32
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2013