THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#299 - modules/debugger: be able to log assign actions
User who did this - Daniel-Constantin Mierla (miconda)
----------
The first three patches look ok, they can be committed.
For the 4th patch I think the cache has to be in private memory, kept by each process (practically, using pkg and no need anymore for locks). I was thinking a bit more about it, and some modules can add items in PV cache (in the …
[View More]core) at runtime (like app_lua). Although the ones used in config should be core PV cache from startup, still there is a potential that a module uses actions inside at runtime and can end up in some assignment.
By the nature of pv_spec that can have pkg alloc'ed content, keeping in share memory a reference to it might lead to a different process accessing it than the one that added it in core PV cache.
If kept in pkg, the debugger pv assign cache can hold only the pv_spec pointer and the name can be taken computing the offset in core pv cache structure relative to it (or simply keep a pointer to the whole structure or directly to the name).
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=299#comment910
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
[View Less]
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task is now closed:
FS#300 - Kamailio crash when module topoh module is loaded and removing Via headers in reply route with remov
User who did this - Daniel-Constantin Mierla (miconda)
Reason for closing: Fixed
Additional comments about closing: Reopen if still an issue.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=300
You are receiving this message because you …
[View More]have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
[View Less]
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#300 - Kamailio crash when module topoh module is loaded and removing Via headers in reply route with remov
User who did this - Daniel-Constantin Mierla (miconda)
----------
I added a safety check for it in master and 4.0 branches. You have to use git branches to test if works ok for you.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&…
[View More]amp;task_id=300#comment909
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
[View Less]
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#299 - modules/debugger: be able to log assign actions
User who did this - Víctor Seva (linuxmaniac)
----------
Patches refreshed.
Now I don't call pv_parse_spec/pv_parse_spec2 on patch 0001.
Added a while loop inside the FOR on patch 0003.
Thanks Daniel for your reviews
----------
One or more files have been attached.
More information can be found at the following URL:
http://sip-router.org/tracker/…
[View More]index.php?do=details&task_id=299#comment908
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
[View Less]