sr-dev May 2013

sr-dev@lists.kamailio.org

29 participants
317 discussions

[tracker] Comment added: UAC generates messages with a NULL body which failes in SANITY module check
by sip-router 26 May '13

26 May '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#295 - UAC generates messages with a NULL body which failes in SANITY module check User who did this - oren avraham (orenav) ---------- Thanks ! i've added the \r\n and it seems to work now... ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=295#comment901 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: UAC generates messages with a NULL body which failes in SANITY module check
by sip-router 26 May '13

26 May '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#295 - UAC generates messages with a NULL body which failes in SANITY module check User who did this - Daniel-Constantin Mierla (miconda) ---------- Content-Type is not needed. I just added to have hdrs set, which now gives a hint of what might be the problem in your side, with this line: $uac_req(hdrs) = $sht(websocket=>$si:$sp:hdrs); Be sure $sht(websocket=>$si:$sp:hdrs) is ending in "\r\n", because must be in full header format: "Name: body\r\n" ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=295#comment900 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: UAC generates messages with a NULL body which failes in SANITY module check
by sip-router 26 May '13

26 May '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#295 - UAC generates messages with a NULL body which failes in SANITY module check User who did this - oren avraham (orenav) ---------- I mean, when the body is empty, it is ok not to provide the content type header. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=295#comment899 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: UAC generates messages with a NULL body which failes in SANITY module check
by sip-router 26 May '13

26 May '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#295 - UAC generates messages with a NULL body which failes in SANITY module check User who did this - oren avraham (orenav) ---------- As you asked: U 2013/05/27 00:25:52.090319 10.0.0.4:5060 -> 10.0.0.4:5060 REGISTER sip:oren@10.0.0.4 SIP/2.0. Via: SIP/2.0/UDP 10.0.0.4;branch=z9hG4bKdf2a.37a13ec2.0. To: sip:oren@10.0.0.4. From: sip:oren@10.0.0.4;tag=ea1fc35981b38c23d4118e13e0c2a171-ffc8. CSeq: 10 REGISTER. Call-ID: 3f3dfd38-17008(a)10.0.0.4. Max-Forwards: 70. Content-Length: 0. User-Agent: kamailio (4.0.1 (i386/linux)). Contact: "Seller"<sip:oren@df7jal23ls0d.invalid;rtcweb-breaker=no;transport=ws>;expires=0;click2call=no. I found the problem: because i dont provied the content-type header it happens. when i add it, like in your example, the problem is solved. BUT acording to the RFC it is OK not to provide the Content-Type header.... ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=295#comment898 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: UAC generates messages with a NULL body which failes in SANITY module check
by sip-router 26 May '13

26 May '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#295 - UAC generates messages with a NULL body which failes in SANITY module check User who did this - Daniel-Constantin Mierla (miconda) ---------- I did a test with: $uac_req(method)="REGISTER"; $uac_req(ruri) = "sip:testb@127.0.0.1:5090"; $uac_req(turi) = "sip:testb@127.0.0.1"; $uac_req(furi) = "sip:testa@127.0.0.1"; $uac_req(hdrs) = "Content-Type: text/plain\r\n"; uac_req_send(); and the result is ok: REGISTER sip:testb@127.0.0.1:5090 SIP/2.0. Via: SIP/2.0/UDP 127.0.0.1;branch=z9hG4bK8443.08598b30000000000000000000000000.0. To: <sip:testb@127.0.0.1>. From: <sip:testa@127.0.0.1>;tag=533cb9e91f4b999cf76861cbb9ed54ed-8f53. CSeq: 10 REGISTER. Call-ID: 5193b50938528bb9-25802(a)127.0.0.1. Max-Forwards: 70. Content-Length: 0. User-Agent: kamailio (4.1.0-dev6 (x86_64/darwin)). Content-Type: text/plain. . Provide a ngrep output of what you get, that's what I asked. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=295#comment897 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: sctp: added rpc commands to module documentation
by Daniel-Constantin Mierla 26 May '13

26 May '13

Module: sip-router Branch: master Commit: 375d878b5f318acc08b155c29398e4abb74edbd5 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=375d878… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun May 26 17:11:25 2013 +0200 sctp: added rpc commands to module documentation --- modules/sctp/README | 36 ++++++++++++++++++++++++++++++++++++ modules/sctp/doc/sctp_admin.xml | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 69 insertions(+), 0 deletions(-) diff --git a/modules/sctp/README b/modules/sctp/README index e05854e..1fb71dc 100644 --- a/modules/sctp/README +++ b/modules/sctp/README @@ -39,6 +39,11 @@ Andrei Pelinescu-Onciul 3.18. sctp_sack_freq (int) 3.19. sctp_max_burst (int) + 4. RPC Commands + + 4.1. sctp.info + 4.2. sctp.options + List of Examples 1.1. Set sctp_socket_rcvbuf parameter @@ -60,6 +65,8 @@ Andrei Pelinescu-Onciul 1.17. Set sctp_sack_delay parameter 1.18. Set sctp_sack_freq parameter 1.19. Set sctp_max_burst parameter + 1.20. Use sctp.info with kamcmd + 1.21. Use sctp.options with kamcmd Chapter 1. Admin Guide @@ -93,6 +100,11 @@ Chapter 1. Admin Guide 3.18. sctp_sack_freq (int) 3.19. sctp_max_burst (int) + 4. RPC Commands + + 4.1. sctp.info + 4.2. sctp.options + 1. Overview This module provides SCTP transport layer for Kamailio. SCTP is an @@ -464,3 +476,27 @@ modparam("sctp", "sctp_sack_freq", 3) ... modparam("sctp", "sctp_max_burst", 3) ... + +4. RPC Commands + + 4.1. sctp.info + 4.2. sctp.options + +4.1. sctp.info + + Print information about SCTP transport. + + Example 1.20. Use sctp.info with kamcmd +... +kamcmd sctp.info +... + +4.2. sctp.options + + Print the options of SCTP sockets. It can take an optional parameter + that specifies the listen address of SCTP socket. + + Example 1.21. Use sctp.options with kamcmd +... +kamcmd sctp.options +... diff --git a/modules/sctp/doc/sctp_admin.xml b/modules/sctp/doc/sctp_admin.xml index 2009fcb..3ede4ca 100644 --- a/modules/sctp/doc/sctp_admin.xml +++ b/modules/sctp/doc/sctp_admin.xml @@ -585,5 +585,38 @@ modparam("sctp", "sctp_max_burst", 3) </section> </section> + <section> + <title>RPC Commands</title> + <section id="sctp.r.sctp.info"> + <title><varname>sctp.info</varname></title> + <para> + Print information about SCTP transport. + </para> + <example> + <title>Use <varname>sctp.info</varname> with kamcmd</title> + <programlisting format="linespecific"> +... +kamcmd sctp.info +... +</programlisting> + </example> + </section> + <section id="sctp.r.sctp."> + <title><varname>sctp.options</varname></title> + <para> + Print the options of SCTP sockets. It can take an optional + parameter that specifies the listen address of SCTP socket. + </para> + <example> + <title>Use <varname>sctp.options</varname> with kamcmd</title> + <programlisting format="linespecific"> +... +kamcmd sctp.options +... +</programlisting> + </example> + </section> + </section> + </chapter>

1 0

git:master: sctp: rpc commands are prefixed with sctp
by Daniel-Constantin Mierla 26 May '13

26 May '13

Module: sip-router Branch: master Commit: ca923db8727333ad7df14126bb377418a829cce3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ca923db… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun May 26 17:04:23 2013 +0200 sctp: rpc commands are prefixed with sctp - no longer part of core and proper matching of the module --- modules/sctp/sctp_rpc.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/sctp/sctp_rpc.c b/modules/sctp/sctp_rpc.c index cbed0d6..15dbd07 100644 --- a/modules/sctp/sctp_rpc.c +++ b/modules/sctp/sctp_rpc.c @@ -155,9 +155,9 @@ static void core_sctpinfo(rpc_t* rpc, void* c) * RPC Methods exported by this module */ static rpc_export_t scp_rpc_methods[] = { - {"core.sctp_options", core_sctp_options, core_sctp_options_doc, + {"sctp.options", core_sctp_options, core_sctp_options_doc, 0}, - {"core.sctp_info", core_sctpinfo, core_sctpinfo_doc, 0}, + {"sctp.info", core_sctpinfo, core_sctpinfo_doc, 0}, {0, 0, 0, 0} };

1 0

git:3.3: topoh: safety check for SIP messages
by Daniel-Constantin Mierla 26 May '13

26 May '13

Module: sip-router Branch: 3.3 Commit: cd97c66880bc1597d64dd7e075428fcc25a537ee URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cd97c66… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun May 26 16:14:51 2013 +0200 topoh: safety check for SIP messages - received callback can be executed for non-sip messages - reported by Julia (cherry picked from commit 352a7dccf2570af857d7e2e50fed600c4762278d) (cherry picked from commit 533f2238d9d14ed8ef0a367ce574aef8052c0452) --- modules/topoh/topoh_mod.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/modules/topoh/topoh_mod.c b/modules/topoh/topoh_mod.c index f42b928..73ebf21 100644 --- a/modules/topoh/topoh_mod.c +++ b/modules/topoh/topoh_mod.c @@ -204,6 +204,18 @@ int th_prepare_msg(sip_msg_t *msg) return 1; } + if(msg->first_line.type==SIP_REQUEST) + { + if(!IS_SIP(msg)) + { + LM_DBG("non sip request message\n"); + return 1; + } + } else if(msg->first_line.type!=SIP_REPLY) { + LM_DBG("non sip message\n"); + return 1; + } + if (parse_headers(msg, HDR_EOH_F, 0)==-1) { LM_DBG("parsing headers failed");

1 0

git:4.0: topoh: safety check for SIP messages
by Daniel-Constantin Mierla 26 May '13

26 May '13

Module: sip-router Branch: 4.0 Commit: 533f2238d9d14ed8ef0a367ce574aef8052c0452 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=533f223… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun May 26 16:14:51 2013 +0200 topoh: safety check for SIP messages - received callback can be executed for non-sip messages - reported by Julia (cherry picked from commit 352a7dccf2570af857d7e2e50fed600c4762278d) --- modules/topoh/topoh_mod.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/modules/topoh/topoh_mod.c b/modules/topoh/topoh_mod.c index f42b928..73ebf21 100644 --- a/modules/topoh/topoh_mod.c +++ b/modules/topoh/topoh_mod.c @@ -204,6 +204,18 @@ int th_prepare_msg(sip_msg_t *msg) return 1; } + if(msg->first_line.type==SIP_REQUEST) + { + if(!IS_SIP(msg)) + { + LM_DBG("non sip request message\n"); + return 1; + } + } else if(msg->first_line.type!=SIP_REPLY) { + LM_DBG("non sip message\n"); + return 1; + } + if (parse_headers(msg, HDR_EOH_F, 0)==-1) { LM_DBG("parsing headers failed");

1 0

git:master: topoh: safety check for SIP messages
by Daniel-Constantin Mierla 26 May '13

26 May '13

Module: sip-router Branch: master Commit: 352a7dccf2570af857d7e2e50fed600c4762278d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=352a7dc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun May 26 16:14:51 2013 +0200 topoh: safety check for SIP messages - received callback can be executed for non-sip messages - reported by Julia --- modules/topoh/topoh_mod.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/modules/topoh/topoh_mod.c b/modules/topoh/topoh_mod.c index f42b928..73ebf21 100644 --- a/modules/topoh/topoh_mod.c +++ b/modules/topoh/topoh_mod.c @@ -204,6 +204,18 @@ int th_prepare_msg(sip_msg_t *msg) return 1; } + if(msg->first_line.type==SIP_REQUEST) + { + if(!IS_SIP(msg)) + { + LM_DBG("non sip request message\n"); + return 1; + } + } else if(msg->first_line.type!=SIP_REPLY) { + LM_DBG("non sip message\n"); + return 1; + } + if (parse_headers(msg, HDR_EOH_F, 0)==-1) { LM_DBG("parsing headers failed");

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
32
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2013