sr-dev June 2013

sr-dev@lists.kamailio.org

33 participants
235 discussions

[tracker] Comment added: modules/lcr: use pv_cache_get on mod_init

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#306 - modules/lcr: use pv_cache_get on mod_init User who did this - Víctor Seva (linuxmaniac) ---------- Thanks Juha. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=306#comment927 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

[tracker] Comment added: modules/lcr: use pv_cache_get on mod_init

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#306 - modules/lcr: use pv_cache_get on mod_init User who did this - Juha Heinanen (jh) ---------- Ok, i'll apply the patch tomorrow. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=306#comment926 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

[tracker] Comment added: modules/lcr: use pv_cache_get on mod_init

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#306 - modules/lcr: use pv_cache_get on mod_init User who did this - Víctor Seva (linuxmaniac) ---------- Hi Juha, There is no bug. If we use pv_cache_get then the avps used in the lcr module can be reached by debugger module. So the debugger can dump them by the new dbg_pv_dump config command that I'm working on [FS#307]. I think this change will not affect the lcr module at all, the changes are just in the mod_init function and will improve our debug ability. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=306#comment925 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

[tracker] Comment added: modules/lcr: use pv_cache_get on mod_init

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#306 - modules/lcr: use pv_cache_get on mod_init User who did this - Juha Heinanen (jh) ---------- can you elaborate why you want to make the change? is there a bug in current implementation? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=306#comment924 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

[tracker] Task closed: modules/debugger: be able to log assign actions

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#299 - modules/debugger: be able to log assign actions User who did this - Víctor Seva (linuxmaniac) Reason for closing: Fixed More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=299 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

[tracker] Comment added: modules/debugger: be able to log assign actions

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#299 - modules/debugger: be able to log assign actions User who did this - Víctor Seva (linuxmaniac) ---------- FTR: - first commit: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2312e2a… - fix commit: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=26b15ad… ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=299#comment923 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

git:master: modules/debugger: fixed last commit.

by Victor Seva

Module: sip-router Branch: master Commit: 26b15ad0006defeb8df17dff090fd93ffa11ede6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=26b15ad… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Mon Jun 3 18:43:51 2013 +0200 modules/debugger: fixed last commit. - checked malloc result on dbg_init_pvcache. - checked result of dbg_init_pvcache on mod_init. - removed commented code. --- modules/debugger/debugger_api.c | 18 ++++++++---------- modules/debugger/debugger_api.h | 2 +- modules/debugger/debugger_mod.c | 6 +++++- 3 files changed, 14 insertions(+), 12 deletions(-) diff --git a/modules/debugger/debugger_api.c b/modules/debugger/debugger_api.c index 1f42d74..f0dbdce 100644 --- a/modules/debugger/debugger_api.c +++ b/modules/debugger/debugger_api.c @@ -1120,17 +1120,22 @@ typedef struct _dbg_pvcache { static dbg_pvcache_t **_dbg_pvcache = NULL; -void dbg_init_pvcache() +int dbg_init_pvcache() { _dbg_pvcache = (dbg_pvcache_t**)pkg_malloc(sizeof(dbg_pvcache_t*)*DBG_PVCACHE_SIZE); + if(_dbg_pvcache==NULL) + { + LM_ERR("no more memory.\n"); + return -1; + } memset(_dbg_pvcache, 0, sizeof(dbg_pvcache_t*)*DBG_PVCACHE_SIZE); + return 0; } int dbg_assign_add(str *name, pv_spec_t *spec) { dbg_pvcache_t *pvn, *last, *next; unsigned int pvid; - //unsigned i = 0; if(name==NULL||spec==NULL) return -1; @@ -1140,7 +1145,7 @@ int dbg_assign_add(str *name, pv_spec_t *spec) pvid = get_hash1_raw((char *)&spec, sizeof(pv_spec_t*)); pvn = (dbg_pvcache_t*)pkg_malloc(sizeof(dbg_pvcache_t)); - if(pvn==0) + if(pvn==NULL) { LM_ERR("no more memory\n"); return -1; @@ -1157,14 +1162,11 @@ int dbg_assign_add(str *name, pv_spec_t *spec) { while(next) { - //i++; last = next; next = next->next; } last->next = pvn; } - /*LM_DBG("spec[%p] pvar[%.*s] added in cache[%d][%d]\n", spec, - name->len, name->s, pvid%DBG_PVCACHE_SIZE, i);*/ return 0; } @@ -1173,7 +1175,6 @@ str *_dbg_pvcache_lookup(pv_spec_t *spec) dbg_pvcache_t *pvi; unsigned int pvid; str *name = NULL; - //unsigned int i = 0; if(spec==NULL) return NULL; @@ -1186,11 +1187,8 @@ str *_dbg_pvcache_lookup(pv_spec_t *spec) while(pvi) { if(pvi->spec==spec) { - /*LM_DBG("spec[%p] pvar[%.*s] found in cache[%d][%d]\n", spec, - pvi->pvname->len, pvi->pvname->s, pvid%DBG_PVCACHE_SIZE, i);*/ return pvi->pvname; } - //i++; pvi = pvi->next; } name = pv_cache_get_name(spec); diff --git a/modules/debugger/debugger_api.h b/modules/debugger/debugger_api.h index 6a45678..54d5c59 100644 --- a/modules/debugger/debugger_api.h +++ b/modules/debugger/debugger_api.h @@ -37,7 +37,7 @@ int dbg_init_mod_levels(int _dbg_mod_hash_size); int dbg_set_mod_debug_level(char *mname, int mnlen, int *mlevel); void dbg_enable_mod_levels(void); -void dbg_init_pvcache(void); +int dbg_init_pvcache(void); void dbg_enable_log_assign(void); #endif diff --git a/modules/debugger/debugger_mod.c b/modules/debugger/debugger_mod.c index 18b50e6..f048b0d 100644 --- a/modules/debugger/debugger_mod.c +++ b/modules/debugger/debugger_mod.c @@ -137,7 +137,11 @@ static int mod_init(void) if(_dbg_log_assign>0) { - dbg_init_pvcache(); + if(dbg_init_pvcache()!=0) + { + LM_ERR("failed to create pvcache\n"); + return -1; + } } return dbg_init_bp_list(); }

11 years, 5 months

git:master: DB scheme: as discussed on sr-users list, change default mysql engine to InnoDB

by Henning Westerholt

Module: sip-router Branch: master Commit: fa49fe070adadfff893b338f2a2d69776c043653 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fa49fe0… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: Wed May 29 11:49:59 2013 +0200 DB scheme: as discussed on sr-users list, change default mysql engine to InnoDB --- lib/srdb1/schema/entities.xml | 2 +- utils/kamctl/mysql/acc-create.sql | 4 ++-- utils/kamctl/mysql/alias_db-create.sql | 2 +- utils/kamctl/mysql/auth_db-create.sql | 2 +- utils/kamctl/mysql/avpops-create.sql | 2 +- utils/kamctl/mysql/carrierroute-create.sql | 8 ++++---- utils/kamctl/mysql/cpl-create.sql | 2 +- utils/kamctl/mysql/dialog-create.sql | 4 ++-- utils/kamctl/mysql/dialplan-create.sql | 2 +- utils/kamctl/mysql/dispatcher-create.sql | 2 +- utils/kamctl/mysql/domain-create.sql | 4 ++-- utils/kamctl/mysql/domainpolicy-create.sql | 2 +- utils/kamctl/mysql/drouting-create.sql | 8 ++++---- utils/kamctl/mysql/group-create.sql | 4 ++-- utils/kamctl/mysql/htable-create.sql | 2 +- utils/kamctl/mysql/imc-create.sql | 4 ++-- utils/kamctl/mysql/lcr-create.sql | 6 +++--- utils/kamctl/mysql/matrix-create.sql | 2 +- utils/kamctl/mysql/msilo-create.sql | 2 +- utils/kamctl/mysql/mtree-create.sql | 4 ++-- utils/kamctl/mysql/pdt-create.sql | 2 +- utils/kamctl/mysql/permissions-create.sql | 4 ++-- utils/kamctl/mysql/pipelimit-create.sql | 2 +- utils/kamctl/mysql/presence-create.sql | 10 +++++----- utils/kamctl/mysql/purple-create.sql | 2 +- utils/kamctl/mysql/registrar-create.sql | 2 +- utils/kamctl/mysql/rls-create.sql | 4 ++-- utils/kamctl/mysql/rtpproxy-create.sql | 2 +- utils/kamctl/mysql/sca-create.sql | 2 +- utils/kamctl/mysql/siptrace-create.sql | 2 +- utils/kamctl/mysql/speeddial-create.sql | 2 +- utils/kamctl/mysql/standard-create.sql | 2 +- utils/kamctl/mysql/uac-create.sql | 2 +- utils/kamctl/mysql/uid_auth_db-create.sql | 2 +- utils/kamctl/mysql/uid_avp_db-create.sql | 2 +- utils/kamctl/mysql/uid_domain-create.sql | 4 ++-- utils/kamctl/mysql/uid_gflags-create.sql | 2 +- utils/kamctl/mysql/uid_uri_db-create.sql | 4 ++-- utils/kamctl/mysql/uri_db-create.sql | 2 +- utils/kamctl/mysql/userblacklist-create.sql | 4 ++-- utils/kamctl/mysql/usrloc-create.sql | 4 ++-- 41 files changed, 65 insertions(+), 65 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=fa4…

11 years, 5 months

[tracker] Comment added: modules/debugger: be able to log assign actions

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#299 - modules/debugger: be able to log assign actions User who did this - Daniel-Constantin Mierla (miconda) ---------- OK. Just commit from now on for obvious patches related to issues of this particular feature -- the code is already in the repository and add here the link for future cases. Only patches that add completely new features should be reviewed separately. Commit and close this item. I will look in more details over the initial patch soon, as I get the time, today I just looked quickly and spotted what I reported above. If happens to be the case of other issues, I will reopen this item. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=299#comment922 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

[tracker] Comment added: modules/debugger: be able to log assign actions (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#299 - modules/debugger: be able to log assign actions User who did this - Víctor Seva (linuxmaniac) ---------- Ups. Sorry for that I thought It was polish enough. The only malloc without checking that I see is the one on dbg_init_pvcache. I have removed the commented code. Thanks ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=299#comment921 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2013