sr-dev June 2013

sr-dev@lists.kamailio.org

33 participants
236 discussions

git:master: core: allow c++ style of one line comments
by Daniel-Constantin Mierla 25 Jun '13

25 Jun '13

Module: sip-router Branch: master Commit: 584508d5374726bf523a23693da86f0763b34767 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=584508d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Jun 23 05:37:34 2013 +0200 core: allow c++ style of one line comments - can make easier the read of config files with defines and comments --- cfg.lex | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cfg.lex b/cfg.lex index 4b69287..053fa2e 100644 --- a/cfg.lex +++ b/cfg.lex @@ -540,7 +540,7 @@ CR \n EVENT_RT_NAME [a-zA-Z][0-9a-zA-Z-]*(":"[a-zA-Z][0-9a-zA-Z-]*)+ -COM_LINE # +COM_LINE "#"|"//" COM_START "/\*" COM_END "\*/"

1 0

git:master: examples: Make S-CSCF more quiet
by admin＠sip-router.org 24 Jun '13

24 Jun '13

Module: sip-router Branch: master Commit: 756620fd0c1912e492781f05fde944f9035d95b3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=756620f… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Mon Jun 24 22:13:26 2013 +0200 examples: Make S-CSCF more quiet --- examples/scscf/kamailio.cfg | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/scscf/kamailio.cfg b/examples/scscf/kamailio.cfg index 6a34006..f3b3cac 100644 --- a/examples/scscf/kamailio.cfg +++ b/examples/scscf/kamailio.cfg @@ -235,6 +235,7 @@ modparam("ims_auth", "registration_default_algorithm", REG_AUTH_DEFAULT_ALG) modparam("ims_auth", "cxdx_forced_peer", CXDX_FORCED_PEER) #!endif modparam("ims_auth", "cxdx_dest_realm", NETWORKNAME) +modparam("ims_auth", "av_check_only_impu", 1) # -- ims_registrar_scscf params -- #!ifdef WITH_DEBUG @@ -480,8 +481,7 @@ route[REGISTER] { exit; } } else { - xlog("L_ERR", "Auth succeeded\n"); - setdebug("9"); + xlog("L_DBG", "Auth succeeded\n"); # We need to check if this user is registered or not if (!impu_registered("location")) { xlog("L_ERR", "Not REGISTERED\n");

1 0

git:master: Added missing parameters to documentation
by admin＠sip-router.org 24 Jun '13

24 Jun '13

Module: sip-router Branch: master Commit: 9fc55badeaa54d2cfde7a152459b957f8ae5a192 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9fc55ba… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Mon Jun 24 18:08:29 2013 +0200 Added missing parameters to documentation --- modules/ims_auth/doc/ims_auth_admin.xml | 64 +++++++++++++++++++++++++++++- 1 files changed, 61 insertions(+), 3 deletions(-) diff --git a/modules/ims_auth/doc/ims_auth_admin.xml b/modules/ims_auth/doc/ims_auth_admin.xml index 18834cd..a7e4649 100644 --- a/modules/ims_auth/doc/ims_auth_admin.xml +++ b/modules/ims_auth/doc/ims_auth_admin.xml @@ -210,11 +210,11 @@ modparam("ims_auth", "registration_default_algorithm", "HSS-Selected") <quote>auth,auth-int</quote>.</para> <example> - <title><varname>load_credentials</varname> parameter usage</title> + <title><varname>registration_qop</varname> parameter usage</title> <programlisting format="linespecific"> ... -modparam("ims_auth", "load_credentials", "auth-int") +modparam("ims_auth", "registration_qop", "auth-int") ... </programlisting> </example> @@ -246,7 +246,7 @@ modparam("ims_auth", "cxdx_forced_peer", "hss.ims.smilecoms.com") <para>Default value is <quote>ims.smilecoms.com</quote>.</para> <example> - <title><varname>version_table</varname> parameter usage</title> + <title><varname>cxdx_dest_realm</varname> parameter usage</title> <programlisting format="linespecific"> ... @@ -255,6 +255,64 @@ modparam("ims_auth", "cxdx_dest_realm", "ims.smilecoms.com") </programlisting> </example> </section> + + <section> + <title><varname>max_nonce_reuse</varname> (integer)</title> + + <para>Defines, how many times a nonce can be reused (provided nc is incremented)</para> + + <para>Default value is <quote>0</quote> (don't allow reuse).</para> + + <example> + <title><varname>max_nonce_reuse</varname> parameter usage</title> + + <programlisting format="linespecific"> +... +modparam("ims_auth", "max_nonce_reuse", 1) +... +</programlisting> + </example> + </section> + + </section> + + <section> + <title><varname>add_authinfo_hdr</varname> (integer)</title> + + <para>Should an Authentication-Info header be added on 200 OK responses?</para> + + <para>Default value is <quote>1</quote> (add Authentication-Info header).</para> + + <example> + <title><varname>add_authinfo_hdr</varname> parameter usage</title> + + <programlisting format="linespecific"> +... +modparam("ims_auth", "add_authinfo_hdr", 0) +... +</programlisting> + </example> + </section> + + <section> + <title><varname>ignore_failed_auth</varname> (integer)</title> + + <para>Ignore invalid passwords (only IMPI/IMPU is checked).</para> + <para>It should be used only for testing, e.g. load balancing with SIPP where we dont want to worry about auth.</para> + + <para>Default value is <quote>0</quote> (don't ingnore the failed authentication).</para> + + <example> + <title><varname>ignore_failed_auth</varname> parameter usage</title> + + <programlisting format="linespecific"> +... +modparam("ims_auth", "ignore_failed_auth", 1) +... +</programlisting> + </example> + </section> + </section> <section>

1 0

git:master: Fixed Editor note
by admin＠sip-router.org 24 Jun '13

24 Jun '13

Module: sip-router Branch: master Commit: 72d79d20964ac192dbe1cbe35f48c21ec749c39a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=72d79d2… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Mon Jun 24 18:08:05 2013 +0200 Fixed Editor note --- modules/dispatcher/doc/dispatcher.xml | 2 +- modules/ims_auth/doc/ims_auth.xml | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a/modules/dispatcher/doc/dispatcher.xml b/modules/dispatcher/doc/dispatcher.xml index 29c0105..dada67e 100644 --- a/modules/dispatcher/doc/dispatcher.xml +++ b/modules/dispatcher/doc/dispatcher.xml @@ -26,7 +26,7 @@ <editor> <firstname>Carsten</firstname> <surname>Bock</surname> - <affiliation><orgname>ng-voice.com</orgname></affiliation> + <affiliation><orgname>ng-voice GmbH</orgname></affiliation> <address> <email>carsten(a)ng-voice.com</email> </address> diff --git a/modules/ims_auth/doc/ims_auth.xml b/modules/ims_auth/doc/ims_auth.xml index eb61566..3a7a399 100644 --- a/modules/ims_auth/doc/ims_auth.xml +++ b/modules/ims_auth/doc/ims_auth.xml @@ -44,6 +44,17 @@ <email>richard.good(a)smilecoms.com</email> </author> + + <editor> + <firstname>Carsten</firstname> + <surname>Bock</surname> + <affiliation> + <orgname>ng-voice GmbH</orgname> + </affiliation> + <address> + <email>carsten(a)ng-voice.com</email> + </address> + </editor> </authorgroup> <copyright>

1 0

git:master: auth_ims: New option to store authentication vectors using the IMPU only, instead of IMPI/IMPU.
by admin＠sip-router.org 24 Jun '13

24 Jun '13

Module: sip-router Branch: master Commit: 14ef8ff8d460bc22f0df4793e11455487ea91aab URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=14ef8ff… Author: Carsten Bock <carsten(a)ng-voice.com> Committer: Carsten Bock <carsten(a)ng-voice.com> Date: Mon Jun 24 22:10:33 2013 +0200 auth_ims: New option to store authentication vectors using the IMPU only, instead of IMPI/IMPU. (this is required to work with some SIP-clients) - added some more debug info - replaced the hashing function with core_hash from Kamailio-core --- modules/ims_auth/authims_mod.c | 2 + modules/ims_auth/authorize.c | 42 ++++++++++++++++++++++++++---- modules/ims_auth/cxdx_mar.c | 3 +- modules/ims_auth/doc/ims_auth_admin.xml | 21 +++++++++++++++ 4 files changed, 61 insertions(+), 7 deletions(-) diff --git a/modules/ims_auth/authims_mod.c b/modules/ims_auth/authims_mod.c index 12070c6..0e94f69 100644 --- a/modules/ims_auth/authims_mod.c +++ b/modules/ims_auth/authims_mod.c @@ -86,6 +86,7 @@ int av_request_at_once = 1; /**< how many auth vectors to request in a MAR * int av_request_at_sync = 1; /**< how many auth vectors to request in a sync MAR */ char *registration_qop = "auth,auth-int"; /**< the qop options to put in the authorization challenges */ str registration_qop_str = {0, 0}; /**< the qop options to put in the authorization challenges */ +int av_check_only_impu = 0; /**< Should we check IMPU (0) or IMPU and IMPI (1), when searching for authentication vectors? */ static str s_qop_s = {", qop=\"", 7}; static str s_qop_e = {"\"", 1}; @@ -139,6 +140,7 @@ static param_export_t params[] = { {"registration_default_algorithm", STR_PARAM, &registration_default_algorithm}, {"registration_qop", STR_PARAM, &registration_qop}, {"ignore_failed_auth", INT_PARAM, &ignore_failed_auth}, + {"av_check_only_impu", INT_PARAM, &av_check_only_impu}, {"cxdx_forced_peer", STR_PARAM, &cxdx_forced_peer_s}, {"cxdx_dest_realm", STR_PARAM, &cxdx_dest_realm_s}, {0, 0, 0} diff --git a/modules/ims_auth/authorize.c b/modules/ims_auth/authorize.c index 8b1904d..7f3e753 100644 --- a/modules/ims_auth/authorize.c +++ b/modules/ims_auth/authorize.c @@ -47,6 +47,7 @@ #include "../../ut.h" #include "../../str.h" #include "../../basex.h" +#include "../../hashes.h" #include "../../lib/srdb1/db.h" #include "../../lib/srdb1/db_ut.h" #include "../../dprint.h" @@ -85,6 +86,7 @@ extern int add_authinfo_hdr; extern int max_nonce_reuse; extern str scscf_name_str; extern int ignore_failed_auth; +extern int av_check_only_impu; auth_hash_slot_t *auth_data; /**< Authentication vector hash table */ extern int auth_data_hash_size; /**< authentication vector hash table size */ @@ -1162,6 +1164,12 @@ void free_auth_userdata(auth_userdata * aud) { * @returns the hash % Auth_data->size */ inline unsigned int get_hash_auth(str private_identity, str public_identity) { +if (av_check_only_impu) + return core_hash(&public_identity, 0, auth_data_hash_size); +else + return core_hash(&public_identity, 0, auth_data_hash_size); +/* + #define h_inc h+=v^(v>>3) char* p; @@ -1192,6 +1200,7 @@ inline unsigned int get_hash_auth(str private_identity, str public_identity) { h = ((h)+(h >> 11))+((h >> 13)+(h >> 23)); return (h) % auth_data_hash_size; #undef h_inc +*/ } /** @@ -1209,13 +1218,29 @@ auth_userdata * get_auth_userdata(str private_identity, str public_identity) { hash = get_hash_auth(private_identity, public_identity); auth_data_lock(hash); aud = auth_data[hash].head; + if (av_check_only_impu) + LM_DBG("Searching auth_userdata for IMPU %.*s (Hash %d)\n", public_identity.len, public_identity.s, hash); + else + LM_DBG("Searching auth_userdata for IMPU %.*s / IMPI %.*s (Hash %d)\n", public_identity.len, public_identity.s, + private_identity.len, private_identity.s, hash); + while (aud) { - if (aud->private_identity.len == private_identity.len && - aud->public_identity.len == public_identity.len && - memcmp(aud->private_identity.s, private_identity.s, private_identity.len) == 0 && - memcmp(aud->public_identity.s, public_identity.s, public_identity.len) == 0) { - return aud; - } + if (av_check_only_impu) { + if (aud->public_identity.len == public_identity.len && + memcmp(aud->public_identity.s, public_identity.s, public_identity.len) == 0) { + LM_DBG("Found auth_userdata\n"); + return aud; + } + } else { + if (aud->private_identity.len == private_identity.len && + aud->public_identity.len == public_identity.len && + memcmp(aud->private_identity.s, private_identity.s, private_identity.len) == 0 && + memcmp(aud->public_identity.s, public_identity.s, public_identity.len) == 0) { + LM_DBG("Found auth_userdata\n"); + return aud; + } + } + aud = aud->next; } /* if we get here, there is no auth_userdata for this user */ @@ -1408,6 +1433,11 @@ int add_auth_vector(str private_identity, str public_identity, auth_vector * av) aud = get_auth_userdata(private_identity, public_identity); if (!aud) goto error; + LM_DBG("Adding auth_vector (status %d) for IMPU %.*s / IMPI %.*s (Hash %d)\n", av->status, + public_identity.len, public_identity.s, + private_identity.len, private_identity.s, aud->hash); + + av->prev = aud->tail; av->next = 0; diff --git a/modules/ims_auth/cxdx_mar.c b/modules/ims_auth/cxdx_mar.c index 2ec113b..4fa7e17 100644 --- a/modules/ims_auth/cxdx_mar.c +++ b/modules/ims_auth/cxdx_mar.c @@ -154,7 +154,6 @@ void async_cdp_callback(int is_timeout, void *param, AAAMessage *maa, long elaps goto error; } - //get each individual element from the MAA cxdx_get_result_code(maa, &rc); cxdx_get_experimental_result_code(maa, &experimental_rc); @@ -388,6 +387,8 @@ success: //TODO need to confirm that removing this has done no problems //tmp->auth_data->code = -tmp->auth_data->code; + LM_DBG("Added new auth-vector.\n"); + tmp = tmp->next; } diff --git a/modules/ims_auth/doc/ims_auth_admin.xml b/modules/ims_auth/doc/ims_auth_admin.xml index a7e4649..56eb972 100644 --- a/modules/ims_auth/doc/ims_auth_admin.xml +++ b/modules/ims_auth/doc/ims_auth_admin.xml @@ -313,6 +313,27 @@ modparam("ims_auth", "ignore_failed_auth", 1) </example> </section> + <section> + <title><varname>av_check_only_impu</varname> (integer)</title> + + <para>When storing the authentication vectors for an account, use either IMPI/IMPU (=0, default) or IMPU (=1).</para> + <para>In case the IMPI is different from the IMPU, this option needs to be enabled to allow registration from + classic "SIP-clients", such as Snom phones and others, as they do not send an authentication username in the first REGISTER.</para> + <para>Default value is <quote>0</quote> (store authentication vectors based on IMPI/IMPU).</para> + + <example> + <title><varname>av_check_only_impu</varname> parameter usage</title> + + <programlisting format="linespecific"> +... +modparam("ims_auth", "av_check_only_impu", 1) +... +</programlisting> + </example> + </section> + + + </section> <section>

1 0

git:master: modules/ims_registrar_scscf: execute route block on async reply of unreg. SAR
by Jason Penton 24 Jun '13

24 Jun '13

Module: sip-router Branch: master Commit: bd1a534515678f69385d00b08699b434e1fab8df URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bd1a534… Author: Jason Penton <jason.penton(a)smilecoms.com> Committer: Jason Penton <jason.penton(a)smilecoms.com> Date: Mon Jun 24 15:24:49 2013 +0200 modules/ims_registrar_scscf: execute route block on async reply of unreg. SAR - changed this to make the use of saync CDP cleaner - fixes inconsistencies we are experienceing with async TM and not using route block --- modules/ims_registrar_scscf/cxdx_sar.c | 6 +++- modules/ims_registrar_scscf/reg_mod.c | 37 +++++++++++++++++++++++++++---- modules/ims_registrar_scscf/save.c | 27 +++++++++++++++++++---- modules/ims_registrar_scscf/save.h | 2 +- 4 files changed, 59 insertions(+), 13 deletions(-) diff --git a/modules/ims_registrar_scscf/cxdx_sar.c b/modules/ims_registrar_scscf/cxdx_sar.c index 3c67ce7..51dafdd 100644 --- a/modules/ims_registrar_scscf/cxdx_sar.c +++ b/modules/ims_registrar_scscf/cxdx_sar.c @@ -249,7 +249,8 @@ success: update_stat(accepted_registrations, 1); done: - reg_send_reply_transactional(t->uas.request, data->contact_header, t); + if (data->sar_assignment_type != AVP_IMS_SAR_UNREGISTERED_USER) + reg_send_reply_transactional(t->uas.request, data->contact_header, t); LM_DBG("DBG:SAR Async CDP callback: ... Done resuming transaction\n"); set_avp_list(AVP_TRACK_FROM | AVP_CLASS_URI, &t->uri_avps_from); set_avp_list(AVP_TRACK_TO | AVP_CLASS_URI, &t->uri_avps_to); @@ -274,7 +275,8 @@ done: return; error: - reg_send_reply_transactional(t->uas.request, data->contact_header, t); + if (data->sar_assignment_type != AVP_IMS_SAR_UNREGISTERED_USER) + reg_send_reply_transactional(t->uas.request, data->contact_header, t); error_no_send: //if we don't have the transaction then we can't send a transaction response update_stat(rejected_registrations, 1); diff --git a/modules/ims_registrar_scscf/reg_mod.c b/modules/ims_registrar_scscf/reg_mod.c index f948dcb..4e2a31e 100644 --- a/modules/ims_registrar_scscf/reg_mod.c +++ b/modules/ims_registrar_scscf/reg_mod.c @@ -108,12 +108,13 @@ static int mod_init(void); static int child_init(int); static void mod_destroy(void); static int w_save(struct sip_msg* _m, char* _d, char* mode, char* _cflags); -static int w_assign_server_unreg(struct sip_msg* _m, char* _d, char* _direction); +static int w_assign_server_unreg(struct sip_msg* _m, char* _route, char* _d, char* _direction); static int w_lookup(struct sip_msg* _m, char* _d, char* _p2); /*! \brief Fixup functions */ static int domain_fixup(void** param, int param_no); static int assign_save_fixup3(void** param, int param_no); +static int assign_save_fixup3_async(void** param, int param_no); //static int save_fixup2(void** param, int param_no); //static int assign_fixup2(void** param, int param_no); static int unreg_fixup(void** param, int param_no); @@ -190,7 +191,7 @@ static cmd_export_t cmds[] = { {"lookup", (cmd_function) w_lookup, 1, domain_fixup, 0, REQUEST_ROUTE | FAILURE_ROUTE}, {"term_impu_registered", (cmd_function) term_impu_registered, 1, domain_fixup, 0, REQUEST_ROUTE | FAILURE_ROUTE}, {"impu_registered", (cmd_function) impu_registered, 1, domain_fixup, 0, REQUEST_ROUTE | FAILURE_ROUTE}, - {"assign_server_unreg", (cmd_function) w_assign_server_unreg, 2, assign_save_fixup3, 0, REQUEST_ROUTE}, + {"assign_server_unreg", (cmd_function) w_assign_server_unreg, 3, assign_save_fixup3_async, 0, REQUEST_ROUTE}, {"add_sock_hdr", (cmd_function) add_sock_hdr, 1, fixup_str_null, 0, REQUEST_ROUTE}, {"unregister", (cmd_function) unregister, 2, unreg_fixup, 0, REQUEST_ROUTE | FAILURE_ROUTE}, {"reg_fetch_contacts", (cmd_function) pv_fetch_contacts, 3, fetchc_fixup, 0, REQUEST_ROUTE | FAILURE_ROUTE}, @@ -515,13 +516,12 @@ static int w_save(struct sip_msg* _m, char* _d, char* mode, char* _cflags) { return save(_m, _d); } -static int w_assign_server_unreg(struct sip_msg* _m, char* _d, char* _direction) { +static int w_assign_server_unreg(struct sip_msg* _m, char* _route, char* _d, char* _direction) { str direction; direction.s = _direction; direction.len = strlen(_direction); - //return assign_server_unreg(_m, (udomain_t*)_d, &direction); - return assign_server_unreg(_m, _d, &direction); + return assign_server_unreg(_m, _d, &direction, _route); } @@ -599,6 +599,33 @@ static int assign_save_fixup3(void** param, int param_no) { return 0; } +/* + * Convert the char* parameters + */ +static int assign_save_fixup3_async(void** param, int param_no) { + + if (strlen((char*) *param) <= 0) { + LM_ERR("empty parameter %d not allowed\n", param_no); + return -1; + } + + if (param_no == 1) { //route name - static or dynamic string (config vars) + if (fixup_spve_null(param, param_no) < 0) + return -1; + return 0; + } else if (param_no == 2) { + udomain_t* d; + + if (ul.register_udomain((char*) *param, &d) < 0) { + LM_ERR("Error doing fixup on assign save"); + return -1; + } + *param = (void*) d; + } + + return 0; +} + /*! \brief * Convert char* parameter to udomain_t* pointer * Convert char* parameter to pv_elem_t* pointer diff --git a/modules/ims_registrar_scscf/save.c b/modules/ims_registrar_scscf/save.c index 4eb8ab5..605fb76 100644 --- a/modules/ims_registrar_scscf/save.c +++ b/modules/ims_registrar_scscf/save.c @@ -926,20 +926,37 @@ error: } -int assign_server_unreg(struct sip_msg* _m, char* str1, str* direction) { +int assign_server_unreg(struct sip_msg* _m, char* str1, str* direction, char* route) { str private_identity = {0, 0}, public_identity = {0, 0}; int assignment_type = AVP_IMS_SAR_NO_ASSIGNMENT; int data_available = AVP_IMS_SAR_USER_DATA_NOT_AVAILABLE; int require_user_data = 1; rerrno = R_FINE; tm_cell_t *t = 0; + str route_name; saved_transaction_t* saved_t; cfg_action_t* cfg_action; - sar_param_t* ap = (sar_param_t*) str1; - cfg_action = ap->paction->next; - + udomain_t* _d = (udomain_t*) str1; + + if (fixup_get_svalue(_m, (gparam_t*) route, &route_name) != 0) { + LM_ERR("no async route block for assign_server_unreg\n"); + return -1; + } + + LM_DBG("Looking for route block [%.*s]\n", route_name.len, route_name.s); + int ri = route_get(&main_rt, route_name.s); + if (ri < 0) { + LM_ERR("unable to find route block [%.*s]\n", route_name.len, route_name.s); + return -1; + } + cfg_action = main_rt.rlist[ri]; + if (cfg_action == NULL) { + LM_ERR("empty action lists in route block [%.*s]\n", route_name.len, route_name.s); + return -1; + } + LM_DBG("Assigning unregistered user for direction [%.*s]\n", direction->len, direction->s); enum cscf_dialog_direction dir = cscf_get_dialog_direction(direction->s); @@ -995,7 +1012,7 @@ int assign_server_unreg(struct sip_msg* _m, char* str1, str* direction) { saved_t->expires = 1; //not a dereg as this is server_assign_unreg saved_t->require_user_data = require_user_data; saved_t->sar_assignment_type = assignment_type; - saved_t->domain = (udomain_t*) ap->param; + saved_t->domain = (udomain_t*) _d; saved_t->contact_header = 0; diff --git a/modules/ims_registrar_scscf/save.h b/modules/ims_registrar_scscf/save.h index 5ab4488..85ec2ce 100644 --- a/modules/ims_registrar_scscf/save.h +++ b/modules/ims_registrar_scscf/save.h @@ -56,7 +56,7 @@ /*! \brief * Process REGISTER request and save it's contacts */ -int assign_server_unreg(struct sip_msg* _m, char* str1, str* direction); +int assign_server_unreg(struct sip_msg* _m, char* str1, str* direction, char* route); int save(struct sip_msg* msg, char* str1);

1 0

Segfaults in mem subsystem
by Николай 23 Jun '13

23 Jun '13

Hi *, we are using kamailio built from source (with minor changes not in mem subsystem): # /usr/local/sbin/kamailio -V version: kamailio 3.4.0-dev6 (x86_64/linux) cd2b26-dirty flags: STATS: Off, USE_IPV6, USE_TCP, USE_TLS, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 4MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: cd2b26 -dirty compiled on 17:41:52 Jan 6 2013 with gcc 4.6.3 and facing segfaults in memory control subsystem in different places. Some examples follow: 1) (gdb) back #0 del_nonshm_lump (lump_list=0x7f750e650600) at data_lump.c:668 #1 0x00007f750e413d9c in ?? () #2 0x00000000008db480 in mem_pool () #3 0x00007f750e4137e1 in ?? () #4 0x0000000000000004 in ?? () #5 0x0000000001f200a7 in ?? () #6 0x00007f740b5e40f0 in ?? () #7 0x00007f740dc6d2a0 in ?? () #8 0x00007f740d9d0af0 in ?? () #9 0x00007f740c605900 in ?? () #10 0x0000000000000001 in ?? () #11 0x0000000000000000 in ?? () (gdb) info local r = 0x83b7b789de298df2 crt = 0x7f740c43ba60 prev = 0x7f750e650600 prev_r = 0x7f740c43ba60 2) (gdb) back #0 free_to_params (tb=0x1) at parser/parse_to.c:824 #1 free_to (tb=0x1) at parser/parse_to.c:836 #2 0x00007f4249ba2e92 in ?? () #3 0x00000000008db480 in mem_pool () #4 0x00007f4249ba27e1 in ?? () #5 0x0000000000000004 in ?? () #6 0x00000000027a5a37 in ?? () #7 0x00007f4146d831e0 in ?? () #8 0x00007f4148b7da50 in ?? () #9 0x00007f4147eec600 in ?? () #10 0x00007f4147f19350 in ?? () #11 0x0000000000000001 in ?? () #12 0x0000000000000000 in ?? () (gdb) info local tp = <value optimized out> 3) (gdb) back #0 free_lump_list (lump_list=<value optimized out>) at data_lump.c:504 #1 del_nonshm_lump (lump_list=<value optimized out>) at data_lump.c:661 #2 0x00007f0631a69d9c in ?? () #3 0x00000000008db480 in mem_pool () #4 0x00007f0631a697e1 in ?? () #5 0x0000000000000004 in ?? () #6 0x0000000000f4eb77 in ?? () #7 0x00007f052ec5a5b0 in ?? () #8 0x00007f05303071d0 in ?? () #9 0x00007f05309374c0 in ?? () #10 0x00007f0530e0ccd0 in ?? () #11 0x0000000000000001 in ?? () #12 0x0000000000000000 in ?? () (gdb) info local r = 0x7fa2312af83ca962 Are the issues already known/fixed? Should I post a bugreport? The memory subsystem looks pretty buggy... Does kamailio implement/use its own mem allocating system? PS I'm new to the list - sorry for possibly bad email Thanks ---- Nikolay

2 1

git:master: auth: set ids for elements in the documentation
by Daniel-Constantin Mierla 22 Jun '13

22 Jun '13

Module: sip-router Branch: master Commit: 678ab425062e6c6a30b5f1d37025c2bbdcd5425d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=678ab42… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jun 21 04:23:38 2013 +0200 auth: set ids for elements in the documentation - split checks parameters in own section for easier reference --- modules/auth/README | 686 +++++++++++++++++------------------ modules/auth/doc/auth_functions.xml | 18 +- modules/auth/doc/auth_params.xml | 54 ++-- 3 files changed, 383 insertions(+), 375 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=678…

1 0

Number of calls per profile
by Carlos Ruiz Díaz 21 Jun '13

21 Jun '13

Hi, is there a way of counting the number of calls a customer has without involving additional external scripting such as perl, lua, databases, etc? I tried to use the dialog module with set_dlg_profile() function but I wasn't able to provide the profile name using a pvar, instead a string constant was needed and, in my case, the nature of the name was dynamic and couldn't be specified statically. The original intention was to limit the amount of simultaneous calls using the proper methods but since it wasn't possible, at least the way I wanted to do it, I added this functionality to the cnxcc module which has all the necessary information to properly handle these scenarios. Regards, -- Carlos http://caruizdiaz.com +595981146623

1 0

git:master: Added support to limit number of calls per customer/profile
by Carlos Ruiz Diaz 20 Jun '13

20 Jun '13

Module: sip-router Branch: master Commit: fc83d3b1f1dd0934e5638b91d11e27f47880b411 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fc83d3b… Author: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Committer: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Date: Thu Jun 20 17:34:49 2013 -0400 Added support to limit number of calls per customer/profile - added function cnxcc_set_max_channels() per customer/profile - added function cnxcc_get_channel_count() per customer/profile - added function cnxcc_terminate_all() to terminate calls per customer/profile - added select @cnxcc.channels["customer/profile"].count - added modified version of kamailio-cnxcc.cfg to reflect changes and examples --- modules/cnxcc/cnxcc_check.c | 23 ++- modules/cnxcc/cnxcc_check.h | 23 ++- modules/cnxcc/cnxcc_mod.c | 369 ++++++++++++++++++++++++++++-- modules/cnxcc/cnxcc_mod.h | 6 +- modules/cnxcc/cnxcc_rpc.c | 23 ++- modules/cnxcc/cnxcc_rpc.h | 23 ++- modules/cnxcc/cnxcc_select.c | 67 ++++++ modules/cnxcc/cnxcc_select.h | 32 +++ modules/cnxcc/example/kamailio-cnxcc.cfg | 105 ++++++++- 9 files changed, 629 insertions(+), 42 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=fc8…

1 0

← Newer
1
2
3
4
5
6
7
...
24
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2013