sr-dev July 2013

sr-dev@lists.kamailio.org

21 participants
246 discussions

Outbound flow failure handling merged to master

by Hugh Waite

Hello, As you will see I have merged my branch back into master. These changes add a new event route [tm:branch-failure] to the tm module which is run when any failure response is received on a transaction. The event_route uses a new route type BRANCH_ROUTE which limits the functions that can be run in the route. The functions t_check_status(), t_next_contact_flow(), t_relay() and unregister() can be used in this route. A new pv $T_reply_ruid is accessible in this route which can be used to unregister a single contact entry. The following example route can be used on a registrar to handle failed or invalid flows: event_route[tm:branch-failure] { xlog("L_INFO", "event_route[tm:branch-failure]\n"); if (t_check_status("430|403")) { if (!unregister("location", "$tu", "$T_reply_ruid")) { xlog("L_WARN", "failed to unregister $tu with ruid $T_reply_ruid\n"); } if (!t_next_contact_flow()) { xlog("L_INFO", "No more flows\n"); } else { xlog("L_INFO", "Next flow\n"); t_relay(); } } } Any bugs, memory leaks etc. let me know! Hugh -- Hugh Waite Principal Design Engineer Crocodile RCS Ltd.

8 years, 1 month

Using t_suspend()/t_continue() multiple times on the same transaction

by Peter Dunkley

Hi, I am trying to use t_suspend()/t_continue() multiple times on the same transaction. Calling t_suspend() more than once works, but the second time I call t_continue() the transaction is killed and a 500 response is sent. It is the "if (branch == t->nr_of_outgoings)" check from the code fragment below (from t_suspend.c:t_continue()) that results in the transaction being killed - you can see the debug/error line I added to determine this in the fragment. Is using t_suspend()/t_continue() multiple times something that should work? Thanks, Peter if (t->uas.status < 200) { /* No final reply has been sent yet. * Check whether or not there is any pending branch. */ for ( branch = 0; branch < t->nr_of_outgoings; branch++ ) { if ((t->uac[branch].request.buffer != NULL) && (t->uac[branch].last_received < 200) ) break; } if (branch == t->nr_of_outgoings) { /* There is not any open branch so there is * no chance that a final response will be received. */ ret = 0; LM_ERR("branch == t->nr_of_outgoings\n"); goto kill_trans; } } -- Peter Dunkley Technical Director Crocodile RCS Ltd

10 years, 6 months

default config: do loose_route() for in-dialog NOTIFY as per new RFC 6665

by Iñaki Baz Castillo

Hi, the new RFC 6665 mandates that the subscription dialog is made *after* the first NOTIFY from the UAS (rather than after the 200 to the initial SUBSCRIBE). This means that the UAC MUST take the route set from the *first* received NOTIFY (instead of taking it from the 200 to the initial SUBSCRIBE). Therefore a proxy compliant with RFC 6665 MUST always add RR to in-dialog NOTIFY requests and thus, I propose that the default SR script file implements it. Regards. -- Iñaki Baz Castillo <ibc(a)aliax.net>

10 years, 10 months

json and jsonrpc-c modules

by Matthew Williams

Hi, The Flowroute development team is pleased to announce a complete overhaul of the json and jsonrpc-c modules, originally authored two years ago. Credit should first and foremost go to Joe Hillenbrand who did most of the new development. Jordan Levy (our CTO) and I were also involved in the updates and QA to a lesser extent. The updated modules are available in the mgw/json branch. In addition to the Kamailio modules, we have developed a Twisted Python library to complement the jsonrpc-c module: https://github.com/flowroute/txjason We would be interested in any critiques of the API, documentation, and code. Please let us know if you use these modules and especially if you find any bugs. We hope to merge this into master once we have had it in production for awhile and (ideally) have received some feedback from other users. Feel free to contact either Joe (joe(a)flowroute.com) or me directly with any questions or comments. -- Matthew Williams Flowroute LLC http://www.flowroute.com/

11 years, 3 months

git:tmp/tm_async_extensions: modules/tm: extensions for tm asynchronous processing of requests

by Jason Penton

Module: sip-router Branch: tmp/tm_async_extensions Commit: ebbb462fcc7ff9380b30441492403b3a0a3a9c10 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ebbb462… Author: Jason Penton <jason.penton(a)smilecoms.com> Committer: Jason Penton <jason.penton(a)smilecoms.com> Date: Wed Jul 31 21:46:26 2013 +0200 modules/tm: extensions for tm asynchronous processing of requests - allow t_relay and forward, etc processing in aysn route blocks - extends to allow any route block to be continued, not only failure route block... --- modules/tm/h_table.c | 1 + modules/tm/h_table.h | 17 +++++- modules/tm/lock.c | 36 ++++++++++++- modules/tm/lock.h | 1 + modules/tm/t_fwd.c | 5 ++ modules/tm/t_reply.c | 135 +++++++++++++++++++++++++++-------------------- modules/tm/t_reply.h | 2 +- modules/tm/t_suspend.c | 75 ++++++++++++++++----------- modules/tm/t_suspend.h | 3 + 9 files changed, 182 insertions(+), 93 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=ebb…

11 years, 5 months

git:tmp/tm_async_extensions: acc: acc_db_set_table_name fixup

by Jason Penton

Module: sip-router Branch: tmp/tm_async_extensions Commit: 7ba6cbfcaf70cb546ea3a9f148a0f0b0bc38c16d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7ba6cbf… Author: Federico Cabiddu <fcabiddu(a)orange-vallee.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Jul 29 07:59:13 2013 +0200 acc: acc_db_set_table_name fixup - add termination char to db_table_name_buf --- modules/acc/acc_logic.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules/acc/acc_logic.c b/modules/acc/acc_logic.c index 55b4196..c9bdd20 100644 --- a/modules/acc/acc_logic.c +++ b/modules/acc/acc_logic.c @@ -197,6 +197,8 @@ int acc_db_set_table_name(struct sip_msg *msg, void *param, str *table) return -1; } strncpy(db_table_name_buf, dbtable.s, dbtable.len); + /* FS#327: since the buffer is static terminate the table name */ + db_table_name_buf[dbtable.len] = '\0'; env_set_text(db_table_name_buf, dbtable.len); } else { if(table==NULL) {

11 years, 5 months

git:3.3: perl: push the sip msg structure to perl after initializing it

by Daniel-Constantin Mierla

Module: sip-router Branch: 3.3 Commit: f2b89129941c93ffae99c2d2b35990333b339eb0 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f2b8912… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jul 31 13:51:34 2013 +0200 perl: push the sip msg structure to perl after initializing it - reported by David Cunningham - backport from amster commit 341f810dca0cc0596e22f2ac1bca86de0b8d142d --- modules_k/perl/perlfunc.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules_k/perl/perlfunc.c b/modules_k/perl/perlfunc.c index 9684a0d..47886c6 100644 --- a/modules_k/perl/perlfunc.c +++ b/modules_k/perl/perlfunc.c @@ -131,12 +131,13 @@ int perl_exec2(struct sip_msg* _msg, char* fnc, char* mystr) { ENTER; /* everything created after here */ SAVETMPS; /* ...is a temporary variable. */ PUSHMARK(SP); /* remember the stack pointer */ - XPUSHs(m); /* Our reference to the stack... */ m = sv_newmortal(); sv_setref_pv(m, "OpenSER::Message", (void *)_msg); SvREADONLY_on(SvRV(m)); + XPUSHs(m); /* Our reference to the stack... */ + if (mystr) XPUSHs(sv_2mortal(newSVpv(mystr, strlen(mystr)))); /* Our string to the stack... */

11 years, 5 months

git:4.0: app_perl: push the sip msg structure to perl after initializing it

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.0 Commit: 3935fedf23f3bf2b6675182193cef6af3bbd903a URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3935fed… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jul 31 12:22:12 2013 +0200 app_perl: push the sip msg structure to perl after initializing it - reported by David Cunningham (cherry picked from commit 341f810dca0cc0596e22f2ac1bca86de0b8d142d) --- modules/app_perl/perlfunc.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules/app_perl/perlfunc.c b/modules/app_perl/perlfunc.c index 90a80d4..06d3314 100644 --- a/modules/app_perl/perlfunc.c +++ b/modules/app_perl/perlfunc.c @@ -130,12 +130,13 @@ int perl_exec2(struct sip_msg* _msg, char* fnc, char* mystr) { ENTER; /* everything created after here */ SAVETMPS; /* ...is a temporary variable. */ PUSHMARK(SP); /* remember the stack pointer */ - XPUSHs(m); /* Our reference to the stack... */ m = sv_newmortal(); sv_setref_pv(m, "Kamailio::Message", (void *)_msg); SvREADONLY_on(SvRV(m)); + XPUSHs(m); /* Our reference to the stack... */ + if (mystr) XPUSHs(sv_2mortal(newSVpv(mystr, strlen(mystr)))); /* Our string to the stack... */

11 years, 5 months

git:master: app_perl: push the sip msg structure to perl after initializing it

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 341f810dca0cc0596e22f2ac1bca86de0b8d142d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=341f810… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Jul 31 12:22:12 2013 +0200 app_perl: push the sip msg structure to perl after initializing it - reported by David Cunningham --- modules/app_perl/perlfunc.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/modules/app_perl/perlfunc.c b/modules/app_perl/perlfunc.c index 90a80d4..06d3314 100644 --- a/modules/app_perl/perlfunc.c +++ b/modules/app_perl/perlfunc.c @@ -130,12 +130,13 @@ int perl_exec2(struct sip_msg* _msg, char* fnc, char* mystr) { ENTER; /* everything created after here */ SAVETMPS; /* ...is a temporary variable. */ PUSHMARK(SP); /* remember the stack pointer */ - XPUSHs(m); /* Our reference to the stack... */ m = sv_newmortal(); sv_setref_pv(m, "Kamailio::Message", (void *)_msg); SvREADONLY_on(SvRV(m)); + XPUSHs(m); /* Our reference to the stack... */ + if (mystr) XPUSHs(sv_2mortal(newSVpv(mystr, strlen(mystr)))); /* Our string to the stack... */

11 years, 5 months

[tracker] Task opened: SCA - Primary line appearance hangs when secondary is picked up.

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Kevin Scott Adams (TheGrandWazoo) Attached to Project - sip-router Summary - SCA - Primary line appearance hangs when secondary is picked up. Task Type - Bug Report Category - Module Status - Unconfirmed Assigned To - Operating System - Linux Severity - Medium Priority - Normal Reported Version - 4.0 Due in Version - Undecided Due Date - Undecided Details - Using Polycom 650's with SIP Firmware 3.3.5 or 4.0.4 and Kamailio 4.0.2 the following happens.. If you have two line appearances with 1 call each and you select the 2nd appearance the 1st appearance on both phones will illuminate. When you hangup the second appearance the first will stay in a 'seized' state on both phones. Using the kamcmd sca.release_appearance will clear 'seized' line. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=329 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2013