sr-dev July 2013

sr-dev@lists.kamailio.org

21 participants
246 discussions

git:4.0: modules/ims_registrar_scscf: safety check in async_cdp_callback
by Camille Oudot 25 Jul '13

25 Jul '13

Module: sip-router Branch: 4.0 Commit: 3438215263f20f63f0e69121113999f952334886 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3438215… Author: Camille Oudot <camille.oudot(a)orange.com> Committer: Camille Oudot <camille.oudot(a)orange.com> Date: Tue Jul 23 11:11:01 2013 +0200 modules/ims_registrar_scscf: safety check in async_cdp_callback (cherry-picked from commit 1aea13af9b3eea3788e90411bd94cb9e0b0c4ea3) --- modules/ims_auth/cxdx_mar.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/modules/ims_auth/cxdx_mar.c b/modules/ims_auth/cxdx_mar.c index 2ec113b..7fea383 100644 --- a/modules/ims_auth/cxdx_mar.c +++ b/modules/ims_auth/cxdx_mar.c @@ -425,13 +425,14 @@ done: shm_free(avlist); avlist = 0; } - struct auth_data_item *tmp1 = adi_list->first; - while (tmp1) { - struct auth_data_item *tmp2 = tmp1->next; - shm_free(tmp1); - tmp1 = tmp2; - } + if (adi_list) { + struct auth_data_item *tmp1 = adi_list->first; + while (tmp1) { + struct auth_data_item *tmp2 = tmp1->next; + shm_free(tmp1); + tmp1 = tmp2; + } shm_free(adi_list); adi_list = 0; }

1 0

git:master: modules/ims_registrar_scscf: safety check in async_cdp_callback
by Camille Oudot 25 Jul '13

25 Jul '13

Module: sip-router Branch: master Commit: 1aea13af9b3eea3788e90411bd94cb9e0b0c4ea3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1aea13a… Author: Camille Oudot <camille.oudot(a)orange.com> Committer: Camille Oudot <camille.oudot(a)orange.com> Date: Tue Jul 23 11:11:01 2013 +0200 modules/ims_registrar_scscf: safety check in async_cdp_callback --- modules/ims_auth/cxdx_mar.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/modules/ims_auth/cxdx_mar.c b/modules/ims_auth/cxdx_mar.c index 4fa7e17..f48927b 100644 --- a/modules/ims_auth/cxdx_mar.c +++ b/modules/ims_auth/cxdx_mar.c @@ -426,13 +426,14 @@ done: shm_free(avlist); avlist = 0; } - struct auth_data_item *tmp1 = adi_list->first; - while (tmp1) { - struct auth_data_item *tmp2 = tmp1->next; - shm_free(tmp1); - tmp1 = tmp2; - } + if (adi_list) { + struct auth_data_item *tmp1 = adi_list->first; + while (tmp1) { + struct auth_data_item *tmp2 = tmp1->next; + shm_free(tmp1); + tmp1 = tmp2; + } shm_free(adi_list); adi_list = 0; }

1 0

[tracker] Comment added: Parser doesn't eliminate linebreaks when logging bad packets, breaks syslog
by sip-router 25 Jul '13

25 Jul '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#328 - Parser doesn't eliminate linebreaks when logging bad packets, breaks syslog User who did this - Sebastian Damm (sdamm) ---------- No I haven't. And in fact, those systems are running different debian versions, and thus different syslog-ng versions as well. Didn't think of syslog-ng as the source of the problems. Could you please close this as "not a bug"? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=328#comment1028 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: Parser doesn't eliminate linebreaks when logging bad packets, breaks syslog
by sip-router 25 Jul '13

25 Jul '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#328 - Parser doesn't eliminate linebreaks when logging bad packets, breaks syslog User who did this - Daniel-Constantin Mierla (miconda) ---------- I did a diff to relevant files between 3.1 and 4.0, respectively: parser/msg_parser.c dprint.c dprint.h Nothing was changed in regard to what you see. There was no stripping at any time of linebreaks from the message and the logging functions were not changed as well. Have you run the two versions on the same host? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=328#comment1027 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task opened: Parser doesn't eliminate linebreaks when logging bad packets, breaks syslog
by sip-router 25 Jul '13

25 Jul '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Sebastian Damm (sdamm) Attached to Project - sip-router Summary - Parser doesn't eliminate linebreaks when logging bad packets, breaks syslog Task Type - Bug Report Category - Core Status - Unconfirmed Assigned To - Operating System - Linux Severity - Low Priority - Normal Reported Version - 4.0 Due in Version - Undecided Due Date - Undecided Details - When sending broken packets to a Kamailio 4.0, the parser logs the complete packet. In Kamailio 3.1 it eliminated line breaks before logging, so that one line with the the packet was written to the correct logfile. In Kamailio 4.0 only the first line of the broken packet is written to the logfile, the rest of the packet is written to the main syslog file (probably since no syslog facility is specified). Comparison: Kamailio 3.1 kamailio.log Jul 25 06:26:00 hostname /usr/sbin/kamailio[5452]: ERROR: <core> [parser/msg_parser.c:714]: ERROR: parse_msg: message=<REGISTER sip:Dach GXP2100 SIP/2.0 Via: SIP/2.0/UDP 192.168.0.209:5468;branch=z9hG4bK1668961676;rport From: <sip:1234567e20@Dach GXP2100>;tag=1685573665 To: <sip:1234567e20@Dach GXP2100> Call-ID: 1720384019-5468-1(a)BJC.BGI.A.CAJ CSeq: 28699 REGISTER Contact: <sip:1234567e20@192.168.0.209:5468>;reg-id=1;+sip.instance="<urn:uuid:00000000-0000-1000-8000-000B823AFF6E>" X-Grandstream-PBX: true Max-Forwards: 70 User-Agent: Grandstream GXP2100 1.0.1.110 Supported: path Expires: 600 Allow: INVITE, ACK, OPTIONS, CANCEL, BYE, SUBSCRIBE, NOTIFY, INFO, REFER, UPDATE, MESSAGE Content-Length: 0 > Kamailio 4.0 kamailio.log Jul 25 06:26:00 hostname /usr/sbin/kamailio[13036]: ERROR: <core> [parser/msg_parser.c:705]: parse_msg(): ERROR: parse_msg: message=<REGISTER sip:Dach GXP2100 SIP/2.0 syslog Jul 25 06:26:00 hostname Via: SIP/2.0/UDP 192.168.0.209:5468;branch=z9hG4bK1668961676;rport Jul 25 06:26:00 hostname From: <sip:1234567e20@Dach GXP2100>;tag=1685573665 Jul 25 06:26:00 hostname To: <sip:1234567e20@Dach GXP2100> Jul 25 06:26:00 hostname Call-ID: 1720384019-5468-1(a)BJC.BGI.A.CAJ Jul 25 06:26:00 hostname CSeq: 28699 REGISTER Jul 25 06:26:00 hostname Contact: <sip:1234567e20@192.168.0.209:5468>;reg-id=1;+sip.instance="<urn:uuid:00000000-0000-1000-8000-000B823AFF6E>" Jul 25 06:26:00 hostname X-Grandstream-PBX: true Jul 25 06:26:00 hostname Max-Forwards: 70 Jul 25 06:26:00 hostname User-Agent: Grandstream GXP2100 1.0.1.110 Jul 25 06:26:00 hostname Supported: path Jul 25 06:26:00 hostname Expires: 600 Jul 25 06:26:00 hostname Allow: INVITE, ACK, OPTIONS, CANCEL, BYE, SUBSCRIBE, NOTIFY, INFO, REFER, UPDATE, MESSAGE Jul 25 06:26:00 hostname Content-Length: 0 Jul 25 06:26:00 hostname > How to reproduce: Configure Kamailio to log into a syslog facility, then send a broken packet to that kamailio. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=328 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: Possible memory leak in srdb1
by sip-router 25 Jul '13

25 Jul '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#319 - Possible memory leak in srdb1 User who did this - Daniel-Constantin Mierla (miconda) Reason for closing: Not a bug Additional comments about closing: Re-open if having clear details pointing to the source code files and lines. More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=319 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:4.0: app_perl: move initialization of SIP message var after initialization of temporary environment
by Daniel-Constantin Mierla 25 Jul '13

25 Jul '13

Module: sip-router Branch: 4.0 Commit: 4471593e5f6e292d205bd84fb5912088bde32870 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4471593… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 25 10:14:55 2013 +0200 app_perl: move initialization of SIP message var after initialization of temporary environment - upon a report by David Cunningham of a leak in operating system memory (cherry picked from commit 6ff74701652a11497bd82ee3ba2ac7547d1ce666) --- modules/app_perl/perlfunc.c | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/modules/app_perl/perlfunc.c b/modules/app_perl/perlfunc.c index 96f7596..90a80d4 100644 --- a/modules/app_perl/perlfunc.c +++ b/modules/app_perl/perlfunc.c @@ -127,16 +127,15 @@ int perl_exec2(struct sip_msg* _msg, char* fnc, char* mystr) { return -1; } - m = sv_newmortal(); - sv_setref_pv(m, "Kamailio::Message", (void *)_msg); - SvREADONLY_on(SvRV(m)); - - ENTER; /* everything created after here */ SAVETMPS; /* ...is a temporary variable. */ - PUSHMARK(SP); /* remember the stack pointer */ + PUSHMARK(SP); /* remember the stack pointer */ XPUSHs(m); /* Our reference to the stack... */ + m = sv_newmortal(); + sv_setref_pv(m, "Kamailio::Message", (void *)_msg); + SvREADONLY_on(SvRV(m)); + if (mystr) XPUSHs(sv_2mortal(newSVpv(mystr, strlen(mystr)))); /* Our string to the stack... */

1 0

git:3.3: perl: move initialization of SIP message var after initialization of temporary environment
by Daniel-Constantin Mierla 25 Jul '13

25 Jul '13

Module: sip-router Branch: 3.3 Commit: fe571b1cc75132994fb94879e294dfc79c2e2787 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fe571b1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 25 11:47:12 2013 +0200 perl: move initialization of SIP message var after initialization of temporary environment - upon a report by David Cunningham of a leak in operating system memory - backport from master commit 6ff74701652a11497bd82ee3ba2ac7547d1ce666 --- modules_k/perl/perlfunc.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules_k/perl/perlfunc.c b/modules_k/perl/perlfunc.c index f65b9c0..9684a0d 100644 --- a/modules_k/perl/perlfunc.c +++ b/modules_k/perl/perlfunc.c @@ -127,16 +127,16 @@ int perl_exec2(struct sip_msg* _msg, char* fnc, char* mystr) { return -1; } - m = sv_newmortal(); - sv_setref_pv(m, "OpenSER::Message", (void *)_msg); - SvREADONLY_on(SvRV(m)); - ENTER; /* everything created after here */ SAVETMPS; /* ...is a temporary variable. */ PUSHMARK(SP); /* remember the stack pointer */ XPUSHs(m); /* Our reference to the stack... */ + m = sv_newmortal(); + sv_setref_pv(m, "OpenSER::Message", (void *)_msg); + SvREADONLY_on(SvRV(m)); + if (mystr) XPUSHs(sv_2mortal(newSVpv(mystr, strlen(mystr)))); /* Our string to the stack... */

1 0

git:master: app_perl: move initialization of SIP message var after initialization of temporary environment
by Daniel-Constantin Mierla 25 Jul '13

25 Jul '13

Module: sip-router Branch: master Commit: 6ff74701652a11497bd82ee3ba2ac7547d1ce666 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6ff7470… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Jul 25 10:14:55 2013 +0200 app_perl: move initialization of SIP message var after initialization of temporary environment - upon a report by David Cunningham of a leak in operating system memory --- modules/app_perl/perlfunc.c | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/modules/app_perl/perlfunc.c b/modules/app_perl/perlfunc.c index 96f7596..90a80d4 100644 --- a/modules/app_perl/perlfunc.c +++ b/modules/app_perl/perlfunc.c @@ -127,16 +127,15 @@ int perl_exec2(struct sip_msg* _msg, char* fnc, char* mystr) { return -1; } - m = sv_newmortal(); - sv_setref_pv(m, "Kamailio::Message", (void *)_msg); - SvREADONLY_on(SvRV(m)); - - ENTER; /* everything created after here */ SAVETMPS; /* ...is a temporary variable. */ - PUSHMARK(SP); /* remember the stack pointer */ + PUSHMARK(SP); /* remember the stack pointer */ XPUSHs(m); /* Our reference to the stack... */ + m = sv_newmortal(); + sv_setref_pv(m, "Kamailio::Message", (void *)_msg); + SvREADONLY_on(SvRV(m)); + if (mystr) XPUSHs(sv_2mortal(newSVpv(mystr, strlen(mystr)))); /* Our string to the stack... */

1 0

[tracker] Comment added: bugs in uac_redirect module
by sip-router 24 Jul '13

24 Jul '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#327 - bugs in uac_redirect module User who did this - Daniel-Constantin Mierla (miconda) ---------- In the patch for acc, why is needed the next part? + + if (dbtable.len < DB_TABLE_NAME_SIZE) { + db_table_name_buf[dbtable.len] = '\0'; + } + ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=327#comment1026 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
2
3
4
5
6
7
...
25
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2013