sr-dev August 2013

sr-dev@lists.kamailio.org

29 participants
148 discussions

[tracker] Comment added: debugger: new RPC command dbg.reset_msgid

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#330 - debugger: new RPC command dbg.reset_msgid User who did this - Daniel-Constantin Mierla (miconda) ---------- It can be committed. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=330#comment1047 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

git:4.0: usrloc: safety checks to catch empty ruid

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.0 Commit: 3898507f56eefe5c9d8e72b37280e0d133f6e357 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3898507… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Aug 13 09:37:21 2013 +0200 usrloc: safety checks to catch empty ruid (cherry picked from commit b0e9132ccd1e8385b8b4faf72db806320d48e2f5) --- modules/usrloc/ucontact.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/modules/usrloc/ucontact.c b/modules/usrloc/ucontact.c index 35dfa0d..996e8d5 100644 --- a/modules/usrloc/ucontact.c +++ b/modules/usrloc/ucontact.c @@ -93,6 +93,11 @@ ucontact_t* new_ucontact(str* _dom, str* _aor, str* _contact, ucontact_info_t* _ { ucontact_t *c; + if(unlikely(_ci->ruid.len<=0)) { + LM_ERR("no ruid for aor: %.*s\n", _aor->len, ZSW(_aor->s)); + return 0; + } + c = (ucontact_t*)shm_malloc(sizeof(ucontact_t)); if (!c) { LM_ERR("no more shm memory\n"); @@ -465,6 +470,11 @@ int db_insert_ucontact(ucontact_t* _c) if (_c->flags & FL_MEM) { return 0; } + if(unlikely(_c->ruid.len<=0)) { + LM_ERR("invalid ruid for aor: %.*s\n", + _c->aor->len, ZSW(_c->aor->s)); + return -1; + } keys[0] = &user_col; keys[1] = &contact_col;

11 years

git:master: usrloc: safety checks to catch empty ruid

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: b0e9132ccd1e8385b8b4faf72db806320d48e2f5 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b0e9132… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Aug 13 09:37:21 2013 +0200 usrloc: safety checks to catch empty ruid --- modules/usrloc/ucontact.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/modules/usrloc/ucontact.c b/modules/usrloc/ucontact.c index c8da8ec..d1ae1f3 100644 --- a/modules/usrloc/ucontact.c +++ b/modules/usrloc/ucontact.c @@ -93,6 +93,11 @@ ucontact_t* new_ucontact(str* _dom, str* _aor, str* _contact, ucontact_info_t* _ { ucontact_t *c; + if(unlikely(_ci->ruid.len<=0)) { + LM_ERR("no ruid for aor: %.*s\n", _aor->len, ZSW(_aor->s)); + return 0; + } + c = (ucontact_t*)shm_malloc(sizeof(ucontact_t)); if (!c) { LM_ERR("no more shm memory\n"); @@ -465,6 +470,11 @@ int db_insert_ucontact(ucontact_t* _c) if (_c->flags & FL_MEM) { return 0; } + if(unlikely(_c->ruid.len<=0)) { + LM_ERR("invalid ruid for aor: %.*s\n", + _c->aor->len, ZSW(_c->aor->s)); + return -1; + } keys[0] = &user_col; keys[1] = &contact_col;

11 years

git:tmp/tm_async_reply_support: Merge branch 'master' into tmp/ tm_async_reply_support

by Richard Good

Module: sip-router Branch: tmp/tm_async_reply_support Commit: 7637a9ae26113813394f8a4def451e08b9660cd8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7637a9a… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Tue Aug 13 09:28:22 2013 +0200 Merge branch 'master' into tmp/tm_async_reply_support ---

11 years

[tracker] Comment added: debugger: new RPC command dbg.reset_msgid (Attachment added)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#330 - debugger: new RPC command dbg.reset_msgid User who did this - Víctor Seva (linuxmaniac) ---------- This version does not need any changes in core. As you said I use a pre-script callback to modify the msg->id. Internally there is no change. The module debugger changes the id when it's necessary. When the dbg.reset_msgid command is triggered the flag reset_msg is set to 1 ( per process ). If the flag is set, I save the value of the current msg->id ( per process ) as msgid_base and the msg->id is "reset". Thanks for the help! ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=330#comment1046 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years

git:richard.good/diameter_rx_media: Merge branch 'master' into richard.good /diameter_rx_media

by Richard Good

Module: sip-router Branch: richard.good/diameter_rx_media Commit: cf23fa53124a13db8610bf84b82762b5096eaf5b URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cf23fa5… Author: Richard Good <richard.good(a)smilecoms.com> Committer: Richard Good <richard.good(a)smilecoms.com> Date: Tue Aug 13 09:21:25 2013 +0200 Merge branch 'master' into richard.good/diameter_rx_media ---

11 years

git:4.0: usrloc: more verbose log messages in case of failure to update db records

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.0 Commit: e59bb3303252c0b47f6027ae2b99a11096521154 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e59bb33… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Aug 13 09:19:02 2013 +0200 usrloc: more verbose log messages in case of failure to update db records (cherry picked from commit 66c8e730d59f9816f09573f5300e4463e5997876) --- modules/usrloc/urecord.c | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/modules/usrloc/urecord.c b/modules/usrloc/urecord.c index dd98450..75ddd1a 100644 --- a/modules/usrloc/urecord.c +++ b/modules/usrloc/urecord.c @@ -333,7 +333,9 @@ static inline void wb_timer(urecord_t* _r) /* Should we remove the contact from the database ? */ if (st_expired_ucontact(t) == 1) { if (db_delete_ucontact(t) < 0) { - LM_ERR("failed to delete contact from the database\n"); + LM_ERR("failed to delete contact from the database" + " (aor: %.*s)\n", + ptr->aor->len, ZSW(ptr->aor->s)); } } @@ -349,7 +351,9 @@ static inline void wb_timer(urecord_t* _r) case 1: /* insert */ if (db_insert_ucontact(ptr) < 0) { - LM_ERR("inserting contact into database failed\n"); + LM_ERR("inserting contact into database failed" + " (aor: %.*s)\n", + ptr->aor->len, ZSW(ptr->aor->s)); ptr->state = old_state; } break; @@ -360,7 +364,8 @@ static inline void wb_timer(urecord_t* _r) else res = db_update_ucontact(ptr); if (res < 0) { - LM_ERR("updating contact in db failed\n"); + LM_ERR("updating contact in db failed (aor: %.*s)\n", + ptr->aor->len, ZSW(ptr->aor->s)); ptr->state = old_state; } break;

11 years

git:master: usrloc: more verbose log messages in case of failure to update db records

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 66c8e730d59f9816f09573f5300e4463e5997876 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=66c8e73… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Aug 13 09:19:02 2013 +0200 usrloc: more verbose log messages in case of failure to update db records --- modules/usrloc/urecord.c | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/modules/usrloc/urecord.c b/modules/usrloc/urecord.c index 89defe0..93c8446 100644 --- a/modules/usrloc/urecord.c +++ b/modules/usrloc/urecord.c @@ -333,7 +333,9 @@ static inline void wb_timer(urecord_t* _r) /* Should we remove the contact from the database ? */ if (st_expired_ucontact(t) == 1) { if (db_delete_ucontact(t) < 0) { - LM_ERR("failed to delete contact from the database\n"); + LM_ERR("failed to delete contact from the database" + " (aor: %.*s)\n", + ptr->aor->len, ZSW(ptr->aor->s)); } } @@ -349,7 +351,9 @@ static inline void wb_timer(urecord_t* _r) case 1: /* insert */ if (db_insert_ucontact(ptr) < 0) { - LM_ERR("inserting contact into database failed\n"); + LM_ERR("inserting contact into database failed" + " (aor: %.*s)\n", + ptr->aor->len, ZSW(ptr->aor->s)); ptr->state = old_state; } break; @@ -360,7 +364,8 @@ static inline void wb_timer(urecord_t* _r) else res = db_update_ucontact(ptr); if (res < 0) { - LM_ERR("updating contact in db failed\n"); + LM_ERR("updating contact in db failed (aor: %.*s)\n", + ptr->aor->len, ZSW(ptr->aor->s)); ptr->state = old_state; } break;

11 years

git:master: presence: Iterate correctly around presence updates

by Hugh Waite

Module: sip-router Branch: master Commit: d1cda7ca9a64cf818b82f7b777fa2dd640717c53 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d1cda7c… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Mon Aug 12 11:15:55 2013 +0100 presence: Iterate correctly around presence updates - timer_send_notify should increment the subset by one on each loop --- modules/presence/notify.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/presence/notify.c b/modules/presence/notify.c index d06fa6c..0a7ffb2 100644 --- a/modules/presence/notify.c +++ b/modules/presence/notify.c @@ -2667,9 +2667,6 @@ int process_dialogs(int round, int presence_winfo) int updated = 0; db_query_f query_fn = pa_dbf.query_lock ? pa_dbf.query_lock : pa_dbf.query; - if (++subset > (pres_waitn_time * pres_notifier_poll_rate) -1) - subset = 0; - query_cols[n_query_cols] = &str_updated_col; query_vals[n_query_cols].type = DB1_INT; query_vals[n_query_cols].nul = 0; @@ -3000,6 +2997,9 @@ void pres_timer_send_notify(unsigned int ticks, void *param) int round = subset + (pres_waitn_time * pres_notifier_poll_rate * process_num); + if (++subset > (pres_waitn_time * pres_notifier_poll_rate) -1) + subset = 0; + if (process_dialogs(round, 0) < 0) { LM_ERR("Handling non presence.winfo dialogs\n");

11 years

git:master: rls: Fix memory leak in rls notify.c

by Hugh Waite

Module: sip-router Branch: master Commit: 4f42993660c52c757918ca2806f7ffe6af0674ce URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4f42993… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Committer: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Mon Aug 12 11:05:55 2013 +0100 rls: Fix memory leak in rls notify.c - xml is leaked in an error case --- modules/rls/notify.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/modules/rls/notify.c b/modules/rls/notify.c index 7b5bec3..6738f91 100644 --- a/modules/rls/notify.c +++ b/modules/rls/notify.c @@ -1073,6 +1073,7 @@ int process_list_and_exec(xmlNodePtr list_node, str username, str domain, else { LM_ERR("unable to parse URI for <resource-list/>\n"); + xmlFree(uri.s); return -1; } }

11 years

← Newer
1
...
8
9
10
11
12
13
14
15
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2013