sr-dev September 2013

sr-dev@lists.kamailio.org

33 participants
296 discussions

[tracker] Comment added: avpops: use xavp semantic on second parameter

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#346 - avpops: use xavp semantic on second parameter User who did this - Daniel-Constantin Mierla (miconda) ---------- It is ok. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=346#comment1090 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 2 months

[tracker] Comment added: xavp semantics

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#345 - xavp semantics User who did this - Daniel-Constantin Mierla (miconda) ---------- Instead of declaring a local buffer where you print the values, better use pv_get_buffer() which returns a buffer from core (which part of a group of buffers circularly returned for various PV needs). It is better because the size of the buffer can be set via config parameter: * http://www.kamailio.org/wiki/cookbooks/devel/core#pv_buffer_size You can get the size of the buffer via pv_get_buffer_size(), so you can check for buffer overflow. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=345#comment1089 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

11 years, 2 months

git:master: xcap_client: fix what it seems to be an old copy/paste error

by Ovidiu Sas

Module: sip-router Branch: master Commit: 5acf191aee9d10b26b730df20d622e527c656db3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5acf191… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Wed Sep 18 17:10:10 2013 -0400 xcap_client: fix what it seems to be an old copy/paste error --- modules/xcap_client/xcap_callbacks.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/xcap_client/xcap_callbacks.c b/modules/xcap_client/xcap_callbacks.c index 58c1fc0..93d32ff 100644 --- a/modules/xcap_client/xcap_callbacks.c +++ b/modules/xcap_client/xcap_callbacks.c @@ -78,6 +78,6 @@ void destroy_xcapcb_list(void) { prev_xcb= xcb; xcb= xcb->next; - shm_free(xcb); + shm_free(prev_xcb); } }

11 years, 2 months

git:master: xcap_client: fix what it seems to be an old copy/paste error

by Ovidiu Sas

Module: sip-router Branch: master Commit: 11ea7e73f0b541c2759d89a125b69a23cecb9ba9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=11ea7e7… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Wed Sep 18 16:57:56 2013 -0400 xcap_client: fix what it seems to be an old copy/paste error --- modules/xcap_client/xcap_functions.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/xcap_client/xcap_functions.c b/modules/xcap_client/xcap_functions.c index 28d4d42..4c3eead 100644 --- a/modules/xcap_client/xcap_functions.c +++ b/modules/xcap_client/xcap_functions.c @@ -85,8 +85,8 @@ void xcapFreeNodeSel(xcap_node_sel_t* node) { m= n; n= n->next; - pkg_free(n->value.s); - pkg_free(n); + pkg_free(m->value.s); + pkg_free(m); } pkg_free(node);

11 years, 2 months

New commits on branch admorten/sca

by Andrew Mortensen

URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=34c5b37… Author: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Date: Thu Sep 19 18:15:21 2013 +0100 modules/auth_ephemeral: many improvements - Some general tidying up of the code - Support for both draft-uberti-rtcweb-turn-rest format usernames and the original format - New non-digest authenticate function that can be used to authenticate WebSocket handshakes (based on URL and Cookie: contents) - this means no SIP level authentication is required for WebSocket traffic - Check functions to verify that the From:/To: URIs match the user-string part of ephemeral usernames - Check function so you can re-check the timestamp (for example, when caching the ephemeral username during WebSocket handshakes you may want to check it is still valid when a SIP request arrives) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1d62be2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 15:59:18 2013 +0200 pkg: kamailio - provide -f $CFGFILE to init.d config check function - reported by Grant Bagdasarian URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f216e0d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 15:50:29 2013 +0200 core: msg_ldata_t field is memset to 0 in the shm clone URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ece35e6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 15:49:48 2013 +0200 outbound: updated access cached flow through local data structire in sip_msg_t URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d112797… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 15:49:17 2013 +0200 tm: reset local data structure for faked request after failure handlers URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a1d3dc2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 15:45:43 2013 +0200 parser: refactored a bit sip_msg_t struct for extra fields needed per process - a new structure to keep cached decoded flow for outbound, previously was declared inline - easier to reset it for shm clone and tm faked environment - new fields that are needed inside the sip_msg_t but not cloned in shm, must be added in the msg_ldata_t structure, accessible via ldv field URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9bb4c94… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 15:17:38 2013 +0200 core: fix for warning dereferencing type-punned pointer will break strict-aliasing rules - related to timer list operation URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ae9b978… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 15:12:29 2013 +0200 parser: added note about new fields in sip_msg_t URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a2e702a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 13:25:41 2013 +0200 core: set to NULL the pointers to several sip msg fileds in cloned structure - instance, ruid and location_ua are reset to null for the clone in shm, otherwise they point to pkg and the shm can be used from other process, resulting in crash - reported and credits for testing and troubleshooting to Alex Balashov URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e658c24… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 13:24:57 2013 +0200 tm: faked request fields are freed using wrapper functions from core URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9e996b3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 13:23:53 2013 +0200 parser: use wrapper functions to reset fields in sip_msg_t - used for freeing the structure URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1be8beb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 12:34:33 2013 +0200 parser: ppi/pai - fix warning dereferencing type-punned pointer will break strict-aliasing rules URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=284bf76… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 12:27:35 2013 +0200 core: a bit of cleaning in sip_msg_t comments URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=21e1ba9… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Sep 18 21:58:12 2013 +0100 modules/app_lua: Fix off-by-one error in modf - Fixes calling sr.modf with additional parameters URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d1f236e… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Sep 18 21:34:16 2013 +0100 modules/sdpops: Check for valid sdp body in sdp_remove_line_by_prefix - Fixes crash when used on requests with no body URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=736919b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 00:09:55 2013 +0200 README: updated version number - bits of formatting for ToC URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cd794d2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Sep 18 22:23:41 2013 +0200 pua_reginfo: documented the parameter for reginfo_handle_notify() - reported in FS#340 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1a32829… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Sep 18 22:17:55 2013 +0200 pua_reginfo: add ruid for location records - patch by Wonbin Cho, FS#339 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bcba5ac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Sep 18 22:02:04 2013 +0200 pua_reginfo: unlock udomain only when aor is set - patch by Wonbin Cho, FS#338 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b73413b… Author: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Date: Wed Sep 18 13:39:23 2013 -0400 ims_registrar_scscf: fixed bug caused by uninitialized global variable - "rerrno" variable was not initialized and caused corruption in transaction states URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d33cd83… Author: Ovidiu Sas <osas(a)voipembedded.com> Date: Tue Sep 17 09:24:51 2013 -0400 dispatcher: fix mi/rpc reload command URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f21c3b3… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Wed Sep 18 14:15:17 2013 +0200 avops: use pv_cache_get instead of pv_parse_spec. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=70e5cf8… Author: Juha Heinanen <jh(a)tutpro.com> Date: Wed Sep 18 08:18:33 2013 +0300 modules/lcr: fixed checking of IPv4 address in to_any_gw_2 function - Patch was provided by Reinier Boon. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=545026a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 17 15:00:37 2013 +0200 debugger: reset_msgid parameter was in functions sections - added some section ids URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6e588cd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 17 14:55:07 2013 +0200 debugger: documentation for cfgpkgcheck parameter URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f6d79c7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 17 14:47:49 2013 +0200 debugger: new parameter cfgpkgcheck to do pkg memory check before each action URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=229899b… Author: Ovidiu Sas <osas(a)voipembedded.com> Date: Sun Sep 15 18:10:06 2013 -0400 xmlrpc: fix warning: âc.lenâay be used uninitialized in this function [-Wmaybe-uninitialized] URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3f85d5f… Author: Ovidiu Sas <osas(a)voipembedded.com> Date: Sun Sep 15 18:06:18 2013 -0400 ipops: fix warning: variable âtâet but not used [-Wunused-but-set-variable] URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=49109c5… Author: Mikko Lehto <mslehto(a)iki.fi> Date: Sun Sep 15 16:55:04 2013 -0400 rtpproxy(-ng): patch: has_sdp() does not exist URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f160c47… Author: Ovidiu Sas <osas(a)voipembedded.com> Date: Sun Sep 15 16:38:34 2013 -0400 xhttp_pi: fix crash when checking bad configs URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=58981cc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Sep 16 20:31:44 2013 +0200 corex: new pv $cfg(key) - return attributes for config file - $cfg(line) - the line of the current action. - $cfg(name) - the name of the current conf file Example of usage: append_to_reply("P-Cfg-Line: $cfg(line)\r\n"); URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=65063a6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Sep 16 09:53:15 2013 +0200 core: added wrapper functions to return cfg line and name for current action URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5e8a3a5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Sep 15 22:35:38 2013 +0200 core: store current executed cfg action in a global variable - can be retrieved by module to access name of config file and the line URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=dd9862a… Author: Charles Chance <charles.chance(a)sipcentric.com> Date: Sun Sep 15 23:38:56 2013 +0100 dmq: added dmq_load_api to exported functions URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3770c9e… Author: Charles Chance <charles.chance(a)sipcentric.com> Date: Sun Sep 15 23:38:45 2013 +0100 dmq: regenerated readme URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b27c706… Author: Charles Chance <charles.chance(a)sipcentric.com> Date: Sun Sep 15 23:38:30 2013 +0100 dmq: updated documentation URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cfae9c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Sep 14 09:46:50 2013 +0200 tm: readme regenerated URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a6da21e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sat Sep 14 09:46:23 2013 +0200 tm: added missing documentation for t_check_status() URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cbf1145… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Sep 13 13:47:00 2013 +0200 textops: free result of subst transformation when is larger than target buffer URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=abf3059… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Sep 13 11:08:48 2013 +0200 usrloc: fixed xml tags and regenerated readme URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=68693a2… Author: Vitaliy Aleksandrov <vitalik.voip(a)gmail.com> Date: Fri Sep 13 11:05:07 2013 +0200 usrloc: update connection id for registration refresh URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2278aaf… Author: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Date: Thu Sep 12 22:54:35 2013 +0100 pkg/kamailio/centos: moved stun from it's own RPM to the main RPM - stun no longer has external dependencies and doesn't need to be in its own RPM URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e4e6180… Author: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Date: Thu Sep 12 22:41:37 2013 +0100 Makefiles: moved stun to the standard module group now that it has no external dependencies URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b9413b6… Author: Peter Dunkley <peter.dunkley(a)crocodile-rcs.com> Date: Thu Sep 12 16:36:28 2013 +0100 modules/stun: removed dependency on OpenSSL URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=91394c4… Author: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Date: Wed Sep 11 13:09:31 2013 +0100 pkg/kamailio/centos: CentOS build updates - CentOS .spec is now separate from Fedora .spec. This is because I no longer have a Fedora system to test/maintain this on. Old .spec with Fedora support is in pkg/kamailio/fedora and can be taken on by someone else if needed. - Updated rel in .spec to dev8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8cb0981… Author: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Date: Wed Sep 11 11:30:50 2013 +0100 core: Raspberry-pi builds now work without needing to specify extra flags URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4fd5ed3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 10 14:14:52 2013 +0200 kamdbctl: added missing dbuid tables group creation - patch by elactrum [at] jamailca.com URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ff1b44f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Mon Sep 9 16:52:47 2013 +0200 uac_redirect: get_redirect() check reason value before using it. This fix a core dump when get_redirects() config fuction is called with just the one parameter. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fac32df… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 5 11:54:03 2013 +0200 acc: for time_mode=1, save timestamp in time_attr and microsecs in time_exten - database records stores time as datetime value - new parameter time_exten to allow customization of attribute name URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=73382ca… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 5 11:08:17 2013 +0200 acc: fixed c&p typo of parameter name in docs URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b5adf24… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 5 10:04:57 2013 +0200 kamctl: added scripts to define table acc_cdrs URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=28815d1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 5 10:04:14 2013 +0200 lib/srdb1: added id for definition of column start_time in acc_cdrs table URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7531f23… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 5 10:02:01 2013 +0200 lib/srdb1: initial db schema for acc_cdrs table URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5e9d52e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Sep 4 22:59:13 2013 +0200 registrar: reset r-uri pointer after backup in lookup_branches() - otherwise can be invalidated by next branch lookup URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a70b96e… Author: Hugh Waite <hugh.waite(a)crocodile-rcs.com> Date: Wed Sep 4 12:04:18 2013 +0100 modules/rtpproxy-ng: Allow PV in second rtpproxy_manage parameter - Incorrect fixup function caused a crash when the second parameter was given URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5619abe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Sep 4 13:04:23 2013 +0200 topoh: safety check for missing To header - based on a patch by Michel de Weerd, FS#303 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c4ae8d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Sep 4 12:33:45 2013 +0200 db_postgres: use variable for make tool in module Makefile - fixes builds in BSD systems - patch by Victor (coyote), FS#335 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c5bbabe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Sep 4 11:44:23 2013 +0200 rtpproxy: updated rtpproxy_manage() to handle PRACKs with sdp URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8fc3c2d… Author: Vitaliy Aleksandrov <vitalik.voip(a)gmail.com> Date: Wed Sep 4 09:56:28 2013 +0200 usrloc: detect lost tcp connnections on timer and set associated contact as expired - new module parameter to control this feature: handle_lost_tcp - at this moment it is not implemented for db only mode URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d1545bf… Author: Vitaliy Aleksandrov <vitalik.voip(a)gmail.com> Date: Wed Sep 4 09:55:23 2013 +0200 registrar: propagate tcp connection id in contact info structure URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=58f9b1f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 3 23:16:50 2013 +0200 pua: basic framework for handling xcap-diff event URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e38b27c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 3 23:15:55 2013 +0200 presence_xml: basic framework for handling xcap-diff event = can be diabled via modparam disable_xcapdiff URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=18012ab… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 3 16:16:30 2013 +0200 acc: option to write dialog-based cdrs to database - new module parameter cdrs_table has to be set and classic db accounting enabled at compile time and db_url set - cdr_log_enable - new parameter to turn off writing cdrs to syslog, cdr_enable being now used as top level control flag for both cdrs to syslog or db URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5aa488c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 3 15:11:47 2013 +0200 acc: increment crt position when adding extra time value URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f475b0a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 3 14:31:58 2013 +0200 Makefiles.defs: version set to 4.1.0-dev8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ec35af5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 3 13:47:24 2013 +0200 acc: updated readme with the new parameters URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b3b5b0b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 3 13:35:08 2013 +0200 acc: cast to double for safer conversion in time_mode==2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9290ae7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 3 13:28:54 2013 +0200 acc: new parameter time_mode - store additional time value in time_attr attribute/db column - if time_mode==1, then time_attr stores the microseconds - if time_mode==2, then time_attr store the seconds.miliseconds (proposed by FS#163) - if time_mode==0 (default), then it is like now, only timestamp stored - time_attr value can be set via parameter with same name - it represents syslog value or db table column - for db accounting, when time_mode==1, the type of column has to be int, and for time_mode==2, the type of column has to be double - features implemented only for syslog and db accounting URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cb1ad05… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Sep 2 14:09:18 2013 +0200 kamctl: added commands to set extra columns in subscriber table - useful to deal with columns added for load_credentials of auth_db module - 'sets' - sets a column with string value - 'setn' - sets a column with numeric value URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=07eb1cb… Author: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Date: Sun Sep 1 19:56:57 2013 -0400 Fixed potential bug in exceptional condition when max-time updated is called URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8d19a9e… Author: Juha Heinanen <jh(a)tutpro.com> Date: Thu Aug 29 17:05:41 2013 +0300 parser/fline.c: syslog message cleanup when request line parsing fails URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6fc5de3… Author: Richard Fuchs <rfuchs(a)sipwise.com> Date: Wed Aug 28 15:03:01 2013 -0400 rtpproxy-ng: fix possible segfault in rtpproxy_manage Reported by Hugh Waite URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5ff6e57… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Aug 28 12:02:34 2013 +0200 dialog: fixed typo related to module name inside log message URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7d44501… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Tue Aug 27 18:43:39 2013 +0200 permissions: fix ws support on allow_trusted function. Thanks to Alex Hermann <alex(a)speakup.nl> Reminder: Never commit with more than one glass of wine. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=74cf96d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Aug 27 14:44:17 2013 +0200 core: set to-params pointer to null after freeing - avoid potential double freeing issues or invalid pointer access URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=64fb2a6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Aug 27 14:00:17 2013 +0200 kamdbctl: new command add-tables - creates only tables that are groupped under same id, thus have the sql script in a file - syntax: kamdbctl add-tables <gid> - there has to be a <gid>-create.sql script - eg: kamdbctl add-tables lcr URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b1a1f50… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Aug 27 11:16:52 2013 +0200 kamctl: use FIFOPATH instead of OSER_FIFO in kamctlrc - no longer relation to former project name, however OSER_FIFO can still be set to keep the compatibility with older deployemnts, but will be used only when FIFOPATH is not explicitely set URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=161350c… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Tue Aug 27 00:07:58 2013 +0200 permissions: update allow_trusted documentation. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=277e77f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Tue Aug 27 00:03:49 2013 +0200 permissions: fix ws support on allow_trusted function. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a58ed15… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Aug 23 21:04:06 2013 +0200 tm: readme regenerated URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=da7a331… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Aug 23 21:03:13 2013 +0200 tm: removed note about no-implentation for no-reply flag for t_relay_to() URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=595256f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Aug 23 21:02:24 2013 +0200 tm: updated xml docs with t_set_disable_internal_reply() URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6fa6dfd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Aug 23 20:53:55 2013 +0200 tm: re-added the option for no-internal reply on error - new function t_set_disable_internal_reply(0|1) to disable|enable this option per transaction - t_relay_to() flags re-enabled for this option URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=27d52db… Author: Carsten Bock <carsten(a)ng-voice.com> Date: Fri Aug 23 17:29:43 2013 +0200 Very basic DNS-Zone file-example for IMS (for use in the online-tutorial on howto install IMS with Kamailio) URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=920f405… Author: Carsten Bock <carsten(a)ng-voice.com> Date: Thu Aug 22 16:36:48 2013 +0200 Define missing fixup_functions. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=b8fb0e1… Author: Carsten Bock <carsten(a)ng-voice.com> Date: Wed Aug 21 20:14:16 2013 +0200 Fix fixup functions. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4eb8509… Author: Carsten Bock <carsten(a)ng-voice.com> Date: Wed Aug 21 20:02:23 2013 +0200 Add support for sending POST-Requests to http_query() method. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9ff6beb… Author: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Date: Thu Aug 22 20:39:41 2013 +0100 pkg/kamailio/(centos|fedora): Added rtpproxy-ng module to the build URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e5dad70… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Aug 22 17:51:49 2013 +0200 core: efectively run the event_route[core:receive-parse-error] - reported by Juha Heinanen URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2f7e6e5… Author: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Date: Thu Aug 22 11:16:31 2013 -0400 Added support for max-time update of monitored calls - updated example config file - updated documentation URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=15c6b8f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Aug 22 15:44:05 2013 +0200 core: fix condition to lookup envet_route[core:receive-parse-error] - reported by Juha Heinanen URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6c1c838… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Aug 22 13:01:55 2013 +0200 core: execute event_route[core:receive-parse-error] block on error of initial sip message parsing - note that the SIP message is broken in this case, but it gets access to source and local socket addresses (ip, port, proto, af) as well as the whole message buffer and its size URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f2a887f… Author: Juha Heinanen <jh(a)tutpro.com> Date: Thu Aug 22 08:20:52 2013 +0300 modules/lcr: added some linefeed chars missing from syslog messages - Patch provided by Kevin Scott Adams. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4d18094… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Aug 22 00:14:53 2013 +0200 core: print src address details if initial message parsing fails - reported by Juha Heinanen URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c1972db… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Aug 21 11:20:07 2013 +0200 kamailio.cfg: use is_first_hop() for adding alias parameter to contact uri - done for natted devices URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d02a350… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Wed Aug 21 11:04:08 2013 +0200 avpops: allow use of avps as second parameter on re operation at avp_check function URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=12250b6… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Tue Aug 20 10:24:53 2013 +0200 fixed spelling errors catched by lintian URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1801978… Author: Elena-Ramona Modroiu <ramona(a)asipto.com> Date: Mon Aug 19 17:43:16 2013 +0200 htable: updated readme with rpc command htable.stats URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7345c1e… Author: Elena-Ramona Modroiu <ramona(a)asipto.com> Date: Mon Aug 19 17:39:26 2013 +0200 htbale: added rpc command htable.stats - print stats about htables: name, number of slots, number of items, max number of items per slot, min number of items per slot URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=c895fd4… Author: Elena-Ramona Modroiu <ramona(a)asipto.com> Date: Mon Aug 19 16:48:01 2013 +0200 htable: lifted limit for max number of slots to 2^31 - there can be systems with large amount of memory - clarification in docs about the case when the value is out of exected range URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fad8fa0… Author: Jason Penton <jason.penton(a)smilecoms.com> Date: Mon Aug 19 13:41:45 2013 +0200 cdp: fixed spelling and removed some erroneous code URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2884fac… Author: Carsten Bock <carsten(a)ng-voice.com> Date: Sun Aug 18 17:47:08 2013 +0200 Only update received info, if a contact is "new" contact. In case of multiple registration for one AoR, each registration will have a different contact. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=693489d… Author: Carsten Bock <carsten(a)ng-voice.com> Date: Fri Aug 16 17:08:15 2013 +0200 Do some debug output, when searching for user based on IP/Port/Proto. URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7ffcda4… Author: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Date: Wed Aug 14 21:30:45 2013 +0100 pkg/kamailio/(centos|fedora): Updated .spec URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=75c5787… Author: Richard Fuchs <rfuchs(a)sipwise.com> Date: Fri Jul 12 12:26:07 2013 -0400 rtpproxy-ng: implement second parameter to rtpproxy_offer/answer/manage URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d984f75… Author: Richard Fuchs <rfuchs(a)sipwise.com> Date: Thu Jul 11 15:36:54 2013 -0400 rtpproxy-ng: implement $rtpstat and document start_recording() URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ce44f10… Author: Richard Fuchs <rfuchs(a)sipwise.com> Date: Tue Jul 9 12:28:48 2013 -0400 rtpproxy-ng: initial checkin

11 years, 2 months

git:admorten/sca: modules/sca: fix return value of sca_call_info_uri_update ()

by Andrew Mortensen

Module: sip-router Branch: admorten/sca Commit: d815cdbf97cb6c0cd57bc492eed5aabe378cce80 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d815cdb… Author: Andrew Mortensen <admorten(a)isc.upenn.edu> Committer: Andrew Mortensen <admorten(a)isc.upenn.edu> Date: Thu Sep 19 13:49:24 2013 -0400 modules/sca: fix return value of sca_call_info_uri_update() - return value of 0 can bubble up as return value of sca_call_info_update(), causing early script termination (exported function returning 0 in script is equivalent to "exit") - report and patch from Timo Teräs --- modules/sca/sca_call_info.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/sca/sca_call_info.c b/modules/sca/sca_call_info.c index 2d36eae..1e5bbfd 100644 --- a/modules/sca/sca_call_info.c +++ b/modules/sca/sca_call_info.c @@ -761,7 +761,7 @@ sca_call_info_uri_update( str *aor, sca_call_info *call_info, STR_FMT( contact_uri ), STR_FMT( call_id ), call_info->index ); if ( !sca_uri_is_shared_appearance( sca, aor )) { - return( 0 ); + return( 1 ); } dialog.id.s = dlg_buf;

11 years, 2 months

git:master: modules/auth_ephemeral: many improvements

by Peter Dunkley

Module: sip-router Branch: master Commit: e45df83ddb68a90e91cc99fcdbb364f7b09ea541 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e45df83… Author: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Committer: Peter Dunkley <peter.dunkley(a)crocodilertc.net> Date: Thu Sep 19 18:15:21 2013 +0100 modules/auth_ephemeral: many improvements - Some general tidying up of the code - Support for both draft-uberti-rtcweb-turn-rest format usernames and the original format - New non-digest authenticate function that can be used to authenticate WebSocket handshakes (based on URL and Cookie: contents) - this means no SIP level authentication is required for WebSocket traffic - Check functions to verify that the From:/To: URIs match the user-string part of ephemeral usernames - Check function so you can re-check the timestamp (for example, when caching the ephemeral username during WebSocket handshakes you may want to check it is still valid when a SIP request arrives) --- modules/auth_ephemeral/README | 308 +++++++++++++++----- modules/auth_ephemeral/autheph_mod.c | 76 ++++- modules/auth_ephemeral/autheph_mod.h | 6 + modules/auth_ephemeral/authorize.c | 283 +++++++++++++----- modules/auth_ephemeral/authorize.h | 12 +- modules/auth_ephemeral/checks.c | 282 ++++++++++++++++++ modules/auth_ephemeral/checks.h | 40 +++ .../auth_ephemeral/doc/auth_ephemeral_admin.xml | 276 +++++++++++++++--- 8 files changed, 1078 insertions(+), 205 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=e45…

11 years, 2 months

git:4.0: pkg: kamailio - provide -f $CFGFILE to init. d config check function

by Daniel-Constantin Mierla

Module: sip-router Branch: 4.0 Commit: 052dfbe29933bf773ba5d109a530c2b2f7ecb59c URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=052dfbe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 15:59:18 2013 +0200 pkg: kamailio - provide -f $CFGFILE to init.d config check function - reported by Grant Bagdasarian (cherry picked from commit f7fe8b68ffb100fbaa27344e4bee7ba69c760584) --- pkg/kamailio/deb/debian/kamailio.init | 2 +- pkg/kamailio/deb/lucid/kamailio.init | 2 +- pkg/kamailio/deb/precise/kamailio.init | 2 +- pkg/kamailio/deb/squeeze/kamailio.init | 2 +- pkg/kamailio/deb/wheezy/kamailio.init | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/kamailio/deb/debian/kamailio.init b/pkg/kamailio/deb/debian/kamailio.init index 03b7888..6b0a1ee 100644 --- a/pkg/kamailio/deb/debian/kamailio.init +++ b/pkg/kamailio/deb/debian/kamailio.init @@ -39,7 +39,7 @@ check_kamailio_config () { # Check if kamailio configuration is valid before starting the server. set +e - out=$($DAEMON -M $PKG_MEMORY -c 2>&1 > /dev/null) + out=$($DAEMON -f $CFGFILE -M $PKG_MEMORY -c 2>&1 > /dev/null) retcode=$? set -e if [ "$retcode" != '0' ]; then diff --git a/pkg/kamailio/deb/lucid/kamailio.init b/pkg/kamailio/deb/lucid/kamailio.init index 03b7888..6b0a1ee 100644 --- a/pkg/kamailio/deb/lucid/kamailio.init +++ b/pkg/kamailio/deb/lucid/kamailio.init @@ -39,7 +39,7 @@ check_kamailio_config () { # Check if kamailio configuration is valid before starting the server. set +e - out=$($DAEMON -M $PKG_MEMORY -c 2>&1 > /dev/null) + out=$($DAEMON -f $CFGFILE -M $PKG_MEMORY -c 2>&1 > /dev/null) retcode=$? set -e if [ "$retcode" != '0' ]; then diff --git a/pkg/kamailio/deb/precise/kamailio.init b/pkg/kamailio/deb/precise/kamailio.init index 03b7888..6b0a1ee 100644 --- a/pkg/kamailio/deb/precise/kamailio.init +++ b/pkg/kamailio/deb/precise/kamailio.init @@ -39,7 +39,7 @@ check_kamailio_config () { # Check if kamailio configuration is valid before starting the server. set +e - out=$($DAEMON -M $PKG_MEMORY -c 2>&1 > /dev/null) + out=$($DAEMON -f $CFGFILE -M $PKG_MEMORY -c 2>&1 > /dev/null) retcode=$? set -e if [ "$retcode" != '0' ]; then diff --git a/pkg/kamailio/deb/squeeze/kamailio.init b/pkg/kamailio/deb/squeeze/kamailio.init index 03b7888..6b0a1ee 100644 --- a/pkg/kamailio/deb/squeeze/kamailio.init +++ b/pkg/kamailio/deb/squeeze/kamailio.init @@ -39,7 +39,7 @@ check_kamailio_config () { # Check if kamailio configuration is valid before starting the server. set +e - out=$($DAEMON -M $PKG_MEMORY -c 2>&1 > /dev/null) + out=$($DAEMON -f $CFGFILE -M $PKG_MEMORY -c 2>&1 > /dev/null) retcode=$? set -e if [ "$retcode" != '0' ]; then diff --git a/pkg/kamailio/deb/wheezy/kamailio.init b/pkg/kamailio/deb/wheezy/kamailio.init index 03b7888..6b0a1ee 100644 --- a/pkg/kamailio/deb/wheezy/kamailio.init +++ b/pkg/kamailio/deb/wheezy/kamailio.init @@ -39,7 +39,7 @@ check_kamailio_config () { # Check if kamailio configuration is valid before starting the server. set +e - out=$($DAEMON -M $PKG_MEMORY -c 2>&1 > /dev/null) + out=$($DAEMON -f $CFGFILE -M $PKG_MEMORY -c 2>&1 > /dev/null) retcode=$? set -e if [ "$retcode" != '0' ]; then

11 years, 2 months

git:master: pkg: kamailio - provide -f $CFGFILE to init. d config check function

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: f7fe8b68ffb100fbaa27344e4bee7ba69c760584 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f7fe8b6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Thu Sep 19 15:59:18 2013 +0200 pkg: kamailio - provide -f $CFGFILE to init.d config check function - reported by Grant Bagdasarian --- pkg/kamailio/deb/debian/kamailio.init | 2 +- pkg/kamailio/deb/lucid/kamailio.init | 2 +- pkg/kamailio/deb/precise/kamailio.init | 2 +- pkg/kamailio/deb/squeeze/kamailio.init | 2 +- pkg/kamailio/deb/wheezy/kamailio.init | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/kamailio/deb/debian/kamailio.init b/pkg/kamailio/deb/debian/kamailio.init index 03b7888..6b0a1ee 100644 --- a/pkg/kamailio/deb/debian/kamailio.init +++ b/pkg/kamailio/deb/debian/kamailio.init @@ -39,7 +39,7 @@ check_kamailio_config () { # Check if kamailio configuration is valid before starting the server. set +e - out=$($DAEMON -M $PKG_MEMORY -c 2>&1 > /dev/null) + out=$($DAEMON -f $CFGFILE -M $PKG_MEMORY -c 2>&1 > /dev/null) retcode=$? set -e if [ "$retcode" != '0' ]; then diff --git a/pkg/kamailio/deb/lucid/kamailio.init b/pkg/kamailio/deb/lucid/kamailio.init index 03b7888..6b0a1ee 100644 --- a/pkg/kamailio/deb/lucid/kamailio.init +++ b/pkg/kamailio/deb/lucid/kamailio.init @@ -39,7 +39,7 @@ check_kamailio_config () { # Check if kamailio configuration is valid before starting the server. set +e - out=$($DAEMON -M $PKG_MEMORY -c 2>&1 > /dev/null) + out=$($DAEMON -f $CFGFILE -M $PKG_MEMORY -c 2>&1 > /dev/null) retcode=$? set -e if [ "$retcode" != '0' ]; then diff --git a/pkg/kamailio/deb/precise/kamailio.init b/pkg/kamailio/deb/precise/kamailio.init index 03b7888..6b0a1ee 100644 --- a/pkg/kamailio/deb/precise/kamailio.init +++ b/pkg/kamailio/deb/precise/kamailio.init @@ -39,7 +39,7 @@ check_kamailio_config () { # Check if kamailio configuration is valid before starting the server. set +e - out=$($DAEMON -M $PKG_MEMORY -c 2>&1 > /dev/null) + out=$($DAEMON -f $CFGFILE -M $PKG_MEMORY -c 2>&1 > /dev/null) retcode=$? set -e if [ "$retcode" != '0' ]; then diff --git a/pkg/kamailio/deb/squeeze/kamailio.init b/pkg/kamailio/deb/squeeze/kamailio.init index 03b7888..6b0a1ee 100644 --- a/pkg/kamailio/deb/squeeze/kamailio.init +++ b/pkg/kamailio/deb/squeeze/kamailio.init @@ -39,7 +39,7 @@ check_kamailio_config () { # Check if kamailio configuration is valid before starting the server. set +e - out=$($DAEMON -M $PKG_MEMORY -c 2>&1 > /dev/null) + out=$($DAEMON -f $CFGFILE -M $PKG_MEMORY -c 2>&1 > /dev/null) retcode=$? set -e if [ "$retcode" != '0' ]; then diff --git a/pkg/kamailio/deb/wheezy/kamailio.init b/pkg/kamailio/deb/wheezy/kamailio.init index 03b7888..6b0a1ee 100644 --- a/pkg/kamailio/deb/wheezy/kamailio.init +++ b/pkg/kamailio/deb/wheezy/kamailio.init @@ -39,7 +39,7 @@ check_kamailio_config () { # Check if kamailio configuration is valid before starting the server. set +e - out=$($DAEMON -M $PKG_MEMORY -c 2>&1 > /dev/null) + out=$($DAEMON -f $CFGFILE -M $PKG_MEMORY -c 2>&1 > /dev/null) retcode=$? set -e if [ "$retcode" != '0' ]; then

11 years, 2 months

Crash bug freeing To headers

by Alex Balashov

(Sorry for the long post. Unfortunately, not all bugs are simple.) I've got a crash bug that occurs when freeing To header parameters when freeing a SIP message. It only occurs in certain circumstances. I can reproduce the circumstances on my side consistently, but I suspect it would be difficult for someone else to reproduce them independently. Those circumstances are: 1. A Kamailio registrar routes an inbound call from the PSTN to a user using a Snom One PBX using serial forking across two different bindings (two different AOR domains) that come from two different registrars (going into the same database). 2. The PBX sends back a 480 Temporarily Unavailable message to Kamailio in response to every INVITE, on all branches, all the time. 3. It takes several attempts (usually 5-10) of calling that PBX to get to Kamailio crash. 4. It only happens when the initial INVITE is processed using a particular sequence of routes in the route script. There is nothing unusual about the routes themselves, and I've eliminated all the side effects and dependencies I can. It just doesn't happen when I have the call zig through those routes as opposed to those routes. That suggests package memory corruption that is tripped over by a particular conjuncture of circumstances. Here is the 480 Temporarily Unavailable message sent by the PBX. IPs and numbers have been redacted for customer privacy, but the string lengths are the same: Here's the INVITE we're sending to the PBX: INVITE sip:16504578199@184.178.234.121:5060;transport=udp;line=eccbc87e SIP/2.0 Record-Route: <sip:55.177.31.199;lr=on;ftag=c00080a-13c4-521c7390-2e862c51-6c96b554;vsf=AAAAAB0GDg4NDQUCBwd3A3AKHgEaFwUbCBsIHjEwOjUwNjA7aXN1cC1vbGk9MA--;dlgcor=5af.3bb> From: <sip:6784841111@192.13.219.87>;tag=c00080a-13c4-521c7390-2e862c51-6c96b554 To: <sip:16504578199@55.177.31.199:5060> Call-ID: CXC-72-6a0635d8-c00080a-13c4-521c7390-2e862c51-7eeb3166(a)192.13.219.87 CSeq: 1 INVITE Via: SIP/2.0/UDP 55.177.31.199;branch=z9hG4bKcdfc.af721dd5.1 Via: SIP/2.0/UDP 192.13.219.87:5060;branch=z9hG4bK-3290-521c7390-2e862c51-3a62fcfd Max-Forwards: 32 Content-Disposition: session;handling=required Contact: <sip:+16784841111@192.13.219.87:5060;isup-oli=0;maddr=192.13.219.87;transport=udp> Content-Type: application/sdp Content-Length: 274 Privacy: off P-Asserted-Identity: "Unavailable" <sip:+16784841111@192.13.219.87> v=0 o=Acme_UAS 0 1 IN IP4 175.154.21.89 s=SIP Media Capabilities c=IN IP4 12.131.2.144 t=0 0 m=audio 6698 RTP/AVP 0 18 101 a=rtpmap:0 PCMU/8000 a=rtpmap:18 G729/8000 a=rtpmap:101 telephone-event/8000 a=fmtp:18 annexb=no a=fmtp:101 0-15 a=maxptime:30 a=sendrecv And here's the 480 Temporarily Unavailable we get back every time we do, on both branches. Nothing about it looks unusual to me: SIP/2.0 480 Temporarily Unavailable Via: SIP/2.0/UDP 55.177.31.199;branch=z9hG4bKcdfc.af721dd5.0 Via: SIP/2.0/UDP 192.13.219.87:5060;branch=z9hG4bK-3290-521c7390-2e862c51-3a62fcfd Record-Route: <sip:55.177.31.199;lr=on;ftag=c00080a-13c4-521c7390-2e862c51-6c96b554;vsf=AAAAAB0GDg4NDQUCBwd3A3AKHgEaFwUbCBsIHjEwOjUwNjA7aXN1cC1vbGk9MA--;dlgcor=5af.3bb> From: <sip:6784841111@192.13.219.87>;tag=c00080a-13c4-521c7390-2e862c51-6c96b554 To: <sip:16504578199@55.177.31.199:5060>;tag=d3516ef5fa Call-ID: CXC-72-6a0635d8-c00080a-13c4-521c7390-2e862c51-7eeb3166(a)192.13.219.87 CSeq: 1 INVITE Contact: <sip:5282797646@195.105.225.111:5060;transport=udp> Supported: 100rel, replaces, norefersub Allow-Events: refer Allow: INVITE, ACK, CANCEL, BYE, REFER, PRACK, INFO, UPDATE Accept: application/sdp User-Agent: snomONE/4.5.1.1107 Zeta Perseids Content-Length: 0 But when this happens a few times, Kamailio crashes: 05:38:24.317781 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 592 E..l..@.4.2....yA.,......X..SIP/2.0 100 Trying -- 05:38:24.333573 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 865 E..}..@.4.1....yA.,......i.$SIP/2.0 480 Temporarily Unavailable -- 05:38:24.333767 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 411 E.......@..<A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:24.335593 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1187 E.......@..3A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:38:24.385873 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 865 E..}..@.4.1....yA.,......i.$SIP/2.0 480 Temporarily Unavailable -- 05:38:24.386126 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 411 E.......@..:A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:24.831672 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1187 E.......@..1A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:38:24.877627 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 865 E..}..@.4.1....yA.,......i.$SIP/2.0 480 Temporarily Unavailable -- 05:38:24.877933 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 411 E.......@..8A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:25.831617 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1187 E.......@../A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:38:25.881560 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 865 E..}..@.4.1....yA.,......i.$SIP/2.0 480 Temporarily Unavailable -- 05:38:25.881731 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 411 E.......@..6A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:32.219484 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1183 E.......@..1A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:32.270568 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 588 E..h..@.4.2....yA.,......T..SIP/2.0 100 Trying -- 05:38:32.289120 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 861 E..y..@.4.1....yA.,......e.7SIP/2.0 480 Temporarily Unavailable -- 05:38:32.289284 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 408 E.......@..7A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:32.291180 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1183 E.......@../A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:38:32.340763 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 861 E..y..@.4.1....yA.,......e.7SIP/2.0 480 Temporarily Unavailable -- 05:38:32.340986 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 408 E.......@..5A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:32.769133 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1183 E.......@..-A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:38:32.814851 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 861 E..y..@.4.1....yA.,......e.7SIP/2.0 480 Temporarily Unavailable -- 05:38:32.814993 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 408 E.... ..@..3A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:33.769113 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1183 E.... -- 05:38:33.815374 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 861 E..y..@.4.1....yA.,......e.7SIP/2.0 480 Temporarily Unavailable -- 05:38:33.815600 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 408 E.......@..1A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:42.371141 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1188 E.......@..$A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:42.422190 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 592 E..l..@.4.2....yA.,......X.jSIP/2.0 100 Trying -- 05:38:42.438849 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 865 E..}..@.4.1....yA.,......iE SIP/2.0 480 Temporarily Unavailable -- 05:38:42.439005 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 410 ..@..-A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:42.440373 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1188 E.......@.."A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:38:42.490261 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 865 E..}..@.4.1....yA.,......iE SIP/2.0 480 Temporarily Unavailable -- 05:38:42.490348 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 410 E.......@..+A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:42.894122 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1188 E.......@.. A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:38:42.940323 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 865 E..}..@.4.1....yA.,......iE SIP/2.0 480 Temporarily Unavailable -- 05:38:42.940562 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 410 E.......@..)A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:43.894116 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1188 E.......@...A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:38:43.940482 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 865 E..}..@.4.1....yA.,......iE SIP/2.0 480 Temporarily Unavailable -- 05:38:43.940604 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 410 E.......@..'A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:50.261551 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1188 E.......@...A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:50.313509 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 592 E..l..@.4.2....yA.,......X..SIP/2.0 100 Trying -- 05:38:50.329411 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 865 E..}..@.4.1....yA.,......i..SIP/2.0 480 Temporarily Unavailable -- 05:38:50.329584 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 411 E.......@..$A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:50.331250 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1188 E.......@...A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:38:50.379415 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 865 E..}..@.4.1....yA.,......i..SIP/2.0 480 Temporarily Unavailable -- 05:38:50.379584 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 411 E.......@.."A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:50.769124 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1188 E.......@...A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:38:50.817797 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 865 E..}..@.4.1....yA.,......i..SIP/2.0 480 Temporarily Unavailable -- 05:38:50.817936 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 411 E.......@.. A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:38:51.769119 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1188 E.......@...A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:38:51.815689 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 865 E..}..@.4.1....yA.,......i..SIP/2.0 480 Temporarily Unavailable -- 05:38:51.815844 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 411 E.......@...A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:39:00.197890 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1182 E.......@...A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:39:00.248713 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 586 E..f..@.4.2....yA.,......RD_SIP/2.0 100 Trying -- 05:39:00.264983 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 859 E..w..@.4.1....yA.,......c-.SIP/2.0 480 Temporarily Unavailable -- 05:39:00.265140 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 408 E.......@...A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:39:00.266675 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1182 E.......@...A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:39:00.317151 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 859 E..w..@.4.1....yA.,......c-.SIP/2.0 480 Temporarily Unavailable -- 05:39:00.317285 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 408 E.......@...A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:39:00.706627 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1182 E.... ..@...A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:39:00.752906 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 859 E..w..@.4.1....yA.,......c-.SIP/2.0 480 Temporarily Unavailable -- 05:39:00.753054 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 408 E....!..@...A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:39:01.706639 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1182 E...."..@...A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:39:01.753036 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 859 E..w..@.4.1....yA.,......c-.SIP/2.0 480 Temporarily Unavailable -- 05:39:01.753198 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 408 E....#..@...A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:39:08.088801 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1190 E....$..@.. -- 05:39:08.139841 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 594 E..n..@.4.2....yA.,......ZhVSIP/2.0 100 Trying -- 05:39:08.156036 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 867 E.....@.4.1....yA.,......k4.SIP/2.0 480 Temporarily Unavailable -- 05:39:08.156222 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 412 E....%..@...A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:39:08.157697 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1190 E....&..@...A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:39:08.208158 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 867 E.....@.4.1....yA.,......k4.SIP/2.0 480 Temporarily Unavailable -- 05:39:08.208282 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 412 E....'..@...A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:39:08.644104 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1190 E....(..@...A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:39:08.690068 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 867 E.....@.4.1....yA.,......k4.SIP/2.0 480 Temporarily Unavailable -- 05:39:08.690212 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 412 E....)..@...A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 -- 05:39:09.644112 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 1190 E....*..@...A.,....y........INVITE sip:16504578199@195.105.225.111:5060;transport=udp;line=eccbc87e SIP/2.0 -- 05:39:09.690201 IP 195.105.225.111.5060 > 55.177.31.199.5060: SIP, length: 867 E.....@.4.1....yA.,......k4.SIP/2.0 480 Temporarily Unavailable -- 05:39:09.690374 IP 55.177.31.199.5060 > 195.105.225.111.5060: SIP, length: 412 A.,....y........ACK sip:16504578199@195.105.225.111:5060;transport=udp;line=c81e728d SIP/2.0 Anyway, my core dumps were showing me qm_*() free errors. To get at the problem, I disabled loop unrolling, removed -09 and added the GDB debug flags (-ggdb*) to the compile flags. When I do that, I get one of these two call stacks--mostly the first, and occasionally the second: #0 0x000000000055dc2e in free_to_params (tb=0x7fcb38f5f750) at parser/parse_to.c:827 #1 0x000000000055dc75 in free_to (tb=0x7fcb38f5f750) at parser/parse_to.c:836 #2 0x000000000053d9df in clean_hdr_field (hf=0x7fcb38f5fb50) at parser/hf.c:169 #3 0x000000000053db49 in free_hdr_field_lst (hf=0x7fcb38f590e0) at parser/hf.c:223 #4 0x0000000000542330 in free_sip_msg (msg=0x7fcb38f5edf0) at parser/msg_parser.c:729 #5 0x000000000049d9cb in receive_msg ( buf=0x905580 "SIP/2.0 480 Temporarily Unavailable\r\nVia: SIP/2.0/UDP 55.177.31.199;branch=z9hG4bK818c.b6308b63.0\r\nVia: SIP/2.0/UDP 192.13.219.87:5060;branch=z9hG4bK-28db-521c65ea-2e50da5e- 8f9ae0d\r\nRecord-Route: <sip"..., len=864, rcv_info=0x7fff2bcad950) at receive.c:294 #6 0x000000000052f5cd in udp_rcv_loop () at udp_server.c:557 #7 0x0000000000467de2 in main_loop () at main.c:1638 #8 0x000000000046ad8b in main (argc=13, argv=0x7fff2bcadc88) at main.c:2566 ---- #0 0x00000000005394e9 in qm_detach_free (qm=0x7f25c3037010, frag=0x7f25c3256af0) at mem/q_malloc.c:266 #1 0x0000000000539744 in qm_malloc (qm=0x7f25c3037010, size=960) at mem/q_malloc.c:386 #2 0x00000000004bba49 in rval_new_empty (extra_size=102) at rvalue.c:236 #3 0x00000000004bbabb in rval_new_str (s=0x7fffbad95460, extra_size=80) at rvalue.c:260 #4 0x00000000004be1b3 in rval_convert (h=0x7fffbad972a0, msg=0x7f25c2587920, type=RV_STR, v=0x7f25c3182ee8, c=0x7fffbad95620) at rvalue.c:1321 #5 0x00000000004bf657 in rval_str_lop2 (h=0x7fffbad972a0, msg=0x7f25c2587920, res=0x7fffbad95ac8, op=RVE_EQ_OP, l=0x7f25c3182ee8, c1=0x7fffbad95620, r=0x7f25c3183668, c2=0x0) at rvalue.c:1752 #6 0x00000000004c028d in rval_expr_eval_int (h=0x7fffbad972a0, msg=0x7f25c2587920, res=0x7fffbad95ac8, rve=0x7f25c3183d40) at rvalue.c:2058 #7 0x0000000000418d5a in do_action (h=0x7fffbad972a0, a=0x7f25c3185190, msg=0x7f25c2587920) at action.c:1050 #8 0x0000000000421aa7 in run_actions (h=0x7fffbad972a0, a=0x7f25c3182d40, msg=0x7f25c2587920) at action.c:1573 #9 0x000000000042047f in do_action (h=0x7fffbad972a0, a=0x7f25c3185530, msg=0x7f25c2587920) at action.c:1374 #10 0x0000000000421aa7 in run_actions (h=0x7fffbad972a0, a=0x7f25c317a2a0, msg=0x7f25c2587920) at action.c:1573 #11 0x0000000000418fa2 in do_action (h=0x7fffbad972a0, a=0x7f25c318ac10, msg=0x7f25c2587920) at action.c:1065 #12 0x0000000000421aa7 in run_actions (h=0x7fffbad972a0, a=0x7f25c318ac10, ---Type <return> to continue, or q <return> to quit--- msg=0x7f25c2587920) at action.c:1573 #13 0x0000000000418ffb in do_action (h=0x7fffbad972a0, a=0x7f25c318ad10, msg=0x7f25c2587920) at action.c:1069 #14 0x0000000000421aa7 in run_actions (h=0x7fffbad972a0, a=0x7f25c3163930, msg=0x7f25c2587920) at action.c:1573 #15 0x0000000000416f3a in do_action (h=0x7fffbad972a0, a=0x7f25c3194fc0, msg=0x7f25c2587920) at action.c:690 #16 0x0000000000421aa7 in run_actions (h=0x7fffbad972a0, a=0x7f25c318eaf0, msg=0x7f25c2587920) at action.c:1573 #17 0x0000000000422231 in run_top_route (a=0x7f25c318eaf0, msg=0x7f25c2587920, c=0x0) at action.c:1658 #18 0x00007f25c233b220 in run_failure_handlers (t=0x7f24be53b2a0, rpl=0x7f25c32554b0, code=480, extra_flags=64) at t_reply.c:1024 #19 0x00007f25c233c39b in t_should_relay_response (Trans=0x7f24be53b2a0, new_code=480, branch=0, should_store=0x7fffbad97580, should_relay=0x7fffbad97584, cancel_data=0x7fffbad97790, reply=0x7f25c32554b0) at t_reply.c:1300 #20 0x00007f25c233dec4 in relay_reply (t=0x7f24be53b2a0, p_msg=0x7f25c32554b0, branch=0, msg_status=480, cancel_data=0x7fffbad97790, do_put_on_wait=1) at t_reply.c:1703 #21 0x00007f25c2340f46 in reply_received (p_msg=0x7f25c32554b0) at t_reply.c:2370 #22 0x0000000000458861 in do_forward_reply (msg=0x7f25c32554b0, mode=0) at forward.c:799 #23 0x00000000004590d0 in forward_reply (msg=0x7f25c32554b0) at forward.c:882 #24 0x000000000049d8a4 in receive_msg ( ---Type <return> to continue, or q <return> to quit--- buf=0x905580 "SIP/2.0 480 Temporarily Unavailable\r\nVia: SIP/2.0/UDP 55.177.31.199;branch=z9hG4bK0c.2611fa52.0\r\nVia: SIP/2.0/UDP 192.13.219.87:5060;branch=z9hG4bK-293c-521c669b-2e538ce5- 7bec16be\r\nRecord-Route: <sip:"..., len=863, rcv_info=0x7fffbad97af0) at receive.c:270 #25 0x000000000052f5cd in udp_rcv_loop () at udp_server.c:557 #26 0x0000000000467de2 in main_loop () at main.c:1638 #27 0x000000000046ad8b in main (argc=13, argv=0x7fffbad97e28) at main.c:2566 But, 90% of the time, it's the first one. The second one shows up only occasionally. Sometimes, this variant appears: #0 0x0000000000538d7a in qm_insert_free (qm=0x7f069c7a6010, frag=0x7f069c9c57e0) at mem/q_malloc.c:182 #1 0x0000000000539c3d in qm_free (qm=0x7f069c7a6010, p=0x7f069c9c57f0) at mem/q_malloc.c:527 #2 0x000000000055dc4c in free_to_params (tb=0x7f069c9c73a0) at parser/parse_to.c:828 #3 0x000000000055dc75 in free_to (tb=0x7f069c9c73a0) at parser/parse_to.c:836 #4 0x000000000053d8d5 in clean_hdr_field (hf=0x7f069c7d7da0) at parser/hf.c:113 #5 0x000000000053db49 in free_hdr_field_lst (hf=0x7f069c7d6340) at parser/hf.c:223 #6 0x0000000000542330 in free_sip_msg (msg=0x7f069c9c44b0) at parser/msg_parser.c:729 #7 0x000000000049d9cb in receive_msg ( buf=0x905580 "SIP/2.0 480 Temporarily Unavailable\r\nVia: SIP/2.0/UDP 55.177.31.199;branch=z9hG4bKeb96.24a5718.0\r\nVia: SIP/2.0/UDP 208.94.157.10:5060;branch=z9hG4bK-368a-521c67f1-3b3bc7c- 5366754e\r\nRecord-Route: <sip:55.177.31.199;lr=on;ftag=c00070a-13c4- 521c67f1-3b3bc7c- 3af08849;vsf=AAAAAB0GDg4NDQUCBwd3A3AKHgEaFwUbBhsGHjEwOjUwNjA7aXN1cC1vbGk 9MA--;dlgcor=789.3d01>\r\nFrom: <sip:6784841111@208.94.157.10>;tag=c00070a-13c4-521c67f1-3b3bc7c- 3af08849\r\nTo: <sip:16504578199@55.177.31.199:5060>;tag=3af8238437\r\nCall-ID: CXC-408- 6bb35b50-c00070a-13c4-521c67f1-3b3bc7c-3c339c13(a)208.94.157.10\r\nCSeq: 1 INVITE\r\nContact: <sip:5282797646@195.105.225.111:5060;transport=udp>\r\nSupported: 100rel, replaces, norefersub\r\nAllow-Events: refer\r\nAllow: INVITE, ACK, CANCEL, BYE, REFER, PRACK, INFO, UPDATE\r\nAccept: application/sdp\r\nUser-Agent: snomONE/4.5.1.1107 Zeta Perseids\r\nContent-Length: 0\r\n\r\n", len=862, rcv_info=0x7fff87c23070) So, I focused on the first one. The crash is on pkg_free() in this loop in parser/parse_to.c: void free_to_params(struct to_body* const tb) { struct to_param *tp=tb->param_lst; struct to_param *foo; while (tp){ foo = tp->next; pkg_free(tp); tp=foo; } } Removing the pkg_free() definitely eliminates the crash. Or, at least, I haven't been able to get the proxy to crash in that scenario. In poking at the values of the to_body, (gdb) frame 2 #2 0x000000000055dc4c in free_to_params (tb=0x7f069c9c73a0) at parser/parse_to.c:828 828 pkg_free(tp); (gdb) print tb $30 = (struct to_body * const) 0x7f069c9c73a0 (gdb) print tb->uri->s $31 = 0x9056e6 "sip:6784841111@208.94.157.10>;tag=c00070a-13c4-521c67f1- 3b3bc7c-3af08849\r\nTo: <sip:16504578199@55.177.31.199:5060>;tag=3af8238437\r\nCall-ID: CXC-408- 6bb35b50-c00070a-13c4-521c67f1-3b3bc7c-3c339c13(a)208.94.157.10\r\nCSeq: 1 INVITE\r\nContact: <sip:5282797646@195.105.225.111:5060;transport=udp>\r\nSupported: 100rel, replaces, norefersub\r\nAllow-Events: refer\r\nAllow: INVITE, ACK, CANCEL, BYE, REFER, PRACK, INFO, UPDATE\r\nAccept: application/sdp\r\nUser-Agent: snomONE/4.5.1.1107 Zeta Perseids\r\nContent-Length: 0\r\n\r\n" (gdb) print tb->param_lst $32 = (struct to_param *) 0x7f069c9c57f0 (gdb) print tb->param_lst->next $33 = (struct to_param *) 0x0 (gdb) print tb->param_lst->value $34 = { s = 0x905708 "c00070a-13c4-521c67f1-3b3bc7c-3af08849\r\nTo: <sip:16504578199@55.177.31.199:5060>;tag=3af8238437\r\nCall-ID: CXC-408- 6bb35b50-c00070a-13c4-521c67f1-3b3bc7c-3c339c13(a)208.94.157.10\r\nCSeq: 1 INVITE\r\nContact: <sip:5282797646@195.105.225.111:5060;transport=udp>\r\nSupported: 100rel, replaces, norefersub\r\nAllow-Events: refer\r\nAllow: INVITE, ACK, CANCEL, BYE, REFER, PRACK, INFO, UPDATE\r\nAccept: application/sdp\r\nUser-Agent: snomONE/4.5.1.1107 Zeta Perseids\r\nContent-Length: 0\r\n\r\n", len = 38} (gdb) print tb->param_lst->name $35 = {s = 0x3e653834323335 <Address 0x3e653834323335 out of bounds>, len = 3} I eventually noticed that I can't seem to get at the 'name' value in the first (and only) parameter list node: (gdb) print tb->param_lst->name $35 = {s = 0x3e653834323335 <Address 0x3e653834323335 out of bounds>, len = 3} I guess that should be 'tag', right? It's the only parameter, unsurprisingly: (gdb) print tb->param_lst->next $33 = (struct to_param *) 0x0 Anyway, I can also say that accessing the pointer into the message buffer to which it corresponds crashes it, but only for that 480 -- not for any other SIP message that comes through the proxy: while (tp){ foo = tp->next; LM_ERR("Freeing up the hinterland: <%s>\n", tp->name.s); pkg_free(tp); tp=foo; } (gdb) where #0 0x0000003dbae480ac in vfprintf () from /lib64/libc.so.6 #1 0x0000003dbaee4fe0 in __vsyslog_chk () from /lib64/libc.so.6 #2 0x0000003dbaee5210 in syslog () from /lib64/libc.so.6 #3 0x000000000055dd47 in free_to_params (tb=0x7fc1def09610) So, I really get the sense that there's something wrong with that 480 that's corrupting memory. Is that an accurate conclusion? If so, what it could be, and what's the next step to try to diagnose further? Thank you! -- Alex -- Alex Balashov - Principal Evariste Systems LLC 235 E Ponce de Leon Ave Suite 106 Decatur, GA 30030 United States Tel: +1-678-954-0670 Web: http://www.evaristesys.com/, http://www.alexbalashov.com/

11 years, 2 months

← Newer
1
...
9
10
11
12
13
14
15
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2013