sr-dev September 2013

sr-dev@lists.kamailio.org

33 participants
296 discussions

[tracker] Task opened: to_any_gw_2 takes only IPv6 addresses, fails on valid IPv4 address parameter (Attachment added)
by sip-router 17 Sep '13

17 Sep '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Reinier Boon (reinierboon) Attached to Project - sip-router Summary - to_any_gw_2 takes only IPv6 addresses, fails on valid IPv4 address parameter Task Type - Bug Report Category - Module Status - Unconfirmed Assigned To - Operating System - All Severity - Medium Priority - Normal Reported Version - Development Due in Version - Undecided Due Date - Undecided Details - Hi, Thanks for all the good work on Kamailio. I thing I have found a bug in the LCR module. When a valid IPv4 address has been detected, by the function to_any_gw_2(), the function continues to check for a valid IPv6 address, then fails if that was not found. I have attached a patch that should fix this issue. Best regards, Reinier Boon One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=343 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: debugger: reset_msgid parameter was in functions sections
by Daniel-Constantin Mierla 17 Sep '13

17 Sep '13

Module: sip-router Branch: master Commit: af8923703276bb41ea269cc19a7812fea325a250 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=af89237… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 17 15:00:37 2013 +0200 debugger: reset_msgid parameter was in functions sections - added some section ids --- modules/debugger/README | 40 ++++++++-------- modules/debugger/doc/debugger_admin.xml | 74 ++++++++++++++++--------------- 2 files changed, 58 insertions(+), 56 deletions(-) diff --git a/modules/debugger/README b/modules/debugger/README index efef14b..b63f333 100644 --- a/modules/debugger/README +++ b/modules/debugger/README @@ -37,12 +37,12 @@ Daniel-Constantin Mierla 3.10. mod_level (str) 3.11. log_assign (int) 3.12. cfgpkgcheck (int) + 3.13. reset_msgid (int) 4. Functions 4.1. dbg_breakpoint(mode) 4.2. dbg_pv_dump([mask] [, level]) - 4.3. reset_msgid (int) 5. Exported RPC Functions @@ -68,9 +68,9 @@ Daniel-Constantin Mierla 1.10. Set mod_level parameter 1.11. Set log_assign parameter 1.12. Set cfgpkgcheck parameter - 1.13. dbg_breakpoint usage - 1.14. dbg_pv_dump usage - 1.15. Set reset_msgid parameter + 1.13. Set reset_msgid parameter + 1.14. dbg_breakpoint usage + 1.15. dbg_pv_dump usage Chapter 1. Admin Guide @@ -96,12 +96,12 @@ Chapter 1. Admin Guide 3.10. mod_level (str) 3.11. log_assign (int) 3.12. cfgpkgcheck (int) + 3.13. reset_msgid (int) 4. Functions 4.1. dbg_breakpoint(mode) 4.2. dbg_pv_dump([mask] [, level]) - 4.3. reset_msgid (int) 5. Exported RPC Functions @@ -166,6 +166,7 @@ Chapter 1. Admin Guide 3.10. mod_level (str) 3.11. log_assign (int) 3.12. cfgpkgcheck (int) + 3.13. reset_msgid (int) 3.1. cfgtrace (int) @@ -315,11 +316,22 @@ modparam("debugger", "log_assign", 1) modparam("debugger", "cfgpkgcheck", 1) ... +3.13. reset_msgid (int) + + Used to enable or disable the ability to reset the msgid ($mi) through + the dbg.reset_msgid RPC command. (0 - disabled, 1 - enabled). + + Default value is "0" - feature disabled. + + Example 1.13. Set reset_msgid parameter +... +modparam("debugger", "reset_msgid", 1) +... + 4. Functions 4.1. dbg_breakpoint(mode) 4.2. dbg_pv_dump([mask] [, level]) - 4.3. reset_msgid (int) 4.1. dbg_breakpoint(mode) @@ -330,7 +342,7 @@ modparam("debugger", "cfgpkgcheck", 1) Note that this version of the module does not export this anchors to RPC for interactive debugging (temporarily disabled). - Example 1.13. dbg_breakpoint usage + Example 1.14. dbg_breakpoint usage ... if($si=="10.0.0.10") dbg_breakpoint("1"); @@ -358,7 +370,7 @@ if($si=="10.0.0.10") * L_INFO - log level 2 * L_DBG - log level 3 - Example 1.14. dbg_pv_dump usage + Example 1.15. dbg_pv_dump usage ... $var(temp) = 1; $avp(s:more_avp) = 2; @@ -381,18 +393,6 @@ vp(x)":[{"different":["foo"]},{"other":[2,1],"more":["hi","bye"]}],"$T_branch_id x":0,"$var(empty)":0} ... -4.3. reset_msgid (int) - - Used to enable or disable the ability to reset the msgid ($mi) through - the dbg.reset_msgid RPC command. (0 - disabled, 1 - enabled). - - Default value is "0" - feature disabled. - - Example 1.15. Set reset_msgid parameter -... -modparam("debugger", "reset_msgid", 1) -... - 5. Exported RPC Functions 5.1. dbg.ls diff --git a/modules/debugger/doc/debugger_admin.xml b/modules/debugger/doc/debugger_admin.xml index 46d0cea..3fa272f 100644 --- a/modules/debugger/doc/debugger_admin.xml +++ b/modules/debugger/doc/debugger_admin.xml @@ -74,7 +74,7 @@ </section> <section> <title>Parameters</title> - <section> + <section id="dbg.p.cfgtrace"> <title><varname>cfgtrace</varname> (int)</title> <para> Control whether the config script trace is enabled or disabled @@ -96,7 +96,7 @@ modparam("debugger", "cfgtrace", 1) </example> </section> - <section> + <section id="dbg.p.breakpoint"> <title><varname>breakpoint</varname> (int)</title> <para> Control whether every line (global) breakpoint is enabled @@ -117,7 +117,7 @@ modparam("debugger", "breakpoint", 1) </example> </section> - <section> + <section id="dbg.p.log_level"> <title><varname>log_level</varname> (int)</title> <para> What log level is to be used to print module-specific messages. @@ -137,7 +137,7 @@ modparam("debugger", "log_level", 1) </example> </section> - <section> + <section id="dbg.p.log_facility"> <title><varname>log_facility</varname> (str)</title> <para> Which log facility is to be used to print module-specific messages. @@ -159,7 +159,7 @@ modparam("debugger", "log_facility", "LOG_DAEMON") </example> </section> - <section> + <section id="dbg.p.log_prefix"> <title><varname>log_prefix</varname> (str)</title> <para> String to print before any module-specific messages. @@ -179,7 +179,7 @@ modparam("debugger", "log_prefix", "from-debugger-with-love:") </example> </section> - <section> + <section id="dbg.p.step_usleep"> <title><varname>step_usleep</varname> (int)</title> <para> Microseconds to sleep before checking for new commands when @@ -200,7 +200,7 @@ modparam("debugger", "step_usleep", 500000) </example> </section> - <section> + <section id="dbg.p.step_loops"> <title><varname>step_loops</varname> (int)</title> <para> How many sleeps of 'step_usleep' the RPC process performs when @@ -223,11 +223,12 @@ modparam("debugger", "step_loops", 100) </example> </section> - <section> + <section id="dbg.p.mod_hash_size"> <title><varname>mod_hash_size</varname> (int)</title> <para> Used to compute power of two as size of internal hash table to store levels - per module (e.g., if its set to 4, internal hash table has 16 slots). This parameter is accesible readonly via the Kamailio config framework. + per module (e.g., if its set to 4, internal hash table has 16 slots). This + parameter is accesible readonly via the Kamailio config framework. </para> <para> <emphasis> @@ -244,10 +245,11 @@ modparam("debugger", "mod_hash_size", 5) </example> </section> - <section> + <section id="dbg.p.mod_level_mode"> <title><varname>mod_level_mode</varname> (int)</title> <para> - Enable or disable per module log level (0 - disabled, 1 - enabled). This parameter is tunable via the Kamailio config framework. + Enable or disable per module log level (0 - disabled, 1 - enabled). + This parameter is tunable via the Kamailio config framework. </para> <para> <emphasis> @@ -264,7 +266,7 @@ modparam("debugger", "mod_level_mode", 1) </example> </section> - <section> + <section id="dbg.p.mod_level"> <title><varname>mod_level</varname> (str)</title> <para> Specify module log level - the value must be in the format: @@ -282,7 +284,7 @@ modparam("debugger", "mod_level", "tm=3") </example> </section> - <section> + <section id="dbg.p.log_assign"> <title><varname>log_assign</varname> (int)</title> <para> Enable or disable log assign actions on config (0 - disabled, 1 - enabled). @@ -323,11 +325,32 @@ modparam("debugger", "cfgpkgcheck", 1) </example> </section> + <section id="dbg.p.reset_msgid"> + <title><varname>reset_msgid</varname> (int)</title> + <para> + Used to enable or disable the ability to reset the msgid ($mi) + through the dbg.reset_msgid RPC command. (0 - disabled, 1 - enabled). + </para> + <para> + <emphasis> + Default value is <quote>0</quote> - feature disabled. + </emphasis> + </para> + <example> + <title>Set <varname>reset_msgid</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("debugger", "reset_msgid", 1) +... +</programlisting> + </example> + </section> + </section> <section> <title>Functions</title> - <section> + <section id="dbg.f.db_breakpoint"> <title> <function moreinfo="none">dbg_breakpoint(mode)</function> </title> @@ -351,7 +374,7 @@ if($si=="10.0.0.10") </example> </section> - <section> + <section id="dbg.f.dbg_pv_dump"> <title> <function moreinfo="none">dbg_pv_dump([mask] [, level])</function> </title> @@ -436,27 +459,6 @@ dbg_pv_dump(30, "L_DBG"); </example> </section> - <section> - <title><varname>reset_msgid</varname> (int)</title> - <para> - Used to enable or disable the ability to reset the msgid ($mi) - through the dbg.reset_msgid RPC command. (0 - disabled, 1 - enabled). - </para> - <para> - <emphasis> - Default value is <quote>0</quote> - feature disabled. - </emphasis> - </para> - <example> - <title>Set <varname>reset_msgid</varname> parameter</title> - <programlisting format="linespecific"> -... -modparam("debugger", "reset_msgid", 1) -... -</programlisting> - </example> - </section> - </section> <section>

1 0

git:master: debugger: documentation for cfgpkgcheck parameter
by Daniel-Constantin Mierla 17 Sep '13

17 Sep '13

Module: sip-router Branch: master Commit: 2710177c2673034d3f026dfa79432e986b8c3a90 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=2710177… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 17 14:55:07 2013 +0200 debugger: documentation for cfgpkgcheck parameter --- modules/debugger/README | 66 +++++++++++++++++++------------ modules/debugger/doc/debugger_admin.xml | 21 ++++++++++ 2 files changed, 62 insertions(+), 25 deletions(-) diff --git a/modules/debugger/README b/modules/debugger/README index 3a51c02..efef14b 100644 --- a/modules/debugger/README +++ b/modules/debugger/README @@ -10,7 +10,7 @@ Daniel-Constantin Mierla <miconda(a)gmail.com> - Copyright © 2010 Daniel-Constantin Mierla (asipto.com) + Copyright � 2010 Daniel-Constantin Mierla (asipto.com) __________________________________________________________________ Table of Contents @@ -36,6 +36,7 @@ Daniel-Constantin Mierla 3.9. mod_level_mode (int) 3.10. mod_level (str) 3.11. log_assign (int) + 3.12. cfgpkgcheck (int) 4. Functions @@ -66,9 +67,10 @@ Daniel-Constantin Mierla 1.9. Set mod_level_mode parameter 1.10. Set mod_level parameter 1.11. Set log_assign parameter - 1.12. dbg_breakpoint usage - 1.13. dbg_pv_dump usage - 1.14. Set reset_msgid parameter + 1.12. Set cfgpkgcheck parameter + 1.13. dbg_breakpoint usage + 1.14. dbg_pv_dump usage + 1.15. Set reset_msgid parameter Chapter 1. Admin Guide @@ -93,6 +95,7 @@ Chapter 1. Admin Guide 3.9. mod_level_mode (int) 3.10. mod_level (str) 3.11. log_assign (int) + 3.12. cfgpkgcheck (int) 4. Functions @@ -162,6 +165,7 @@ Chapter 1. Admin Guide 3.9. mod_level_mode (int) 3.10. mod_level (str) 3.11. log_assign (int) + 3.12. cfgpkgcheck (int) 3.1. cfgtrace (int) @@ -169,7 +173,7 @@ Chapter 1. Admin Guide startup. You can change the value at runtime without restart, globally or per process. - Default value is “0” (disabled). + Default value is "0" (disabled). Example 1.1. Set cfgtrace parameter ... @@ -181,7 +185,7 @@ modparam("debugger", "cfgtrace", 1) Control whether every line (global) breakpoint is enabled or disabled at startup. - Default value is “0” (disabled). + Default value is "0" (disabled). Example 1.2. Set breakpoint parameter ... @@ -192,7 +196,7 @@ modparam("debugger", "breakpoint", 1) What log level is to be used to print module-specific messages. - Default value is “-1” (L_ERR). + Default value is "-1" (L_ERR). Example 1.3. Set log_level parameter ... @@ -205,7 +209,7 @@ modparam("debugger", "log_level", 1) using this setting, you can configure syslog to send debug messages to a separate log channel, like a specific kamailio-debug log file. - Default value is “NULL” (default from core). + Default value is "NULL" (default from core). Example 1.4. Set log_facility parameter ... @@ -216,7 +220,7 @@ modparam("debugger", "log_facility", "LOG_DAEMON") String to print before any module-specific messages. - Default value is “*** cfgtrace:”. + Default value is "*** cfgtrace:". Example 1.5. Set log_prefix parameter ... @@ -228,7 +232,7 @@ modparam("debugger", "log_prefix", "from-debugger-with-love:") Microseconds to sleep before checking for new commands when waiting at a breakpoint. - Default value is “100000” (that is 0.1 sec). + Default value is "100000" (that is 0.1 sec). Example 1.6. Set step_usleep parameter ... @@ -242,7 +246,7 @@ modparam("debugger", "step_usleep", 500000) blocking RPC process forever in case the worker process 'forgets' to write back a reply. - Default value is “200”. + Default value is "200". Example 1.7. Set step_loops parameter ... @@ -256,7 +260,7 @@ modparam("debugger", "step_loops", 100) slots). This parameter is accesible readonly via the Kamailio config framework. - Default value is “0” - feature disabled. + Default value is "0" - feature disabled. Example 1.8. Set mod_hash_size parameter ... @@ -268,7 +272,7 @@ modparam("debugger", "mod_hash_size", 5) Enable or disable per module log level (0 - disabled, 1 - enabled). This parameter is tunable via the Kamailio config framework. - Default value is “0”. + Default value is "0". Example 1.9. Set mod_level_mode parameter ... @@ -292,20 +296,32 @@ modparam("debugger", "mod_level", "tm=3") Enable or disable log assign actions on config (0 - disabled, 1 - enabled). - Default value is “0”. + Default value is "0". Example 1.11. Set log_assign parameter ... modparam("debugger", "log_assign", 1) ... +3.12. cfgpkgcheck (int) + + If set, before each config action is done pkg memory check, useful to + detect buffer overflows. + + Default value is "0" (disabled). + + Example 1.12. Set cfgpkgcheck parameter +... +modparam("debugger", "cfgpkgcheck", 1) +... + 4. Functions 4.1. dbg_breakpoint(mode) 4.2. dbg_pv_dump([mask] [, level]) 4.3. reset_msgid (int) -4.1. dbg_breakpoint(mode) +4.1. dbg_breakpoint(mode) Anchor a breakpoint at the current line of the config (the one on which this function is called). The 'mode' specifies whether the breakpoint @@ -314,13 +330,13 @@ modparam("debugger", "log_assign", 1) Note that this version of the module does not export this anchors to RPC for interactive debugging (temporarily disabled). - Example 1.12. dbg_breakpoint usage + Example 1.13. dbg_breakpoint usage ... if($si=="10.0.0.10") dbg_breakpoint("1"); ... -4.2. dbg_pv_dump([mask] [, level]) +4.2. dbg_pv_dump([mask] [, level]) Prints the content of pv_cache on json format. Defaults are mask=31 and level = "L_DBG" @@ -342,7 +358,7 @@ if($si=="10.0.0.10") * L_INFO - log level 2 * L_DBG - log level 3 - Example 1.13. dbg_pv_dump usage + Example 1.14. dbg_pv_dump usage ... $var(temp) = 1; $avp(s:more_avp) = 2; @@ -370,9 +386,9 @@ x":0,"$var(empty)":0} Used to enable or disable the ability to reset the msgid ($mi) through the dbg.reset_msgid RPC command. (0 - disabled, 1 - enabled). - Default value is “0” - feature disabled. + Default value is "0" - feature disabled. - Example 1.14. Set reset_msgid parameter + Example 1.15. Set reset_msgid parameter ... modparam("debugger", "reset_msgid", 1) ... @@ -385,7 +401,7 @@ modparam("debugger", "reset_msgid", 1) 5.4. dbg.mod_level 5.5. dbg.reset_msgid -5.1. dbg.ls +5.1. dbg.ls List Kamailio processes with info related to interactive debugging. @@ -399,7 +415,7 @@ modparam("debugger", "reset_msgid", 1) dbg.ls dbg.ls 1234 -5.2. dbg.trace +5.2. dbg.trace Control config script running trace. @@ -416,7 +432,7 @@ modparam("debugger", "reset_msgid", 1) dbg.trace off dbg.trace on 1234 -5.3. dbg.bp +5.3. dbg.bp Control breakpoints and config execution. @@ -454,7 +470,7 @@ modparam("debugger", "reset_msgid", 1) dbg.bp eval 1234 $fu dbg.bp move 1234 -5.4. dbg.mod_level +5.4. dbg.mod_level Specify module log level. @@ -468,7 +484,7 @@ modparam("debugger", "reset_msgid", 1) dbg.mod_level core 3 dbg.mod_level tm 3 -5.5. dbg.reset_msgid +5.5. dbg.reset_msgid Resets the message sequence ($mi). Internally there is no real change. This can be useful for unit test cases in order to be able to replicate diff --git a/modules/debugger/doc/debugger_admin.xml b/modules/debugger/doc/debugger_admin.xml index 4a41ade..46d0cea 100644 --- a/modules/debugger/doc/debugger_admin.xml +++ b/modules/debugger/doc/debugger_admin.xml @@ -302,6 +302,27 @@ modparam("debugger", "log_assign", 1) </example> </section> + <section id="dbg.p.cfgpkgcheck"> + <title><varname>cfgpkgcheck</varname> (int)</title> + <para> + If set, before each config action is done pkg memory check, + useful to detect buffer overflows. + </para> + <para> + <emphasis> + Default value is <quote>0</quote> (disabled). + </emphasis> + </para> + <example> + <title>Set <varname>cfgpkgcheck</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("debugger", "cfgpkgcheck", 1) +... +</programlisting> + </example> + </section> + </section> <section>

1 0

git:master: debugger: new parameter cfgpkgcheck to do pkg memory check before each action
by Daniel-Constantin Mierla 17 Sep '13

17 Sep '13

Module: sip-router Branch: master Commit: d1e456b251602e1336e4dbede1e9f8b5d1c19415 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d1e456b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Sep 17 14:47:49 2013 +0200 debugger: new parameter cfgpkgcheck to do pkg memory check before each action --- modules/debugger/debugger_api.c | 16 ++++++++++++++++ modules/debugger/debugger_mod.c | 2 ++ 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/modules/debugger/debugger_api.c b/modules/debugger/debugger_api.c index 7a11631..56d2975 100644 --- a/modules/debugger/debugger_api.c +++ b/modules/debugger/debugger_api.c @@ -152,6 +152,11 @@ int _dbg_cfgtrace = 0; /** * */ +int _dbg_cfgpkgcheck = 0; + +/** + * + */ int _dbg_breakpoint = 0; /** @@ -302,6 +307,17 @@ int dbg_cfg_trace(void *data) an = dbg_get_action_name(a); + if(_dbg_cfgpkgcheck!=0) + { +#ifdef q_malloc_h + LM_DBG("checking pkg memory before action %.*s (line %d)\n", + an->len, an->s, a->cline); + qm_check(mem_block); +#else + LM_DBG("cfg pkg check is disbled due to missing qm handler\n"); +#endif + } + if(_dbg_pid_list[process_no].set&DBG_CFGTRACE_ON) { if(is_printable(_dbg_cfgtrace_level)) diff --git a/modules/debugger/debugger_mod.c b/modules/debugger/debugger_mod.c index 87724ce..2f0caa7 100644 --- a/modules/debugger/debugger_mod.c +++ b/modules/debugger/debugger_mod.c @@ -53,6 +53,7 @@ static int w_dbg_dump(struct sip_msg* msg, char* mask, char* level); /* parameters */ extern int _dbg_cfgtrace; +extern int _dbg_cfgpkgcheck; extern int _dbg_breakpoint; extern int _dbg_cfgtrace_level; extern int _dbg_cfgtrace_facility; @@ -89,6 +90,7 @@ static param_export_t params[]={ {"mod_level_mode", INT_PARAM, &default_dbg_cfg.mod_level_mode}, {"mod_level", STR_PARAM|USE_FUNC_PARAM, (void*)dbg_mod_level_param}, {"reset_msgid", INT_PARAM, &_dbg_reset_msgid}, + {"cfgpkgcheck", INT_PARAM, &_dbg_cfgpkgcheck}, {0, 0, 0} };

1 0

[tracker] Comment added: module pua_reginfo, function reginfo_handle_notify
by sip-router 16 Sep '13

16 Sep '13

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#340 - module pua_reginfo, function reginfo_handle_notify User who did this - Wonbin Cho (wbcho) ---------- It does need a parameter named 'domain' as it is used in calling another function 'process_body' within 'reginfo_handle_notify'. The parameter is the name of the location table. It's pretty much the same with the domain parameter for 'lookup' function in registrar module. So you can use the function this way in the configuration script: reginfo_handle_notify("location"); I think the module doc should be updated. I reported this to the documentation mailing list but it's been pending. Can someone please let me know how I can proceed to update the document? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=340#comment1081 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: xmlrpc: fix warning: âc. lenâay be used unini tialized in this function [ -Wmaybe-uninitialized]
by Ovidiu Sas 16 Sep '13

16 Sep '13

Module: sip-router Branch: master Commit: af7c3a816529cde599af9a62bfd174b2de3a2fb6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=af7c3a8… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Sun Sep 15 18:10:06 2013 -0400 xmlrpc: fix warning: âc.lenâay be used uninitialized in this function [-Wmaybe-uninitialized] --- modules/xmlrpc/xmlrpc.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/xmlrpc/xmlrpc.c b/modules/xmlrpc/xmlrpc.c index b840131..4fa9b15 100644 --- a/modules/xmlrpc/xmlrpc.c +++ b/modules/xmlrpc/xmlrpc.c @@ -1995,7 +1995,7 @@ error: */ static int open_doc(rpc_ctx_t* ctx, sip_msg_t* msg) { - str doc; + str doc = {NULL,0}; xmlNodePtr root; xmlNodePtr cur; struct xmlrpc_reply* reply; @@ -2396,7 +2396,7 @@ static int xmlrpc_reply(sip_msg_t* msg, char* p1, char* p2) static int select_method(str* res, struct select* s, sip_msg_t* msg) { static char buf[1024]; - str doc; + str doc = {NULL,0}; xmlDocPtr xmldoc; xmlNodePtr cur; char* method;

1 0

git:master: ipops: fix warning: variable âtâet but?==?UTF-8?Q? not used [-Wunused-but-set-variable]
by Ovidiu Sas 16 Sep '13

16 Sep '13

Module: sip-router Branch: master Commit: 78a1c7e972b66c882e9466404d1cb6c08982eb91 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=78a1c7e… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Sun Sep 15 18:06:18 2013 -0400 ipops: fix warning: variable âtâet but not used [-Wunused-but-set-variable] --- modules/ipops/ipops_mod.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/modules/ipops/ipops_mod.c b/modules/ipops/ipops_mod.c index c87a0eb..d90aaa3 100644 --- a/modules/ipops/ipops_mod.c +++ b/modules/ipops/ipops_mod.c @@ -703,7 +703,6 @@ static int w_dns_int_match_ip(sip_msg_t *msg, char *hnp, char *ipp) str ips; struct hostent* he; char ** h; - int ret; if (fixup_get_svalue(msg, (gparam_p)hnp, &hns)) { @@ -729,7 +728,7 @@ static int w_dns_int_match_ip(sip_msg_t *msg, char *hnp, char *ipp) DBG("could not resolve %s\n", hns.s); return -4; } - ret = 0; + if (he->h_addrtype==ipa->af) { for(h=he->h_addr_list; (*h); h++)

1 0

patch: has_sdp() does not exist
by Mikko Lehto 16 Sep '13

16 Sep '13

I want to stop writing has_sdp() in script, maybe this patch eventually helps. -- Mikko

2 1

git:master: rtpproxy(-ng): patch: has_sdp() does not exist
by Ovidiu Sas 16 Sep '13

16 Sep '13

Module: sip-router Branch: master Commit: aa15067b8a1f44d57551f646acd5058c08abe41f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=aa15067… Author: Mikko Lehto <mslehto(a)iki.fi> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Sun Sep 15 16:55:04 2013 -0400 rtpproxy(-ng): patch: has_sdp() does not exist --- modules/rtpproxy-ng/README | 8 ++++---- modules/rtpproxy-ng/doc/rtpproxy_admin.xml | 8 ++++---- modules/rtpproxy/README | 8 ++++---- modules/rtpproxy/doc/rtpproxy_admin.xml | 8 ++++---- 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/modules/rtpproxy-ng/README b/modules/rtpproxy-ng/README index 3155db6..6e14ecf 100644 --- a/modules/rtpproxy-ng/README +++ b/modules/rtpproxy-ng/README @@ -427,14 +427,14 @@ rtpproxy_offer(); route { ... if (is_method("INVITE")) { - if (has_sdp()) { + if (has_body("application/sdp")) { if (rtpproxy_offer()) t_on_reply("1"); } else { t_on_reply("2"); } } - if (is_method("ACK") && has_sdp()) + if (is_method("ACK") && has_body("application/sdp")) rtpproxy_answer(); ... } @@ -442,7 +442,7 @@ route { onreply_route[1] { ... - if (has_sdp()) + if (has_body("application/sdp")) rtpproxy_answer(); ... } @@ -450,7 +450,7 @@ onreply_route[1] onreply_route[2] { ... - if (has_sdp()) + if (has_body("application/sdp")) rtpproxy_offer(); ... } diff --git a/modules/rtpproxy-ng/doc/rtpproxy_admin.xml b/modules/rtpproxy-ng/doc/rtpproxy_admin.xml index 9ad60c3..18c389b 100644 --- a/modules/rtpproxy-ng/doc/rtpproxy_admin.xml +++ b/modules/rtpproxy-ng/doc/rtpproxy_admin.xml @@ -438,14 +438,14 @@ rtpproxy_offer(); route { ... if (is_method("INVITE")) { - if (has_sdp()) { + if (has_body("application/sdp")) { if (rtpproxy_offer()) t_on_reply("1"); } else { t_on_reply("2"); } } - if (is_method("ACK") && has_sdp()) + if (is_method("ACK") && has_body("application/sdp")) rtpproxy_answer(); ... } @@ -453,7 +453,7 @@ route { onreply_route[1] { ... - if (has_sdp()) + if (has_body("application/sdp")) rtpproxy_answer(); ... } @@ -461,7 +461,7 @@ onreply_route[1] onreply_route[2] { ... - if (has_sdp()) + if (has_body("application/sdp")) rtpproxy_offer(); ... } diff --git a/modules/rtpproxy/README b/modules/rtpproxy/README index da2c9a1..43b57df 100644 --- a/modules/rtpproxy/README +++ b/modules/rtpproxy/README @@ -511,14 +511,14 @@ rtpproxy_offer(); route { ... if (is_method("INVITE")) { - if (has_sdp()) { + if (has_body("application/sdp")) { if (rtpproxy_offer()) t_on_reply("1"); } else { t_on_reply("2"); } } - if (is_method("ACK") && has_sdp()) + if (is_method("ACK") && has_body("application/sdp")) rtpproxy_answer(); ... } @@ -526,7 +526,7 @@ route { onreply_route[1] { ... - if (has_sdp()) + if (has_body("application/sdp")) rtpproxy_answer(); ... } @@ -534,7 +534,7 @@ onreply_route[1] onreply_route[2] { ... - if (has_sdp()) + if (has_body("application/sdp")) rtpproxy_offer(); ... } diff --git a/modules/rtpproxy/doc/rtpproxy_admin.xml b/modules/rtpproxy/doc/rtpproxy_admin.xml index 8f968ea..7a60c17 100644 --- a/modules/rtpproxy/doc/rtpproxy_admin.xml +++ b/modules/rtpproxy/doc/rtpproxy_admin.xml @@ -494,14 +494,14 @@ rtpproxy_offer(); route { ... if (is_method("INVITE")) { - if (has_sdp()) { + if (has_body("application/sdp")) { if (rtpproxy_offer()) t_on_reply("1"); } else { t_on_reply("2"); } } - if (is_method("ACK") && has_sdp()) + if (is_method("ACK") && has_body("application/sdp")) rtpproxy_answer(); ... } @@ -509,7 +509,7 @@ route { onreply_route[1] { ... - if (has_sdp()) + if (has_body("application/sdp")) rtpproxy_answer(); ... } @@ -517,7 +517,7 @@ onreply_route[1] onreply_route[2] { ... - if (has_sdp()) + if (has_body("application/sdp")) rtpproxy_offer(); ... }

1 0

git:4.0: xhttp_pi: fix crash when checking bad configs
by Ovidiu Sas 16 Sep '13

16 Sep '13

Module: sip-router Branch: 4.0 Commit: a331af11519765e863ddad68878f7c5d571d0823 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a331af1… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: Sun Sep 15 16:38:34 2013 -0400 xhttp_pi: fix crash when checking bad configs (cherry picked from commit d1219dc0d0c5e2eab0672a439aa7ce6486c31ba3) --- modules/xhttp_pi/http_db_handler.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/modules/xhttp_pi/http_db_handler.c b/modules/xhttp_pi/http_db_handler.c index 0a5a509..730f37d 100644 --- a/modules/xhttp_pi/http_db_handler.c +++ b/modules/xhttp_pi/http_db_handler.c @@ -90,8 +90,11 @@ int init_http_db(ph_framework_t *framework_data, int index) void destroy_http_db(ph_framework_t *framework_data) { int i; - ph_db_url_t *ph_db_urls = framework_data->ph_db_urls; + ph_db_url_t *ph_db_urls; + + if (framework_data == NULL) return; + ph_db_urls = framework_data->ph_db_urls; /* close the DB connections */ for(i=0;i<framework_data->ph_db_urls_size;i++){ if (ph_db_urls[i].http_db_handle) {

1 0

← Newer
1
...
15
16
17
18
19
20
21
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2013