sr-dev January 2014

sr-dev@lists.kamailio.org

27 participants
211 discussions

git:master: acc: added note about MySQL InnoDB not supporting INSERT DELAYED
by Daniel-Constantin Mierla 03 Jan '14

03 Jan '14

Module: sip-router Branch: master Commit: d26eff22c8a543c63a40cd7d91bb3c70f04aabc6 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d26eff2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Fri Jan 3 10:04:39 2014 +0100 acc: added note about MySQL InnoDB not supporting INSERT DELAYED - reported by Daniel Tryba --- modules/acc/doc/acc_admin.xml | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/modules/acc/doc/acc_admin.xml b/modules/acc/doc/acc_admin.xml index e233cb4..c59aa0e 100644 --- a/modules/acc/doc/acc_admin.xml +++ b/modules/acc/doc/acc_admin.xml @@ -1093,7 +1093,9 @@ modparam("acc", "db_extra", "ct=$hdr(Content-type); email=$avp(s:email)") <para> If set to 1, use INSERT DELAYED to add records to accounting tables when the DB driver has support for it. If no INSERT DELAYED support - is offered by DB driver, then standard INSERT is used. + is offered by DB driver, then standard INSERT is used. Beware that + MySQL InnoDB engine doesn't support INSERT DELAYED, thus be sure + the acc tables are defined with different type (e.g., MyISAM). </para> <para> Default value is 0 (no INSERT DELAYED).

1 0

[tracker] Comment added: modules/app_lua: sr.xavp.get() allow get all values of a name (Attachment added)
by sip-router 03 Jan '14

03 Jan '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#365 - modules/app_lua: sr.xavp.get() allow get all values of a name User who did this - Víctor Seva (linuxmaniac) ---------- Here I allow nil as second parameter to indicate all values and <0 index to get a value counting from the end. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=365#comment1260 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: acc: refresh README
by Victor Seva 03 Jan '14

03 Jan '14

Module: sip-router Branch: master Commit: cff3406513c30d41ce1118a1f0997e254531bdb9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cff3406… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Fri Jan 3 08:57:17 2014 +0100 acc: refresh README --- modules/acc/README | 90 +++++++++++++++++++++++++++++----------------------- 1 files changed, 50 insertions(+), 40 deletions(-) diff --git a/modules/acc/README b/modules/acc/README index f6b1c5c..93b323f 100644 --- a/modules/acc/README +++ b/modules/acc/README @@ -29,11 +29,11 @@ Sven Knoblich 1&1 Internet AG <sven.knoblich(a)1und1.de> - Copyright � 2002, 2003 FhG FOKUS + Copyright © 2002, 2003 FhG FOKUS - Copyright � 2004, 2006 Voice Sistem SRL + Copyright © 2004, 2006 Voice Sistem SRL - Copyright � 2011 1&1 Internet AG + Copyright © 2011 1&1 Internet AG Revision History Revision $Revision$ $Date$ __________________________________________________________________ @@ -1351,7 +1351,7 @@ modparam("acc", "time_format", "%Y/%m/%d %H:%M:%S") 7.3. acc_rad_request(comment) 7.4. acc_diam_request(comment) -7.1. acc_log_request(comment) +7.1. acc_log_request(comment) acc_request reports on a request, for example, it can be used to report on missed calls to off-line users who are replied 404 - Not Found. To @@ -1359,23 +1359,28 @@ modparam("acc", "time_format", "%Y/%m/%d %H:%M:%S") embed the action in stateful processing. Meaning of the parameters is as follows: - * comment - Comment to be appended. + * comment - Comment to be appended. The string can contain any number + of pseudo-variables. This function can be used from ANY_ROUTE. Example 1.51. acc_log_request usage ... acc_log_request("Some comment"); +$var(code) = 404; +$avp(reason) = "Not found"; +acc_log_request("$var(code) Error: $avp(reason)"); ... -7.2. acc_db_request(comment, table) +7.2. acc_db_request(comment, table) Like acc_log_request, acc_db_request reports on a request. The report is sent to database at "db_url", in the table referred to in the second action parameter. Meaning of the parameters is as follows: - * comment - Comment to be appended. + * comment - Comment to be appended. The string can contain any number + of pseudo-variables. * table - Database table to be used. It can contain config variables that are evaluated at runtime. @@ -1385,36 +1390,41 @@ acc_log_request("Some comment"); ... acc_db_request("Some comment", "SomeTable"); acc_db_request("Some comment", "acc_$time(year)_$time(mon)"); +acc_db_request("$var(code) Error: $avp(reason)", "SomeTable"); ... -7.3. acc_rad_request(comment) +7.3. acc_rad_request(comment) Like acc_log_request, acc_rad_request reports on a request. It reports to radius server as configured in "radius_config". Meaning of the parameters is as follows: - * comment - Comment to be appended. + * comment - Comment to be appended. The string can contain any number + of pseudo-variables. This function can be used from ANY_ROUTE. Example 1.53. acc_rad_request usage ... acc_rad_request("Some comment"); +acc_rad_request("$var(code) Error: $avp(reason)"); ... -7.4. acc_diam_request(comment) +7.4. acc_diam_request(comment) Like acc_log_request, acc_diam_request reports on a request. It reports to the configured Diameter server. Meaning of the parameters is as follows: - * comment - Comment to be appended. + * comment - Comment to be appended. The string can contain any number + of pseudo-variables. This function can be used from ANY_ROUTE. Example 1.54. acc_diam_request usage ... acc_diam_request("Some comment"); +acc_diam_request("$var(code) Error: $avp(reason)"); ... Chapter 2. Frequently Asked Questions @@ -1428,55 +1438,55 @@ Chapter 2. Frequently Asked Questions 2.1. - What happend with old log_fmt parameter + What happend with old log_fmt parameter - The parameter became obsolete with the restructure of the data logged - by ACC module (refer to the Overview chapter). For similar behaviour - you can use the extra accouting (see the coresponding chapter). + The parameter became obsolete with the restructure of the data logged + by ACC module (refer to the Overview chapter). For similar behaviour + you can use the extra accouting (see the coresponding chapter). 2.2. - What happend with old multi_leg_enabled parameter + What happend with old multi_leg_enabled parameter - The parameter becaome obsolete by the addition of the new - multi_leg_info parameter. The multi-leg accouting is automatically - enabled when multi_leg_info is defined. + The parameter becaome obsolete by the addition of the new + multi_leg_info parameter. The multi-leg accouting is automatically + enabled when multi_leg_info is defined. 2.3. - What happend with old src_leg_avp_id and dst_leg_avp_id parameters + What happend with old src_leg_avp_id and dst_leg_avp_id parameters - The parameter was replaced by the more generic new parameter - multi_leg_info. This allows logging (per-leg) of more information than - just dst and src. + The parameter was replaced by the more generic new parameter + multi_leg_info. This allows logging (per-leg) of more information than + just dst and src. 2.4. - Where can I find more about Kamailio? + Where can I find more about Kamailio? - Take a look at http://www.kamailio.org/. + Take a look at http://www.kamailio.org/. 2.5. - Where can I post a question about this module? + Where can I post a question about this module? - First at all check if your question was already answered on one of our - mailing lists: - * User Mailing List - - http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users - * Developer Mailing List - - http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev + First at all check if your question was already answered on one of our + mailing lists: + * User Mailing List - + http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users + * Developer Mailing List - + http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev - E-mails regarding any stable Kamailio release should be sent to - <sr-users(a)lists.sip-router.org> and e-mails regarding development - versions should be sent to <sr-dev(a)lists.sip-router.org>. + E-mails regarding any stable Kamailio release should be sent to + <sr-users(a)lists.sip-router.org> and e-mails regarding development + versions should be sent to <sr-dev(a)lists.sip-router.org>. - If you want to keep the mail private, send it to - <sr-users(a)lists.sip-router.org>. + If you want to keep the mail private, send it to + <sr-users(a)lists.sip-router.org>. 2.6. - How can I report a bug? + How can I report a bug? - Please follow the guidelines provided at: - http://sip-router.org/tracker. + Please follow the guidelines provided at: + http://sip-router.org/tracker.

1 0

[tracker] Comment added: modules/app_lua: sr.xavp.get() allow get all values of a name
by sip-router 02 Jan '14

02 Jan '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#365 - modules/app_lua: sr.xavp.get() allow get all values of a name User who did this - Víctor Seva (linuxmaniac) ---------- I think it is better to use sr.xavp.get with the second parameter as nil to indicate all values. So we can use <0 values too. ---------- More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=365#comment1259 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Task closed: acc: allow pvar as first parameter for functions
by sip-router 02 Jan '14

02 Jan '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#386 - acc: allow pvar as first parameter for functions User who did this - Víctor Seva (linuxmaniac) Reason for closing: Implemented More information can be found at the following URL: https://sip-router.org/tracker/index.php?do=details&task_id=386 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:vseva/acc_pvar DELETED: acc: allow pvar as first parameter for functions. WIP.
by Victor Seva 02 Jan '14

02 Jan '14

Module: sip-router Branch: vseva/acc_pvar DELETED Commit: 7c83177a07037a80160eb5a89828a3d3874a9e62 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7c83177… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Thu Dec 12 17:35:16 2013 +0100 acc: allow pvar as first parameter for functions. WIP. --- modules/acc/acc_api.h | 1 + modules/acc/acc_logic.c | 50 ++++++++++++++++++++++++++++++++++++++++++---- modules/acc/acc_mod.c | 17 +++++++-------- 3 files changed, 54 insertions(+), 14 deletions(-) diff --git a/modules/acc/acc_api.h b/modules/acc/acc_api.h index aa51380..0660797 100644 --- a/modules/acc/acc_api.h +++ b/modules/acc/acc_api.h @@ -48,6 +48,7 @@ typedef struct acc_param { int code; str code_s; str reason; + pv_spec_t *spec; } acc_param_t; /* various acc variables */ diff --git a/modules/acc/acc_logic.c b/modules/acc/acc_logic.c index 50278fb..e7c754f 100644 --- a/modules/acc/acc_logic.c +++ b/modules/acc/acc_logic.c @@ -166,14 +166,45 @@ static inline int acc_preparse_req(struct sip_msg *req) return 0; } - +int acc_get_param_value(struct sip_msg *rq, struct acc_param *param) +{ + pv_value_t xvalue; + char *p; + if(param->spec!=NULL) { + if(pv_get_spec_value(rq, param->spec, &xvalue)==-1) { + LM_ERR("Can't get value for %.*s\n", param->reason.len, param->reason.s); + return -1; + } + if(!(xvalue.flags&(PV_VAL_STR))) { + LM_ERR("pvar %.*s is not a string", param->reason.len, param->reason.s); + return -1; + } + param->reason.s = xvalue.rs.s; + param->reason.len = xvalue.rs.len; + } + p = param->reason.s; + /* any code? */ + if (param->reason.len>=3 && isdigit((int)p[0]) + && isdigit((int)p[1]) && isdigit((int)p[2]) ) { + param->code = (p[0]-'0')*100 + (p[1]-'0')*10 + (p[2]-'0'); + param->code_s.s = p; + param->code_s.len = 3; + param->reason.s += 3; + for( ; isspace((int)param->reason.s[0]) ; param->reason.s++ ); + param->reason.len = strlen(param->reason.s); + } + return 0; +} int w_acc_log_request(struct sip_msg *rq, char *comment, char *foo) { + struct acc_param *param = (struct acc_param*)comment; if (acc_preparse_req(rq)<0) return -1; + if(acc_get_param_value(rq, param)<0) + return -1; env_set_to( rq->to ); - env_set_comment((struct acc_param*)comment); + env_set_comment(param); env_set_text( ACC_REQUEST, ACC_REQUEST_LEN); return acc_log_request(rq); } @@ -212,6 +243,7 @@ int acc_db_set_table_name(struct sip_msg *msg, void *param, str *table) int w_acc_db_request(struct sip_msg *rq, char *comment, char *table) { + struct acc_param *param = (struct acc_param*)comment; if (!table) { LM_ERR("db support not configured\n"); return -1; @@ -222,8 +254,10 @@ int w_acc_db_request(struct sip_msg *rq, char *comment, char *table) LM_ERR("cannot set table name\n"); return -1; } + if(acc_get_param_value(rq, param)<0) + return -1; env_set_to( rq->to ); - env_set_comment((struct acc_param*)comment); + env_set_comment(param); return acc_db_request(rq); } #endif @@ -232,10 +266,13 @@ int w_acc_db_request(struct sip_msg *rq, char *comment, char *table) #ifdef RAD_ACC int w_acc_rad_request(struct sip_msg *rq, char *comment, char *foo) { + struct acc_param *param = (struct acc_param*)comment; if (acc_preparse_req(rq)<0) return -1; + if(acc_get_param_value(rq, param)<0) + return -1; env_set_to( rq->to ); - env_set_comment((struct acc_param*)comment); + env_set_comment(param); return acc_rad_request(rq); } #endif @@ -244,10 +281,13 @@ int w_acc_rad_request(struct sip_msg *rq, char *comment, char *foo) #ifdef DIAM_ACC int w_acc_diam_request(struct sip_msg *rq, char *comment, char *foo) { + struct acc_param *param = (struct acc_param*)comment; if (acc_preparse_req(rq)<0) return -1; + if(acc_get_param_value(rq, param)<0) + return -1; env_set_to( rq->to ); - env_set_comment((struct acc_param*)comment); + env_set_comment(param); return acc_diam_request(rq); } #endif diff --git a/modules/acc/acc_mod.c b/modules/acc/acc_mod.c index 2fb9258..9d9b583 100644 --- a/modules/acc/acc_mod.c +++ b/modules/acc/acc_mod.c @@ -355,15 +355,14 @@ static int acc_fixup(void** param, int param_no) memset( accp, 0, sizeof(struct acc_param)); accp->reason.s = p; accp->reason.len = strlen(p); - /* any code? */ - if (accp->reason.len>=3 && isdigit((int)p[0]) - && isdigit((int)p[1]) && isdigit((int)p[2]) ) { - accp->code = (p[0]-'0')*100 + (p[1]-'0')*10 + (p[2]-'0'); - accp->code_s.s = p; - accp->code_s.len = 3; - accp->reason.s += 3; - for( ; isspace((int)accp->reason.s[0]) ; accp->reason.s++ ); - accp->reason.len = strlen(accp->reason.s); + if (p[0]=='$') { /* is a variable $xxxxx */ + accp->spec = pv_cache_get(&accp->reason); + if (accp->spec==0 || accp->spec->type==PVT_NULL || accp->spec->type==PVT_EMPTY) + { + LM_ERR("bad param 1; " + "expected : $pseudo-variable or str value\n"); + return E_UNSPEC; + } } *param = (void*)accp; #ifdef SQL_ACC

1 0

git:master: acc: allow pseudo-variables as first parameter for functions.
by Victor Seva 02 Jan '14

02 Jan '14

Module: sip-router Branch: master Commit: 81c6e0bc108b8f4211ffade6de7a7448d1ba72f9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=81c6e0b… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Thu Jan 2 20:39:43 2014 +0100 acc: allow pseudo-variables as first parameter for functions. --- modules/acc/acc_api.h | 1 + modules/acc/acc_logic.c | 52 +++++++++++++++++++++++++++++++++++++++++++--- modules/acc/acc_logic.h | 2 +- modules/acc/acc_mod.c | 24 +++++++++++++-------- 4 files changed, 65 insertions(+), 14 deletions(-) diff --git a/modules/acc/acc_api.h b/modules/acc/acc_api.h index aa51380..a4d8bc6 100644 --- a/modules/acc/acc_api.h +++ b/modules/acc/acc_api.h @@ -48,6 +48,7 @@ typedef struct acc_param { int code; str code_s; str reason; + pv_elem_p elem; } acc_param_t; /* various acc variables */ diff --git a/modules/acc/acc_logic.c b/modules/acc/acc_logic.c index 18437fc..0641388 100644 --- a/modules/acc/acc_logic.c +++ b/modules/acc/acc_logic.c @@ -166,14 +166,49 @@ static inline int acc_preparse_req(struct sip_msg *req) return 0; } +int acc_parse_code(char *p, struct acc_param *param) +{ + if (p==NULL||param==NULL) + return -1; + /* any code? */ + if (param->reason.len>=3 && isdigit((int)p[0]) + && isdigit((int)p[1]) && isdigit((int)p[2]) ) { + param->code = (p[0]-'0')*100 + (p[1]-'0')*10 + (p[2]-'0'); + param->code_s.s = p; + param->code_s.len = 3; + param->reason.s += 3; + for( ; isspace((int)param->reason.s[0]) ; param->reason.s++ ); + param->reason.len = strlen(param->reason.s); + } + return 0; +} + +int acc_get_param_value(struct sip_msg *rq, struct acc_param *param) +{ + if(param->elem!=NULL) { + if(pv_printf_s(rq, param->elem, &param->reason)==-1) { + LM_ERR("Can't get value for %.*s\n", param->reason.len, param->reason.s); + return -1; + } + if(acc_parse_code(param->reason.s, param)<0) + { + LM_ERR("Can't parse code\n"); + return -1; + } + } + return 0; +} int w_acc_log_request(struct sip_msg *rq, char *comment, char *foo) { + struct acc_param *param = (struct acc_param*)comment; if (acc_preparse_req(rq)<0) return -1; + if(acc_get_param_value(rq, param)<0) + return -1; env_set_to( rq->to ); - env_set_comment((struct acc_param*)comment); + env_set_comment(param); env_set_text( ACC_REQUEST, ACC_REQUEST_LEN); return acc_log_request(rq); } @@ -212,6 +247,7 @@ int acc_db_set_table_name(struct sip_msg *msg, void *param, str *table) int w_acc_db_request(struct sip_msg *rq, char *comment, char *table) { + struct acc_param *param = (struct acc_param*)comment; if (!table) { LM_ERR("db support not configured\n"); return -1; @@ -222,8 +258,10 @@ int w_acc_db_request(struct sip_msg *rq, char *comment, char *table) LM_ERR("cannot set table name\n"); return -1; } + if(acc_get_param_value(rq, param)<0) + return -1; env_set_to( rq->to ); - env_set_comment((struct acc_param*)comment); + env_set_comment(param); return acc_db_request(rq); } #endif @@ -232,10 +270,13 @@ int w_acc_db_request(struct sip_msg *rq, char *comment, char *table) #ifdef RAD_ACC int w_acc_rad_request(struct sip_msg *rq, char *comment, char *foo) { + struct acc_param *param = (struct acc_param*)comment; if (acc_preparse_req(rq)<0) return -1; + if(acc_get_param_value(rq, param)<0) + return -1; env_set_to( rq->to ); - env_set_comment((struct acc_param*)comment); + env_set_comment(param); return acc_rad_request(rq); } #endif @@ -244,10 +285,13 @@ int w_acc_rad_request(struct sip_msg *rq, char *comment, char *foo) #ifdef DIAM_ACC int w_acc_diam_request(struct sip_msg *rq, char *comment, char *foo) { + struct acc_param *param = (struct acc_param*)comment; if (acc_preparse_req(rq)<0) return -1; + if(acc_get_param_value(rq, param)<0) + return -1; env_set_to( rq->to ); - env_set_comment((struct acc_param*)comment); + env_set_comment(param); return acc_diam_request(rq); } #endif diff --git a/modules/acc/acc_logic.h b/modules/acc/acc_logic.h index 7348471..29ee8f7 100644 --- a/modules/acc/acc_logic.h +++ b/modules/acc/acc_logic.h @@ -41,7 +41,7 @@ #include "../../modules/tm/t_hooks.h" #include "acc_api.h" - +int acc_parse_code(char *p, struct acc_param *param); void acc_onreq( struct cell* t, int type, struct tmcb_params *ps ); int w_acc_log_request(struct sip_msg *rq, char *comment, char *foo); diff --git a/modules/acc/acc_mod.c b/modules/acc/acc_mod.c index 2fb9258..8be152a 100644 --- a/modules/acc/acc_mod.c +++ b/modules/acc/acc_mod.c @@ -355,15 +355,21 @@ static int acc_fixup(void** param, int param_no) memset( accp, 0, sizeof(struct acc_param)); accp->reason.s = p; accp->reason.len = strlen(p); - /* any code? */ - if (accp->reason.len>=3 && isdigit((int)p[0]) - && isdigit((int)p[1]) && isdigit((int)p[2]) ) { - accp->code = (p[0]-'0')*100 + (p[1]-'0')*10 + (p[2]-'0'); - accp->code_s.s = p; - accp->code_s.len = 3; - accp->reason.s += 3; - for( ; isspace((int)accp->reason.s[0]) ; accp->reason.s++ ); - accp->reason.len = strlen(accp->reason.s); + if (strchr(p,PV_MARKER)!=NULL) { /* is a variable $xxxxx */ + if (pv_parse_format(&accp->reason, &accp->elem)<0) + { + LM_ERR("bad param 1; " + "parse format error [%.*s]\n", accp->reason.len, accp->reason.s); + return E_UNSPEC; + } + } + else { + if(acc_parse_code(p,accp)<0) + { + LM_ERR("bad param 1;" + "parse code error\n"); + return E_UNSPEC; + } } *param = (void*)accp; #ifdef SQL_ACC

1 0

git:master: acc: add documentation note indicating the use of pseudo-variables
by Victor Seva 02 Jan '14

02 Jan '14

Module: sip-router Branch: master Commit: 1e82ef702f9a0c3dec3e24e4f91dc879d7ba5280 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=1e82ef7… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: Thu Jan 2 20:39:43 2014 +0100 acc: add documentation note indicating the use of pseudo-variables --- modules/acc/doc/acc_admin.xml | 21 ++++++++++++++++----- 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/modules/acc/doc/acc_admin.xml b/modules/acc/doc/acc_admin.xml index 97858be..e233cb4 100644 --- a/modules/acc/doc/acc_admin.xml +++ b/modules/acc/doc/acc_admin.xml @@ -1477,7 +1477,7 @@ modparam("acc", "time_format", "%Y/%m/%d %H:%M:%S") <section> <title>Functions</title> - <section> + <section id="acc.f.acc_log_request"> <title> <function moreinfo="none">acc_log_request(comment)</function> </title> @@ -1493,6 +1493,7 @@ modparam("acc", "time_format", "%Y/%m/%d %H:%M:%S") <itemizedlist> <listitem> <para><emphasis>comment</emphasis> - Comment to be appended. + The string can contain any number of pseudo-variables. </para> </listitem> </itemizedlist> @@ -1504,11 +1505,14 @@ modparam("acc", "time_format", "%Y/%m/%d %H:%M:%S") <programlisting format="linespecific"> ... acc_log_request("Some comment"); +$var(code) = 404; +$avp(reason) = "Not found"; +acc_log_request("$var(code) Error: $avp(reason)"); ... </programlisting> </example> </section> - <section> + <section id="acc.f.acc_db_request"> <title> <function moreinfo="none">acc_db_request(comment, table)</function> </title> @@ -1523,7 +1527,9 @@ acc_log_request("Some comment"); </para> <itemizedlist> <listitem> - <para><emphasis>comment</emphasis> - Comment to be appended.</para> + <para><emphasis>comment</emphasis> - Comment to be appended. + The string can contain any number of pseudo-variables. + </para> </listitem> <listitem> <para><emphasis>table</emphasis> - Database table to be used. It @@ -1539,11 +1545,12 @@ acc_log_request("Some comment"); ... acc_db_request("Some comment", "SomeTable"); acc_db_request("Some comment", "acc_$time(year)_$time(mon)"); +acc_db_request("$var(code) Error: $avp(reason)", "SomeTable"); ... </programlisting> </example> </section> - <section> + <section id="acc.f.acc_rad_request"> <title> <function moreinfo="none">acc_rad_request(comment)</function> </title> @@ -1558,6 +1565,7 @@ acc_db_request("Some comment", "acc_$time(year)_$time(mon)"); <itemizedlist> <listitem> <para><emphasis>comment</emphasis> - Comment to be appended. + The string can contain any number of pseudo-variables. </para> </listitem> </itemizedlist> @@ -1569,11 +1577,12 @@ acc_db_request("Some comment", "acc_$time(year)_$time(mon)"); <programlisting format="linespecific"> ... acc_rad_request("Some comment"); +acc_rad_request("$var(code) Error: $avp(reason)"); ... </programlisting> </example> </section> - <section> + <section id="acc.f.acc_diam_request"> <title> <function moreinfo="none">acc_diam_request(comment)</function> </title> @@ -1587,6 +1596,7 @@ acc_rad_request("Some comment"); <itemizedlist> <listitem> <para><emphasis>comment</emphasis> - Comment to be appended. + The string can contain any number of pseudo-variables. </para> </listitem> </itemizedlist> @@ -1598,6 +1608,7 @@ acc_rad_request("Some comment"); <programlisting format="linespecific"> ... acc_diam_request("Some comment"); +acc_diam_request("$var(code) Error: $avp(reason)"); ... </programlisting> </example>

1 0

[tracker] Comment added: acc: allow pvar as first parameter for functions
by sip-router 02 Jan '14

02 Jan '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#386 - acc: allow pvar as first parameter for functions User who did this - Daniel-Constantin Mierla (miconda) ---------- It can be committed, just add a note about it in the docs/readme. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=386#comment1258 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: acc: allow pvar as first parameter for functions (Attachment added)
by sip-router 02 Jan '14

02 Jan '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#386 - acc: allow pvar as first parameter for functions User who did this - Víctor Seva (linuxmaniac) ---------- changes: - comparison is done against PV_MARKER - if first param is a static string we do the code parse ( just ones at fixup ) or at acc_get_param_value if is dynamic. - Now I use pv_parse_format and pv_printf_s as you suggested allowing the use of a string with pseudo vars. Thanks for the suggestions and the review. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=386#comment1257 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2014