Hey all,
I was taking a look at the presence module API code, specfically the API
code for the hash table. I see that when we delete a subscription according
to hash.c:
int delete_shtable(shtable_t htable,unsigned int hash_code,str to_tag)
{
subs_t* s= NULL, *ps= NULL;
int found= -1;
lock_get(&htable[hash_code].lock);
ps= htable[hash_code].entries;
s= ps->next;
while(s)
{
if(s->to_tag.len== to_tag.len &&
strncmp(s->to_tag.s, to_tag.s, to_tag.len)== 0)
{
found= s->local_cseq +1;
ps->next= s->next;
if(s->contact.s!=NULL)
shm_free(s->contact.s);
shm_free(s);
break;
}
ps= s;
s= s->next;
}
lock_release(&htable[hash_code].lock);
return found;
}
Why are we only searching on to-tag? What if there is a collision on the
hash AND the to-tag is the same for 2+ different subscriptions. This is
even more likely of happening considering that the hash calculation is
based only on the callid and to-tag...
any comments? Am I missing something here?
Cheers
jason
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#338 - Kamailio 4.0.x crash with pua_reginfo : reginfo_handle_notify
User who did this - Devs Voicenter (voicenter)
----------
As 4.0.x has as well stable versions, i think we do need to get that patch to 4.0.x especially when the report was initially on 4.0.x
Thanks
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=338#comment1280
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task has a new comment added:
FS#389 - libsrdb1.so.1.0 in multiple debian packages
User who did this - Víctor Seva (linuxmaniac)
----------
Hi Krischan,
We are working on a new building system for the Debian packages.
This should be fixed in a short time.
Thanks for reporting.
----------
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=389#comment1279
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.