pua subs_info has
str* outbound_proxy; /* the outbound_proxy to use when sending the
Subscribe request*/
but publ_info for publish requests does not have it? is there some good
reason or just that no-one has needed it?
-- juha
Module: sip-router
Branch: master
Commit: 3eef4c8be5cc2b6ccba993a62f8c8039d1adf7da
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3eef4c8…
Author: Alex Hermann <alex(a)speakup.nl>
Committer: Alex Hermann <alex(a)speakup.nl>
Date: Thu Oct 23 15:09:05 2014 +0200
dialog: Don't destroy dialogs in timer while they're still being referenced
---
modules/dialog/dlg_hash.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/modules/dialog/dlg_hash.c b/modules/dialog/dlg_hash.c
index 09166b8..31ad428 100644
--- a/modules/dialog/dlg_hash.c
+++ b/modules/dialog/dlg_hash.c
@@ -242,7 +242,7 @@ int dlg_clean_run(ticks_t ti)
while (dlg) {
tdlg = dlg;
dlg = dlg->next;
- if(tdlg->state==DLG_STATE_UNCONFIRMED && tdlg->init_ts<tm-300) {
+ if(tdlg->state==DLG_STATE_UNCONFIRMED && tdlg->init_ts<tm-300 && tdlg->ref<=1) {
/* dialog in early state older than 5min */
LM_NOTICE("dialog in early state is too old (%p ref %d)\n",
tdlg, tdlg->ref);
Module: sip-router
Branch: master
Commit: e673771368c25a70c5b289435694df6e9880f969
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e673771…
Author: Alex Hermann <alex(a)speakup.nl>
Committer: Alex Hermann <alex(a)speakup.nl>
Date: Tue Nov 4 14:24:46 2014 +0100
Revert "dialog: Don't destroy dialogs in timer while they're still being referenced"
This reverts commit 3eef4c8be5cc2b6ccba993a62f8c8039d1adf7da.
Reintroduces possible segfault in cleanup routine.
---
modules/dialog/dlg_hash.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/modules/dialog/dlg_hash.c b/modules/dialog/dlg_hash.c
index 31ad428..09166b8 100644
--- a/modules/dialog/dlg_hash.c
+++ b/modules/dialog/dlg_hash.c
@@ -242,7 +242,7 @@ int dlg_clean_run(ticks_t ti)
while (dlg) {
tdlg = dlg;
dlg = dlg->next;
- if(tdlg->state==DLG_STATE_UNCONFIRMED && tdlg->init_ts<tm-300 && tdlg->ref<=1) {
+ if(tdlg->state==DLG_STATE_UNCONFIRMED && tdlg->init_ts<tm-300) {
/* dialog in early state older than 5min */
LM_NOTICE("dialog in early state is too old (%p ref %d)\n",
tdlg, tdlg->ref);
Hello Daniel,
I must admit I only saw your mail last Friday. Until the 10th of October
I was also on vacation. I know that you actually committed some of the
changes together with your comments on the 12th this month.
I don't know if we can consider the topic of the patch closed. As far as
I understand, the state-full replies have not been addressed, right?
(There should be a change in the t_reply.c) I followed the code to the
relay_reply but I did not yet come to find the send function. Should I
pursue further?
Thank you,
Lucian Balaceanu
> Hi Lucian,
>
> somehow I forgot to follow up on this. But we need to get sorted out
> soon, before we release, so it works as expected with the new version.
> See more comments inline.
>
>
> On 17/09/14 18:09, Lucian Balaceanu wrote:
>> Hi Daniel,
>>
>> Please forgive me for my delay in responding to your mail.
>> Please find attached a second version of the onsend_route_reply patch
>> (which again has some problems). As per your previous indications I
>> did the following:
>>
>> *Issue1*
>>> From performances point of view, there can be added a config
>>> parameter to enable running of onsend_route for replies:
>>>
>>> onsend_route_reply = 0|1
>>
>> Following
>> http://www.asipto.com/pub/kamailio-devel-guide/#c08add_parameters I
>> have tried to add onsend_route_reply parameter. The code compiles,
>> but when trying to start kamailio with this parameter inside, the
>> parsing fails with syntax errors signaling:
>>
>> / 0(1321) :<core> [cfg.y:3423]: yyerror_at(): parse error in config
>> file kamailio-basic.cfg.4.1, from line 107, column 1 to line 108,
>> column 0: syntax error
>> 0(1321) : <core> [cfg.y:3423]: yyerror_at(): parse error in config
>> file kamailio-basic.cfg.4.1, from line 107, column 1 to line 108,
>> column 0:
>> ERROR: bad config file (2 errors)/
>
> The issue is:
>
> +<INITIAL>{ONSEND_RT_REPLY} { yylval.intval=atoi(yytext);
> + yy_number_str=yytext; return NUMBER; }
>
> It should be:
>
> +<INITIAL>{ONSEND_RT_REPLY} { yylval.intval=atoi(yytext);
> + yy_number_str=yytext; return ONSEND_RT_REPLY; }
>
>>
>> *Issue2*
>>> #define onsend_enabled(rtype)
>>> (onsend_rt.rlist[DEFAULT_RT]?((rtype==SIP_REPLY)?onsend_route_reply:1):0)
>> That is to say you see it best to take the chek for
>> onsend_rt.list[DEFAULT_RT] from inside run_onsend() function and call
>> this onsend_enabled(...) before the run_onsend()?
>
> This is to detect whether the onsend_route should be executed for SIP
> replies. The condition being:
>
> - if is a sip reply and onsend_route is set and the onsend_route_reply
> parameter is 1
>>
>> *Issue3*
>>> On the other hand, is onsend_route also executed for local requests?
>>> I had in mind it is only for received requests that are forwarded
>>> ... Iirc, on onsend_route, the sip message is the one received, the
>>> outgoing content being accessible via $snd(buf).
>>>
>> I agree with you with taking out the locally generated requests and
>> only left the run_onsend call in do_forward_reply function (inside
>> forward.c).
>> Could you point me to the reply relaying function that is called for
>> state-full processing?
> Stateful processing for replies is mainly done in t_reply.c from tm
> module. At some point there should be a send buffer function call.
>
> Cheers,
> Daniel
>>
>> Thank you and sorry again for my late answer,
>> Lucian
>
> --
> Daniel-Constantin Mierla
> http://twitter.com/#!/miconda -http://www.linkedin.com/in/miconda
>
>
Module: sip-router
Branch: master
Commit: 952227ef749da464c7990fa7f056764daf4bda0d
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=952227e…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: Mon Nov 3 18:41:01 2014 +0100
uac: use transaction to propagate uac_auth() flag
- needed by dialog to increase the cseq
- local request is no longer accessible at forwarding callback
---
modules/uac/auth.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/modules/uac/auth.c b/modules/uac/auth.c
index 1717cc7..3bdee90 100644
--- a/modules/uac/auth.c
+++ b/modules/uac/auth.c
@@ -469,8 +469,10 @@ int uac_auth( struct sip_msg *msg)
goto error;
}
- /* mark msg wit uac auth for increase of cseq via dialog */
- msg->msg_flags |= FL_UAC_AUTH;
+ /* mark request in T with uac auth for increase of cseq via dialog
+ * - this function is executed in failure route, msg_flags will be
+ * reset afterwards by tm fake env */
+ if(t->uas.request) t->uas.request->msg_flags |= FL_UAC_AUTH;
return 0;
error:
THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.
The following task is now closed:
FS#463 - Content of $dlg_vars are mixed with each other when writing cdr values on version 4.1.5-1.1
User who did this - Daniel-Constantin Mierla (miconda)
Reason for closing: Not a bug
Additional comments about closing: No follow up for two months - upgrade to latest version in the branch and reopen if it is still an issue, providing the requested details.
More information can be found at the following URL:
http://sip-router.org/tracker/index.php?do=details&task_id=463
You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.