sr-dev April 2014

sr-dev@lists.kamailio.org

26 participants
304 discussions

[tracker] Comment added: Crash when reloading addresses from mysql database (permissions module)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#420 - Crash when reloading addresses from mysql database (permissions module) User who did this - Torrey Searle (tsearle) ---------- Yup! I see the following lines which correspond to the time of the segfault Apr 13 01:11:01 bebr0lbr02 /usr/sbin/kamailio[1130]: ERROR: db_mysql [km_res.c:188]: db_mysql_convert_rows(): error while converting row #9 Apr 13 01:11:01 bebr0lbr02 /usr/sbin/kamailio[1130]: ERROR: db_mysql [km_res.c:217]: db_mysql_convert_result(): error while converting rows Apr 13 01:11:01 bebr0lbr02 /usr/sbin/kamailio[1130]: ERROR: db_mysql [km_dbase.c:191]: db_mysql_store_result(): error while converting result ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=420#comment1392 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 7 months

Stuck dialogs

by Alex Balashov

With 4.1, I've got a call scenario that looks like this: 1. INVITE --> 2. <-- 100 3. <-- 183 4. <-- 200 OK 5. <-- 200 OK again (no ACK from near end) 6. Finally an e2e ACK comes through --> 7. (38 seconds later) BYE --> 8. (no response to BYE) BYE --> 9. BYE --> 10. BYE --> 11. BYE --> 12. BYE --> 13. BYE --> etc. I've also got another call that looks very similarly, except that the BYE comes from the callee instead of the caller. It also goes unanswered by the near end. I am tracking both dialogs with 'dialog', and, sooner or later, they end up in DELETED state. However, they do not get deleted. I have one that has been in there for 4 days and isn't going anywhere, and another that has been stuck in DELETED state for 3. My dialog timeout is set to 4 hours, but the timeout operation doesn't delete dialogs that are already DELETED. Moreover, dlg_end_dlg is not a means of removing these dialogs, either: [root@gw1 ~]# kamctl fifo dlg_end_dlg 154 6753 500 Operation failed Any suggestions on what to do here? Should this be considered a bug? Thanks, -- Alex -- Alex Balashov - Principal Evariste Systems LLC 235 E Ponce de Leon Ave Suite 106 Decatur, GA 30030 United States Tel: +1-678-954-0670 Web: http://www.evaristesys.com/, http://www.alexbalashov.com/

10 years, 7 months

[tracker] Comment added: Dialog never times-out when ka_timer < 10, even on 481 or 408(fake) response

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#417 - Dialog never times-out when ka_timer < 10, even on 481 or 408(fake) response User who did this - Bill Radis (radisb) ---------- For the purpose of discovering the disappearence faster (and so terminate the dialog faster), is it possible to adjust the retransmission/timeout time of the specific OPTIONS keep alive messages? If we can do this then maybe the ka_timer parameter could essentially just adjust this retransmission/timeout value, and the ka_interval could represent when to send the next keep-alive only when the previous was succesfully responded. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=417#comment1391 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 7 months

[tracker] Comment added: Crash in msrp module

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#419 - Crash in msrp module User who did this - Daniel-Constantin Mierla (miconda) ---------- Thanks for the fix. Can you change to use tabs for indentation (like the rest of the code in the module, to have coherent formatting)? Afterwards you can merge it to master branch and backport to stable branches. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=419#comment1390 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 7 months

[tracker] Comment added: Dialog never times-out when ka_timer < 10, even on 481 or 408(fake) response

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#417 - Dialog never times-out when ka_timer < 10, even on 481 or 408(fake) response User who did this - Daniel-Constantin Mierla (miconda) ---------- Indeed there have to be some safety checks. The keepalive interval should be higher that tm retransmission time, otherwise the network will be 'flooded' if the caller or callee disappears. It should be no good benefit of having very low timer intervals. I will add those safety checks soon. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=417#comment1389 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 7 months

[tracker] Comment added: Crash when reloading addresses from mysql database (permissions module)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#420 - Crash when reloading addresses from mysql database (permissions module) User who did this - Daniel-Constantin Mierla (miconda) ---------- Can you check syslog to see if you get error messages like: <code>error while converting result</code> I pushed a patch for it, just wanted to have a confirmation is the situation I found, which was an obvious bug lasting for ages (I checked v1.5 and is there as well). It happens only on a failure of a mysql lib function, so it didn't surfaced before. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=420#comment1388 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 7 months

git:master: db_mysql: properly free db result structure if db_mysql_convert_result() fails

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 37983c9f57536c57c5d34ce2d8a1c8f411e61e39 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=37983c9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Apr 16 19:43:45 2014 +0200 db_mysql: properly free db result structure if db_mysql_convert_result() fails - reported by Torrey Searle, FS#420 --- modules/db_mysql/km_dbase.c | 8 ++++---- modules/db_mysql/km_res.c | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/modules/db_mysql/km_dbase.c b/modules/db_mysql/km_dbase.c index 7beaf91..0ab9066 100644 --- a/modules/db_mysql/km_dbase.c +++ b/modules/db_mysql/km_dbase.c @@ -251,12 +251,12 @@ static int db_mysql_store_result(const db1_con_t* _h, db1_res_t** _r) if (db_mysql_convert_result(_h, *_r) < 0) { LM_ERR("error while converting result\n"); LM_DBG("freeing result set at %p\n", _r); - pkg_free(*_r); - *_r = 0; /* all mem on Kamailio API side is already freed by * db_mysql_convert_result in case of error, but we also need - * to free the mem from the mysql lib side */ - mysql_free_result(RES_RESULT(*_r)); + * to free the mem from the mysql lib side, internal pkg for it + * and *_r */ + db_mysql_free_result(_h, *_r); + *_r = 0; #if (MYSQL_VERSION_ID >= 40100) while( mysql_more_results(CON_CONNECTION(_h)) && mysql_next_result(CON_CONNECTION(_h)) > 0 ) { MYSQL_RES *res = mysql_store_result( CON_CONNECTION(_h) ); diff --git a/modules/db_mysql/km_res.c b/modules/db_mysql/km_res.c index 965e6dc..3f1ca26 100644 --- a/modules/db_mysql/km_res.c +++ b/modules/db_mysql/km_res.c @@ -69,6 +69,7 @@ int db_mysql_get_columns(const db1_con_t* _h, db1_res_t* _r) } if (db_allocate_columns(_r, RES_COL_N(_r)) != 0) { + RES_COL_N(_r) = 0; LM_ERR("could not allocate columns\n"); return -3; } @@ -173,6 +174,7 @@ static inline int db_mysql_convert_rows(const db1_con_t* _h, db1_res_t* _r) if (db_allocate_rows(_r) < 0) { LM_ERR("could not allocate rows"); + RES_ROW_N(_r) = 0; return -2; }

10 years, 7 months

[tracker] Task changed: Crash when reloading addresses from mysql database (permissions module)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has been changed. The changes are listed below. For full information about what has changed, visit the URL and click the History tab. FS#420 - Crash when reloading addresses from mysql database (permissions module) User who did this: Daniel-Constantin Mierla (miconda) Task details edited: ------- I have a cron job reloading the addresses table from database once a minute. Every few days I get a crash with the following back trace. Crash occurred in Kamailio 4.1.1 <code> #0 0x00007fa4fab7889e in db_mysql_store_result (_h=0x7fa4fae6c0e8, _r=0x7fff0b62c2b8) at km_dbase.c:198 #1 0x00007fa4fa33b867 in db_do_query_internal (_h=0x7fa4fae6c0e8, _k=0x0, _op=0x0, _v=0x0, _c=0x7fff0b62c2c0, _n=0, _nc=5, _o=0x0, _r=0x7fff0b62c2b8, val2str=0x7fa4fab803c4 <db_mysql_val2str>, submit_query=0x7fa4fab77a76 <db_mysql_submit_query>, store_result=0x7fa4fab78063 <db_mysql_store_result>, _l=0) at db_query.c:137 #2 0x00007fa4fa33bba8 in db_do_query (_h=0x7fa4fae6c0e8, _k=0x0, _op=0x0, _v=0x0, _c=0x7fff0b62c2c0, _n=0, _nc=5, _o=0x0, _r=0x7fff0b62c2b8, val2str=0x7fa4fab803c4 <db_mysql_val2str>, submit_query=0x7fa4fab77a76 <db_mysql_submit_query>, store_result=0x7fa4fab78063 <db_mysql_store_result>) at db_query.c:156 #3 0x00007fa4fab78d40 in db_mysql_query (_h=0x7fa4fae6c0e8, _k=0x0, _op=0x0, _v=0x0, _c=0x7fff0b62c2c0, _n=0, _nc=5, _o=0x0, _r=0x7fff0b62c2b8) at km_dbase.c:263 #4 0x00007fa4f2315f67 in reload_address_table () at address.c:111 #5 0x00007fa4f2317fd1 in reload_address_table_cmd () at address.c:270 #6 0x00007fa4f2321032 in mi_address_reload (cmd_tree=0x0, param=0x0) at mi.c:117 #7 0x00007fa4f562055f in run_mi_cmd (cmd=0xc6c948, t=0x0) at ../../lib/kmi/mi.h:77 #8 0x00007fa4f5625a79 in mi_fifo_server (fifo_stream=0x103ee30) at fifo_fnc.c:509 #9 0x00007fa4f5627b43 in fifo_process (rank=1) at mi_fifo.c:247 #10 0x00007fa4f56273f0 in mi_child_init (rank=0) at mi_fifo.c:211 </code> ------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=420 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 7 months

[tracker] Task changed: Crash when reloading addresses from mysql database (permissions module)

by sip-router

10 years, 7 months

[tracker] Task opened: Crash when reloading addresses from mysql database (permissions module)

by sip-router

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below. User who did this - Torrey Searle (tsearle) Attached to Project - sip-router Summary - Crash when reloading addresses from mysql database (permissions module) Task Type - Bug Report Category - Modules kamailio Status - Unconfirmed Assigned To - Operating System - Linux Severity - Low Priority - Normal Reported Version - 4.1 Due in Version - Undecided Due Date - Undecided Details - I have a cron job reloading the addresses table from database once a minute. Every few days I get a crash with the following back trace. Crash occurred in Kamailio 4.1.1 #0 0x00007fa4fab7889e in db_mysql_store_result (_h=0x7fa4fae6c0e8, _r=0x7fff0b62c2b8) at km_dbase.c:198 #1 0x00007fa4fa33b867 in db_do_query_internal (_h=0x7fa4fae6c0e8, _k=0x0, _op=0x0, _v=0x0, _c=0x7fff0b62c2c0, _n=0, _nc=5, _o=0x0, _r=0x7fff0b62c2b8, val2str=0x7fa4fab803c4 <db_mysql_val2str>, submit_query=0x7fa4fab77a76 <db_mysql_submit_query>, store_result=0x7fa4fab78063 <db_mysql_store_result>, _l=0) at db_query.c:137 #2 0x00007fa4fa33bba8 in db_do_query (_h=0x7fa4fae6c0e8, _k=0x0, _op=0x0, _v=0x0, _c=0x7fff0b62c2c0, _n=0, _nc=5, _o=0x0, _r=0x7fff0b62c2b8, val2str=0x7fa4fab803c4 <db_mysql_val2str>, submit_query=0x7fa4fab77a76 <db_mysql_submit_query>, store_result=0x7fa4fab78063 <db_mysql_store_result>) at db_query.c:156 #3 0x00007fa4fab78d40 in db_mysql_query (_h=0x7fa4fae6c0e8, _k=0x0, _op=0x0, _v=0x0, _c=0x7fff0b62c2c0, _n=0, _nc=5, _o=0x0, _r=0x7fff0b62c2b8) at km_dbase.c:263 #4 0x00007fa4f2315f67 in reload_address_table () at address.c:111 #5 0x00007fa4f2317fd1 in reload_address_table_cmd () at address.c:270 #6 0x00007fa4f2321032 in mi_address_reload (cmd_tree=0x0, param=0x0) at mi.c:117 #7 0x00007fa4f562055f in run_mi_cmd (cmd=0xc6c948, t=0x0) at ../../lib/kmi/mi.h:77 #8 0x00007fa4f5625a79 in mi_fifo_server (fifo_stream=0x103ee30) at fifo_fnc.c:509 #9 0x00007fa4f5627b43 in fifo_process (rank=1) at mi_fifo.c:247 #10 0x00007fa4f56273f0 in mi_child_init (rank=0) at mi_fifo.c:211 More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=420 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

10 years, 7 months

← Newer
1
...
17
18
19
20
21
22
23
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2014