sr-dev May 2014

sr-dev@lists.kamailio.org

34 participants
238 discussions

git:master: modules/acc: renamed module param reason_from_reason_hf => reason_from_hf
by Juha Heinanen 31 May '14

31 May '14

Module: sip-router Branch: master Commit: 6214fe8702626a4d9edc1ca45e3cd657ee8093ee URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6214fe8… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Sat May 31 19:38:30 2014 +0300 modules/acc: renamed module param reason_from_reason_hf => reason_from_hf - as per Daniel's suggestion --- modules/acc/README | 14 +++++++------- modules/acc/acc_logic.c | 2 +- modules/acc/acc_mod.c | 4 ++-- modules/acc/acc_mod.h | 2 +- modules/acc/doc/acc_admin.xml | 8 ++++---- 5 files changed, 15 insertions(+), 15 deletions(-) diff --git a/modules/acc/README b/modules/acc/README index 8316b52..cea7651 100644 --- a/modules/acc/README +++ b/modules/acc/README @@ -131,7 +131,7 @@ Sven Knoblich 6.48. time_attr (str) 6.49. time_exten (str) 6.50. time_format (str) - 6.51. reason_from_reason_hf (int) + 6.51. reason_from_hf (int) 7. Functions @@ -194,7 +194,7 @@ Sven Knoblich 1.48. time_attr example 1.49. time_exten example 1.50. time_format example - 1.51. reason_from_reason_hf + 1.51. reason_from_hf 1.52. acc_log_request usage 1.53. acc_db_request usage 1.54. acc_rad_request usage @@ -293,7 +293,7 @@ Chapter 1. Admin Guide 6.48. time_attr (str) 6.49. time_exten (str) 6.50. time_format (str) - 6.51. reason_from_reason_hf (int) + 6.51. reason_from_hf (int) 7. Functions @@ -708,7 +708,7 @@ $dlg_var(callee) = $avp(callee); #callee='C' 6.48. time_attr (str) 6.49. time_exten (str) 6.50. time_format (str) - 6.51. reason_from_reason_hf (int) + 6.51. reason_from_hf (int) 6.1. early_media (integer) @@ -1354,7 +1354,7 @@ modparam("acc", "time_exten", "micorsecs") modparam("acc", "time_format", "%Y/%m/%d %H:%M:%S") ... -6.51. reason_from_reason_hf (int) +6.51. reason_from_hf (int) Tells where to take sip_reason from. If value is 0, sip_reason is taken from status line. Otherwise, sip_reason is taken from Reason header @@ -1362,9 +1362,9 @@ modparam("acc", "time_format", "%Y/%m/%d %H:%M:%S") Default value is 0. - Example 1.51. reason_from_reason_hf + Example 1.51. reason_from_hf ... -modparam("acc", "reason_from_reason_hf", 1) +modparam("acc", "reason_from_hf", 1) ... 7. Functions diff --git a/modules/acc/acc_logic.c b/modules/acc/acc_logic.c index 452e171..93bf5c1 100644 --- a/modules/acc/acc_logic.c +++ b/modules/acc/acc_logic.c @@ -147,7 +147,7 @@ static inline void env_set_code_status( int code, struct sip_msg *reply) } else { acc_env.code_s = reply->first_line.u.reply.status; hf = NULL; - if (reason_from_reason_hf) { + if (reason_from_hf) { /* TODO: take reason from all Reason headers */ if(parse_headers(reply, HDR_EOH_F, 0) < 0) { LM_ERR("error parsing headers\n"); diff --git a/modules/acc/acc_mod.c b/modules/acc/acc_mod.c index 347e054..6544f35 100644 --- a/modules/acc/acc_mod.c +++ b/modules/acc/acc_mod.c @@ -110,7 +110,7 @@ static char* leg_info_str = 0; /*!< multi call-leg support */ struct acc_extra *leg_info = 0; int acc_prepare_flag = -1; /*!< should the request be prepared for later acc */ char *acc_time_format = "%Y-%m-%d %H:%M:%S"; -int reason_from_reason_hf = 0; /*!< assign reason from reason hf if present */ +int reason_from_hf = 0; /*!< assign reason from reason hf if present */ /* ----- time mode variables ------- */ /*! \name AccTimeModeVariables Time Mode Variables */ @@ -259,7 +259,7 @@ static param_export_t params[] = { {"multi_leg_info", STR_PARAM, &leg_info_str }, {"detect_direction", INT_PARAM, &detect_direction }, {"acc_prepare_flag", INT_PARAM, &acc_prepare_flag }, - {"reason_from_reason_hf", INT_PARAM, &reason_from_reason_hf }, + {"reason_from_hf", INT_PARAM, &reason_from_hf }, /* syslog specific */ {"log_flag", INT_PARAM, &log_flag }, {"log_missed_flag", INT_PARAM, &log_missed_flag }, diff --git a/modules/acc/acc_mod.h b/modules/acc/acc_mod.h index 68911dc..2f5f815 100644 --- a/modules/acc/acc_mod.h +++ b/modules/acc/acc_mod.h @@ -50,7 +50,7 @@ extern int failed_transaction_flag; extern unsigned short failed_filter[]; extern int detect_direction; extern int acc_prepare_flag; -extern int reason_from_reason_hf; +extern int reason_from_hf; extern int log_facility; extern int log_level; diff --git a/modules/acc/doc/acc_admin.xml b/modules/acc/doc/acc_admin.xml index b0a1217..887f953 100644 --- a/modules/acc/doc/acc_admin.xml +++ b/modules/acc/doc/acc_admin.xml @@ -1479,8 +1479,8 @@ modparam("acc", "time_format", "%Y/%m/%d %H:%M:%S") </programlisting> </example> </section> - <section id="acc.p.reason_from_reason_hf"> - <title><varname>reason_from_reason_hf</varname> (int)</title> + <section id="acc.p.reason_from_hf"> + <title><varname>reason_from_hf</varname> (int)</title> <para> Tells where to take sip_reason from. If value is 0, sip_reason is taken from status line. Otherwise, sip_reason @@ -1491,10 +1491,10 @@ modparam("acc", "time_format", "%Y/%m/%d %H:%M:%S") Default value is 0. </para> <example> - <title>reason_from_reason_hf</title> + <title>reason_from_hf</title> <programlisting format="linespecific"> ... -modparam("acc", "reason_from_reason_hf", 1) +modparam("acc", "reason_from_hf", 1) ... </programlisting> </example>

1 0

[tracker] Comment added: crash in parser/sdp/sdp_helpr_funcs.c
by sip-router 31 May '14

31 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#435 - crash in parser/sdp/sdp_helpr_funcs.c User who did this - Michael Ricordeau (mricordeau) ---------- Ok thanks for the explanation ! ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=435#comment1496 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: crash in parser/sdp/sdp_helpr_funcs.c
by sip-router 31 May '14

31 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#435 - crash in parser/sdp/sdp_helpr_funcs.c User who did this - Daniel-Constantin Mierla (miconda) ---------- The crash happened due to some local variables that had uninitialized value (those that should have stored the clock rate and rtpmap parameters). Sometime it can happen that their value is small enough not to result in memory fault access, this is something random. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=435#comment1495 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: crash in parser/sdp/sdp_helpr_funcs.c
by sip-router 31 May '14

31 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#435 - crash in parser/sdp/sdp_helpr_funcs.c User who did this - Michael Ricordeau (mricordeau) ---------- Yes payload 9 G700 is invalid and does not specify the clock rate. But I was trying to reproduce the same crash but when sending the same Sip invite packet to another kamailio with same version as the one crashed, I'm getting this error instead of a crash. So do you think it may happen only when we have some traffic (using shared mem) ? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=435#comment1494 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: crash in parser/sdp/sdp_helpr_funcs.c
by sip-router 31 May '14

31 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#435 - crash in parser/sdp/sdp_helpr_funcs.c User who did this - Daniel-Constantin Mierla (miconda) ---------- The SDP has an invalid a= line, as I said in the comment: - http://sip-router.org/tracker/index.php?do=details&task_id=435#comment1485 The clock rate is missing, therefore the error message. ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=435#comment1493 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: crash in parser/sdp/sdp_helpr_funcs.c (Attachment added)
by sip-router 31 May '14

31 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#435 - crash in parser/sdp/sdp_helpr_funcs.c User who did this - Michael Ricordeau (mricordeau) ---------- I tried to reproduce the same INVITE with wrong codec and with same kamailio version and I'm getting an error, no crash : ERROR: <core> [parser/sdp/sdp_helpr_funcs.c:246]: extract_rtpmap(): invalid encoding in `a=rtpmap' I have attached the python script (basic socket ...) used to send the SIP INVITE from gdb trace . The function is called here in kamailio cfg : if (client_nat_test("3")){ xlog("L_INFO", "CALL RE-INVITE/UPDATE Nat DETECTED $ci\n"); force_rport(); fix_contact(); # Change Media ip address to public IP if(nat_uac_test("8") && search("Content-type: application/sdp")) { xlog("L_INFO", ">>> RE-INVITE/UPDATE CALL fixing SDP- NAT \n"); fix_nated_sdp("2"); } } ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=435#comment1492 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: crash in parser/sdp/sdp_helpr_funcs.c
by sip-router 30 May '14

30 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#435 - crash in parser/sdp/sdp_helpr_funcs.c User who did this - Michael Ricordeau (mricordeau) ---------- Thanks Daniel and Ovidiu, we will try the patch asap . ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=435#comment1491 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: modules/ims_charging: possible seg fault on diameter CCR timeout fixed
by Jason Penton 30 May '14

30 May '14

Module: sip-router Branch: master Commit: 8e2fcd278c9172a1774a1a1bae72f2e6d37b1770 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8e2fcd2… Author: Jason Penton <jason.penton(a)gmail.com> Committer: Jason Penton <jason.penton(a)gmail.com> Date: Fri May 30 18:26:48 2014 +0200 modules/ims_charging: possible seg fault on diameter CCR timeout fixed --- modules/ims_charging/ims_ro.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/modules/ims_charging/ims_ro.c b/modules/ims_charging/ims_ro.c index 59c3ab3..ef1f6e4 100644 --- a/modules/ims_charging/ims_ro.c +++ b/modules/ims_charging/ims_ro.c @@ -680,8 +680,9 @@ error: if (ro_cca_data) Ro_free_CCA(ro_cca_data); -// if (ro_cca_data) - cdpb.AAAFreeMessage(&cca); + if (!is_timeout && cca) { + cdpb.AAAFreeMessage(&cca); + } if (i_req) { i_req->credit_valid_for = 0;

1 0

Re: [sr-dev] acc reply reason
by Daniel-Constantin Mierla 30 May '14

30 May '14

[resent - devel mailing list address was invalid] For the moment I will just get it walking via headers list, with no shortcut in sip_msg_t as hdr_field_t*. The reply doesn't have many headers anyhow. But, if I am not wrong, I think Reason header can occur many times. Or at least I saw it two times, one time like: Reason: Q.850; ... and in the same message, another one like: Reason: SIP;... Overall, I think we should review which shortcut pointers to headers makes sense to keep inside sip_msg_t. Some of them are very rare in sip messages, probably can be found easily by walking the list of headers when needed. Cheers, Daniel On 30/05/14 17:52, Juha Heinanen wrote: > i'll move this to devel. acc module is not trivial one. > > should parsing of reason header be added to parser and struct hdr_field* > reason to struct sip_mgs? > > -- juha -- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

1 0

git:master: Merge branch 'master' of ssh://git.sip-router.org/sip-router
by Jason Penton 30 May '14

30 May '14

Module: sip-router Branch: master Commit: 3a2b5f5a9fa46a5f8502f9ca355a9f689b6cd61e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3a2b5f5… Author: Jason Penton <jason.penton(a)gmail.com> Committer: Jason Penton <jason.penton(a)gmail.com> Date: Fri May 30 16:52:46 2014 +0200 Merge branch 'master' of ssh://git.sip-router.org/sip-router ---

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2014