sr-dev May 2014

sr-dev@lists.kamailio.org

34 participants
238 discussions

git:4.0: db_mysql: reset prev_token to avoid double free in case of url parse error
by Daniel-Constantin Mierla 12 May '14

12 May '14

Module: sip-router Branch: 4.0 Commit: 8ab2488d6e693fdd7dd5fe522f32f65b6045911e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8ab2488… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 21 17:36:01 2014 +0200 db_mysql: reset prev_token to avoid double free in case of url parse error - when db api v2 is used (ser modules) (cherry picked from commit f65bf2c37bfaae740dd3cd8d686308cfa44b42f2) (cherry picked from commit 340768948df423e25812d083fcdf09396ef763e3) --- modules/db_mysql/my_uri.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/modules/db_mysql/my_uri.c b/modules/db_mysql/my_uri.c index b4c5a51..1f98135 100644 --- a/modules/db_mysql/my_uri.c +++ b/modules/db_mysql/my_uri.c @@ -175,12 +175,14 @@ static int parse_mysql_uri(struct my_uri* res, str* uri) case '@': st = ST_HOST; res->username = prev_token; + prev_token = 0; if (dupl_string(&res->password, begin, uri->s + i) < 0) goto err; begin = uri->s + i + 1; break; case '/': res->host = prev_token; + prev_token = 0; res->port = str2s(begin, uri->s + i - begin, 0); if (dupl_string(&res->database, uri->s + i + 1, uri->s + uri->len) < 0) goto err; return 0;

1 0

git:4.0: db_mysql: fixed condition checking the parameter for db uri parsing
by Daniel-Constantin Mierla 12 May '14

12 May '14

Module: sip-router Branch: 4.0 Commit: 20dcf53f2788e4931b87c342b7b831ad048ff2d8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=20dcf53… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Jan 28 18:36:21 2014 +0100 db_mysql: fixed condition checking the parameter for db uri parsing - on a report generated by cppcheck sent by David Binderman (cherry picked from commit c0b2e567b2a27d5d29ede39409d6299f7d375d87) (cherry picked from commit 75203caf1a7a8c582b8eaff67af891b00100f232) --- modules/db_mysql/my_uri.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/db_mysql/my_uri.c b/modules/db_mysql/my_uri.c index 9a4357d..b4c5a51 100644 --- a/modules/db_mysql/my_uri.c +++ b/modules/db_mysql/my_uri.c @@ -113,7 +113,7 @@ static int parse_mysql_uri(struct my_uri* res, str* uri) prev_token = 0; - if (!res || !res) { + if (!res || !uri) { goto err; }

1 0

git:4.1: db_mysql: properly free db result structure if db_mysql_convert_result() fails
by Daniel-Constantin Mierla 12 May '14

12 May '14

Module: sip-router Branch: 4.1 Commit: 402e2122d1aa353ee8c10321aa1eb9315a81cd81 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=402e212… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Wed Apr 16 19:43:45 2014 +0200 db_mysql: properly free db result structure if db_mysql_convert_result() fails - reported by Torrey Searle, FS#420 (cherry picked from commit 37983c9f57536c57c5d34ce2d8a1c8f411e61e39) --- modules/db_mysql/km_dbase.c | 8 ++++---- modules/db_mysql/km_res.c | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/modules/db_mysql/km_dbase.c b/modules/db_mysql/km_dbase.c index f644dea..a1e7ac7 100644 --- a/modules/db_mysql/km_dbase.c +++ b/modules/db_mysql/km_dbase.c @@ -190,12 +190,12 @@ static int db_mysql_store_result(const db1_con_t* _h, db1_res_t** _r) if (db_mysql_convert_result(_h, *_r) < 0) { LM_ERR("error while converting result\n"); LM_DBG("freeing result set at %p\n", _r); - pkg_free(*_r); - *_r = 0; /* all mem on Kamailio API side is already freed by * db_mysql_convert_result in case of error, but we also need - * to free the mem from the mysql lib side */ - mysql_free_result(RES_RESULT(*_r)); + * to free the mem from the mysql lib side, internal pkg for it + * and *_r */ + db_mysql_free_result(_h, *_r); + *_r = 0; #if (MYSQL_VERSION_ID >= 40100) while( mysql_more_results(CON_CONNECTION(_h)) && mysql_next_result(CON_CONNECTION(_h)) > 0 ) { MYSQL_RES *res = mysql_store_result( CON_CONNECTION(_h) ); diff --git a/modules/db_mysql/km_res.c b/modules/db_mysql/km_res.c index 965e6dc..3f1ca26 100644 --- a/modules/db_mysql/km_res.c +++ b/modules/db_mysql/km_res.c @@ -69,6 +69,7 @@ int db_mysql_get_columns(const db1_con_t* _h, db1_res_t* _r) } if (db_allocate_columns(_r, RES_COL_N(_r)) != 0) { + RES_COL_N(_r) = 0; LM_ERR("could not allocate columns\n"); return -3; } @@ -173,6 +174,7 @@ static inline int db_mysql_convert_rows(const db1_con_t* _h, db1_res_t* _r) if (db_allocate_rows(_r) < 0) { LM_ERR("could not allocate rows"); + RES_ROW_N(_r) = 0; return -2; }

1 0

4.1 compiler warnings
by Juha Heinanen 12 May '14

12 May '14

when i re-built my 4.1 presence server, i noticed these compiler warning that i don't remember seeing before: CC (cc) [M presence_dialoginfo.so] notify_body.o notify_body.c: In function 'agregate_xmls': notify_body.c:104:28: warning: unused variable 'priority' [-Wunused-variable] notify_body.c:104:6: warning: unused variable 'winner_priority' [-Wunused-variable] -- juha

1 0

[tracker] Comment added: kamailio sometimes crash when handling failure events (Attachment added)
by sip-router 12 May '14

12 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#427 - kamailio sometimes crash when handling failure events User who did this - Pawel Sternal (Sternik) ---------- Ok, and another crash. Few minutes ago. <code> May 12 11:21:33 node03 /usr/sbin/kamailio[23017]: : <core> [mem/q_malloc.c:468]: qm_free(): BUG: qm_free: freeing already freed pointer (0xa4ab1644), called from dialog: dlg_cb.c: destroy_dlg_ callbacks_list(80), first free dialog: dlg_cb.c: destroy_dlg_callbacks_list(80) - aborting May 12 11:22:02 node03 /usr/sbin/kamailio[22924]: ALERT: <core> [main.c:775]: handle_sigs(): child process 23017 exited by a signal 6 May 12 11:22:02 node03 /usr/sbin/kamailio[22924]: ALERT: <core> [main.c:778]: handle_sigs(): core was generated </code> gdb bt full included. ---------- One or more files have been attached. More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=427#comment1435 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: cnxcc: Added credit vs cost per second check *before* starting the call
by Carlos Ruiz Diaz 12 May '14

12 May '14

Module: sip-router Branch: master Commit: 5ab17c022b5bab6dfd3749dee71961cad14cbe83 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5ab17c0… Author: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Committer: Carlos Ruiz Diaz <carlos.ruizdiaz(a)gmail.com> Date: Sun May 11 22:08:43 2014 -0500 cnxcc: Added credit vs cost per second check *before* starting the call --- modules/cnxcc/cnxcc_mod.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/modules/cnxcc/cnxcc_mod.c b/modules/cnxcc/cnxcc_mod.c index 22330cc..bad2f84 100644 --- a/modules/cnxcc/cnxcc_mod.c +++ b/modules/cnxcc/cnxcc_mod.c @@ -1460,6 +1460,11 @@ static int set_max_credit(struct sip_msg* msg, return -1; } + if (credit < cost_per_second) { + LM_ERR("Not enough credit to start the call: credit=[%f] < cost_per_sec=[%f]", credit, cost_per_second); + return -1; + } + if (client_id_val.rs.len == 0 || client_id_val.rs.s == NULL) { LM_ERR("[%.*s]: client ID cannot be null\n", msg->callid->body.len, msg->callid->body.s);

1 0

[tracker] Comment added: kamailio sometimes crash when handling failure events
by sip-router 11 May '14

11 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#427 - kamailio sometimes crash when handling failure events User who did this - Pawel Sternal (Sternik) ---------- After more digginng in log files i've found 8 restarts after upgrade to kamailio 4.1.3. All ends after processing fail event. There's a list: 1. <code> May 7 12:30:17 node02 /usr/sbin/kamailio[23300]: ALERT: <core> [main.c:775]: handle_sigs(): child process 23313 exited by a signal 11 </code> Not found trying to double free. Last fork used to process ACK event. -- ACK <code> May 7 12:28:34 node02 /usr/sbin/kamailio[23313]: WARNING: tm [t_lookup.c:1537]: t_unref(): WARNING: script writer didn't release transaction </code> 2. <code> May 9 13:57:39 node02 /usr/sbin/kamailio[26402]: ALERT: <core> [main.c:775]: handle_sigs(): child process 26533 exited by a signal 6 </code> -- failure_route <code> May 9 13:57:25 node02 /usr/sbin/kamailio[26533]: : <core> [mem/q_malloc.c:468]: qm_free(): BUG: qm_free: freeing already freed pointer (0xa5f53d00), called from dialog: dlg_cb.c: destroy_dlg_callbacks_list(80), first free dialog: dlg_cb.c: destroy_dlg_callbacks_list(80) - aborting </code> 3. <code> May 9 20:16:40 node02 /usr/sbin/kamailio[4372]: ALERT: <core> [main.c:775]: handle_sigs(): child process 4389 exited by a signal 6 </code> -- failure_route <code> May 9 20:16:23 node02 /usr/sbin/kamailio[4389]: : <core> [mem/q_malloc.c:468]: qm_free(): BUG: qm_free: freeing already freed pointer (0xa606a7f0), called from dialog: dlg_cb.c: destroy_dlg_callbacks_list(80), first free dialog: dlg_cb.c: destroy_dlg_callbacks_list(80) - aborting </code> 4. <code> 07/08/node03.log:May 7 06:13:04 node03 /usr/sbin/kamailio[9784]: ALERT: <core> [main.c:775]: handle_sigs(): child process 9821 exited by a signal 6 </code> -- failure_route <code> May 7 06:12:40 node03 /usr/sbin/kamailio[9821]: : <core> [mem/q_malloc.c:468]: qm_free(): BUG: qm_free: freeing already freed pointer (0xa5dd9af4), called from dialog: dlg_cb.c: destroy_dlg_callbacks_list(80), first free dialog: dlg_cb.c: destroy_dlg_callbacks_list(80) - aborting </code> 5. <code> 07/13/node03.log:May 7 11:23:12 node03 /usr/sbin/kamailio[2924]: ALERT: <core> [main.c:775]: handle_sigs(): child process 2936 exited by a signal 6 </code> -- failure_route <code> May 7 11:23:05 node03 /usr/sbin/kamailio[2936]: : <core> [mem/q_malloc.c:468]: qm_free(): BUG: qm_free: freeing already freed pointer (0xa5b073e4), called from dialog: dlg_cb.c: destroy_dlg_callbacks_list(80), first free dialog: dlg_cb.c: destroy_dlg_callbacks_list(80) - aborting </code> 6. <code> May 7 14:25:33 node03 /usr/sbin/kamailio[10812]: ALERT: <core> [main.c:775]: handle_sigs(): child process 10822 exited by a signal 6 </code> -- failure_route <code> May 7 14:25:27 node03 /usr/sbin/kamailio[10822]: : <core> [mem/q_malloc.c:468]: qm_free(): BUG: qm_free: freeing already freed pointer (0xa5bf8028), called from dialog: dlg_cb.c: destroy_dlg_callbacks_list(80), first free dialog: dlg_cb.c: destroy_dlg_callbacks_list(80) - aborting </code> 7. <code> 08/08/node03.log:May 8 06:43:03 node03 /usr/sbin/kamailio[20901]: ALERT: <core> [main.c:775]: handle_sigs(): child process 20968 exited by a signal 11 </code> Not found trying to double free. Last fork used to process ACK event. -- ACK <code> May 8 06:35:25 node03 /usr/sbin/kamailio[20968]: WARNING: tm [t_lookup.c:1537]: t_unref(): WARNING: script writer didn't release transaction </code> 8. <code> 10/13/node03.log:May 10 11:52:56 node03 /usr/sbin/kamailio[28876]: ALERT: <core> [main.c:775]: handle_sigs(): child process 28897 exited by a signal 11 </code> Not found trying to double free. Last fork used to process ACK event. -- ACK <code> May 10 11:49:19 node03 /usr/sbin/kamailio[28897]: WARNING: tm [t_lookup.c:1537]: t_unref(): WARNING: script writer didn't release transaction </code> ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=427#comment1434 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: kamailio sometimes crash when handling failure events
by sip-router 11 May '14

11 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#427 - kamailio sometimes crash when handling failure events User who did this - Pawel Sternal (Sternik) ---------- For pid 4389: <code> May 9 20:16:23 node02 /usr/sbin/kamailio[4389]: : <core> [mem/q_malloc.c:468]: qm_free(): BUG: qm_free: freeing already freed pointer (0xa606a7f0), called from dialog: dlg_cb.c: destroy_dlg_callbacks_list(80), first free dialog: dlg_cb.c: destroy_dlg_callbacks_list(80) - aborting </code> For pid 28897 I haven't found any of that. Only that might look suspicious: <code> May 10 11:25:13 node03 /usr/sbin/kamailio[28897]: WARNING: tm [t_lookup.c:1537]: t_unref(): WARNING: script writer didn't release transaction May 10 11:34:33 node03 /usr/sbin/kamailio[28897]: WARNING: tm [t_lookup.c:1537]: t_unref(): WARNING: script writer didn't release transaction May 10 11:43:37 node03 /usr/sbin/kamailio[28897]: WARNING: tm [t_lookup.c:1537]: t_unref(): WARNING: script writer didn't release transaction May 10 11:49:19 node03 /usr/sbin/kamailio[28897]: WARNING: tm [t_lookup.c:1537]: t_unref(): WARNING: script writer didn't release transaction </code> ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=427#comment1433 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: kamailio sometimes crash when handling failure events
by sip-router 11 May '14

11 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#427 - kamailio sometimes crash when handling failure events User who did this - Daniel-Constantin Mierla (miconda) ---------- Btw, should be something like: <code> BUG: qm_free: freeing already freed pointer ... </code> ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=427#comment1432 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: kamailio sometimes crash when handling failure events
by sip-router 11 May '14

11 May '14

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#427 - kamailio sometimes crash when handling failure events User who did this - Daniel-Constantin Mierla (miconda) ---------- Looks like double free from dialog module, can you get the log messages from syslog printed by PIDs 4389 and 28897 before crash? ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=427#comment1431 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

← Newer
1
...
17
18
19
20
21
22
23
24
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2014